Compare commits

...

1216 Commits

Author SHA1 Message Date
Sergio Martins
02affc24c7 Add a repro for a bug 2022-10-20 17:42:05 +01:00
Sergio Martins
cb5a42ef2e tests: Fix memory leak
The root3 wasn't being put inside anything
2022-10-17 14:37:33 +01:00
Sergio Martins
437bc31aca Fix memory leak in a test 2022-10-17 13:48:38 +01:00
Sergio Martins
7597bb70a6 Fix memory leak
For consistency, all views create a controller, even if they
don't need it. But these dummy controllers weren't being deleted.
2022-10-17 12:24:11 +01:00
Sergio Martins
b6bbaf9e53 vscode: Add launcher for qtquick_customtitlebar 2022-10-10 21:51:02 +01:00
Sergio Martins
70b566b1b8 Also emit FloatingWindow::numDockWidgetsChanged() when restoring layout 2022-10-10 21:50:23 +01:00
Sergio Martins
8adba89a83 qtquick: Fix crash when mouse receiver gets deleted
Happened when double clicking a tab
2022-10-07 05:43:11 +01:00
Sergio Martins
04c069bf1b qtquick: Emit tabBarQmlItemChanged()
Not very important, as it's not read by QML.
Maybe removing the Q_PROPERTY and adding an invokable setter
would be better

Fixes bug #318
2022-10-05 11:44:48 +01:00
Sergio Martins
edb06f2543 qtquick|example: Rename tabBar to tabBarRow for readability
There's other things named tabbar already
2022-10-04 10:01:11 +01:00
Sergio Martins
de21f60910 Fix typo when emitting hoveredTabIndexChanged
Also added an example on how to style hovered tabs differently.
Fixes #317
2022-10-04 09:58:01 +01:00
Sergio Martins
f110afd1d0 header hygiene for Screen.h
KDDockWidgets_p.h is not installed, and not needed here anyway
2022-10-04 09:32:27 +01:00
Sergio Martins
84052f6db0 qtquick: Fix numDockWidgetsChanged() not being emitted sometimes
For FloatingWindow there's 2 levels of nesting. The outter
titlebar takes care of the nested groups, and then each group
as a title bar as well.

FloatingWindow now detects with inner tabbars get dock widgets
added/removed.
2022-10-03 17:49:07 +01:00
Sergio Martins
2b8b069396 minor readability improvement 2022-10-03 17:31:36 +01:00
Sergio Martins
1bed9c8a62 tests: Manually test that LayoutSaver triggers numDockWidgetsChanged 2022-10-03 17:23:29 +01:00
Sergio Martins
7eddab06d2 vscode: Add a launcher for tst_qtquick 2022-10-03 17:13:53 +01:00
Sergio Martins
66a572f177 tests: Add a test for TitleBar::tst_titlebarNumDockWidgetsChanged() 2022-10-03 17:13:06 +01:00
Sergio Martins
1ee12f5b90 qtquick: Add a 2022-10-03 17:09:41 +01:00
Sergio Martins
b1ff6bf11b qtquick: Add TabBar_qtquick::hoveredTabIndexChanged() signal
So users can style them differently in QML.

For issue #317
2022-10-03 15:15:36 +01:00
Sergio Martins
d8eac5c04b qtquick: MouseEventRedirector now receives less generic types
QQuickItem and View instead of QObject
2022-10-03 15:01:44 +01:00
Sergio Martins
8c0b76074c flutter: TitleBars now show the real title 2022-10-03 13:42:30 +01:00
Sergio Martins
498a0627fd flutter: Regenerate bindings 2022-10-03 13:41:33 +01:00
Sergio Martins
04df3d5bab flutter: add bindings for View.h
It's abstract but shiboken's API extractor doesn't know
since all the virtual methods are returning unknown types (shared pointers),
so give it some help.
2022-09-30 18:28:37 +01:00
pre-commit-ci[bot]
2a53aa8fa2 [pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/pre-commit/mirrors-clang-format: v14.0.0 → v14.0.6](https://github.com/pre-commit/mirrors-clang-format/compare/v14.0.0...v14.0.6)
- [github.com/PyCQA/pylint: v2.15.2 → v2.15.3](https://github.com/PyCQA/pylint/compare/v2.15.2...v2.15.3)
2022-09-28 20:14:09 +01:00
Sergio Martins
0c92b1dd6c qtquick: Added TitleBar_qtquick::numDockWidgetsChanged() signal
In case the custom titlebar wants to do something with it.
2022-09-28 20:01:14 +01:00
Sergio Martins
e265a33b4c Merge branch '1.7' into 2.0
-s ours merge
2022-09-19 13:51:48 +01:00
Sergio Martins
75526982f3 Honour FloatingWindowFlag::DontUseParentForFloatingWindows
(cherry-picked from commit 40d57e5000)
2022-09-19 08:46:33 +01:00
Sergio Martins
9c4b53faa6 Allow to specify Qt::Tool or Qt::Window per floating window
(cherry-picked from commit 7ac6a31512)
2022-09-19 08:44:42 +01:00
Sergio Martins
18d0875bde Add DockWidget::setFloatingWindowFlags(flags)
So you can specify, per floating window, which flags you want

(cherry-picked from commit 757e57559a)
2022-09-19 08:40:08 +01:00
Sergio Martins
d9afb45c05 Load FloatingWindowFlags from disk with LayoutSaver
If a user specified different flags for a certain FloatingWindow,
they'll be reloaded when restored with LayoutSaver as well.

(cherry-picked from commit 0bef7bc0e9)
2022-09-19 08:29:39 +01:00
Sergio Martins
c52ecb65b6 Move FloatingWindow::Flag enum to KDDockWidgets namespace level 2022-09-19 04:05:01 +01:00
Sergio Martins
3f34d12805 Allow to specify which flags FloatingWindow should use
(cherry-picked from commit fd35fc26e6)
2022-09-19 04:01:16 +01:00
Sergio Martins
e01a332386 LayoutSaver: Store the floating window flags too
(cherry-picked from commit c2208b169e)
2022-09-19 03:56:27 +01:00
Sergio Martins
0e66f8a368 Isolate more Config flags in FloatingWindow
(cherry-picked from commit ff200950aa)
2022-09-19 03:50:38 +01:00
Sergio Martins
6241eeca66 Further isolate access to top-level Config in FloatingWindow
In preparation for per-floatingwindow flags

(cherry-picked from commit 9916032981)
2022-09-19 03:43:40 +01:00
Sergio Martins
d54d417c09 Move TitleBar::supportsMinimize|MaximizeButton into FloatingWindow
Just a minor refactoring so FloatingWindow can save it during serialization.
So we can support per-floating window settings.

(cherry-picked from commit e6ccd9d01c)
2022-09-19 03:34:48 +01:00
Sergio Martins
e8814b102a buildsystem required CMake v3.12.0 or higher
(cherry-picked from commit c8e542cabf)
2022-09-19 01:47:58 +01:00
Sergio Martins
aca80b186e cmake: Allow to build with Qt 6.2, since it's the last LTS
(cherry picked from commit 3c2cb67bcd)
2022-09-19 01:44:49 +01:00
Sergio Martins
34d614ab37 Update ChangeLog 2022-09-19 01:42:15 +01:00
Sergio Martins
c91e5099e0 cmake: Remove unity builds from cmake presets
The speed is small since KDDW is small as well.
The burdon on maintaining it isn't worth the speedup.

Fixes static preset failing.

(cherry-picked from commit f5eb97bd26)
2022-09-19 01:36:14 +01:00
Sergio Martins
4ccb7df73c README: Mention that stable branch is 1.6 now 2022-09-19 01:34:22 +01:00
Sergio Martins
fd122b08da flutter: A floating window is now shown 2022-09-11 16:37:39 +01:00
Sergio Martins
617c3d0029 flutter: regenerate bindings 2022-09-11 16:37:18 +01:00
Sergio Martins
f4db14a745 flutter: Platform now tells the overlay about new floating windows 2022-09-11 12:49:57 +01:00
Sergio Martins
4a86415c65 flutter: ViewFactory now creates FloatingWindow view 2022-09-11 12:13:06 +01:00
Sergio Martins
29ac5a2d16 Make DockRegistry actually notify floating window was created
Was missing in last commit. Flutter can now now new windows
were created and create fake overlayed windows for them.
2022-09-11 12:12:14 +01:00
Sergio Martins
9995f70c78 flutter: Get notified when floating windows are created 2022-09-10 22:36:52 +01:00
Sergio Martins
38f605d562 flutter: update bindings 2022-09-10 22:31:27 +01:00
Sergio Martins
c6f0ec9d98 flutter: Be notified when a floating window is created 2022-09-10 22:24:44 +01:00
Sergio Martins
4cb4ab9db0 flutter: Add bindings for DockRegistry 2022-09-10 21:05:34 +01:00
Sergio Martins
d5214b8605 flutter: Add WindowWidget.dart
A widget that represents a kddw window.
Specially since flutter doesn't support multi-window. We'll
have to draw them over an overlay.
2022-09-10 18:57:11 +01:00
Sergio Martins
9dbca2618d flutter: Add initial WindowOverlayWidget.dart
Doesn't do much yet.
2022-09-10 18:21:39 +01:00
Sergio Martins
383246aa7f flutter: Regenerated bindings 2022-09-10 16:33:42 +01:00
Sergio Martins
f1efa95802 Make DockWidgetModel::m_tabBar private 2022-09-10 16:13:34 +01:00
Sergio Martins
f18a288def qtquick: Remove unneeded functions from Stack_qtquick 2022-09-10 15:46:56 +01:00
Sergio Martins
cf6b3c06e0 More m_tabWidget -> m_stack renaming 2022-09-10 15:33:49 +01:00
Sergio Martins
94fcdc990c qtquick: Stack_qtquick doesn't need to be exposed to QML 2022-09-10 15:32:13 +01:00
Sergio Martins
96990be5bb qtquick: Move DockWidgetModel to TabBar_qtquick
It's where it's used
2022-09-10 15:26:46 +01:00
Sergio Martins
0157d7d914 Remove 2 more unneeded TODOs 2022-09-10 13:27:12 +01:00
Sergio Martins
fbfec2f196 Remove unneeded TODO
This is in qtcommon now, so it's fine
2022-09-10 13:25:18 +01:00
Sergio Martins
60dcec9286 Remove some unneeded mentions of QEvent::Show 2022-09-10 12:58:35 +01:00
Sergio Martins
4e3f4e3073 More replacing of show() with open()
This time on DockWidgetViewInterface
2022-09-10 12:40:54 +01:00
Sergio Martins
cf44110033 Rename DockWidget::show() to DockWidget::open()
Since non-current tabs are open but not visible.
2022-09-10 12:26:30 +01:00
Sergio Martins
3cb6c2b8d0 Add DockWidget::open()
Show/hide/visibility is being deprecated
2022-09-10 12:10:25 +01:00
Sergio Martins
b5a9c03c21 Don't handle QEvent::Hide anymore
Update the buttons in DockWidget::setIsOpen() instead.
This makes the controllers self-contained and not depending
on the "view technology". Other frameworks might not even
have the concept of show/hidden events
2022-09-10 11:37:32 +01:00
Sergio Martins
3a280ae377 Minor indirection removal (DockWidget::Private::onDockWidgetShown()) 2022-09-10 11:30:18 +01:00
Sergio Martins
29be2ae819 Remove DockWidget::hidden() and shown() signals
Visibility isn't useful as a concept, since non current tabs
are also hidden. Instead, use DockWidget::isOpen()
2022-09-10 11:23:39 +01:00
Sergio Martins
764385de9f refactor: DockWidget::isOpen() now keeps its state in the controller
No longer tied to QtWidget visibility. This will make it easier to
make new frontends.
2022-09-09 19:51:25 +01:00
Sergio Martins
ea7cb3cbbb README: Explain our versioning 2022-09-08 11:52:29 +01:00
Sergio Martins
4fc43cbadd Merge branch 'master' into 2.0 2022-09-08 11:13:09 +01:00
Sergio Martins
932a80e73b Export SideBarButton
This allows code to link to subclasses of SideBarButton.

(cherry-picked from commit daebe9e680)
2022-09-08 00:15:34 +01:00
Sergio Martins
ac0b00add3 Allow custom sidebars to access its dock widgets
This is useful in cases where a custom sidebar wants behavior that
affects multiple dock widgets it "contains".

(cherry-picked from commit cf7f037af4)
2022-09-08 00:11:16 +01:00
Allen Winter
82729c85ea .reuse/dep5 - minor cleaning
(cherry picked from commit 913c570b2b)
2022-09-07 23:55:57 +01:00
Allen Winter
fd98824184 docs/api/Doxyfile.cmake - add .pngs 2022-09-07 23:52:06 +01:00
Sergio Martins
3ce1a6c77e Add SegmentedIndicators::s_centralIndicatorMaxWidth/height
So the user can change the maximum size of the central indicator

(cherry-picked from commit f84006347b)
2022-09-07 23:41:59 +01:00
Sergio Martins
bc8d17119a Release mouse if Qt doesn't receive mouse release
As explained in commit message for #166, there's a case where Qt
doesn't receive the mouse release from Windows. If that happens
then allow to drop if we're over a drop indicator.

Fixes issue #306

(cherry-picked from commit bde5be9d9c)
2022-09-07 23:29:12 +01:00
Sergio Martins
411750e865 python: Improve Dockerfile
Added more instructions and missing runtime packages

So I can test issue #304

(cherry picked from commit 7e689f0b39)
2022-09-07 23:26:14 +01:00
Sergio Martins
3ac8c5f384 Python: Add a Dockerfile for a python environment
So I can test issue #304

(cherry picked from commit ef78d60751)
2022-09-07 23:24:23 +01:00
Sergio Martins
6b720715bf cmake: Disable unity builds for python preset
It's not supported

(cherry-picked from commit bdbab41674)
2022-09-07 23:07:46 +01:00
Sergio Martins
d515969724 Fix QTabBar::setCurrentIndex() not getting called sometimes
TabBar::setCurrentIndex() was bailing out and not informing the view
because the current dock widget was the same. That happened because
m_currentDockWidget was being set in two places.

Fixes issue #312
2022-09-07 12:47:04 +01:00
Sergio Martins
ad8457490b Add an xfailing test for issue #312 2022-09-07 12:07:03 +01:00
Sergio Martins
c0ef4ae0d2 tests: Add a test for DockWidget:setAsCurrentTab()
CC issue #312
2022-09-07 11:52:19 +01:00
Sergio Martins
ede6dff09b qtquick: Use a simple Item instead of a StackLayout
StackLayout doesn't allow to reorder children. Instead, just stack
them in an arbitrary order and use visibility to hide the non-current ones.
2022-09-06 22:58:49 +01:00
Sergio Martins
c1420a7e80 tests: Check that current tab matches current widget 2022-09-06 21:51:00 +01:00
Sergio Martins
ef1ce9bb1d Remove stray qDebug 2022-09-06 15:50:38 +01:00
Allen Winter
52cd8f753d appveyor.yml - don't build the master branch 2022-09-06 09:09:01 -04:00
Sergio Martins
496be36585 Merge branch '1.6' 2022-09-05 23:13:43 +01:00
Sergio Martins
f9e758d02f Fix affinity of central frame
Fixes issue #245
2022-09-05 22:10:03 +01:00
Sergio Martins
958d1500e5 Remove unneeded View.h include and tidy forward declarations
Fixes #311
2022-09-05 21:34:11 +01:00
Sergio Martins
282c3106a4 Fix build with installed KDDW, do not expose Screen.h
Screen.h depends on KDDockWidgets_p.h which is not installed.
2022-08-23 07:57:20 +01:00
Sergio Martins
a74dace6e4 tests: Add more tests to TestDocks::tst_addAsPlaceholder()
While I'm debugging an issue.
2022-08-22 19:40:19 +01:00
Sergio Martins
1998800883 Remove unneeded "spontaneous" argument from onShown/hidden 2022-08-21 22:55:45 +01:00
Sergio Martins
c8b16c9712 Remove unneeded Group::onDockWidgetShown 2022-08-21 22:09:06 +01:00
Sergio Martins
ffc8038cc4 qtquick: Fix tests when tabs are removed
As explained in the comment
2022-08-21 17:29:16 +01:00
Sergio Martins
21d7d220c5 Remove legacy Group::onDockWidgetHidden code which is now unneeded
Tests pass without it, so let's simplify.
2022-08-21 17:11:06 +01:00
Sergio Martins
b52bb85190 qtquick: Fix test due to renaming tabs not being implemented
A warning will make the tests fail. Downgrade to qDebug as
this is expected.
2022-08-21 16:59:59 +01:00
Sergio Martins
c8386e6ce1 vscode: Fully scope ${workspaceFolder}
So it works if someone adds additional folders.
For example, working on the flutter examples within the same IDE.
2022-08-21 13:19:28 +01:00
Sergio Martins
9d9bce1860 vscode: Add launchers for more tests 2022-08-21 13:11:21 +01:00
Sergio Martins
12e8549f8f vscode: Remove msvc launchers, lldb launchers work on Windows too
It's easier to use the same launcher on all 3 operating systems.
2022-08-21 13:04:47 +01:00
Sergio Martins
f0c008fae3 tests: Add a unit-test for Adding dock widget hidden 2022-08-21 12:57:53 +01:00
Sergio Martins
61e93a1970 tests: Add a unit-test for DockWidget::isOpen() 2022-08-21 00:54:24 +01:00
Sergio Martins
763ad1ae6b Wrapper views now also get a dummy controller
Now we can finally make all setVisible/isVisible calls go
through the controller
2022-08-20 19:24:21 +01:00
Sergio Martins
bf43df1233 Call setVisible() through the controller instead of view
This is state that's moving to the controller
2022-08-20 18:48:01 +01:00
Sergio Martins
8e0ba911d0 Call isVisible() through the controller instead of view
This will be state that's moving to the controller.
2022-08-20 18:28:58 +01:00
Sergio Martins
a1f427e8e2 Remove unused DockRegistry::dockWidgetForGuest() 2022-08-20 18:09:52 +01:00
Sergio Martins
301af34dec flutter: Generate bindings for the MainWindow controller 2022-08-20 15:54:13 +01:00
Sergio Martins
598fedaf86 flutter: Add virtual onRebuildRequested() to tab bar view
So C++ can call this whenever a tab was removed or inserted
2022-08-20 12:05:59 +01:00
Sergio Martins
809ca9e586 cmake: Add preset to build flutter frontend standalone
It can't be build in conjuction with the QtWidgets one, since
that would mean using QAction from Qt and requiring a QApplication.

Instead just build the flutter frontend.
2022-08-19 23:35:50 +01:00
Sergio Martins
8c881b6db7 flutter: Group now shows the current dockwidget 2022-08-19 22:17:01 +01:00
Sergio Martins
b0f98dfd2d flutter: Only DropArea creates the stack now
It was a bad default. Other widgets can fill parent.
2022-08-19 20:53:54 +01:00
Sergio Martins
8e5e4d9d0e flutter: Refactor DropArea_flutter.dart
Just specialized it, so we can customize it.
2022-08-19 20:46:48 +01:00
Sergio Martins
ee14264655 flutter: Regenerate bindings
Since KDDW API has changed
2022-08-18 00:10:16 +01:00
Sergio Martins
6757370ca0 Add more documentation 2022-08-15 21:36:31 +01:00
Sergio Martins
91f0a250e7 Workround Qt bug when reordering tabs 2022-08-15 21:25:11 +01:00
Sergio Martins
63ae96a919 Re-add support for reordering tabs
And this time, implement the state in the controllers.
2022-08-15 21:22:53 +01:00
Sergio Martins
65b0b7e140 Remove TabViewInterface::numDockWidgets()
The controller knows how many. Frontends no longer need to
implement this
2022-08-15 21:02:44 +01:00
Sergio Martins
a11414ed8d insertDockWidget() now returns void instead of bool
It doesn't fail.
Furthermore, the views shouldn't dictate anything. The controller
is in charge. Views don't get to say a tab failed to be added.
2022-08-15 20:56:21 +01:00
Sergio Martins
74bd786be8 qtquick: Remove code already handled by the backend
DockWidget controller knows when it's reparented
2022-08-15 20:48:55 +01:00
Sergio Martins
ca26e856db tests: Fix tst_tabbar for QtQuick 2022-08-15 20:46:36 +01:00
Sergio Martins
be2c297fa9 Fix list of tabs not being updated when dock widget closed
When closing, we need to remove from the TabBar controller.

QtWidgets tests no pass again.
2022-08-15 19:55:01 +01:00
Sergio Martins
838e953320 Fix TabBar::moveTabTo() not swapping indexes
The list of dock widgets is now stored in the controller.
2022-08-15 19:38:12 +01:00
Sergio Martins
e61d55df53 Revert "wip"
This reverts commit 4af2f1d46b.
Shouldn't have been commited, it's a local change.
2022-08-15 15:18:14 +01:00
Sergio Martins
376202c3f8 Remove more logic from tabbar view into controller 2022-08-15 14:33:33 +01:00
Sergio Martins
2a37813409 Remove more TabBarViewInterface related to indexes
That's in the controller now, shared by all frontends
2022-08-15 14:14:15 +01:00
Sergio Martins
bbef108e32 Override QTabBar::tabInserted insted of QTabWidget::tabInserted
Since we're moving logic to tab bar instead of tab widget.
Otherwise calling count() on the tab bar while QTabWidget::tabInserted
is running can give the wrong value. So settle with a single class.
2022-08-15 13:47:03 +01:00
Sergio Martins
a0329a01fb Remove from old tab bar before adding to new
By having the state consistent in the controllers it makes it easier
to implement the view counter part code. Relying on the view to
remove from old tab bar implicitly due to reparenting is obscure
2022-08-15 00:09:06 +01:00
Sergio Martins
4af2f1d46b wip 2022-08-14 23:12:21 +01:00
Sergio Martins
24040ccfbf Remove some unneeded code, already covered in TabBar.cpp 2022-08-14 23:11:51 +01:00
Sergio Martins
5a455f86a1 TabBar now knows the list of dockwidgets
It's no longer on the view.
2022-08-14 22:43:33 +01:00
Sergio Martins
9a8ca5135e Fix build 2022-08-14 19:38:51 +01:00
Sergio Martins
a9485ee0b2 Port an old syle connect to Qt5 style 2022-08-14 18:54:54 +01:00
Sergio Martins
6a9988e7b0 Remove more unneeded tab widget code 2022-08-14 18:47:59 +01:00
Sergio Martins
7f072366ed Remove now unneeded TabBar::currentTabChanged(int)
It's all in terms of current dock widget now, not indexes.
2022-08-14 18:31:50 +01:00
Sergio Martins
0b5e9bc6c1 Remove unneeded emissions of currentDockWidgetChanged
It's now wrapped with a setter, so it's emitted at the right
times always
2022-08-14 17:45:33 +01:00
Sergio Martins
8834f7d75b TabBar controller now stores the current dock widget
It's no longer stored in the view.
This makes it easier for new frontends.
2022-08-14 17:34:01 +01:00
Sergio Martins
4627571f3f qtquick: Fix current tab being current even after removed
Added lots of tests for TabBar.
2022-08-14 15:44:38 +01:00
Sergio Martins
d071fc440a Don't run tst_qtquick if KDDW_TEST_FRONTENT=1 is set
Only QtWidgets test should run in that case.
2022-08-14 14:24:51 +01:00
Sergio Martins
bcbb75da72 Add more documentation to GroupViewInterface.h 2022-08-13 23:19:09 +01:00
Sergio Martins
ca0f767f21 Add more documentation and make interfaces simpler 2022-08-13 23:08:10 +01:00
Sergio Martins
30955b5f5b Remove more pure-virtuals from GroupViewInterface
In this case, made them non-pure, as the default impl is enough
for most frontends. Only qtquick does something different
2022-08-13 22:32:49 +01:00
Sergio Martins
7a4c969b86 Removed a lot of unneeded GroupViewInterface methods
These are already implemented in TabViewInterface
2022-08-13 22:17:56 +01:00
Sergio Martins
3ffe116a02 Move more methods away from StackViewInterface
Let's just have TabBarViewInterface, which is similar
2022-08-13 20:35:09 +01:00
Sergio Martins
fb59e30c59 Move more code away from Stack and into TabBar 2022-08-13 16:04:32 +01:00
Sergio Martins
8955ec8bcb Remove unused StackViewInterface::currentIndex() 2022-08-13 14:54:59 +01:00
Sergio Martins
1868ad7bd4 Move more code out of Stack and into TabBar
The signals are more about the tabs.
2022-08-13 14:50:19 +01:00
Sergio Martins
1abebef40b Move move code from StackViewInterface.h to TabBarViewInterface.h
Phasing out the former, so frontend writers don't have to implement
two duplicate interfaces
2022-08-13 14:11:33 +01:00
Sergio Martins
de3ef59506 flutter: Regenerate bindings
Rename some DropArea arguments too, so they don't appear as "arg_X"
in Dart
2022-08-12 23:01:40 +01:00
Sergio Martins
b56e6a8279 flutter: Add convenience to access the controller
Dart can't access the DockWidgetViewInterface since Dartagnan
doesn't support multiple inheritance
2022-08-12 22:49:32 +01:00
Sergio Martins
da21d35f4b flutter: Group will display the dock widget as well 2022-08-12 22:31:33 +01:00
Sergio Martins
73cdaa8698 flutter: Show a title bar and a tab bar
Just placeholders for now, no actual tabs
2022-08-12 21:41:38 +01:00
Sergio Martins
a97e3ae831 flutter: Derive state/widget for all our view types
Mostly boilerplate code, no functionality
2022-08-12 17:58:54 +01:00
Sergio Martins
6bc2979989 flutter: Subclass the widget and state for Group
So we can start adding the title bar and tab bar
2022-08-12 17:31:38 +01:00
Sergio Martins
3c48b3aab3 flutter: Reuse more code, move code into View_mixin 2022-08-12 17:12:12 +01:00
Sergio Martins
7371171115 flutter: Fix crash due to rootView() being null
We can now show a pink dock widget
2022-08-12 16:48:18 +01:00
Sergio Martins
da38c09dec Improve debug output 2022-08-12 16:37:30 +01:00
Sergio Martins
b55656deec flutter: Added DockWidget view
Not implemented yet, but maybe we can show it on screen hosting
a guest user widget
2022-08-12 15:54:44 +01:00
Sergio Martins
76b03f4700 flutter: Add bindings for DockWidget_flutter view wrapper 2022-08-11 19:15:58 +01:00
Sergio Martins
cc719325cc flutter: Generate bindings for Controllers::DockWidget too
Worksaround Dartagnan only knowing "= {}" as a way to default initialize
QFlags
2022-08-11 16:14:34 +01:00
Sergio Martins
a52428cf35 flutter: Regenerate bindings
DropIndicatorOverlay bindings now build.
2022-08-11 15:45:07 +01:00
Sergio Martins
47ada6dd56 flutter: Add more bindings
Some commented out due to bugs in dartagnan. To be fixed.
2022-08-11 15:04:34 +01:00
Sergio Martins
2862f2b76f flutter: Fix moving separators vertically
Needs to use the layout's local coordinate space and not global
space. Horizontally was working since the layout occupies the whole
window. Vertically there's flutter's app bar, so the movements were
off by a few pixels
2022-08-10 22:11:11 +01:00
Sergio Martins
48b067023f Minor rename 2022-08-10 21:50:55 +01:00
Sergio Martins
51b47a26af flutter: Don't resize separator without primary button pressed 2022-08-10 21:41:36 +01:00
Sergio Martins
cc8dbd3d0c Fix typo on View::onResized()
Width and height were swapped. Caught by the tests.
2022-08-10 21:19:07 +01:00
Sergio Martins
c523d514ee Only check for mouse button being pressed on separator move for Qt
That's a workaround for a bug. Other platforms might not have the
same bug and might not have a way to query mouse buttons the same
way Qt does.
2022-08-10 20:30:09 +01:00
Sergio Martins
e9e88d81e8 Fix install step
Separator_quick was old and got renamed to Separator_qtquick
long time ago
2022-08-10 20:26:49 +01:00
Sergio Martins
cffea940ea cmake: Also define KDDW_FRONTEND_QT if we have QtWidgets or QtQuick 2022-08-10 19:45:04 +01:00
Sergio Martins
647cb4c7f6 Remove Utils::isLeftMouseButtonPressed()
It's an unneeded indirection
2022-08-10 19:39:44 +01:00
Sergio Martins
0b2cc6e078 Make separator not depent on QGuiApplication 2022-08-10 19:36:11 +01:00
Sergio Martins
d9f1a04e8d flutter: Layout can now be resized 2022-08-10 19:33:11 +01:00
Sergio Martins
048d156998 flutter: Tell flutter a view was destroyed
So flutter can stop rendering and gc its widget
2022-08-10 19:31:06 +01:00
Sergio Martins
65f23f9c30 flutter: Implement View::parentView() 2022-08-10 19:30:43 +01:00
Sergio Martins
667b9bb28c flutter: Add ViewWrapper
so we can implement View::parentView(), which returns a shared ptr
2022-08-10 19:29:41 +01:00
Sergio Martins
fb6175c4b3 Move the old ViewWrapper to qtcommon
Since it's Qt specific
2022-08-10 19:28:56 +01:00
Sergio Martins
192533647d flutter: Deal in StatefulWidget instead of PositionedWidget
So we can wrap PositionedWidget in something else
2022-08-09 19:07:18 +01:00
Sergio Martins
2afe86e63b flutter: Support showing a basic layout
Next step is adding a MouseRegion for the separators
2022-08-09 18:45:11 +01:00
Sergio Martins
b52070dc0e flutter: Support flutter telling kddw the side of the layout
DropArea's size isn't driven by kddw, that gets resized whenever
the user resizes the window. Flutter now tells KDDW the new size
2022-08-09 01:37:37 +01:00
Sergio Martins
3cbd437ee6 flutter: Regenerate bindings 2022-08-09 01:26:58 +01:00
Sergio Martins
532dc04ec6 Make View::onResized(QSize) receive 2 integers instead
Avoids an allocation when called by dart.
2022-08-09 01:25:56 +01:00
Sergio Martins
8050ca6259 flutter: Remove unneeded callbacks 2022-08-08 23:33:19 +01:00
Sergio Martins
f493c44729 flutter: Use keys instead of callbacks to update state 2022-08-08 22:49:56 +01:00
Sergio Martins
11301e2f0f flutter: PositionedWidget now takes reference for the mixin
Which is the common denominator
2022-08-07 21:36:40 +01:00
Sergio Martins
151bc356fc flutter: Stack, TabBar and TitleBar now also implement View_mixin 2022-08-07 16:08:14 +01:00
Sergio Martins
f4f7e4508b flutter: Group views now implement View_mixin 2022-08-07 16:02:43 +01:00
Sergio Martins
9cf99ff45c flutter: Use a mixin for the View's data
Group_flutter.dart doesn't inherit from View_flutter.dart, it inherits
directly from C++, so wasn't getting the data.

Since Dart doesn't support multiple inheritance we'll use a mixin
2022-08-07 15:56:13 +01:00
Sergio Martins
882f25c7f7 flutter: regenerate bindings 2022-08-07 14:51:00 +01:00
Sergio Martins
69c7d3fd57 Remove View::maximumSize() as we already have View::maxSizeHint()
Having both was due to QWidgets having both. For QtQuick and other
frontends we only want the latter.
2022-08-07 14:49:32 +01:00
Sergio Martins
62d8426ec4 flutter: Name the view method arguments in the header
While usually unneeded, it makes the bindings generator use
proper names instead of generic "arg1" type names.
2022-08-05 16:54:10 +01:00
Sergio Martins
d8189e3e03 .clang-format: wrap at column 100 2022-08-05 16:49:00 +01:00
Sergio Martins
9a4daf8926 flutter: Don't say we have 1 tab, there's 0 still
as the implementation isn't done yet, should fix a crash
2022-08-03 23:42:08 +01:00
Sergio Martins
4c1e45eea9 flutter: Make the ViewFactory return the actual view instances 2022-08-03 23:41:50 +01:00
Sergio Martins
98a7a0e017 flutter: Add a way to dump a dart backtrace
gdb can now call Platform::instance()->dumpManagedBacktrace()
2022-08-03 23:39:22 +01:00
Sergio Martins
c461721456 flutter: Generate bindings for Platform.h too 2022-08-03 23:32:09 +01:00
Sergio Martins
f634a1e3f7 flutter: Add bindings for the views 2022-08-03 12:32:38 +01:00
Sergio Martins
7a8222a063 flutter: Add dummy views
to be implemented as needed
2022-08-03 12:17:00 +01:00
Sergio Martins
35042c2bef Add dummy views to the dummy frontend
Easier to copy-paste to new frontends now.
2022-08-03 11:43:16 +01:00
Sergio Martins
c9c3fdc1a2 Add assert that there's a stack view interface
Helps catch bugs in flutter frontend
2022-08-03 10:03:39 +01:00
Sergio Martins
69c2c0770f tests: Add another test to tst_dropArea 2022-08-03 09:48:30 +01:00
Sergio Martins
3f32bc3dce tests: Move tst_droparea.cpp into tests/controllers/ 2022-08-03 09:24:03 +01:00
Sergio Martins
8a76c63983 flutter: Add bindings for Stack, TitleBar and TabBar 2022-08-03 00:14:36 +01:00
Sergio Martins
7cc4bae1b7 flutter: Regenerate bindings with newest dartagnan bug fixes 2022-08-02 22:56:51 +01:00
Sergio Martins
bf922a2ecb flutter: Add bindings for Group 2022-08-01 00:22:19 +01:00
Sergio Martins
27b8480da6 Make InitialOption's ctor public
Just mark it as internal.
Someone might think it's useful even if bugs reported won't be prioritized.
2022-08-01 00:17:10 +01:00
Sergio Martins
f97a660584 Remove deprecated function 2022-07-31 23:27:07 +01:00
Sergio Martins
6d30643672 Rename "acceptingFrame" to "acceptingGroup"
Frame class has been renamed to group some time ago already
2022-07-31 23:04:50 +01:00
Sergio Martins
e4b2d37f96 Rename "addWidget" to "addTab" 2022-07-31 23:03:16 +01:00
Sergio Martins
45ad75fcd4 flutter: Add multisplitter to the include path 2022-07-31 13:31:03 +01:00
Sergio Martins
8e5225224d flutter: Regenerate bindings
This time without readability tags so we can reduce diff size
2022-07-31 13:30:27 +01:00
Sergio Martins
8a65d2cc0b flutter: Added bindings for Item 2022-07-31 13:07:59 +01:00
Sergio Martins
cfb5c5e2fe flutter: Add InitialOption_wrapper 2022-07-31 13:02:27 +01:00
Sergio Martins
2c58580d06 flutter: Remove unneeded main.dart
We now depend on flutter, not just dart. So need an embedder
to actually run things.
2022-07-31 12:42:50 +01:00
Sergio Martins
4901b977a0 flutter: PositionedWidget can now fill parent 2022-07-31 12:34:59 +01:00
Sergio Martins
120557b8a6 flutter: A view can now be positioned and sized 2022-07-31 12:12:23 +01:00
Sergio Martins
3c51d201d5 reuse: Ignore .yaml config files 2022-07-31 11:49:57 +01:00
Sergio Martins
b1fcae9bc2 flutter: generate more bindings 2022-07-31 11:46:48 +01:00
Sergio Martins
ecd05ffbc5 flutter: Creating a DropArea almost works 2022-07-27 11:44:04 +01:00
Sergio Martins
7b20eedf6d Add tst_dropArea
Removed the requirement to have a parent, it's not really needed,
conceptually.
2022-07-27 10:34:13 +01:00
Sergio Martins
93b3f77969 flutter: instantiate DropArea_flutter 2022-07-27 10:32:10 +01:00
Sergio Martins
f7c3dea53f flutter: Add bindings for Layout 2022-07-26 17:28:01 +01:00
Sergio Martins
02e591fc52 flutter: Add View_flutter.dart 2022-07-26 15:19:57 +01:00
Sergio Martins
3ee9866d84 flutter: Add bindings for CreateViewOptions_wrapper 2022-07-26 15:10:30 +01:00
Sergio Martins
84ec64fade unnest CreateViewOptions so we can create dart bindings for it
Our binding generator doesn't support nested classes yet
2022-07-26 15:03:21 +01:00
Sergio Martins
f8f75cdabc flutter: Add bindings for View 2022-07-26 14:20:27 +01:00
Sergio Martins
feda194b01 flutter: Also create bindings for ViewFactory 2022-07-26 13:37:21 +01:00
Sergio Martins
249ee2ce67 flutter: Add bindings for ViewFactory_flutter.h 2022-07-26 13:30:35 +01:00
Sergio Martins
d97ccb9792 flutter: Add bindings for Config.h 2022-07-26 13:21:14 +01:00
Sergio Martins
90ba005bc6 flutter: Remove unneeded Platform.dart 2022-07-26 13:15:01 +01:00
Sergio Martins
1a762df812 flutter: Add Platform_dart and regenerate bindings 2022-07-26 13:09:26 +01:00
Sergio Martins
0dd41fc7e9 flutter: Rename Platform.dart to Platform_flutter.dart
Makes it consistent with the naming of all other frontends
2022-07-25 17:57:33 +01:00
Sergio Martins
ff7a30dcc3 flutter: Remove duplicate method from QByteArray.dart
Dart doens't support 2 methods with the same name
2022-07-25 17:56:40 +01:00
Sergio Martins
c40f38097a wip 2022-07-25 17:53:26 +01:00
Sergio Martins
7439040147 Don't compare raw Screen pointers directly
Instead compare the underlying QScreen.
2022-07-25 06:13:42 -07:00
Sergio Martins
2fa27e8f62 Add Screen::equals(), as comparing Screen raw pointers is meaningless 2022-07-25 13:49:45 +01:00
Sergio Martins
b5ad2f6870 dummy|flutter: Add missing Platform::primaryScreen() override 2022-07-25 13:30:12 +01:00
Waqar Ahmed
ac082ca846 Add Platform::primaryScreen 2022-07-25 17:24:27 +05:00
Sergio Martins
fb88f37b37 cmake: Build the flutter frontend only when using Qt5
As the bindings were generated against Qt5, not Qt6.
Won't matter much in the future, since it won't depend on Qt. But for
now there's still some dependencies.
2022-07-25 11:49:06 +01:00
Sergio Martins
0e29658664 Fix flutter and dummy frontend builds
Was missing implementation for the new screen methods
2022-07-25 11:46:49 +01:00
Waqar Ahmed
4d5a43ea1f Remove QScreen usage from non-frontend classes 2022-07-25 11:39:36 +05:00
Waqar Ahmed
396973b987 Add Screen::name 2022-07-25 11:37:52 +05:00
Waqar Ahmed
82d6648119 Avoid emitting thousands of timeout signals without any reason 2022-07-24 15:03:50 +05:00
Sergio Martins
b3dd4516ca flutter: Renamed KDDockWidgets package to KDDockWidgetsBindings
The former is needed for the KDDW flutter frontend, which will use
the latter to access the C++ API.

Using two packages instead of one, since one is generated by
dartagnan.
2022-07-23 20:31:50 +01:00
Sergio Martins
7956ec3b73 flutter: Fix Platform::name_calledFromC()
The return type needs to be ffi.Pointer<Utf8>, not String.
This has been fixed in dartagnan
2022-07-23 18:44:20 +01:00
Sergio Martins
9b7eaebd40 flutter: Fix kddockwidgets library name
So dart can load the correct one
2022-07-23 17:21:00 +01:00
Sergio Martins
307161a8f1 flutter: Tell dartagnan to not generate CMakeLists.txt
We have our own already.
2022-07-23 17:13:26 +01:00
Sergio Martins
ee5bd0094b flutter: Add bindings to View, ViewFactory and Platform 2022-07-23 17:03:45 +01:00
Sergio Martins
71f4246ac1 cmake: Add flutter to the dev6 preset 2022-07-23 12:38:01 +01:00
Sergio Martins
d4b515b7a3 Fix Qt6 build 2022-07-23 12:33:09 +01:00
Sergio Martins
162b6b914c flutter: export bindings too 2022-07-23 10:07:41 +01:00
Sergio Martins
a824bba23f codespell: Accept "sharable" as it comes from Qt 2022-07-23 10:06:14 +01:00
Sergio Martins
42ceb96cc2 flutter: Dart bindings are now built within kddockwidgets.dll too
No need to have a separate library with them.

This is just an initial commit to get the cmake right. We'll be adding
more bindings as we go.

Also, at some point, the Qt bindings will be removed and we'll have just
C++ KDDW bindings without any Qt.
2022-07-23 10:01:51 +01:00
Sergio Martins
1e926005c7 Add missing break, fixes fallthrough 2022-07-23 09:46:28 +01:00
Sergio Martins
1252ba40b3 Update .gitignore 2022-07-23 09:46:16 +01:00
Sergio Martins
5419b27a12 Fix linking due to Screen.cpp missing 2022-07-23 09:45:32 +01:00
Sergio Martins
28324e7a6a flutter: Use QT_NO_CAST_FROM_ASCII for bindings
Otherwise kddw won't compile as the QString ascii ctor is private
2022-07-23 09:38:56 +01:00
Sergio Martins
13b94d151b flutter: Add copyright headers to generated bindings
It's done automatically now when refreshing the bindings.
2022-07-23 09:38:56 +01:00
Allen Winter
4e18d198a0 Merge branch '1.6' 2022-07-22 16:00:32 -04:00
Waqar Ahmed
6e602970fb Add a platform agnostic Screen class 2022-07-22 22:20:18 +05:00
Sergio Martins
4b36717630 flutter: Add binding generation support through dartagnan
For now, only generating a few classes. We'll build up slowly.
2022-07-22 16:20:21 +01:00
Sergio Martins
53e6f6dc0e flutter: Initial boiler-plate commit
Does not have any implementation.
But we can start generating dart bindings for it.
2022-07-22 14:52:50 +01:00
Sergio Martins
0afb9ae113 Actually remove View::parentChanged() signal
Should have gone in the last commit
2022-07-22 10:22:13 +01:00
Sergio Martins
b907c67ee3 Remove View::parentChanged
It was driving too much logic.
The controllers deal with this now. Makes it easier to make
non-Qt frontends
2022-07-22 10:10:17 +01:00
Sergio Martins
fb701e8307 Move DockWidget::parentViewChanged() signal to base class
So it matches the setter, which was already in the base class
2022-07-22 09:54:18 +01:00
Sergio Martins
1097908882 Override DockWidget::setParentView() instead of relying on QEvent
So it works with non-Qt frontends too.
2022-07-22 09:36:20 +01:00
Sergio Martins
5c26aaa9cd Port some raw QObject::setParent() calls 2022-07-21 22:59:27 +01:00
Sergio Martins
d0f1f2ce77 tests: Test DockWidget::isOpen() too 2022-07-21 17:54:39 +01:00
Sergio Martins
a9d2be775b tests: Test that dock widgets are floating after being closed
Not that it means much, since they're hidden. But be consistent.
2022-07-21 17:27:37 +01:00
Sergio Martins
b7665abf68 vscode: Add a launch for tst_docks 2022-07-21 14:42:40 +01:00
Sergio Martins
d4d325a401 qtquick: Don't compare controller parents, compare view parents
Controllers will be ported away from QObject eventually
2022-07-20 18:44:34 +01:00
Sergio Martins
06534bb5d8 tests: Add assert 2022-07-20 14:56:26 +01:00
Sergio Martins
a5589dbe29 tests: Add assert
Makes it easier to debug, as it crashes sooner
2022-07-20 14:53:14 +01:00
Sergio Martins
4706d2527c Remove the *_impl indirection methods from Group
They are no longer virtual, so the indirection doesn't make
sense anymore
2022-07-20 14:26:49 +01:00
Sergio Martins
b5a76a4373 Fix UBSAN warning about Group_qtquick already being deleted
Its dtor was in the stack when the signal was emitted
2022-07-20 14:03:27 +01:00
Sergio Martins
36931e7c45 Allow DragController views to have access to its controller
For consistency
2022-07-20 13:12:52 +01:00
Sergio Martins
013e390428 Don't create unneeded controllers
ViewWrappers don't actually have a controller
2022-07-20 12:39:34 +01:00
Sergio Martins
91821901e3 Override Group::setParentView() instead of listening to QEvent::ParentChanged
The latter is a Qt'ism
2022-07-20 10:35:27 +01:00
Sergio Martins
6e3524f9b2 Fix another two cases of View::setParent() being called directly 2022-07-20 10:16:57 +01:00
Sergio Martins
26acf4dab4 Add Controller::setParentView()
Controllers need to know when the view changes parent. Until know
they listen to event filter's QEvent::ParentChange, which isn't portable
to non-Qt platforms. Instead, always go through the controller.
Then each controller can override setParentView(), which is virtual,
to intercept parent changes without any Qt specific events.

In a followup will inherit from setParentView() in a few controllers
2022-07-19 18:54:45 +01:00
Sergio Martins
d99b842ae1 Always instantiate a controller even if nullptr is passed
During the multisplitter tests we create dummy views without
an associated controller. Let's create the controller anyway, as
more logic is moving into them, even if just for tests.
2022-07-19 18:53:38 +01:00
Sergio Martins
84f0c45cbd qtquick: Add tabs to the customtabbar example
So the user doesn't need to add tabs manually to see them
2022-07-18 10:46:54 +01:00
Sergio Martins
ee59ad5e4b qtquick: Port customtabbar example to TabBarBase.qml
It's now fully functional and styled.
2022-07-18 10:39:53 +01:00
Sergio Martins
82ad2242dd qtquick: Don't assume in the C++ that the tab bar has a list view
Getting the tab index by QPoint is now done in QML, so it can
be overridden by the user.
2022-07-18 10:21:05 +01:00
Sergio Martins
dd1363de6c qtquick: Minor refactoring of getTabAtIndex()
Moved the listview code into a separate function, so it
can be reused soon.
2022-07-18 09:20:32 +01:00
Sergio Martins
92d4922077 qtquick: tabAt(index) now supports non-QtQuickControls TabBar
The C++ had hardcoded looking for the list view. User can now
override and write their own function to get to their custom
tabbar.
2022-07-17 23:53:40 +01:00
Sergio Martins
b8acc8614c qtquick: Split TabBar.qml into two
In general, the kddw logic that shouldn't be touched should go to
TabBarBase.qml while TabBar.qml has customizable bits.

For example, somone might not want to use the tab bar from
QtQuickControls but still inherit some logic from TabBarBase.qml
2022-07-17 22:24:51 +01:00
Sergio Martins
48bac96c71 qtquick: Add example of custom tabBar
Will do some styling in a follow up
2022-07-17 20:11:18 +01:00
Sergio Martins
9b4ac4738a qtquick: Use a Loader to load the TabBar
It now loads the qml file specified in the ViewFactory.
Which by default is the TabBar.qml we ship, but could be something
else.
2022-07-17 20:11:09 +01:00
Sergio Martins
8a2eac8bcb qtquick: Fix "current tab index changed" not being emitted
suppose tab number 5 is current and you remove tab 0. The current
dock widget didn't change but its index is now 4.
2022-07-17 20:11:09 +01:00
Sergio Martins
de40629094 Remove duplicate signal "currentDockWidgetChanged"
Because they were not equivalent, one was emitted in situations
where the other wasn't. Use a single signal to avoid that.
2022-07-17 19:30:28 +01:00
Sergio Martins
3cfc4c484f tests: test that Group::currentIndex is correct 2022-07-17 18:52:18 +01:00
Sergio Martins
a900f73f7b qtquick: Factor out TabBar usage into TabBar.qml
So the user can customize it soon.
2022-07-17 14:27:19 +01:00
Allen Winter
18253c467c Merge branch 'master' into 2.0 2022-07-14 15:30:38 -04:00
Allen Winter
71c221981e Merge branch '1.6' 2022-07-14 15:30:24 -04:00
Allen Winter
fae03328f6 codespelling fixes 2022-07-13 09:12:36 -04:00
Allen Winter
a113a428e7 README.md, docs_devel - markdown linting 2022-07-13 09:08:50 -04:00
Allen Winter
d4e020eb4a reuse compliance 2022-07-13 08:50:25 -04:00
Allen Winter
53c65c6129 Merge branch 'master' into 2.0 2022-07-13 08:42:44 -04:00
Allen Winter
b60e3ef4c9 Merge branch '1.6' 2022-07-13 08:41:26 -04:00
Sergio Martins
7f71efd5f8 Fix build on older gcc
Error was:
    undefined reference to `KDDockWidgets::Views::View_qtwidgets<QTabBar>::childViewsFor(QWidget const*)'
    (Repeated for QLineEdit and others)
2022-07-13 07:19:37 +01:00
Sergio Martins
fc04dc77c4 Install EventFilterInterface.h too
DockWidgetRegistry.h depends on it. Copy it to private/ instead, don't want people
do use it directly

Fixes issue #302
2022-07-13 07:10:45 +01:00
Sergio Martins
c960673de4 Fix build of standalone applications
add_definitions only had an effect when build kddw itself, not
when applications were using it. Use target_compile_definitions
instead.
2022-07-13 06:59:18 +01:00
Sergio Martins
7d08925ea2 Add missing license to View_qt.cpp 2022-07-12 23:02:23 +01:00
Sergio Martins
688139cd38 Merge branch 'master' into 2.0 2022-07-12 22:48:09 +01:00
Allen Winter
ab40c02b56 Merge branch '1.6' 2022-07-12 16:03:53 -04:00
Allen Winter
02847c74bd Merge branch '1.6' 2022-07-12 12:54:25 -04:00
Allen Winter
d12def7baa Merge branch '1.6' 2022-07-12 12:11:04 -04:00
Allen Winter
ed52e6a955 Merge branch '1.6' 2022-07-12 11:13:35 -04:00
Sergio Martins
eaa474e76f Merge branch '1.6' 2022-07-12 15:31:36 +01:00
Sergio Martins
d8e0be874b Merge branch 'master' into 2.0
Merged with "-s ours", as master only contained clang-format changes
already present in 2.0.
2022-07-12 11:35:01 +01:00
Sergio Martins
296de10571 Merge branch '1.6' 2022-07-12 11:31:14 +01:00
Sergio Martins
9ae0ab294c Windows: Fix build 2022-07-11 15:06:29 -07:00
Sergio Martins
760fc8d0fb Fix build of dummy frontend with Qt5 2022-07-11 13:52:11 -07:00
Sergio Martins
62020a3ff9 qtquick|example: Allow users to test floating windows with native titlebar 2022-07-11 21:43:16 +01:00
Sergio Martins
e7c51aabd3 Merge branch 'master' into 2.0 2022-07-11 21:15:34 +01:00
Sergio Martins
e83996b402 Merge branch '1.6' 2022-07-11 21:15:18 +01:00
Sergio Martins
64a4ad5029 Fix build when dummy platform is disabled 2022-07-11 19:31:26 +01:00
Sergio Martins
7e051d5e71 Merge branch 'master' into 2.0 2022-07-11 19:24:58 +01:00
Sergio Martins
0d82880ea7 Merge branch '1.6' 2022-07-11 19:24:43 +01:00
Sergio Martins
fe18f994ac Allow dummy to be built against Qt5 too 2022-07-11 19:18:42 +01:00
Sergio Martins
a5e7b94da1 dummy: Don't look for QtWidgets, QtGui is enough
We still depend on QtGui for QMouseEvent, that needs to be
abstracted out
2022-07-11 17:22:39 +01:00
Sergio Martins
77e19fa5bd Revert "cmake: Remove KDDockWidgets_QT6 from dummy preset"
This reverts commit 2666ed3f5e.

It's still needed, didn't notice as it would need a clean build
to repro the failure.
2022-07-11 17:19:45 +01:00
Sergio Martins
8ad64e5e6f Fix dummy frontend build without QtWidgets
Next step is removing QtGui depenency
2022-07-11 17:14:05 +01:00
Sergio Martins
8b3a17d629 cmake: Treat dummy frontend like any other
Gets enabled by cmake presets now
2022-07-11 15:55:52 +01:00
Sergio Martins
2666ed3f5e cmake: Remove KDDockWidgets_QT6 from dummy preset
It doesn't need Qt conceptually.
2022-07-11 15:12:11 +01:00
Sergio Martins
68e9f4bcea dummy: Ifdef the test functions with developer mode
Fixes release build
2022-07-11 15:08:06 +01:00
Sergio Martins
ecb2c4ff47 Remove QtWidgets from ViewFactory_dummy 2022-07-11 14:54:50 +01:00
Sergio Martins
37688e1874 cmake: Allow to build only dummy frontend
The goal will be to make sure that the backend builds without Qt.
For now, dummy still links to Qt, but we're working on it.
2022-07-11 14:23:03 +01:00
Sergio Martins
adcde3a65c tests: Add tst_dummyplatform
Its only purpose is to instantiate some classes so we're sure
they implement all needed pure virtuals

The dummy platform is just used for copy-pasting into a new
platform, so let's cover as much boiler-plate as possible
2022-07-11 13:45:48 +01:00
Allen Winter
1f7c1e4188 Merge branch 'master' into 2.0 2022-07-11 08:38:22 -04:00
Allen Winter
35c9ccdd6a Merge branch '1.6' 2022-07-11 08:36:52 -04:00
Sergio Martins
b784780428 Add Dummy enumerator to FrontendTypes
so we can test that it reimplements all pure virtual methods.
We get a compiler-error now if any is missing.

Added the missing pure virtual methods too.
2022-07-11 11:54:38 +01:00
Sergio Martins
6ebb680c92 Re-ran clang-format 14 over the source
Fixes some differences with clang 13
2022-07-11 11:40:38 +01:00
Sergio Martins
ceab323916 Move qobjectAsView() and qobjectAsWindow from Platform.h to Platform_qt.h
As it's Qt specific
2022-07-10 23:04:37 +01:00
Sergio Martins
92b49f78a9 View CTOR no longer receives "thisQObject" via argument
It's unused, views don't need to be QObject based anymore
2022-07-10 22:44:54 +01:00
Sergio Martins
8e7e68eddc Rename View_qt::asObject() to View_qt::asQObject()
Which can be done now since View::asQObject() is gone
2022-07-10 22:31:47 +01:00
Sergio Martins
1c21555767 Finally remove View::asQObject()
It's not required anymore.
2022-07-10 22:29:31 +01:00
Sergio Martins
2f6d618048 Remove View::asQObject() occurrances from Platform_qt 2022-07-10 22:12:54 +01:00
Sergio Martins
f9b806ede5 Fix memory leak 2022-07-10 22:08:08 +01:00
Sergio Martins
8894572174 Remove one usage of asQObject from WidgetResizeHandler
It's being deleted manually, so no need to pass parent.
View::asQObject() will be removed soon
2022-07-10 21:55:13 +01:00
Sergio Martins
2c924a3a82 Remove some QPointer usages and include cleanup 2022-07-10 18:42:28 +01:00
Sergio Martins
640ef58553 Allow to pass View* to qDebug 2022-07-10 18:36:35 +01:00
Sergio Martins
897e0debca Replace draggableForQObject with draggableForView 2022-07-10 17:58:27 +01:00
Sergio Martins
233736a20b Replace QPointer with a ViewGuard 2022-07-09 17:07:23 +01:00
Allen Winter
e3c08593b9 src/qtcommon/Platform_qt.h - QT_NAMESPACE 2022-07-09 12:05:54 -04:00
Allen Winter
f6315ba4c0 src/EventFilterInterface.h - QT_NAMESPACE 2022-07-09 11:51:31 -04:00
Allen Winter
1bb3e5de37 CMakeLists.txt - fix a typo that causing --warn-uninitialize 2022-07-09 11:42:47 -04:00
Allen Winter
54a29b5cae Merge branch 'master' into 2.0 2022-07-09 11:09:35 -04:00
Allen Winter
2f9f2c9ba6 Merge branch '1.6' 2022-07-09 09:17:19 -04:00
Allen Winter
146338c9f4 Merge branch '1.6' 2022-07-09 09:14:53 -04:00
Allen Winter
b3e398c530 Merge branch '1.6' 2022-07-08 17:35:24 -04:00
Sergio Martins
2c5df301d8 Bump clang-format to 14.0 2022-07-08 06:56:59 +01:00
Sergio Martins
a0aef05b2d Merge branch '1.6' 2022-07-08 06:56:37 +01:00
Sergio Martins
d958e1cc70 vscode: Copy the compile_commands.json from build to source dir
No longer needed to symlink it to make clangd work
2022-07-08 06:47:41 +01:00
Sergio Martins
9a8539fa42 qtquick: Add support for "Always show tabs" option
Shows the tab even if the group only has 1 dock widget
2022-07-07 18:05:33 +01:00
Sergio Martins
5386d44fdb qtquick: Move the "tabbar autohide" property to TabBar
It's a better location than in Stack
2022-07-07 14:36:48 +01:00
Sergio Martins
019692fd2f Store the "tab auto hide" state in the controller, not the view
Added a signal for the QtQuick view too
2022-07-07 13:52:03 +01:00
Sergio Martins
448313b1e3 Rename Group::m_tabWidget to Group::m_stack
Matches its class name now
2022-07-07 11:41:44 +01:00
Sergio Martins
b1605cc58b Rename Group::tabWidget() to Group::stack()
Matches its class name now
2022-07-07 11:37:47 +01:00
Sergio Martins
8383b227aa qtquick|examples: Add an option to hide title bar 2022-07-07 11:30:34 +01:00
Sergio Martins
cd41697ee6 Added Config::startDragDistance()
Allows the user to change the drag threshold without having
to inherit from Platform
2022-07-07 11:11:02 +01:00
Sergio Martins
4e99b44823 Fix some English typos in comments 2022-07-07 11:04:08 +01:00
Sergio Martins
54802ed856 Remove the last Qt event filter from the backend
Ported to our own event filter
2022-07-06 23:08:21 +01:00
Sergio Martins
572b62aa9a Port DragController/Wayland code from Qt event filter
Uses our own event filter abstraction now
2022-07-05 23:22:28 +01:00
Sergio Martins
b74ca53ac8 Fix potential crash
It's a 2.0 bug on wayland though, but at least bail early.
2022-07-05 23:04:19 +01:00
Sergio Martins
74e9cc94e6 Also send DnD events through the event filter interface 2022-07-04 23:37:22 +01:00
Sergio Martins
8edf8737ce Port FallbackMouseGrabber to our own event filter abstraction
No longer uses Qt's event filter directly
2022-07-04 22:33:40 +01:00
Sergio Martins
b6460c11f7 Add EventFilterInterface::onMouseEvent()
Some event consumers don't want to overload N methods and just
overload one instead
2022-07-04 22:06:30 +01:00
Allen Winter
d75e691795 appveyor.yml - for Qt6 builds use Qt6.3 2022-07-04 09:20:53 -04:00
Sergio Martins
b68e348ff3 Add a .pre-commit-config.yaml file 2022-07-04 11:22:53 +01:00
Sergio Martins
54ad9ec2f2 cmake: format with cmake-format 2022-07-04 11:20:19 +01:00
Sergio Martins
9283a55364 Fix Platform only sending mouse press event
Was ignoring other mouse event types
2022-07-03 22:26:15 +01:00
Sergio Martins
35c1517709 Handle double click event in EventFilterInterface too 2022-07-03 22:21:57 +01:00
Sergio Martins
7b9bde123b Use ViewGuard instead of QPointer 2022-07-03 22:12:32 +01:00
Sergio Martins
7b780bc7e9 Add Windows to DisplayType enumerator too 2022-07-03 21:49:18 +01:00
Sergio Martins
84da42c262 Add Platform_qt::isLeftMouseButtonPressed() 2022-07-03 21:44:42 +01:00
Sergio Martins
1bcd425849 Add Platform::displayType() 2022-07-03 21:36:32 +01:00
Sergio Martins
aafa9526f6 Add Platform::organizationName()
So we don't use QCoreApplication::organizationName() directly
2022-07-03 20:56:48 +01:00
Sergio Martins
16565fcd46 Add Platform::setMouseCursor()
So we don't depend directly on qGuiApp
2022-07-03 20:04:53 +01:00
Sergio Martins
f288d953fc Add Platform::applicationName()
so controllers don't access qGuiApp directly
2022-07-03 19:55:26 +01:00
Sergio Martins
f1fb3f1eac Remove unneeded event filter from DockWidget.cpp
It has been ported already
2022-07-03 19:47:26 +01:00
Sergio Martins
70da9cc638 appveyor: Trying to fix the QtQuick tests
Error was: Failed to create OpenGL context for format QSurfaceFormat.
Reproduced in my docker and setting this env var fixed it.
2022-07-03 19:44:03 +01:00
Sergio Martins
c63290e6d3 Port WidgetResizeHandler away from Qt event filter 2022-07-02 21:27:11 +01:00
Sergio Martins
57c311f850 Fix some typos in comment 2022-07-02 21:26:02 +01:00
Sergio Martins
0963967939 Add mouse move and release events to EventFilterInterface 2022-07-02 20:15:13 +01:00
Sergio Martins
7d21516f6d Add a m_thisWeakPtr member to Views
Allows to promote back to shared pointer
2022-07-02 20:12:33 +01:00
Sergio Martins
ba71ad7407 View_qt: Deliver events to any subscribed event filters
Next we'll por some Qt event filters to View's event filter abstraction
2022-07-02 13:43:38 +01:00
Sergio Martins
8af8c603c1 Allow to install event filters on view too
So we can port away from Qt event filters.

In a followup will deliver events, one commit per type or so.
Not all events will be filtered, only the ones used by us
2022-07-02 13:31:16 +01:00
Sergio Martins
d461c41d8b Fix release build 2022-07-02 12:54:55 +01:00
Sergio Martins
edb2538220 Port DockRegistry away from Qt event filters
Uses our filter abstraction now
2022-07-02 12:50:52 +01:00
Sergio Martins
5639b5632a tests: Construct QCoreApplication earlier
The global event filter wasn't being set as it didn't have
a qGuiApp at that point
2022-07-02 12:48:16 +01:00
Sergio Martins
c72fdf3586 Add EventFilterInterface and port DockRegistry to it
Some classes wont have any Qt in it, so they need another way
to install global event filters. Added API to Platform.h for this
purpose. Implemented as regular event filter in Platform_qt.
2022-07-01 15:28:15 +01:00
Sergio Martins
a690477b73 Move isProcessingAppQuitEvent from DockRegistry to Platform
As different platforms will do this differently
2022-07-01 11:31:40 +01:00
Waqar Ahmed
3638622c48 Fix unity build 2022-06-30 13:53:40 +05:00
Waqar Ahmed
7fc7fba697 Fix static build 2022-06-30 13:16:20 +05:00
Sergio Martins
e7a4b3ecdd Windows: Require VS 2019 as a minimum
There's build failures in KDBindings with earlier versions, among
other build problems.
2022-06-29 15:16:04 +01:00
Sergio Martins
5977ffcc1c appveyor: Run ctest with -V
So I can see why tests are failing
2022-06-29 14:56:55 +01:00
Sergio Martins
16f6a0f35c Trying to fix Mingw build
FloatingWindow.cpp:42: error: "NOMINMAX" redefined [-Werror]
2022-06-29 14:50:21 +01:00
Sergio Martins
3845f8cfae Trying to fix msvc 2017 build 2022-06-29 14:48:58 +01:00
Sergio Martins
9546e55cb0 Trying to fix msvc 2017 build 2022-06-29 14:46:41 +01:00
Sergio Martins
5407e23d31 qtquick: Fix leaks at test exit 2022-06-29 14:21:01 +01:00
Sergio Martins
99240a2f4e vscode: Add launch for tst_floatingwindow 2022-06-29 14:18:03 +01:00
Sergio Martins
d7f677c8fc Remove unused ClassicIndicatorsOverlay_qtwidgets file 2022-06-29 13:59:36 +01:00
Sergio Martins
1d0a304d2b Fix a bunch of warnings in tst_multisplitter
The handler wasn't installed so they weren't fatal.
2022-06-29 13:33:40 +01:00
Sergio Martins
bf6e8886b1 Don't build TestHelper* in non-dev mode
They're just for the tests.
2022-06-29 12:37:40 +01:00
Sergio Martins
cadd94c233 Fix drop indicator overlay leak 2022-06-29 12:31:16 +01:00
Sergio Martins
a99c3e1b70 Fix potential crash found by the tests
Item::checkSanity() can be called via deleteLater when we don't
have a platform anymore
2022-06-29 12:31:16 +01:00
Sergio Martins
214e7d2013 qtquick: Fix pure-virtual method call 2022-06-29 10:11:30 +01:00
Sergio Martins
219ad5be01 Merge branch '2.0' of github.com:KDAB/KDDockWidgets into 2.0 2022-06-29 10:00:59 +01:00
Sergio Martins
199ad09185 Fix shadowing warning 2022-06-29 10:53:46 +01:00
Sergio Martins
e60d535242 vscode: Add a msvc launch for the qtquick example 2022-06-29 10:00:26 +01:00
Sergio Martins
f3532e6ea0 Re-add windowForHandle to fix the windows build 2022-06-29 09:36:19 +01:00
Sergio Martins
cba3f77906 Revert "Remove Window::setProperty/property"
This reverts commit ff9a7fba69.

It's still being used by windows code paths
2022-06-29 09:35:12 +01:00
Sergio Martins
91e2df3ead Fix QtTest being included without a dev-mode guard 2022-06-29 10:19:57 +01:00
Sergio Martins
fd4431246c Remove the "groupViewInMDIResize" property from DockRegistry
Moved it into the QmlHelpers, as it's QtQuick specific.
Allows to remove a asQObject() call.
2022-06-28 21:40:12 +01:00
Sergio Martins
2f12cd8f3d Replace a QPointer with a ViewGuard
Removes another usage of asQObject
2022-06-28 20:47:57 +01:00
Sergio Martins
3ef91d8b7f Minor rename: m_draggableWidget -> m_draggableView 2022-06-28 20:36:55 +01:00
Sergio Martins
558eef792f Don't connect to QObject::destroyed directly
Connect to View::beingDestroyed instead.
Decouples more from QObject and allows to remove some asQbject()
calls
2022-06-28 20:33:02 +01:00
Sergio Martins
269e062609 Don't connect to QObject::objectNameChanged
Connect to the view's signal instead.
Decouples a bit more from QObject
2022-06-28 20:22:58 +01:00
Sergio Martins
2eb72114d7 Share View::setObjectName() implementation between qtwidgets/qtquick 2022-06-28 20:12:07 +01:00
Sergio Martins
a0d5c25c29 Remove 2 unneeded usages of QObject stuff 2022-06-28 19:23:43 +01:00
Sergio Martins
934ba440b3 Rename itemForWidget to itemForView
itemForObject is removed as it's not used
2022-06-28 18:56:13 +01:00
Sergio Martins
aff9806ab1 Port away from using event filter in DockWidget.cpp
Platform now abstract the emittion of window activation/deactivation
2022-06-28 18:36:10 +01:00
Sergio Martins
0cd515679f Don't handle ParentChange event directly, use the signal instead
This removes some duplicated code and decouples from QObject a bit
more
2022-06-28 17:24:03 +01:00
Sergio Martins
5a657785d7 Remove event filter from Item
In preparation for non-QObject views
2022-06-28 13:43:43 +01:00
Sergio Martins
39274d3e6b Fix crash 2022-06-28 13:35:31 +01:00
Sergio Martins
d92691bc5c Add a View::parentChanged() signal
Will help removing event filters from non-Qt code
2022-06-28 13:19:23 +01:00
Sergio Martins
83a2620015 Remove View_qtwidgets::asQWidget 2022-06-27 23:54:18 +01:00
Sergio Martins
3dd455bfb7 Port some code away from View::asQObject()
Use View_qt::asObject() instead
2022-06-27 23:37:27 +01:00
Sergio Martins
5389bcc825 Add View_qt as a base class for View_qtwidgets and View_qtquick
So it can contain the "asObject()" method, which we're removing
from View.h
2022-06-27 22:53:42 +01:00
Sergio Martins
49ccecbadd Remove some unneeded asQObject calls 2022-06-27 22:41:37 +01:00
Sergio Martins
64619d85e9 tst_qtwidgets: Remove some usages of asQObject() 2022-06-27 22:00:49 +01:00
Sergio Martins
1e5cbed254 View: Group virtual methods together 2022-06-27 21:55:44 +01:00
Sergio Martins
0e6f38381b Rename hostWidget to hostView 2022-06-27 21:41:48 +01:00
Sergio Martins
cad7cb1c8f Remove View::parent() and Item::host()
Those deal in QObject, which is being phased out
2022-06-27 21:40:05 +01:00
Sergio Martins
696ce887a8 docs: Add documentaiton about how to create a new frontend
Will be updating it as we go.
2022-06-26 22:33:46 +01:00
Sergio Martins
0a496aca76 tests: Add more tests for Window 2022-06-26 22:27:06 +01:00
Sergio Martins
68403c866b Fix Windows build 2022-06-26 21:14:13 +01:00
Sergio Martins
5669e07252 docs++ 2022-06-26 20:58:29 +01:00
Sergio Martins
07524ad00c Replace Qt::WindowState with KDDockWidget::WindowState 2022-06-26 20:45:28 +01:00
Sergio Martins
2f261b6b70 Add KDDockWidgets_p.h to hold private enums 2022-06-26 20:14:41 +01:00
Sergio Martins
ff9a7fba69 Remove Window::setProperty/property
Mostly unused and much easier to use a member variable.
2022-06-26 20:08:21 +01:00
Sergio Martins
d43c68bef4 Add a test for Window::handle 2022-06-26 20:01:56 +01:00
Sergio Martins
5dbf3590f8 Minor API cleanups 2022-06-26 20:00:07 +01:00
Sergio Martins
6ff0a5d759 Window documentation and make some functions not virtual 2022-06-26 19:42:06 +01:00
Sergio Martins
2ee9debb66 dummy: Add needed virtual implementations to Window_dummy.cpp 2022-06-26 19:14:16 +01:00
Sergio Martins
9aab0af1dc qtquick: Fix View::setVisible(false) always showing the window
Adds some tests for Window too.
2022-06-26 01:23:26 +01:00
Sergio Martins
820161ba29 tests: Added Platform::createDefaultViewFactory test 2022-06-26 00:37:10 +01:00
Sergio Martins
0024ed54c8 tests: Add tst_platform 2022-06-25 23:34:30 +01:00
Sergio Martins
f08efcdab7 Add missing pure virtual implementation to dummy frontend 2022-06-25 23:07:36 +01:00
Sergio Martins
3b8e3b6c6b Add a dummy frontend
Goal will be that people can copy it to start a new frontend
2022-06-25 20:34:49 +01:00
Sergio Martins
c1f6d64ac3 Remove a TODO and add some docs 2022-06-25 19:00:12 +01:00
Sergio Martins
a74d2aae7a tests: Add initial test for Window 2022-06-25 18:52:36 +01:00
Sergio Martins
113cdbafe9 Trying to stabilize a test 2022-06-25 18:05:20 +01:00
Sergio Martins
c9fede2aab Remove the FloatingWindow window state overrides
Nothing is inheriting from controller now. Those methods are already
virtual in view, so just remove them from the controller
2022-06-25 17:41:03 +01:00
Sergio Martins
f640d8852b Fix maximize button not being updated
Moved logic into controller
2022-06-25 16:29:41 +01:00
Sergio Martins
8f10d86cad Fix minimize button not being updated 2022-06-25 16:14:36 +01:00
Sergio Martins
02ef55f9f1 Fix auto-hide button not being updated
Moved logic from view into controller.
2022-06-25 13:50:17 +01:00
Sergio Martins
6cd6408bef cmake: Install v1.x compatible headers for QtWidgets
It's nicer to include DockWidget.h than views/DockWidget_qtwidget.h.
QtQuick won't need pretty headers as the recommended way is to use from QML
directly, not C++
2022-06-25 13:13:00 +01:00
Sergio Martins
7ec71d65be Merge branch 'master' into 2.0 2022-06-25 12:54:32 +01:00
Sergio Martins
8ad2ece8b9 Merge branch '1.6' 2022-06-25 12:54:20 +01:00
Sergio Martins
7cc63926d4 Merge branch '1.6' into 2.0 2022-06-25 12:53:44 +01:00
Sergio Martins
6184b06d12 qtquick: Silence benign warning 2022-06-25 12:30:44 +01:00
Sergio Martins
559a195669 Rename layoutWidget to layout
As already done with the class names
2022-06-25 11:47:55 +01:00
Sergio Martins
95d711ece7 qtquick: Allow to use the MDI feature from QML
No need to use low level C++ API anymore
2022-06-25 11:45:01 +01:00
Sergio Martins
74a1520382 examples: Use less controllers 2022-06-25 11:13:21 +01:00
Sergio Martins
31ba0ec52d mdi: Don't expose the controllers directly in the API 2022-06-24 22:42:31 +01:00
Sergio Martins
10f70c8dd6 Move the QString based API from MainWindow_qtquick to MainWindowViewInterface
Makes sense for other frontends too
2022-06-24 22:26:02 +01:00
Sergio Martins
452a89bfa2 Remove some controllers from the QML interface 2022-06-24 21:21:45 +01:00
Sérgio Martins
5b7630b318 Fix namespaced build 2022-06-24 20:36:01 +01:00
Sergio Martins
82b3aba854 Remove ViewWrapper*h from public API 2022-06-24 17:20:09 +01:00
Sergio Martins
0a9506cd21 Probably fix Qt namespaced build 2022-06-24 17:00:01 +01:00
Sergio Martins
10c918b93c Use View instead of ViewWrapper in the api
The latter will be an implementation detail soon
2022-06-24 00:10:50 +01:00
Sergio Martins
2ac996218f Minor typo fix 2022-06-23 22:13:10 +01:00
Sergio Martins
429bcfc4e0 Rename Frame.qml to Group.qml 2022-06-23 16:03:46 +01:00
Sergio Martins
ae5cf1d723 More renaming of "frame" to "group" 2022-06-23 16:01:43 +01:00
Waqar Ahmed
4ba58ac1be Add DockWidget::aboutToDelete
Relying on QObject::destroyed might not be a good idea, fixes the
following ASAN issue:

```
SideBar.cpp:80:22: runtime error: downcast of address 0x6040005c8b90
which does not point to an object of type 'DockWidget'
0x6040005c8b90: note: object is of type 'QObject'
 00 00 00 00  88 64 e7 43 3f 7f 00 00  a0 ff 0e 00 80 60 00 00
70 81 0c 00 c0 60 00 00  01 be be be
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'QObject'
```
2022-06-22 19:16:56 +05:00
Sergio Martins
cc918c5195 More "frame" to "group" renaming 2022-06-22 13:42:22 +01:00
Sergio Martins
bc767cefac Rename asFrameController to asGroupController 2022-06-21 17:32:38 +01:00
Sergio Martins
0aec6dfdb1 Rename more frame variables to group 2022-06-21 17:31:28 +01:00
Sergio Martins
9469273c7a Rename "frame" variables to "group" 2022-06-21 17:12:11 +01:00
Sergio Martins
fe7a8d450c Rename Frame class to Group 2022-06-21 16:34:20 +01:00
Sergio Martins
b45644af74 Rename FrameViewInterface class to GroupViewInterface 2022-06-21 09:01:44 +01:00
Sergio Martins
73d627554a Remove Frame.h/cpp to Group.h/cpp
It's a better name.
Files only for now. Contents will come in a followup.
2022-06-21 08:51:52 +01:00
Sergio Martins
b9773cd262 qtquick: Move some Q_INVOKABLES to the views
As only the views are exposed
2022-06-19 23:27:21 +01:00
Allen Winter
47ad860921 Merge branch '1.6' 2022-06-19 16:02:49 -04:00
Allen Winter
1c6c7e767f Merge branch '1.6' 2022-06-19 15:39:46 -04:00
Sergio Martins
da70b1baed qtquick: Don't overload Q_INVOKABLES
Apparently QML doesn't support it very well.

Fixes #291
2022-06-19 20:26:19 +01:00
Sergio Martins
9072555814 ChangeLog: Explain what 2.0 is about 2022-06-19 15:22:54 +01:00
Sergio Martins
b599554ba7 Update ChangeLog with the one from master 2022-06-19 15:14:17 +01:00
Sergio Martins
2b62b1965a Merge branch 'master' into 2.0
empty merge with "-s ours" just to reconcile. All changes from
master have been cherry-picked manually since the code has changed
too much todo a normal merge
2022-06-19 14:43:22 +01:00
Sergio Martins
ea55c74768 Added MainWindow::internalLayout()
Allows the application to add more widgets next to the drop area.

(cherry-picked from commit 74dcbd994a)
2022-06-19 14:40:59 +01:00
Sergio Martins
729624ab04 EGLFS: Don't raise the main window when docking
EGLFS doesn't honour that the floating windows should be
on top and will make the floating windows go behind.

It's also unneeded to raise it on eglfs, since it's fullscreen.

(cherry-picked from commit d06c6e8f11)
2022-06-19 14:37:52 +01:00
Sergio Martins
4fa43c7ba1 Make numSideBySide_recursive() ignore invisible items
We have invisible items that just remember the position of
other items.

(cherry-picked from commit 9f96eff663)
2022-06-19 14:37:06 +01:00
Sergio Martins
1f95f67a15 Add DropLocation_Horizontal and DropLocation_Vertical
So we can quickly use a bitwise and to see if an arbitrary
drop location is vertical or horizontal.

(cherry-picked from commit 3260c65a6c)
2022-06-19 14:27:32 +01:00
Sergio Martins
73fd21939f Allow segmented indicators to disable individual segments
The application developer might now want to show some segments.
Now he can use Config::setDropIndicatorAllowedFunc(), which previously
only worked for classic indicators

(cherry-picked from commit 2c8ceb67ef)
2022-06-19 14:23:35 +01:00
Sergio Martins
104a065aeb Pass the DropArea to setDropIndicatorAllowedFunc() too
So the lambda can have more advanced usage and inspect the
target layout before allowing or disallowing the drop.

For our use case, we want to limit max 3 dock widgets side by side,
for example.

(cherry-picked from commit 982904e2ba)
2022-06-19 14:22:12 +01:00
Sergio Martins
7b4e04703d Added MultiSplitter::numSideBySide_recursive()
(cherry-picked from commit f5622732ce)
2022-06-19 13:52:30 +01:00
Sergio Martins
a705ccfe5e Fix typo in code snippet 2022-06-19 13:48:44 +01:00
Sergio Martins
84a8fd61b4 MainWindow: Allow to avoid the immediate QWidget::create()
In case you're going to put the main window into a layout you
don't want to have it create a QWindow.

(cherry-picked from commit 4727c9c7fc)
2022-06-19 13:25:53 +01:00
Sergio Martins
724a67f2ef distro/ - update for ubuntu22.04 and fedora36
(cherry-picked from commit bf255c104f)
2022-06-19 13:21:44 +01:00
Sergio Martins
d1e29e6773 Add the possibility of setting the margin used for overlay docks
(cherry-picked from commit 9b8759c472)
2022-06-19 13:19:50 +01:00
Sergio Martins
f2ddbd2cc3 Added KDDockWidgets::InitialVisibilityOption::PreserveCurrentTab
So you can insert into a tab group without changing the current
tab, if you want.

(cherry-picked from commit 58b8633e3d)
2022-06-19 13:14:54 +01:00
Sergio Martins
8a0fa46deb Don't show middle dock indicator if frame isn't dockable
This was implemented but the logic was wrong.
Fixes central persistent showing the central indicator.

(cherry-picked from 6166e5805c)
2022-06-19 13:06:09 +01:00
Sergio Martins
28cc64be4a Remove unused/duplicated file 2022-06-19 13:04:05 +01:00
Sergio Martins
4856da3bec .pylintrc - initial pylint config file
(cherry-picked from commit b1379f0bef)
2022-06-19 13:00:49 +01:00
Sergio Martins
08518e02e0 various - fix some misspellings
(cherry-picked from commit f3da0f0547)
2022-06-19 13:00:06 +01:00
Sergio Martins
1e7f0d7c5f various - update copyright year
(cherry-picked from commit b2fc0c3eb1)
2022-06-19 12:57:51 +01:00
Sergio Martins
793661ea09 Workaround QTBUG-102430, don't move still maximized window
When dragging a maximized window we show normal, but we can
only start moving it when the window managers acknowledges the new
state. The state in QWidget isn't reliable.

(cherry-picked from commit 6e7268e42a)
2022-06-19 12:54:12 +01:00
Sergio Martins
4c177d7823 Save the last known window state from the window manager POV
Required for QTBUG-102430

(cherry-picked from commit 7e6c5b2d9f)
2022-06-19 12:52:35 +01:00
Sergio Martins
e763cb138a Add a comment regarding QTBUG-102430 2022-06-19 12:47:11 +01:00
Sergio Martins
6da693c5da Workaround FloatingWindow::windowStateChanged regarding QTBUG-102430
QWidget::windowStateChanged isn't useful as it's emitted once sync
and another async, with the same value. Only the async one is useful
as it will represent the real window manager state. Then we can do
further moves.

The QWindow one happens to be good (async), so use that one instead.

(cherry-picked from commit d4fe17a0bf)
2022-06-19 12:42:48 +01:00
Sergio Martins
d1de3a29b4 CMakeLists.txt - Python bindings are not supported in Unity builds
fixes #284

(cherry-picked from commit c6ce421432)
2022-06-19 12:30:57 +01:00
Sergio Martins
940991c75e Use FloatingWindow::isMaximizedOverride() instead of isMaximized()
This is for issue #286.
Allows users to workaround buggy window managers.

(cherry-picked from commit 47f773ab7c)
2022-06-19 12:22:32 +01:00
Sergio Martins
c0d1bd3f92 tests|qtquick|Windows: Stabilize a test
The warning is benign and unrelated to anything kddw is doing

(cherry-picked from commit 1f638d2c7a)
2022-06-19 12:16:46 +01:00
Sergio Martins
92192b7949 Fix position of right overlay dockwidgets when there's a toolbar on the left
(cherry-picked from commit 7b73393095)
2022-06-19 12:15:23 +01:00
Sergio Martins
9fda86a511 Linux: Fix dragging of maximized floating windows
They should restore their normal size when the drag starts

(cherry-picked from commit 1305dee081)
2022-06-19 12:13:50 +01:00
Sergio Martins
4114f00183 Added dockWidgetInserted|Removed signals to TabBarWidget
Since QTabBar doesn't have them.
Useful for custom tab bars

(cherry-picked from commit 743dbc0718)
2022-06-19 12:04:25 +01:00
Sergio Martins
848327d8b3 TitleBarWidget: Mark members as protected
So custom titlebars have more power

(cherry-picked from commit fd4588de0f)
2022-06-19 11:59:21 +01:00
Sergio Martins
44d38f9f84 Added TitleBar::tabBar()
Useful for people writing custom titlebar's with style that depends
on the current tab

(cherry-picked from commit 6ba10cfe12)
2022-06-19 11:57:26 +01:00
Sergio Martins
fe7f71d986 MDI: Fix another case of showing resize handles wrong
(cherry-picked from commit 25b04d7ed8)
2022-06-19 11:48:08 +01:00
Sergio Martins
05b7980cfe MDI: Fix case where resize cursor would be shown for frame bellow
Was already fixed a few days ago, but this is the case for nested
mdi.

(cherry-picked from commit e345e89c35)
2022-06-19 11:46:18 +01:00
Sergio Martins
e2e34fb11b examples: Remove more duplicate MyWidget.cpp/h files
share with main example instead

(cherry-picked from commit bb4cf802f5)
2022-06-19 11:35:54 +01:00
Sergio Martins
1935d3bace example: Allow to test propagation of close event in the mdi example
(cherry-picked from commit 701069617c)
2022-06-19 11:32:37 +01:00
Sergio Martins
8767159cc9 example: Remove duplicate minimal-mdi/MyWidget.cpp
It was using the cpp from the main example but the header from
minimal-mdi. Instead, share both the impl and the header

(cherry-picked from commit a8c50f1876)
2022-06-19 11:28:41 +01:00
Sergio Martins
198bd60565 example: Added --blocks-close-event
Makes dock widget #0 reject the close event, meaning it won't close.

(cherry-picked from commit 21765efbac)
2022-06-19 11:18:02 +01:00
Sergio Martins
f8b1745c68 Forward QCloseEvent to the MDI widgets too
Fixes case where docked MDI widgets were not able to block a close

(cherry-picked from commit 61cca1e5ec)
2022-06-19 00:56:42 +01:00
Sergio Martins
30f43d7579 Fix MainWindow not propagating close events to docked widgets
Nested FloatingWindows already supported it, so make it consistent.

Personal take: In a non-docking world, users can override their
main window close event and prevent a close, to save a document
or such. However, in a docking world, the main window developer
won't know which widgets are docked, so forwarding needs to happen,
as some might have documents to save.

(cherry-picked from commit 7db9938b85)
2022-06-19 00:46:49 +01:00
Sergio Martins
950914e15c Further move onCloseEvent to base class
So that it can be reused by MDI layouts too

(cherry-picked from commit 01cc915734)
2022-06-19 00:34:31 +01:00
Sergio Martins
bd4aed18c9 Refactor: Move close event logic from FloatingWindow to DropArea
So main window can use it too

(cherry-picked from commit 3454b67a45)
2022-06-19 00:32:46 +01:00
Sergio Martins
d47130f0c8 appveyor: cherry-picked changed from master
f98ce37c12
339edf1143
2022-06-19 00:25:07 +01:00
Sergio Martins
f530668711 Don't dereference potentially nullptr 2022-06-19 00:23:54 +01:00
Sergio Martins
67bb7c16cf CMakeLists.txt - find COMPONENTS to search for Qt modules
(cherry-picked from commit 8b8ef7f2b0)
2022-06-19 00:22:01 +01:00
Sergio Martins
c30a266c01 Don't try to restore to previous position if there isn't any
(cherry-picked from commit 524dff9105)
2022-06-19 00:14:33 +01:00
Sergio Martins
66b91c1de3 Make redocking floating windows with tabs possible
TitleBar::isFloating() was returning false, while it should
have returned true.

Fixed by making isFloating() simpler and dumb. isFloating() should
only say if it belongs to a floating window or not. It shouldn't
contain any logic about whether button should be visible or not.

There's already logic elsewhere that will hide the float button
in case there's nesting.

Fixes issue #96 and #44

(cherry-picked from commit 0099a19a82)
2022-06-19 00:09:21 +01:00
Sergio Martins
4c670a552e MDI: Fix resize cursor appearing for frames that had others on top
(cherry-picked from commit e6b8636e88)
2022-06-19 00:05:19 +01:00
Sergio Martins
d5e46dff31 MDI: Fixed closing dock widget in MDI would close main window
We only close the window when the window is a FloatingWindow and
it's the last frame

(cherry picked from commit 86419fd979)
2022-06-18 23:37:02 +01:00
Sergio Martins
3695595826 Merge branch '1.6' 2022-06-18 23:08:40 +01:00
Sergio Martins
303532483b vscode: filter-out some todo-tree folders, mostly 3rdparty 2022-06-18 22:24:21 +01:00
Sergio Martins
ff92af1e62 Removed some TODOs
The comment is still there in case it's interesting for someone,
but it's not something that will be worked on
2022-06-18 22:24:21 +01:00
Sergio Martins
49b2a10cc6 Fix QtQuick build on Windows 2022-06-18 19:13:45 +01:00
Sergio Martins
a3f7126dfe cmake: Prefix ci build dirs with "build-" 2022-06-18 19:49:08 +01:00
Sergio Martins
2faecc68c0 Don't build the "Fuzzer"
It hasn't been needed in a long time.
I'll enable it once it's needed. Build needs fixing though
2022-06-18 19:48:19 +01:00
Sergio Martins
fe75297a29 cmake: Add CI presets
The idea is to test the different code paths, that means:
  - Qt5 vs Qt6
  - dev-mode vs release

but also to test that the qtquick frontend isn't including anything
from qtwidgets and vice-versa.
2022-06-18 19:40:59 +01:00
Sergio Martins
60c6ffaabb Rename MDIArea class to MDIArea_qtwidgets
To match the filename now
2022-06-18 18:15:19 +01:00
Sergio Martins
408fe315ed Rename MDIArea.h to views/MDIArea_qtwidgets.h
As done for all other views. This one was missing
2022-06-18 17:51:19 +01:00
Sergio Martins
5ec68ef608 README: Add a note to use 1.6 branch instead 2022-06-18 13:46:17 +01:00
Sergio Martins
c7f33f589e README: Add warning that 2.0 is in active development 2022-06-18 13:44:49 +01:00
Sergio Martins
942d086905 Fix linking on Qt/macOS 2022-06-18 13:36:07 +01:00
Sergio Martins
8dbd87ae0d cmake: Only add qtquick/ to include path if it's being built
And vice-versa for qtwidgets
2022-06-18 13:32:36 +01:00
Sergio Martins
f04e813af3 Fix Platform.h not being installed 2022-06-18 13:17:58 +01:00
Sergio Martins
a0accacb5d Rename views/MainWindowMDI.h -> ../views/MainWindowMDIViewInterface.h
This one was missing
2022-06-18 13:14:18 +01:00
Sergio Martins
1b0bae7780 Don't include Window.h in DockRegistry.h
As the latter is installed while the former is not.
Window.h depends on KDBindings so would rather not require it publically.
2022-06-18 13:06:29 +01:00
Sergio Martins
f7bb0c1dbd Fix examples trying to be installed to /
Only worked when being built from within kddw.
2022-06-18 12:42:24 +01:00
Sergio Martins
4c4dcf4423 Move KDBindings usage from Platform.h to Platform_p.h.
So user doesn't need to install it
2022-06-18 12:28:54 +01:00
Sergio Martins
7017ce8396 Move KDBindings usage from View.h to View_p.h
KDBindings is implementation detail. User won't have to install
it, at this point.
2022-06-18 12:15:42 +01:00
Sergio Martins
9f1a9df621 cmake: Install view interface headers too 2022-06-18 11:48:29 +01:00
Sergio Martins
d7b57d460f cmake: Don't install Window*h and Item_p.h
They are unneeded, and expose kdbindings
2022-06-18 11:46:46 +01:00
Sergio Martins
6be5339fd3 Add d-ptr to DockRegistry, hides usage of kdbindings 2022-06-18 11:21:53 +01:00
Sergio Martins
82d933ad34 Remove unused include 2022-06-18 11:16:41 +01:00
Sergio Martins
cae9627e06 Add a d-ptr to FloatingWindow_qtwidgets
So we don't expose kdbindings in the API
2022-06-18 11:14:15 +01:00
Sergio Martins
5a6ceade6c cmake: Fix QtQuick not being found when using installed kddw 2022-06-18 10:39:50 +01:00
Sergio Martins
e2870dbe4f cmake: Fix warning about KDDockWidgets_LIBRARY_QTID not being defined 2022-06-18 10:35:19 +01:00
Sergio Martins
d5471aceb6 cmake: Install headers 2022-06-18 10:25:52 +01:00
Sergio Martins
e63a34a4a5 Rename DockRegistry_p.h -> DockRegistry.h
People use it.
2022-06-18 09:28:03 +01:00
Sergio Martins
8be6183543 Include cleanup
Removed unneeded controllers/ includes from headers
2022-06-18 09:15:30 +01:00
Sergio Martins
1ee5d21d4a examples: Remove controller usage, use views instead
Controllers is low level API
2022-06-18 08:36:09 +01:00
Sergio Martins
26ba2199cb Moved 2 more DockWidget enums to KDDockWidget.h
So users don't have to include controllers/DockWidget.h
2022-06-18 08:16:16 +01:00
Sergio Martins
08d2b6f764 Fix documentation of MyTitleBar_CSS.h
It was still refering to the old widgets
2022-06-18 07:54:05 +01:00
Sergio Martins
7ae49ee330 qtquick: Move last DockWidget Q_PROPERTY from controller to view 2022-06-18 00:34:26 +01:00
Sergio Martins
a609f2233b Move DockWidgetOption enum to KDDockWidget.h
controllers/DockWidget.h is not something users will include directly
2022-06-18 00:27:58 +01:00
Sergio Martins
d3de373995 Move "widget" Q_PROPERTY to the qtquick view 2022-06-17 21:54:30 +01:00
Sergio Martins
a5f364da03 qtquick: Fix qml accessing the frame controller
It should access the view instead, as the controller will cease to
be QObject
2022-06-17 20:12:44 +01:00
Sergio Martins
499c9412bb Don't make all DropArea views all DropArea::onResized()
Do it in the controller once, instead of repeating it
2022-06-17 20:06:51 +01:00
Sergio Martins
c48a100f73 Remove unused titleBar() method 2022-06-17 19:58:22 +01:00
Sergio Martins
7e7c9d7300 Rename the remaining view interfaces to *ViewInterface 2022-06-17 18:56:34 +01:00
Sergio Martins
0600c42775 Move common code info FrameViewInterface
So it's not duplicated between QtWidgets and QtQuick
2022-06-17 18:19:01 +01:00
Sergio Martins
4a47366ba0 Suffix our view interfaces with "*ViewInterface.h"
So we know they are a view interface. They'd have the same name
as the controller otherwise
2022-06-17 11:19:27 +01:00
Sergio Martins
a330042339 qtquick: Use enum instead of hardcoded number 2022-06-15 22:01:27 +01:00
Sergio Martins
5e2cc2cc12 Remove old fwd header 2022-06-15 21:56:18 +01:00
Sergio Martins
2a6bd9e415 Add overloads taking view interface instead of controller
People won't be using the controllers directly
2022-06-15 21:51:56 +01:00
Sergio Martins
1e3acd2a92 Remove done TODO 2022-06-15 21:18:56 +01:00
Sergio Martins
ab50f0f19b qtquick: Add the invokables to DockWidget_qtquick.h
Actually in the interface class and we mark them invokable with
Q_MOC_RUN trick
2022-06-15 21:13:27 +01:00
Sergio Martins
1283cc87dc qtwidgets: Added DockWidget_qtwidgets::widget() 2022-06-15 20:30:01 +01:00
Sergio Martins
c373354c0c qtquick: Move some properties to DockWidget view
The controller won't be a QObject soon
2022-06-15 20:25:02 +01:00
Sergio Martins
d2aba705fb qtquick: Rename guestView to guestItem in the public API 2022-06-15 20:13:42 +01:00
Sergio Martins
78815664cc Move some dock widget view code into the shared DockWidgetViewInterface 2022-06-15 20:10:20 +01:00
Sergio Martins
e754bb25c6 Pass the controller to DockWidgetViewInterface
So it can start to have an API
2022-06-15 19:56:34 +01:00
Sergio Martins
4a3d15432e Add a DockWidgetViewInterface
to share code between both QtQuick and QtWidget DockWidget views
2022-06-15 19:52:34 +01:00
Sergio Martins
921d94d731 Added MainWindow_qtwidgets::setPersistentCentralWidget()
Which is nicer for the end user as it deals in QWidget
2022-06-15 19:37:12 +01:00
Sergio Martins
01b2bbc11c Rename "persistent widget" to "persistent view" 2022-06-15 19:27:04 +01:00
Sergio Martins
a45f53f9d9 examples: Don't mention mainWindow much in the examples
Added DockRegistry::mainDockingAreas() as synonym for mainwindows().
2022-06-15 18:45:37 +01:00
Sergio Martins
3e44e0c9a9 qtquick: Add API to the MainWindow view
QtQuick can't access our controllers (as they won't be QObject),
so they need to access via the view.
2022-06-15 18:37:27 +01:00
Sergio Martins
63f0bc9e02 Move some invokables from MainWindow controller to the qtquick view
As Q_INVOKABLE is just for QtQuick.
There's still some remaining to move, but they are exposing Controllers,
so will need a different API.
2022-06-15 18:13:50 +01:00
Sergio Martins
1c9b44394e Add a comment 2022-06-15 18:01:49 +01:00
Sergio Martins
84315daa1a Move MainWindow Q_PROPERTIES to the qtquick view
qtquick and views in general won't have access to controllers much
2022-06-15 17:59:17 +01:00
Sergio Martins
337afd2919 Minor header cleanup 2022-06-15 17:16:02 +01:00
Sergio Martins
126ed773cd Make MainWindow::init() private 2022-06-15 16:55:46 +01:00
Sergio Martins
38432ccacd Make MainWindow::windowGeometry() private 2022-06-15 16:09:04 +01:00
Sergio Martins
0825a6bdc2 Move sidebars into MainWindow controller
No reason to have them duplicated between qtwidgets and qtquick
2022-06-15 15:57:50 +01:00
Sergio Martins
cd35f1ff62 MainWindow header cleanup 2022-06-15 15:29:42 +01:00
Sergio Martins
0c95550af6 Move some common view code into MainWindowViewInterface
So that it's not duplicated between QtWidgets and QtQuick
2022-06-15 12:29:14 +01:00
Sergio Martins
e1fe8054d0 Remove public MainWindow::onResized 2022-06-15 11:23:51 +01:00
Sergio Martins
29c675661f cleanup regarding DockWidget::show() 2022-06-15 05:32:54 +01:00
Sergio Martins
de917f103a Remove unneeded QtWidget ifdefs and TODO 2022-06-15 05:25:09 +01:00
Sergio Martins
95ff95e995 Remove TODO and shorten namespace 2022-06-15 05:22:41 +01:00
Sergio Martins
9fdf0c2ae1 examples: Remove unneeded header and TODO 2022-06-15 05:18:11 +01:00
Sergio Martins
3b2a395668 Fix build with Wweak-vtables
Have to move kdbindings to its own target so we can use -isystem
with it, as it doesn't support Wweak-vtables
2022-06-15 05:01:10 +01:00
Sergio Martins
fec58dd217 Add missing exports 2022-06-15 04:34:49 +01:00
Sergio Martins
148a25a452 Fix some Wweak-tables warnings 2022-06-15 04:33:35 +01:00
Sergio Martins
e6dd002ca8 qtquick: Rename MainWindowLayout to DockingArea
Since it's not an actual Window, it's just a QQuickItem. QtQuick has
proper Window items that mean an actual Window.
2022-06-15 00:27:41 +01:00
Sergio Martins
95acf7a4cb qtquick: Don't register Item, it's unneeded 2022-06-15 00:18:40 +01:00
Sergio Martins
73a5809f62 qtquick: Remove unneeded qml types registering 2022-06-15 00:17:10 +01:00
Sergio Martins
627b6a1593 qtquick: Bump qml imports to 2.0 2022-06-15 00:15:44 +01:00
Sergio Martins
755bc6ac14 cmake: Don't add src/ to include path
Fully qualify includes instead
2022-06-14 16:57:22 +01:00
Sergio Martins
dafa14536f examples: include cleanup 2022-06-13 23:39:31 +01:00
Sergio Martins
a4d337e891 Fully qualify header paths when including controllers
so this still works when private headers are installed
2022-06-13 23:24:43 +01:00
Sergio Martins
44476789c2 Add fwd headers for the controllers 2022-06-13 23:01:57 +01:00
Sergio Martins
458ae05564 Move qtquick qrc into qtquick folder/
as it's unrelated to the other frontends
2022-06-13 22:51:22 +01:00
Sergio Martins
169d2fe8e2 qtquick: Fix custom titlebar example
qrc path was wrong
2022-06-13 22:45:34 +01:00
Sergio Martins
4615936f9e Fix minor typo 2022-06-13 22:42:28 +01:00
Sergio Martins
ebaf0d170f examples: Rename minimal_mdi to mdi
There's not much functionality to show, so no point in saying it's
minimal
2022-06-13 22:39:31 +01:00
Sergio Martins
040fe14907 examples: Uncomment code that sets separator thickness
It works now
2022-06-13 22:32:55 +01:00
Sergio Martins
59013303ac examples: Port MyViewFactory to new design
It was commented out still
2022-06-13 22:31:13 +01:00
Sergio Martins
4dab634abf docs++ 2022-06-13 20:44:59 +01:00
Sergio Martins
32b6c3acbe Simplify ViewFactory by making it receive View parents instead of Controllers
Users don't need to worry about such details, like casting to QWidget.
2022-06-13 20:35:57 +01:00
Sergio Martins
91398d5fab Minor: Make method protected instead of private 2022-06-13 20:16:11 +01:00
Sergio Martins
b596aaf1f4 Add the qtwidget and qtquick fwd headers to include path 2022-06-13 19:48:37 +01:00
Sergio Martins
ec56120290 Don't include controller headers in view headers
view headers will be installed, so shouldn't leak impl details
much. Controllers are more low level things that the user won't use
much
2022-06-13 19:44:47 +01:00
Sergio Martins
8ba160b0f6 Add forward headers for the views 2022-06-13 19:16:51 +01:00
Sergio Martins
6a6854ed84 example: Rename MyFrameworkWidgetFactory to MyViewFactory 2022-06-13 19:00:58 +01:00
Sergio Martins
8b49eabe95 Bump KDBindings 2022-06-13 18:45:05 +01:00
Waqar Ahmed
a17f6468cd use 0 as default serializationVersion 2022-06-13 14:50:43 +05:00
Waqar Ahmed
c62b1a5a9b Dont use nlohmann::operator[], use value() instead 2022-06-13 14:47:30 +05:00
Sergio Martins
2e4c01f604 Move some m2 TODOs to m3, as they're not related to QtQuick stabilization 2022-06-13 02:46:31 +01:00
Sergio Martins
3ab3076263 Fix some low hanging TODOs 2022-06-13 02:37:03 +01:00
Sergio Martins
efc42e8d3f Move updating size constraints from FloatingWindow view to controller 2022-06-13 02:28:56 +01:00
Sergio Martins
e49ecc880e Replace View::onLayoutRequest() with a signal
Which moves more logic into the controllers.
2022-06-13 02:12:12 +01:00
Sergio Martins
cfd4e61a3b Remove View::setLayoutItem()
Because it's specific to Frame
2022-06-13 01:49:06 +01:00
Sergio Martins
b56cf151fe TitleBar_qtwidgets: Header cleanup 2022-06-12 16:34:35 +01:00
Sergio Martins
87414585ea SideBar_qtwidgets: Cleanups
Include cleanups and making things protected/private.
2022-06-12 16:27:04 +01:00
Sergio Martins
3b814866e2 Remove unneeded isVertical() from Sidebar view 2022-06-12 16:21:11 +01:00
Sergio Martins
55620a5d10 TODO cleanup
Removed stale TODOs and promoted some to TODOm2 , as they should
be tackled next
2022-06-12 16:07:29 +01:00
Sergio Martins
5a99c8390a qtquick: Allow the user to pass a different QQmlEngine to DockWidget
Like was the case in v1.x
2022-06-12 15:51:00 +01:00
Sergio Martins
1f7ac6897c qtquick: Rename setWidget to setGuestView 2022-06-12 15:33:56 +01:00
Sergio Martins
24f1f6be33 qtquick: Remove unnneeded connect from frame view
It's already done in the controller
2022-06-12 15:29:21 +01:00
Sergio Martins
6c589f0500 Postpone some m2 TODOs to m3
m2 will focus on QtQuick being usable
2022-06-12 15:25:35 +01:00
Sergio Martins
767bbcb251 Make layout linter work against any frontend 2022-06-12 15:16:30 +01:00
Sergio Martins
c12da6b6d5 cmake: Don't link against QTTest in release builds 2022-06-12 14:51:57 +01:00
Sergio Martins
ab2b481a80 cmake: QtQuick frontend no longer needs to link against QtWidgets 2022-06-12 14:43:17 +01:00
Sergio Martins
fb844bc989 Don't use QAction directly
In prepartion for qtquick frontend not needing QtWidgets
2022-06-11 18:48:37 +01:00
Sergio Martins
098a368c79 qtquick: Use QGuiApplication for tests, not QApplication 2022-06-11 18:29:12 +01:00
Sergio Martins
1acbf48786 Don't depend directly on QSizePolicy, as that's QtWidgets
Introduce our own enum. Soon our qtquick frontend won't link
against QtWidgets
2022-06-11 18:22:38 +01:00
Sergio Martins
e120f6f318 tests: Fix windows tests regarding frame pos vs client pos confusion
It's also more readable now.
Might break on linux though, will need to investigate further if that's
the case. In many cases it's just a timing issue, as some platforms are
"more async" than others to add frame
2022-06-11 16:17:10 +01:00
Sergio Martins
a7b6dd5f24 Port the rest of win32 specific code 2022-06-11 15:50:03 +01:00
Sergio Martins
5cd46d572e Remove a Q_OS_WIN_TODO, nothing to port there 2022-06-11 15:24:32 +01:00
Sergio Martins
0031f1bcfd Release build now builds 2022-06-11 15:24:19 +01:00
Sergio Martins
42998971cc Make DockWidget's d ptr public
This gives more power to users, at their own risk ofc.
2022-06-11 15:22:34 +01:00
Sergio Martins
35f8e3c3f6 cmake: Disable unity build from release builds
It makes it hard to catch missing includes
2022-06-11 15:14:00 +01:00
Sergio Martins
98a8e67f9b Build fixes for release builds 2022-06-11 15:08:25 +01:00
Sergio Martins
6c53777f1b Fix build on Windows 2022-06-11 14:31:20 +01:00
Sergio Martins
02a8da4fb8 tests: Remove whitelisted warning
It doesn't happen anymore
2022-06-11 14:10:00 +01:00
Sergio Martins
29fd6f4a40 qtquick: Fix binding loops
This also restores behaviour with v1.x regarding setParent
2022-06-11 14:03:41 +01:00
Sergio Martins
0f6be75620 vscode: Add a qtquick launcher to the workspace too 2022-06-11 13:25:52 +01:00
Sergio Martins
78025d1e34 Fix name of examples in README and such, since they got renamed 2022-06-11 13:20:26 +01:00
Sergio Martins
b75a10b9eb examples: Normalize names of examples 2022-06-11 13:06:41 +01:00
Sergio Martins
6aed1508af tests: Don't run tst_qtwidgets if only qtquick tests were specified 2022-06-11 12:38:57 +01:00
Sergio Martins
e9c050b659 tests: Delete all QWidgets when test stops
So we don't go with garbage to the QtQuick tests
2022-06-11 12:38:11 +01:00
Sergio Martins
3c9598a560 tests: Fix Qt6/qtquick tests by supressing benign warnings
The main window can be smaller than our layout, we have no way
of imposing a min size to the QWindow, as we don't know what
the user has in main.qml, so don't qWarn when that happens.

This can be handled in the user side of things though, as our
layout exposes its min size, which the user should honour
2022-06-11 12:07:19 +01:00
Sergio Martins
6bded5e832 remove code line that was a no-op 2022-06-11 10:52:46 +01:00
Sergio Martins
e34b4c4d09 tests: Fix Qt6 qtquick tests regarding mouse grabbing not working
QtQuick tests don't work well if run after the QtWidget ones,
so change order.
2022-06-11 00:24:42 +01:00
Sergio Martins
3662f30ea4 vscode: Update the workspace file for Qt6 2022-06-10 23:42:44 +01:00
Sergio Martins
63ff503568 vscode: Remove qtquick workspace files
The same build builds both qtwidgets and qtquick
2022-06-10 23:25:34 +01:00
Sergio Martins
1070cbce87 tests: Remove unneeded test skipping on Qt < 5.15
Minimum is 5.15 nowadays
2022-06-10 23:12:10 +01:00
Sergio Martins
a1d62522f3 Fix Qt6 build 2022-06-10 19:28:25 +01:00
Sergio Martins
cfd90b6779 tests: Enable tests for QtQuick as they pass now 2022-06-10 19:25:37 +01:00
Sergio Martins
b184c6f830 qtquick: Reduce number of sanity checks during incomplete resizes
Fixes the last broken QtQuick test.
2022-06-10 19:24:11 +01:00
Sergio Martins
2aefa9efa0 qtquick: Fix windows being resized bellow their min size 2022-06-10 18:59:53 +01:00
Sergio Martins
5791198c51 qtquick: Fix some benign sizing warnings
During resize QtQuick will trigger lots of calls to setSize()
since it updates the width and the height separately.

Run our sanity checks only after with width and height are done
being updated, and not twice
2022-06-10 15:33:16 +01:00
Sergio Martins
a94daba3fc Bound the suggested floating window geometry
Because why not, seems correct. No bug would happen with QtWidgets
since QtWidgets respect the min sizes of their children, but for
QtQuick it's more flaky as there's no intrinsic mechanism for
min sizes, so give it some help
2022-06-10 14:16:57 +01:00
Sergio Martins
8e85e46ee9 tests: Make the view min size be the same as it was in 1.x 2022-06-08 19:02:01 +01:00
Sergio Martins
118fe3d32e qtquick: Fix guest view not getting parented when getting added
To be improved on milestone 3
2022-06-08 12:22:57 +01:00
Sergio Martins
fb31f893ae Remove unneeded QJsonDocument include 2022-06-08 00:59:16 +01:00
Sergio Martins
d275226df9 qtquick: Fix Stack creating two TabBar's
It's created by the controller, we shouldn't create another one
in the view
2022-06-08 00:32:14 +01:00
Sergio Martins
a5279b5efd qtquick: Minor refactoring, add TabBar_qtquick::qmlTabs() 2022-06-08 00:00:41 +01:00
Sergio Martins
81007f629f qtquick: Fix flaky handling of tabs
The flickable of TabBar from QtQuickControls has a bogus contentX
when removing and readding tabs. Instead implement tabAt() via
iteration and checking which tab contains the point
2022-06-07 23:34:54 +01:00
Sergio Martins
060fe44e71 Remove some unneeded QApplication includes 2022-06-07 17:14:05 +01:00
Sergio Martins
3c13f51017 tests: Also resize the view, not only the window when creating main window
Both are needed. This is how it worked in v1
2022-06-07 00:24:38 +01:00
Sergio Martins
ad9cdad927 qtquick: Don't do geometry changes at destruction
It's unneeded and makes tests fail. Setting visibility would trigger
a bunch of code that we don't want at destruction time
2022-06-06 23:53:22 +01:00
Sergio Martins
31992dcb83 tests: Fix tst_honourGeometryOfHiddenWindow on XCB
The suggested height should be smaller than the floating window
min-size.
2022-06-06 23:35:31 +01:00
Sergio Martins
a5ecfbdd91 tests: Fix createMainWindow having different behavior between frontends 2022-06-06 23:03:53 +01:00
Sergio Martins
0929fb1c75 qtquick: Fix showing qtquick window not setting the root item visible 2022-06-06 15:43:53 +01:00
Sergio Martins
4515c85f91 Don't call "Frame::isMDI" when layout is being destroyed
Just emit the signal always, QtQuick will reread the property.
It's better than doing a complex solution
2022-06-06 15:30:34 +01:00
Sergio Martins
230f562cb4 qtquick: Fix floating window being deleted at construction
When the window is hidden we destroy it, but not while it's
still being constructed.
2022-06-06 14:58:09 +01:00
Sergio Martins
3758dc7dda Fix weird logic in FloatingWindow::isBeingDeleted() 2022-06-06 14:48:58 +01:00
Sergio Martins
464624f2a5 qtquick: Don't dereference FloatingWindow while it's being destructed
Caught by UBSAN
2022-06-06 13:53:31 +01:00
Sergio Martins
0be61b0a1b qtquick: Don't delete dock widgets in frame view dtor
views shouldn't delete controllers
2022-06-06 13:44:53 +01:00
Sergio Martins
5faf36700b Use qGuiApp instead of qApp
As QtQuick applications might not have QApplication.
2022-06-06 13:24:38 +01:00
Sergio Martins
995df8e3e8 qtquick: Remove qFatal in TabBar_qtquick::tabsAreMovable
It wasn't implemented in v 1.x either.
2022-06-06 11:29:14 +01:00
Sergio Martins
14189dc601 Make LayoutSaver deserializeWindowGeometry deal in Window instead of View 2022-06-06 11:23:07 +01:00
Sergio Martins
9c881ec53e Normalize how we set top level window geometry
Prefer Window API, since for QtQuick the root view isn't so tighly
coupled with the QWindow as in QWidgets world. Hide the difference in
Window_qtwidgets.cpp, which now prefers the QWidget API whenever possible,
as that's better tested than using QWindow direclty.
2022-06-06 11:17:42 +01:00
Sergio Martins
581451c342 Remove old ViewWrapper::asDropArea()
It's unneeded, and it wasn't implemented for QtQuick
2022-06-06 10:28:44 +01:00
Sergio Martins
eb198736b8 qtquick: Fixed drag indicators not working on main window
ViewWrapper::asDropArea() was dummy. Will remove it.
2022-06-06 10:23:48 +01:00
Sergio Martins
e8f390f2ad tests|qtquick: Don't create lots of spurious QQuickView
Most of the times we just want to create a dock widget which
will be parented immediately, we don't need the window.
2022-06-06 10:13:19 +01:00
Sergio Martins
2beb4982b0 qtquick: Make Window_qtquick::rootView() behave like in v 1.x
The MainWindow might not be the QQuickView's root item, but
version 1.x would still return that. So preserve that, since it's
what tests expect.

We can improve after having tests passing.
2022-06-06 09:42:06 +01:00
Sergio Martins
46159d88bd Add Window::containsView() 2022-06-06 09:25:45 +01:00
Sergio Martins
fbff1ed4a7 qtquick: Fix min size being violated in FloatingWindow ctor
Only set the suggested geometry after we added the frame.
This is the behaviour in 1.x too.
2022-06-06 09:24:38 +01:00
Sergio Martins
6bd87113b4 Simplify some code, add a View::transientWindow() shortcut 2022-06-05 14:19:08 +01:00
Sergio Martins
7e3a82ed3e qtquick: Fix setting of transient parent window
We need to go through Window, not through View.
This even makes things cleaner, as parentView() shouldn't go across
window boundaries. That's the case for QtWidgets but it's not consistent
with QtQuick. Our View abstraction has saner rules
2022-06-05 14:12:22 +01:00
Sergio Martins
f9efe2755e Fix LayoutSaver not restoring geometry correctly
"normalGeometry" was repeated twice due to typo
2022-06-05 13:31:08 +01:00
Sergio Martins
a88beb7574 qtquick: Implement missing methods for classic indicators 2022-06-05 12:53:22 +01:00
Sergio Martins
792aaf76da Normalize handling of close event for Frame and FloatingWindow too
Fixes windows not closing correctly for QtQuick
2022-06-05 12:47:53 +01:00
Sergio Martins
f11a6a6a8c Honour View::closeRequested signal
This noramalizes how both qtwidgets and qtquick were handling it.
Fixes tests related to close events in qtquick
2022-06-05 03:23:19 +01:00
Sergio Martins
6d926ee6e4 qtquick: Remove two more unneeded signals 2022-06-05 02:39:52 +01:00
Sergio Martins
666d4be478 qtquick: Fix wrong signal being emitted
It's the controller signal that is connected
2022-06-05 02:30:45 +01:00
Sergio Martins
ce88a00b4b tests: Don't enable these qtquick tests yet
Was commited by mistake
2022-06-05 01:14:32 +01:00
Sergio Martins
075a9d30f0 qtquick: Make Layout::floatingWindow()
The layout might be parented to other intermediate stuff.
2022-06-05 01:12:18 +01:00
Sergio Martins
ec4e22b5ae qtquick: Move the ClassicIndicator Q_PROPERTIES to the view
as that's what will be exposed to QtQuick
2022-06-05 00:54:30 +01:00
Sergio Martins
56ca80e8fc qtquick: Fix crash when dereferencing incomplete stack controler
The stack controller CTOR was still in the stack (pun intended), then
dereferenced by tabbar. Instead, call Stack_qtquick::init() to intitialize
the the TabBar. At this point the Stack controller is already usable.
2022-06-04 21:30:43 +01:00
Sergio Martins
ec144472ce Remove unneeded QWidget reference 2022-06-04 21:23:49 +01:00
Sergio Martins
991ced33f6 Rename createTabWidget() to createStack()
as done with the other classes already
2022-06-04 21:21:22 +01:00
Sergio Martins
78357b53a4 move some todos to milestone 3 2022-06-04 20:55:42 +01:00
Sergio Martins
16529c6704 qtquick: Port code that emitted frameGeometryChanged()
It's a public signal used by client code
2022-06-04 20:52:49 +01:00
Sergio Martins
1ead71442f qtquick: Remove old rubber band code, this has been ported already 2022-06-04 20:41:57 +01:00
Sergio Martins
a3f2e8ec9a qtquick: Rename tabBarObj to tabBarViewObj
Makes it clear it's a view
2022-06-04 20:39:41 +01:00
Sergio Martins
a2b5f40ed1 qtquick: Implement Stack_qtquick::tabBarObj() 2022-06-04 20:38:40 +01:00
Sergio Martins
d63a9db5a2 Port wayland commented out code 2022-06-04 20:30:20 +01:00
Sergio Martins
03a17c3a9d Fix TODO about renaming variable 2022-06-04 20:26:35 +01:00
Sergio Martins
0f8823664c qtquick: Remove old references to FrameQuick 2022-06-04 20:24:12 +01:00
Sergio Martins
cdaa03a413 qtquick: Fix Frame_qtquick::updateConstriants() not being called yet 2022-06-04 20:22:49 +01:00
Sergio Martins
e25a940ad1 qtquick: Implement DockWidget_qtquick::frameVisualItem() 2022-06-04 20:18:41 +01:00
Sergio Martins
9332eb3bf8 Remove unneeded FrameOptions argument from createFrame()
It's passed to the controller, the view doesn't need it.
2022-06-04 20:08:26 +01:00
Sergio Martins
84561a9d67 tests: Remove unused color argument from createDockWidget() 2022-06-04 20:03:43 +01:00
Sergio Martins
f1f722f1ce Replace TODOv2 tags with TODOm2 and TODOm3 tags
Not all todos are required for milestone m2
2022-06-04 19:53:25 +01:00
Sergio Martins
e5b82e0a45 qtquick: Fix frame not getting parented to DropArea 2022-06-04 12:32:20 +01:00
Sergio Martins
6c5f477c31 cmake: Remove qtquick presets, they are unneeded now
The build will build both frontends now.
2022-06-04 12:15:23 +01:00
Sergio Martins
20546acc4e cmake: Remove unneeded condition for old Qt
5.15. is the minimum nowadays
2022-06-04 12:07:51 +01:00
Sergio Martins
87319c69d2 cmake: Swap if/else branches to remove a negation 2022-06-04 12:05:59 +01:00
Sergio Martins
dc36435b35 cmake: Make the frontend discovery shorter
The fatal messages aren't needed, replaced by a REQUIRED find_package.
Added missing QtQuickControls find package from one branch, it was
only looking for QtQuick.
2022-06-04 12:03:26 +01:00
Sergio Martins
ea9bf1ef0f cmake: Remove unneeded negation 2022-06-04 11:48:53 +01:00
Sergio Martins
adbaedef89 cmake: Don't require the user to specify a frontend.
It would error-out with "OFF is not a frontend"
Just use find_package instead and enable any compatible frontend.
2022-06-03 19:18:53 +01:00
Sergio Martins
2fafef87df cmake: Replace ${PROJECT_NAME} with the actual project name
Because:
 - Doesn't select the whole option name on double-click
 - Not easily greppable on the terminal

It make's sense for any reusable cmake code though, we can replace
with ${PROJECT_NAME} again after factoring out any of our non-reusable
cmake code into a reusable module, if any.
2022-06-03 19:14:01 +01:00
Waqar Ahmed
cd88e19648 cmake: Add KDDockWidgets_FRONTENDS option 2022-06-03 16:10:41 +05:00
Sergio Martins
a2f1c1347a cmake: Explicitly add QtWidgets as dependency of our widgets frontend 2022-06-02 23:33:20 +01:00
Sergio Martins
e74055c1fd qtquick: Move titlebar invokables to the view
As that's what's exposed to QtQuick
2022-06-01 08:53:11 +01:00
Sergio Martins
1acafd8a6c Remove unneeded MultiSplitterConfig
Config.cpp is enough
2022-05-31 23:31:29 +01:00
Sergio Martins
529cedfcbf Remove the last occurrences of KDDOCKWIDGETS_QTWIDGETS
Don't define it in cmake anymore as it's official dead
2022-05-31 22:43:35 +01:00
Sergio Martins
affd1d12ae tests: Move the last qtwidgets only test to tst_qtwidgets.cpp
tst_docks.cpp is now completely rid of the widget ifdefs
2022-05-31 15:14:16 +01:00
Sergio Martins
300bd89728 tests: Port a bunch of KDDOCKWIDGETS_QTWIDGETS defines
These already existed in version 1.0, so just use the proper
guard. They won't be made generic at this point
2022-05-31 15:09:36 +01:00
Sergio Martins
61fb31b62a tests: Move a qtquick only test to tst_qtquick 2022-05-31 15:05:27 +01:00
Sergio Martins
58f1900b06 Port lazy separator resize 2022-05-31 14:43:47 +01:00
Sergio Martins
b6038bd7d7 Port two instances of KDDOCKWIDGETS_QTWIDGETS
These are OK, so just rename to the new macro
2022-05-31 14:19:02 +01:00
Sergio Martins
07853bdc4d Remove the last two remaining KDDOCKWIDGETS_QTQUICK ifdefs 2022-05-31 14:14:31 +01:00
Sergio Martins
6289e92e54 qtquick: Fix resizing root view
And uncommented the qtquick test for this, which now passes.
Moved the test to its own qtquick tests file.
2022-05-31 14:06:36 +01:00
Sergio Martins
0a1023aa83 Remove qFatal from ViewWrapper_qtquick::setAttribute()
It's ok to be a no-op
2022-05-31 11:33:19 +01:00
Sergio Martins
bc6417c923 Added Window::framePosition() 2022-05-31 11:33:08 +01:00
Sergio Martins
b201737149 Abstract mouse grabbing
It's done via the platforms, not via ifdefs anymore
2022-05-31 11:06:25 +01:00
Sergio Martins
c93911016f tests: remove unused already ported class 2022-05-31 10:37:51 +01:00
Sergio Martins
2e92357adc Add View::setZOrder()
Only relevant to QtQuick.
Removes some ifdefs.
2022-05-31 10:37:14 +01:00
Sergio Martins
8223f462c6 Remove Q_OBJECT from inside comments, so cmake doesn't trigger moc
Fixes a warning where moc says "No relevant classes found"
2022-05-31 10:08:55 +01:00
Sergio Martins
b9b8bfc430 Fix Werorr build due to missing override 2022-05-31 10:05:39 +01:00
Sergio Martins
f9df3c5872 windows: Port system move support 2022-05-30 23:42:41 +01:00
Sergio Martins
9881e0488f windows: Port FloatingWindow's nchittest code
Only DragController needs to be ported on Windows now
2022-05-30 23:36:54 +01:00
Sergio Martins
5a4342c0af windows: Port FloatingWindow::nativeEventFilter() 2022-05-30 23:26:26 +01:00
Sergio Martins
c244d7628d windows: Port AeroSnap to the new API 2022-05-30 23:19:58 +01:00
Sergio Martins
ab830bb6ee windows: Port nchittest code 2022-05-30 23:10:21 +01:00
Sergio Martins
827008a96a windows: Port some code from QWindow to Window
Removed the respectives Q_OS_WIN_TODO as they compile now
2022-05-30 22:54:20 +01:00
Sergio Martins
340e65df0b windows: Remove some Q_OS_WIN_TODO from FloatingWindow 2022-05-30 22:44:52 +01:00
Sergio Martins
83cc6f1b0c Add Window min/max size getter 2022-05-30 22:27:58 +01:00
Sergio Martins
35a44574a0 windows: Port a few leftovers 2022-05-30 22:07:42 +01:00
Sergio Martins
7a21857ea7 Added Window::property() 2022-05-30 22:05:43 +01:00
Sergio Martins
94afae2729 windows: Reviewed and ported a bunch of Q_OS_WIN_OLD usages
Those are fine. Will tackle the difficult ones next.
2022-05-30 22:04:35 +01:00
Sergio Martins
d8e703275f windows: Replace Q_OS_WIN with Q_OS_WIN_TODO so we can start porting
Now it builds. This way I can port each Q_OS_WIN one by one and make
sure everything still builds, without risking breaking Linux/macOS.
2022-05-30 21:55:49 +01:00
Sergio Martins
08dc12e8d7 Move globalGeometry() into View
Allows to remove some cruft
2022-05-30 19:50:58 +01:00
Sergio Martins
31d43b6608 qtquick: Port inDisallowedDragView() 2022-05-30 19:45:58 +01:00
Sergio Martins
ab9396af61 Remove unneeded KDDockWidgets::isWindow() 2022-05-30 19:35:20 +01:00
Sergio Martins
30ca6769e4 qtquick: Use the fallback mouse grabber
This code was needing porting.
2022-05-30 19:31:30 +01:00
Sergio Martins
22f6f4b2f1 Rename DockWidget::parentChanged() to parentViewChanged() for clarity
As this about the visual parent
2022-05-30 19:25:24 +01:00
Sergio Martins
b19f2dfbed Remove unneeded ifdefs 2022-05-30 19:23:12 +01:00
Sergio Martins
82f3cd9c5f Remove some unneeded ifdefs from MDIArea.cpp
Trying to get rid of them as some need to get ported
2022-05-30 19:20:11 +01:00
Sergio Martins
567308934e qtquick: Properly comment out a QtWidgets specific code path
Fixes crash when hovering with mouse
2022-05-30 19:17:49 +01:00
Sergio Martins
4d1add5221 qtquick: Fix assert that assumed the content item only had 1 child
QQuickWindow has other things like popup overlays parented to
the content item too.
2022-05-30 19:14:22 +01:00
Sergio Martins
c619c72094 tests: Introduce an env var to allow to run a subset of tests
by frontend
2022-05-30 18:57:59 +01:00
Sergio Martins
e2bb4fb830 qtquick: Register the main window and dock widget instantiators 2022-05-30 18:46:02 +01:00
Sergio Martins
5c0176f35b qtquick: Implement min/max size for the wrappers 2022-05-30 18:43:48 +01:00
Sergio Martins
095dbe1a7f qtquick|examples: Initialize the platform
Fixes a crash.
There's more (unrelated) crashes though, will look at those next.
2022-05-30 18:39:35 +01:00
Sergio Martins
230317551b Move installMessageHandler() to Platform.h
It's not Qt specific, as other frontends might want to install
their own handler
2022-05-30 18:31:14 +01:00
Sergio Martins
a48ce5ccff tests: Don't fail due to benign warnings 2022-05-30 18:07:14 +01:00
Sergio Martins
10cf965be2 Fix inifinite loop in ViewWrapper_qtquick::maximumSize 2022-05-30 17:59:12 +01:00
Waqar Ahmed
39c058cd29 Fix messageHandler installation for Qt backends 2022-05-30 20:28:44 +05:00
Waqar Ahmed
2815a5e84a Fix build errors 2022-05-30 17:11:05 +05:00
Sergio Martins
08dc4540f8 qtquick: Make customtitlebar example compile 2022-05-30 12:20:44 +01:00
Sergio Martins
bcb0668ace qtquick: Make mdi example compile 2022-05-30 12:16:11 +01:00
Sergio Martins
0b36b7c7e8 qtquick: Port the example 2022-05-30 12:01:04 +01:00
Sergio Martins
2421e607a9 Users now instantiate DockWidget view instead of controller
The controllers are private and not intentend for the public.
2022-05-30 11:45:43 +01:00
Sergio Martins
403f0626b4 tests: Comment the QtQuick examples one by one
so we can uncomment them one by one too as we port them
2022-05-30 10:15:16 +01:00
Sergio Martins
1bb0b13d77 qtquick: Make MainWindowInstantiator compile 2022-05-29 23:27:27 +01:00
Sergio Martins
1787a69edb qtquick: Make DockWidgetInstantiator compile 2022-05-29 23:16:56 +01:00
Sergio Martins
04b9590d59 cmake: Compile tst_qtwidgets only if QtWidgets frontend is built
The QtQuick frontend is now buildable withotu the QtWidgets one.
2022-05-29 22:14:45 +01:00
Sergio Martins
c36832d71c Port tst_viewguard away from QtWidgets 2022-05-29 22:07:38 +01:00
Sergio Martins
eff711b9ca Port MainWindowMDI to the new architecture
Has a qtquick implementation now.
2022-05-29 21:57:08 +01:00
Sergio Martins
340f618060 Split MainWindowMDI in two, so it can be reused by QtQuick 2022-05-29 21:09:24 +01:00
Sergio Martins
58c246cedc Remove unneeded qtquick ifdef 2022-05-29 20:55:42 +01:00
Sergio Martins
e27f142ec8 Fix KDDockWidgets::initFrontend() not initializing qtquick
As a drive-by add the required ifdefs
2022-05-29 20:27:50 +01:00
Sergio Martins
6d760cb5e1 Rename Some _p.h headers to .h
Easier for vscode to toggle between header the source
2022-05-29 20:24:11 +01:00
Sergio Martins
85f02d8ceb DockRegistry doesn't depend on QtWidgets anymore 2022-05-29 20:14:25 +01:00
Sergio Martins
fe87380d83 Layout.cpp no longer depends on QtWidgets 2022-05-29 20:09:26 +01:00
Sergio Martins
20c41fa3b1 qtquick: Implement Platform_qtquick::tests_createNonClosableView() 2022-05-29 19:54:37 +01:00
Sergio Martins
34d4ba6f64 Remove TODO, it has been renamed already 2022-05-28 20:01:32 +01:00
Sergio Martins
bdb5c533f2 Remove unused forward declaration 2022-05-28 19:55:55 +01:00
Sergio Martins
07bcea1226 cmake: Make QtQuick frontend build without QtWidgets frontend
Fails to link but compiles.
2022-05-28 19:50:59 +01:00
Sergio Martins
f645a4345f Don't run tests on unsupported frontends
If kddw wasn't compiled with QtQuick support then don't run the
QtQuick tests.
2022-05-28 16:06:17 +01:00
Sergio Martins
1c0c594abe cmake: Add qtwidgets/qtquick ifdefs
Code now builds without QtQuick if needed
2022-05-28 16:02:14 +01:00
Sergio Martins
c77b9628b4 cmake: Only link to QtWidgets when building qtwidgets frontend
And the same for QtQuick
2022-05-28 15:34:59 +01:00
Sergio Martins
a3750ea79a cmake: allow to build qtquick and qtwidgets independently
Still hardcoded to on, but the sources are now separated
2022-05-28 15:13:22 +01:00
Sergio Martins
4cd362dc33 cmake: Set minimum Qt6 version to 6.2
Anything else is untested
2022-05-28 14:31:39 +01:00
Sergio Martins
812892f3f2 bump version to 2.0 2022-05-28 14:25:25 +01:00
Sergio Martins
2e6924ec43 qtquick: Remove isWrapper
Will readd it if it's really needed
2022-05-28 11:57:20 +01:00
Sergio Martins
56a871b86b tests: Remove unneeded setContentsMargin() call 2022-05-27 15:50:16 +01:00
Sergio Martins
8354043337 qtquick: Don't abort when setContentsMargins() are called
It wasn't implemented for version 1.x either
2022-05-27 15:48:55 +01:00
Sergio Martins
410d893de9 qtquick: Implement the missing methods in ViewWrapper 2022-05-27 15:39:08 +01:00
Sergio Martins
406dd19285 qtquick: Don't dereference null FloatingWindow controller
Controller is already gone
2022-05-27 14:29:51 +01:00
Sergio Martins
586ed8d70b Replace View_qtquick::windowIsBeingDestroyed with View::aboutToBeDestroyed
Easier if it's generic.
2022-05-27 14:26:34 +01:00
Sergio Martins
da8539820e qtquick: Find the correct controller when using ViewWrapper 2022-05-27 14:00:19 +01:00
Sergio Martins
267bc4ec79 tests: Test that a floating window is created 2022-05-27 13:35:52 +01:00
Sergio Martins
fb8639969c Delete QObject::setParent() in the controller
To find places where we're setting parent on the controller instead
of in the view. Fix such case where the dock widget view
wasn't being parented to the frame view.
2022-05-27 13:25:06 +01:00
Sergio Martins
5fdbc12524 Add some asserts 2022-05-27 12:53:22 +01:00
Sergio Martins
18651bbf7a qtquick: Add some qFatal to some unimplemented methods
So I can easy get feedback they are missing impl.
2022-05-27 12:47:44 +01:00
Sergio Martins
bcaf0737e9 Move Platform::createMainWindow() to dev mode
This is for tests only
2022-05-27 12:11:43 +01:00
Sergio Martins
ad7f5f5970 tests: Remove some manual creation of QQuickView
It's abstracted by the platform now
2022-05-27 12:11:43 +01:00
Sergio Martins
652286760b qtquick: Fix creation of main window
It wasn't initializing the controller
2022-05-27 10:57:54 +01:00
Sergio Martins
df0dde80ef Remove unneeded "initView" parameter from MainWindow 2022-05-27 10:41:50 +01:00
Sergio Martins
03f1a6930c Added Platform::createMainWindow()
Called by tests and layout linter to create a main window.

Simplifies creation of the main window, we can now remove one of the ctors.
Before we supported both the controller creating the view and vice-versa,
while this is convenient it's complex to support, due to order or initializations.

Now, you a create a view, and it creates the controller behind the scenes.
MainWindow is special in this sense, as it's created by the end user, it's
not something internal we want in the ViewFactory.
2022-05-27 10:36:54 +01:00
Sergio Martins
e20a8ba396 Remove unneeded KDDOCKWIDGETS_QTQUICK ifdef 2022-05-26 23:24:38 +01:00
Sergio Martins
73dd788fa1 cmake: Remove unneeded -DKDDOCKWIDGETS_QTQUICK 2022-05-26 23:20:27 +01:00
Sergio Martins
ebb623f080 Initialize static resources in the correct platform
Non-Qt platforms won't have to do this
2022-05-26 23:16:02 +01:00
Sergio Martins
1dde7e3e99 Add a generic interface for the classic indicator window
this removes QWidget references from ClassicIndicators.cpp.
Both the QtQuick and QtWidgets impl will implement this new
interface, which is what ClassicIndicators.cpp uses now
2022-05-26 23:10:26 +01:00
Sergio Martins
fc74698dac Remove some unused qtwidget includes from controllers/ 2022-05-26 10:02:28 +01:00
Sergio Martins
c554bdc68c Fix DropArea only looking for QtWidget children
Instead of using findChildren(), just ask the layout for the
items.

tst_floatingWindow now doesn't crash anymore when looking for
the layout items.
2022-05-26 09:58:23 +01:00
Sergio Martins
4a8ac4a309 Remove unneeded assignment, since we're using scoped rollback 2022-05-26 09:54:31 +01:00
Sergio Martins
042cabbe5d Use a RAII class to emit floatingChanging()
Otherwise during reparenting the signal can be emitted by mistake.
Now we only check at the end if we need to emit it.
2022-05-26 09:29:37 +01:00
Sergio Martins
1e1204a991 Merge branch '1.6' 2022-05-25 00:38:49 +01:00
Allen Winter
6c42a2d40e Merge branch '1.6' 2022-05-24 17:22:41 -04:00
Sergio Martins
a85c56a25a Implement ViewWrapper::is() 2022-05-23 23:37:25 +01:00
Sergio Martins
ac51ffc7d4 tests: Add tests for DockWidget and FloatingWindow ctor
To catch potential QML errors in the .qml files.
2022-05-23 23:06:32 +01:00
Sergio Martins
c648e5fbba qtquick: View::rootView() now returns itself if no parent
This matches QWidget::window() behaviour
2022-05-23 22:51:57 +01:00
Sergio Martins
6fd88a8570 qtquick: Add missing properties to floating window
They return QObject as they can't be fwd declared in Qt 6 and might
have circular dependency.
2022-05-23 22:31:54 +01:00
Sergio Martins
bab0c99d13 tests: Added tst_separator
Helps finding problems in the respective qml file
2022-05-23 19:12:32 +01:00
Sergio Martins
79ef648a27 tests: Added tst_stack and tst_tabbar
Finds errors in the respective qml files
2022-05-23 19:00:21 +01:00
Sergio Martins
0f55a2f87a tests: Add tst_titlebar
At least for the ctor, which already helps to find bugs in
the .qml file
2022-05-23 18:07:56 +01:00
Sergio Martins
87e9cbc388 tests: Add tst_frame 2022-05-23 17:15:43 +01:00
Sergio Martins
821002ce43 qtquick: Add QML interface to TitleBar_qtquick 2022-05-23 17:12:35 +01:00
Sergio Martins
dab7195408 tests: Fix view factory being overridden
It's set during init
2022-05-23 16:39:03 +01:00
Sergio Martins
349816dab7 qtquick: Add QML interface for Frame
Since the controllers won't be QObjects eventually, we need the
C++ views to hold the properties.
2022-05-23 15:55:54 +01:00
Sergio Martins
46968556bb tests: Add missing viewwrapper ctest 2022-05-23 14:59:48 +01:00
Sergio Martins
e09a328281 qtquick: Add missing isMDI Q_PROPERTY 2022-05-21 10:36:41 +01:00
Sergio Martins
8c757955b5 qtquick: Fix signal connection in Frame 2022-05-21 10:33:14 +01:00
Sergio Martins
e7d20a403a qtquick: Dont' crash in frame ctor 2022-05-21 10:26:12 +01:00
Sergio Martins
bafa21d11c tests: Abort tests if there were warnings 2022-05-21 00:00:14 +01:00
Sergio Martins
07fc7d0437 tests: Move waitForDeleted() into Platform
So each platform can implement their own.
Meaning old Testing.cpp can be deleted too.
2022-05-20 16:41:59 +01:00
Sergio Martins
cc1f75b1b3 tests: Move our message filter into Platform_qt
So it can be reused by other tests
2022-05-20 16:29:14 +01:00
Sergio Martins
4a7446e57b qtquick: Build QmlTypes.cpp
Still a bit commented out
2022-05-20 15:02:33 +01:00
Sergio Martins
fc0fa1c58c qtquick: Return the correct paths for qml files 2022-05-19 19:28:48 +01:00
Sergio Martins
bb4f5a5037 Mass renaming of last usages of FrameworkWidgetFactory 2022-05-19 08:12:29 +01:00
Sergio Martins
09eb303bab Rename some methods from FrameworkWidget to View 2022-05-19 08:00:20 +01:00
Sergio Martins
4708b2c25d Rename FrameworkWidgetFactory_qtwidgets|qtquick to ViewFactory_* 2022-05-19 07:51:50 +01:00
Sergio Martins
e514a8c3e1 Rename FrameworkWidgetFactory to ViewFactory
We now deal in views instead of widgets, and the "Framework"
part was redundant. It's also shorter now
2022-05-18 23:12:43 +01:00
Sergio Martins
aefbbd5738 Allow the classic/segmented views be created by FrameworkWidgetFactory
Instead of the controllers. We only allow the user to customize
the views.
2022-05-18 23:10:27 +01:00
Sergio Martins
ab881c9b5a Fix fwd declaration typo 2022-05-18 22:54:49 +01:00
Sergio Martins
e54ebd096c Both ClassicIndicatorsWindow qtquick and qtwidgets build
They don't clash anymore. Rename them to include the suffix.
Next step is abstracting the creation of IndicatorWindow so we
remove the last qtwidget traces from ClassicIndicators.cpp
2022-05-18 05:27:24 +01:00
Sergio Martins
6054ccfdf2 Move Indicator class into .cpp file
It's impl detail
2022-05-18 05:19:24 +01:00
Sergio Martins
2fda6d11e1 Removed the qtquick/qtwidgets ifdefs from ClassicIndicatorsWindow_*
They now each have their own implementation.
qtquick one still not compiling, as it duplicates symbols.
2022-05-18 05:10:01 +01:00
Sergio Martins
34c25a065a Copy ClassicIndicatorsWindow.cpp into qtwidgets and qtquick
No other changes made.
In preparation to remove the ifdefs.
2022-05-18 05:03:15 +01:00
Sergio Martins
89ceb01b59 Remove some classes that were copied instead of renamed 2022-05-18 04:49:54 +01:00
Sergio Martins
65c1b53ea0 tests: Some include cleanup 2022-05-18 04:48:31 +01:00
Sergio Martins
522b2623be Moved DropIndicatorOverlay into controllers/ folder 2022-05-18 04:47:01 +01:00
Sergio Martins
d2bf83e4ac Rename DropIndicatorOverlayInterface to DropIndicatorOverlay
We don't suffix our base classes with "Interface"
2022-05-18 04:39:21 +01:00
Sergio Martins
30c3a047d1 Move the indicator classes into controllers/indicators/ 2022-05-18 04:35:33 +01:00
Sergio Martins
2b6c18dbcd Move the drop indicators into Controllers namespace 2022-05-18 04:24:16 +01:00
Sergio Martins
7b486bb28c qtwidgets: Add views for the Classical and Segmented indicators
Copied from indicators/
2022-05-18 04:10:01 +01:00
Sergio Martins
10b61f0e30 Remove unused Type::DropIndicatorOverlayInterface 2022-05-17 23:45:54 +01:00
Sergio Martins
1b35810766 Add Platform::createView()
For when kddw internalls need to create an empty view.
Use case will be to create the parent widget for the drop indicators.
2022-05-17 23:43:41 +01:00
Sergio Martins
fc0160213e Remove old MDILayoutWidget_p.h file
It has been renamed already
2022-05-17 22:18:40 +01:00
Sergio Martins
a039f102a3 Remove some unneeded QWidget includes 2022-05-17 22:16:00 +01:00
Sergio Martins
41efefa21e Port away from ViewWrapper_qtwidgets in the backend
Only qtwidgets frontend is allow to use this type
2022-05-16 23:10:04 +01:00
Sergio Martins
cc8ee097a3 Remove last usage of QWidgetOrQuick type 2022-05-16 23:04:29 +01:00
Sergio Martins
1bacb31949 tests: Use generic view instead of QWidget NonClosableWidget 2022-05-16 22:55:46 +01:00
Sergio Martins
be75247dba tests: Remove some unused includes 2022-05-16 22:37:22 +01:00
Sergio Martins
6bc68fece8 tests: Remove instances of QTextEdit in tests
It's generic now
2022-05-16 22:30:57 +01:00
Sergio Martins
be8250acb7 tests: Remove instances of QLineEdit from the tests
It's now generic
2022-05-16 21:59:43 +01:00
Sergio Martins
8372ffc0d7 tests: Remove all instances of QPushButton from tst_docks
Now uses generic alternatives that will work with other frontends too
2022-05-16 21:29:46 +01:00
Sergio Martins
a10187ed5d tests: Port away further from "QWidgetOrQuick" 2022-05-16 20:01:08 +01:00
Sergio Martins
7fbd1ea920 Added Platform::startDragDistance()
As its value is per platform.
2022-05-15 22:31:40 +01:00
Sergio Martins
ef4a0214ed Added Platform::isQtWidgets()
Removes it from Utils_p.h
2022-05-15 22:23:34 +01:00
Sergio Martins
d5ac23a8d2 qtquick: Implement DefaultWidgetFactory_qtquick
Requires implementing some pure-virtuals in the views too
2022-05-15 22:14:51 +01:00
Sergio Martins
7434865967 Move Layout.cpp to controllers/ folder
as it's a controller
2022-05-15 21:30:31 +01:00
Sergio Martins
f29d3bf5f8 Move Layout into Controllers namespace 2022-05-15 21:22:26 +01:00
Sergio Martins
97baed0ef9 Rename layoutWidget variable/method name to layout
It's a controller, so don't suffix it with Widget/View
2022-05-15 21:12:01 +01:00
Sergio Martins
378f380968 Rename LayoutWidget to Layout , since it's not a view
Controllers shouldn't be suffixed
2022-05-15 21:04:07 +01:00
Sergio Martins
8e506aa327 Rename LayoutWidget.cpp to Layout.cpp , as it's a controller 2022-05-15 16:51:55 +01:00
Sergio Martins
df96b7ab81 Move MDILayout into Controllers namespace 2022-05-15 16:47:05 +01:00
Sergio Martins
20cd7b04a5 Rename MDILayoutWidget class to MDILayout
Since it's a controller, we strip the suffix
2022-05-15 16:27:51 +01:00
Sergio Martins
fa16020d61 Rename MDILayoutWidget to MDILayout and move it to controllers/
Since it's not a view, remove the "Widget" suffix
2022-05-15 16:24:57 +01:00
Sergio Martins
5ba4e0ee9d qtquick: Added MDILayout_qtquick 2022-05-15 16:17:28 +01:00
Sergio Martins
a27ee4944a qtquick: Added DropArea_qtquick 2022-05-15 16:12:25 +01:00
Sergio Martins
f537ff007c qtquick: Remove type registring from MultiSplitterConfig.cpp
It's specific to QtQuick
2022-05-15 15:38:04 +01:00
Sergio Martins
c563fc7d42 Fix path of ClassicIndicatorsOverlay.qml 2022-05-15 15:33:43 +01:00
Sergio Martins
9d0f137f9d qtquick: FloatingWindow and MainWindow are now ported and compile 2022-05-15 15:29:54 +01:00
Sergio Martins
bcc823e900 qtquick: Do the boring boilerplate porting for MainWindow/FloatingWindow
Mostly interesting things left to port there only.
2022-05-15 14:26:49 +01:00
Sergio Martins
23b2ade6bd qtquick: Port some commented out code 2022-05-15 14:13:21 +01:00
Sergio Martins
9bebf50d4d qtquick: Some initial porting for DockWidgetInstantiator 2022-05-15 14:10:21 +01:00
Sergio Martins
6b98322d96 qtquick: Ported rubberband to the new architecture 2022-05-15 14:02:36 +01:00
Sergio Martins
97faaea983 qtquick: Store the public class in 'q' pointer
As usual in Qt
2022-05-15 13:54:16 +01:00
Sergio Martins
35c7964365 qtquick: More porting of DockWidget_qtquick
Compiles now, but some things are commented out still.
2022-05-15 13:51:32 +01:00
Sergio Martins
65f74077d3 tests: Replace a usage of QWidgetOrQuick with View 2022-05-15 13:00:08 +01:00
Sergio Martins
d8cf526b5a Remove some dead code 2022-05-15 12:58:06 +01:00
Sergio Martins
5ce2c0eefd Replace another usage of QWidgetOrQuick with View 2022-05-15 12:56:55 +01:00
Sergio Martins
1a47d52ed9 Make View::handle() non virtual
So we can still do comparisons if ~View_qtwidgets was already called.
Otherwise it would be calling a pure-virtual.
2022-05-15 12:55:55 +01:00
Sergio Martins
383e4f8abd tests: Use tests_createView() instead of MyWidget2
Decouples tests from Qt a bit more
2022-05-15 12:20:30 +01:00
Sergio Martins
9698baefd0 tests: Remove unused HostedWidget 2022-05-15 12:20:30 +01:00
Sergio Martins
c5f05694aa Fix build due to missing include 2022-05-15 11:41:46 +01:00
Sergio Martins
cda924ac74 Ported RubberBand from QWidget to View 2022-05-14 10:36:53 +01:00
Sergio Martins
f719697852 Remove DockWidget::setWidget(QWidget) 2022-05-14 09:38:55 +01:00
Sergio Martins
df61c35314 Implemented ViewWrapper::sizePolicy() 2022-05-14 09:26:07 +01:00
Sergio Martins
a3f80ef2f8 Add .DS_Store to .gitignore 2022-05-13 15:33:15 +01:00
Sergio Martins
e6f05a7815 docs: Added documentation about the basic concepts.
Will add images next.
2022-05-13 00:39:00 +01:00
Sergio Martins
1ce6d3721e Add a mkdocs.yml file
So we can start writing internal documentation
2022-05-12 23:41:33 +01:00
Sergio Martins
07be3dd0d4 Port away from DockWidget::widget()
Use guestView() instead
2022-05-11 23:59:10 +01:00
Sergio Martins
f5fe7e6cc8 tests: Port away from QWidget further
DockWidget::widget() is getting removed in favor of guestView()
2022-05-11 23:51:57 +01:00
Sergio Martins
6d9fa9eecd cmake: Add an lcov preset and disable it on the dev preset
It's not very good for incremental development as one needs
to constantly remove the gcda files
2022-05-11 17:25:06 +01:00
Sergio Martins
313be585ae tests: More focus tests 2022-05-11 17:23:31 +01:00
Sergio Martins
8a725298de Added View::hasFocus() 2022-05-11 00:02:18 +01:00
Sergio Martins
721402b710 Remove a few usages of DockWidget::widget()
Use View instead of QWidget
2022-05-10 23:43:07 +01:00
Sergio Martins
73e6822a1d Added View::focusPolicy() 2022-05-10 23:23:27 +01:00
Sergio Martins
9f7c4cb217 Removed the DockWidgetBase typedef
That existed only to ease porting
2022-05-10 22:53:16 +01:00
Sergio Martins
855b572656 cmake: Enable gcov code coverage by default for dev preset 2022-05-09 23:46:27 +01:00
Sergio Martins
93e388e04f tests: tst_multisplitter is now run against all platforms 2022-05-09 17:38:22 +01:00
Sergio Martins
146b929b5d qtquick: Implement View::maximumSize() and test 2022-05-09 17:28:48 +01:00
Sergio Martins
5f38814fd2 qtquick: Fix crash during instantiation of Separator_qtquick
The qml file would call into the view which would call into the
controller while its d ptr wasn't initialized yet
2022-05-09 16:31:49 +01:00
Sergio Martins
45a364c44b qtquick: Normalize location of Separator.qml
We don't want any qml files outside of qtquick/ folder
2022-05-09 15:44:45 +01:00
Sergio Martins
d35afdf81c qtquick: Compile our qrc file too
Updated paths
2022-05-09 15:40:20 +01:00
Sergio Martins
5f7eb335e6 qtquick: Warn and bailout whenever we can't find the requested QML file 2022-05-09 15:37:36 +01:00
Sergio Martins
9173226be7 tests: Normalise signature of argc/argv to match QApplication's
Fixes crash when passing "platform -xcb", because argc was being
passed by value, decremented in QApplication, then going out
of bounds in QTest
2022-05-09 15:16:36 +01:00
Sergio Martins
5d8da8aab6 qtquick: Compile and return Separator in the framework factory 2022-05-09 14:41:21 +01:00
Waqar Ahmed
df00c13899 Add code coverage 2022-05-09 16:45:41 +05:00
Waqar Ahmed
d1567322ec Fix unused variable warning 2022-05-09 16:44:18 +05:00
Sergio Martins
eb42d9e3f0 workaround linking examples 2022-05-09 12:17:15 +01:00
Sergio Martins
79eb41298c qtquick: Port Separator to the new view architecture 2022-05-09 10:25:58 +01:00
Sergio Martins
e0f48c9f32 Added convenience View_qtquick::createQQuickItem() 2022-05-09 10:06:43 +01:00
Sergio Martins
f033e4eb36 qtquick: Fix the qml engine not being set 2022-05-08 23:13:44 +01:00
Sergio Martins
8751216f62 qtquick: Added a FrameworkWidgetFactory too
The impl is dummy, but at least Config doesn't return a nullptr
one, meaning we can have more involved tests for QtQuick
2022-05-08 23:12:20 +01:00
Sergio Martins
cfeb59ee8f qtquick: Move m_qmlEngine from Config to Platform_qtquick
As it's QtQuick specific it should be in the qtquick frontend folder.
2022-05-08 20:16:23 +01:00
Sergio Martins
3c340aee40 tests: Remove last traces of QWidget from tst_multisplitter 2022-05-08 19:56:25 +01:00
Sergio Martins
2b2c5efd1a tests: Don't instance Separator_qtwidgets directly
So it can support qtquick
2022-05-08 19:50:15 +01:00
Sergio Martins
985224f24b tests: Run tst_view on offscreen by default
Moved the QPA offscreen defaulting to Platform_qt
2022-05-08 19:38:52 +01:00
Sergio Martins
97f26743e5 tests: Decouple tst_multisplitter from QWidget more
It now asks the platform to create a test view instead of
using one that inherits from QWidget.
2022-05-08 19:33:04 +01:00
Sergio Martins
a3bf159281 tests: Minor, add two QCOMPARE 2022-05-08 19:21:28 +01:00
Sergio Martins
543427255f tests: Make the maxSize test compabitle with 1.0
we didn't call QWidget::setMaximumSize(), we just set a hint
2022-05-08 19:17:53 +01:00
Sergio Martins
8eba26fd53 tests: minor, add 2 QVERIFY 2022-05-08 19:09:39 +01:00
Sergio Martins
17b6b7f7b9 tests: minor, add a QCOMPARE for min position 2022-05-08 18:38:48 +01:00
Sergio Martins
0997d48d60 tests: Test View: Also set max size 2022-05-08 17:10:56 +01:00
Sergio Martins
6e6bd92d5e Minor debug improvement 2022-05-08 16:56:54 +01:00
Sergio Martins
a6e0fdb6b9 qtwidgets: Add missing layoutInvalidated() emittions
So tst_multisplitter can use generic View instead of its own
QtWidget specific implementation
2022-05-08 16:53:22 +01:00
Sergio Martins
7d27d76448 Port layoutInvalidated signal to KDBindings
This removes triplication between qtquick, qtwidgets and tests.
It also allows us to remove the usage of old-style Qt connect.
2022-05-08 15:23:40 +01:00
Sergio Martins
418c4514df tests: Remove some unneeded overridden methods in tst_multisplitter 2022-05-08 15:13:42 +01:00
Sergio Martins
bd675c09a1 Remove unused and old Widget_qwidget/Widget_quick 2022-05-08 14:00:00 +01:00
Sergio Martins
bacaa0127a qtquick: Move remaining contents from old/ into views/
They are not ported yet, bet let's do things in batches so we have less
context switches.
2022-05-08 13:54:56 +01:00
Sergio Martins
76b1a394f2 qtquick: Ported the old DockWidgetQuick to the new architecture
Mostly anyway. Facing several blockers that need to be ported first,
for example DockWidget::setWidget() is still receiving QWidget
2022-05-08 13:27:37 +01:00
Sergio Martins
984bcd5f06 qtquick: Ported Frame view to the new architecture 2022-05-08 12:20:33 +01:00
Sergio Martins
7ba5d1de3b qtquick: Remove old TabWidgetQuick 2022-05-06 18:50:43 +01:00
Sergio Martins
16cca5a719 qtquick: Move LayoutSaverInstantiator to new location 2022-05-06 18:48:33 +01:00
Sergio Martins
9d5c7bfc53 qtquick: Ported TabWidget to the new architecture 2022-05-06 18:04:25 +01:00
Sergio Martins
62c25eec2e Merge branch '1.6' 2022-05-05 14:28:47 +01:00
Sergio Martins
bc3126ebee Merge branch '1.6' 2022-05-05 10:46:14 +01:00
Sergio Martins
d6f56169e1 qtquick: Ported TabBar to the new architecture 2022-05-03 22:01:47 +01:00
Sergio Martins
c0d9e3247b qtquick: Ported TitleBar to the new architecture 2022-05-03 20:24:20 +01:00
Sergio Martins
0a1a783054 Implemented ViewWrapper::window()
Implementation was missing for qtquick and add a bug for qtwidgets.
2022-05-03 20:02:14 +01:00
Sergio Martins
dc9a0145e2 tests: Rename ViewWrapper tests, they still said "View::" 2022-05-03 19:46:30 +01:00
Sergio Martins
9f532fb543 qtquick: Implement ViewWrapper::minSize() 2022-05-02 23:40:14 +01:00
Sergio Martins
b719435ae8 qtquick: Implement ViewWrapper::objectName() 2022-05-02 23:27:09 +01:00
Sergio Martins
16816d47d6 Added Window::screen()
Which allows to make View::screen() non-virtual
2022-05-02 23:24:49 +01:00
Sergio Martins
a693a995b1 qtquick: Implement ViewWrapper_qtquick::grabMouse and releaseMouse 2022-05-02 23:19:21 +01:00
Sergio Martins
f8a287675b qtquick: Implement ViewWrapper::setParent and childViews 2022-05-02 23:10:00 +01:00
Sergio Martins
e462098cce tests: Move tst_view.cpp's main into a separate file, so it can be shared 2022-05-02 22:40:33 +01:00
Sergio Martins
3d2e45b5d5 tests: Add test for View::closeRequested 2022-05-02 22:00:15 +01:00
Sergio Martins
a49faeced6 Remove some duplicate TODOs, already in header 2022-05-02 21:35:04 +01:00
Sergio Martins
401ebc586e qtquick: Move all inline View methods into .cpp file 2022-05-02 21:33:07 +01:00
Sergio Martins
cccd3a47f0 View::closeWindow() is no longer virtual.
Implementation is common to all frontends.
Renamed it to closeRootView() to be consistent.
2022-05-02 17:54:00 +01:00
Sergio Martins
96912515a8 View::windowGeometry() is no longer virtual.
Implementation is the same for all frontends.
2022-05-02 17:33:44 +01:00
Sergio Martins
04785a8b49 View::parentSize() is no longer virtual
The implementation is common to all frontends.
2022-05-02 17:30:47 +01:00
Sergio Martins
2b129380d6 qtquick: Move a few implementations to cpp file 2022-05-02 17:28:41 +01:00
Sergio Martins
a6e698b0fe tests: Add a test for View::objectName 2022-05-02 17:23:39 +01:00
Sergio Martins
33d7d730f4 tests: Add a test for View::minSize() 2022-05-02 17:21:31 +01:00
Sergio Martins
5607fab8db tests: Add test for View::sizeHint 2022-05-02 10:29:46 +01:00
Sergio Martins
c2ae9abfb5 tests_createView() now receives a struct
As we'll be passing more parameters
2022-05-02 10:20:19 +01:00
Sergio Martins
a8cb498eb5 Amend previous commit, use *Controller as suffix 2022-05-02 00:05:18 +01:00
Sergio Martins
d0c1b94585 Remove *View and *Widget suffixes from layouts
They are controllers, not views.
2022-05-02 00:01:44 +01:00
Sergio Martins
e17f6c0066 Add some missing const 2022-05-01 23:58:14 +01:00
Sergio Martins
a550567a4c Rename asMultisplitterView to asDropArea
It's no longer a view.
2022-05-01 23:56:41 +01:00
Sergio Martins
3fabf34bee Renamed View::windowHandle() to View::window()
windowHandle() is missnamed in Qt because QWidget::window() was already
taken in Qt4. But we can make it better here.
2022-05-01 23:09:18 +01:00
Sergio Martins
0d02be6387 qtquick: Implement View::rootView() 2022-05-01 23:00:19 +01:00
Sergio Martins
fff3adf967 Rename View::window() to View::rootView()
window() was an artifact of Qt4 times, when QWindow didn't exist yet.
2022-05-01 22:52:00 +01:00
Sergio Martins
4b41291830 qtquick: Fix geometry() always returning 0,0 as position 2022-05-01 22:42:23 +01:00
Sergio Martins
8dd8eabf1a tests: tests_createView now can create visible views too 2022-05-01 22:21:08 +01:00
Sergio Martins
1591ed49da tests: Added tests for View::geometry,pos,x,y,width,height,rect 2022-05-01 21:15:27 +01:00
Sergio Martins
a069a812db tests: Remove qDebug() from doctest based tests
TestExplorer will fail to work if we print to stderr. Instead
we now print to stdout.
2022-05-01 20:17:51 +01:00
Sergio Martins
3416a74723 Don't make View::move(QPoint) pure-virtual
We already have a virtual overload, just call it.
2022-05-01 20:12:32 +01:00
Sergio Martins
58afb97eb2 qtquick: Move the rest of old/QWidgetAdapter_quick to View_qtquick 2022-05-01 20:01:46 +01:00
Sergio Martins
738a78d12b qtquick: Implement View::windowHandle() and Window_qtquick::rootView()
For QtWidgets it now calls create() in the ctor so we have a window
during tests.
2022-05-01 14:38:20 +01:00
Sergio Martins
545c45e78d qtquick: Port a bunch of methods from the old QWidgetAdapter 2022-05-01 13:11:32 +01:00
Sergio Martins
0a3c2433e7 qtquick: Implement setGeometry and related methods 2022-05-01 12:46:14 +01:00
Waqar Ahmed
df7627c08a Use QVariant::userType instead of QVariant::type 2022-05-01 02:43:31 +05:00
Sergio Martins
b089b49b28 qtquick: Implement and test View::hide() too 2022-04-30 11:47:02 +01:00
Sergio Martins
7547163d2d qtquick: Implement View::isVisible/setVisible 2022-04-30 11:42:53 +01:00
Sergio Martins
95f61629a9 tests: Print the name of the platform we're testing 2022-04-30 11:33:02 +01:00
Sergio Martins
3227ffab81 qtquick: Implemented and tested View::parentView/childViews
tst_view is now enabled for QtQuick too
2022-04-30 11:27:47 +01:00
Sergio Martins
1ecc42d50c tests: Fix memory leaks in tst_view 2022-04-30 11:19:12 +01:00
Sergio Martins
712751e89b tests: Make tst_view test View, not ViewWrapper 2022-04-30 11:08:54 +01:00
Sergio Martins
b6d87d10c4 Add a TestHelpers_ file for each platform
So we don't have too much ifdefed stuff that's only for tests in
the main files.
2022-04-30 10:31:31 +01:00
Sergio Martins
59e5759bc2 qtquick: initialize the the QQmlEngine during tests 2022-04-30 01:20:09 +01:00
Sergio Martins
ee256284cc Remove View::isWindow(), use isRootView() instead.
QWidget::isWindow() is misnamed in Qt, it's an artifact from Qt4
times.
2022-04-30 01:10:24 +01:00
Sergio Martins
f3934ebd2c Rename View::isTopLevel() to isRootView() 2022-04-30 01:06:03 +01:00
Sergio Martins
22a43eb9af Add 3rdparty/doctest
It's header only.
2022-04-30 00:56:28 +01:00
Sergio Martins
ba92225678 Implement View_qtquick::setParent and setObjectName 2022-04-30 00:43:27 +01:00
Sergio Martins
496451c434 Implemented Platform_qtquick::tests_createView()
Creates a view for us to test with.
2022-04-29 19:15:02 +01:00
Sergio Martins
9d52f40632 Make the qtquick files compile
They weren't being built.
Build-system is simplified for now.
2022-04-29 19:00:40 +01:00
Sergio Martins
c55cac97d0 tests: Add unit-test for View::setParent() 2022-04-29 18:46:28 +01:00
Sergio Martins
8d09acdf5f tests: Fix warning about requiring to call init after qApp 2022-04-29 18:05:24 +01:00
Sergio Martins
fcf02fc8bf tests: Move isGammaray() into Platform_qt 2022-04-29 15:52:46 +01:00
Sergio Martins
721d344533 tests: Delete platform when test finishes 2022-04-29 15:47:54 +01:00
Sergio Martins
9dc53f9755 tests: Create the QApplication in Platform ctor
Other frontends won't use QApplication, and QtQuick might even use
just QGuiApplication eventually
2022-04-29 15:36:16 +01:00
Sergio Martins
aa72a8cd5a Add Platform_qtwidgets::init(), so we can share some code with ctors 2022-04-29 15:09:43 +01:00
Sergio Martins
099a9018df Make it easier for tests to init the platform
Only a single static method is needed now, instead of 2.
2022-04-29 14:34:32 +01:00
Sergio Martins
34b07ef340 Delete the Platform when a test is complete
So that we support testing multiple platforms in the same test run
2022-04-29 14:05:35 +01:00
Sergio Martins
3907660dde Set s_platform to nullptr when dtor runs 2022-04-29 13:53:36 +01:00
Sergio Martins
3d1b450cbb Remove View::minimumSizeHint()
It's a QWidget specific concept, so move it to the qtwidgets
frontendcode. QtQuick won't need it.
2022-04-29 00:27:07 +01:00
Sergio Martins
93ccaff407 test: Fix test failure due to unimplemented wrapper method 2022-04-28 21:27:32 +01:00
Sergio Martins
a2d17fd0b9 Added Platform::frontendTypes()
Needed by the tests
2022-04-27 10:44:44 +01:00
Sergio Martins
9fa80d2061 vscode: Remove the Qt6 build folder from the Qt5 namespace 2022-04-26 23:40:35 +01:00
Sergio Martins
5ef9f4e8ac vscode: Configure TestMate extension, tell it where the tests are 2022-04-26 23:39:48 +01:00
Sergio Martins
bcd639599a Port tst_viewguard.cpp to doctest
doctest will be the unit-test framework for new tests, since we'll
have a lot of non-Qt code.
2022-04-26 23:35:25 +01:00
Sergio Martins
1b8ac876ce Port away from WidgetType typedef
Introduces View::childViews(), required for the porting
2022-04-26 00:13:07 +01:00
Sergio Martins
420a85943a Finally remove View::asQWidget()
Soon we can start the QtQuick port to the new architecture
2022-04-26 00:00:23 +01:00
Sergio Martins
00bee2edcb Move the "kddockwidgets_qwidget" property hack into the Qt platform
This removes the last usages of asQWidget() from the generic part.
2022-04-25 20:44:05 +01:00
Sergio Martins
41383bf7a4 Remove more asQWidget() instances, only 3 remaining now 2022-04-25 20:25:56 +01:00
Sergio Martins
3bb0c6a8d2 Move MDIArea to qtwidgets/ as it was never ported to QtQuick
Can be ported if needed
2022-04-25 20:16:25 +01:00
Sergio Martins
0f61ef63a2 Split DropArea and MDILayout into View/Controller 2022-04-25 18:50:41 +01:00
Sergio Martins
6ebb432932 Port LayoutWidget away from QWidget
DropArea and MDILayout now inherit from it, in addittion to QWidget.
This mean DropArea can now be split into View/Controller alone,
without having to port LayoutWidget and MDILayout in the same commit,
which would be hard to review.
2022-04-24 12:57:20 +01:00
Sergio Martins
b08c49e788 Update KDBindings/signal.h
Has support for scoped connection handle now.
It disconnects the connection when deleted
2022-04-24 12:56:06 +01:00
Sergio Martins
1b6fa1bd36 Rename Type::MultiSplitter to Type::DropArea
MultiSplitter was removed
2022-04-23 15:28:17 +01:00
Sergio Martins
dc6d77e266 Fold MultiSplitter into DropArea
The separation was never very useful. There's was always only
one derived class, the DropArea. Merge the two.
2022-04-23 15:22:38 +01:00
Sergio Martins
4f5ffa2370 Add DropArea_qtwidgets stub 2022-04-23 14:42:03 +01:00
Sergio Martins
860a1a1bb0 Move DropArea into Controllers namespace
In preparation for View/Controller split.
2022-04-23 12:14:30 +01:00
Sergio Martins
daa6afd14c Move DropArea into controllers/
In preparation to split it into View/Controller.
This is just the move, no code changed yet.
Next will be the namespace change.
2022-04-23 11:46:11 +01:00
Sergio Martins
28754ec260 Fold DropAreaWithCentralFrame into DropArea
This separation was never useful
2022-04-23 00:17:20 +01:00
Sergio Martins
ab0208b603 Remove the remaining asQWidget usages from WidgetResizeHandler
Remaining ones in the code base are because DropArea isn't ported
to View yet, that will come next
2022-04-21 23:15:04 +01:00
Sergio Martins
358dfd4cb7 Replace some usages of asQWidget with asQObject
That at least allows us to start the QtQuick port
2022-04-21 22:57:57 +01:00
Sergio Martins
6d2d5ca0ed Add View::setMouseTracking() 2022-04-21 22:50:46 +01:00
Sergio Martins
e71c54f041 Add View::setCursor() 2022-04-21 22:41:52 +01:00
Sergio Martins
f9c3a301b5 Add View::render() 2022-04-21 22:31:11 +01:00
Sergio Martins
2c162630f4 Add View::setWindowOpacity() 2022-04-21 22:24:18 +01:00
Sergio Martins
8015e49bee Add Platform::screenSizeFor(window), removes more asQWidget() usage 2022-04-21 22:10:59 +01:00
Sergio Martins
3f97845c9c Use Window instead of QWindow in a few more places 2022-04-21 21:50:58 +01:00
Sergio Martins
4946cdeed3 Add Platform::screenNumberFor, removes more asQWidget() usage 2022-04-21 21:47:55 +01:00
Sergio Martins
eff3798987 Remove a few unused functions 2022-04-21 20:20:49 +01:00
Sergio Martins
554deb22da Add View::releaseKeyboard(), removes some asQWidget() usage 2022-04-21 20:13:10 +01:00
Sergio Martins
0249b0e933 Remove more usages of asQWidget()
Adds View::mapTo()
2022-04-20 23:18:41 +01:00
Sergio Martins
2f59fb197b Remove more usages of asQWidget() 2022-04-20 23:07:16 +01:00
Sergio Martins
38df31e99f Port away from qApp->sendEvent() 2022-04-19 19:38:20 +01:00
Sergio Martins
a6cbfbf065 Rename tests_sendEvent() to sendEvent()
Non-test code will also need it
2022-04-19 19:32:56 +01:00
Sergio Martins
28b210586c Remove deprecated and now unused Widget_*h classes 2022-04-19 19:28:15 +01:00
Sergio Martins
33073c75ee tests: Remove the last usage of asQWidget() from tests/
Now only a few remaining in src/
2022-04-19 19:26:34 +01:00
Sergio Martins
23b2ea7195 tests: Remove last usage of asQWidget() from tst_docks.cpp 2022-04-19 19:20:46 +01:00
Sergio Martins
80beeb7ffb tests: Remove last 2 usages of asQWidget from tst_qtwidgets.cpp
That method will be removed from View soon
2022-04-19 19:17:48 +01:00
Sergio Martins
d2b5bedfa1 tests: Remove another usage of deprecated asQWidget() 2022-04-19 19:14:58 +01:00
Sergio Martins
d5cec9f5de tests: Move QtWidget specific tests to tst_qtwidgets.cpp
Let's have less ifdefs
2022-04-19 19:07:57 +01:00
Sergio Martins
05deea3cd8 tests: Move some ifdefed code to their respective platforms 2022-04-19 17:44:36 +01:00
Sergio Martins
7632278ba8 Remove asQWidget() instances from tst_multisplitter
This test is QWidget only, but we want to remove View::asQWidget(),
so just cast directly here.
2022-04-19 16:55:33 +01:00
Sergio Martins
faf3971044 Merge branch '1.6' 2022-04-19 15:54:26 +01:00
Sergio Martins
8e4e998e74 tests: port away from QApplication::topLevelAt() 2022-04-14 23:44:39 +01:00
Sergio Martins
995882d2d1 tests: More porting away from asQWidget() 2022-04-14 19:06:41 +01:00
Sergio Martins
c8b896bdd6 tests: Remove casts to QTabBar 2022-04-14 18:31:41 +01:00
Sergio Martins
201e631a0b tests: Remove some QPointer usage
Which in turn also removes some asQWidget() usage
2022-04-14 18:22:32 +01:00
Sergio Martins
a3d1990857 tests: Port more tests away from asQWidget() 2022-04-14 18:05:23 +01:00
Allen Winter
ba79f754dc Merge branch '1.6' 2022-04-14 12:40:48 -04:00
Allen Winter
61a4373459 Merge branch '1.6' 2022-04-14 12:01:28 -04:00
Sergio Martins
924b32b3c5 tests: Port some QWindow based utils to Window::Ptr
So it doesn't depend on Qt
2022-04-13 23:49:29 +01:00
Sergio Martins
664798ee6e tests: Remove some asQWidget() calls 2022-04-13 22:28:04 +01:00
Sergio Martins
2dd39ad0cb Merge branch '1.6' 2022-04-12 17:02:17 +01:00
Sergio Martins
90bd78846a tests: Port away from a few Qt specific waitForEvent
Removes a bunch of asQWidget() from the tests
2022-04-11 15:14:51 +01:00
Sergio Martins
31db3d9562 Port away from QTest::qWaitForWindowActive, it's Qt specific
Simpliy moved it to Platform_qt
2022-04-11 11:37:31 +01:00
Sergio Martins
52d91d350b Remove qtwidgets usage from Config 2022-04-11 01:51:41 +01:00
Sergio Martins
432ff65cc2 Remove QTimer hacks from Platform
It's now instantiated after qApp, so it's safe
2022-04-11 01:48:48 +01:00
Sergio Martins
037140b980 Add KDDockWidgets::initPlatform()
Instead of using the static variable, which is initialized before
having QApplication.

Will allow us to remove the QTimer from Platform init
2022-04-11 00:55:28 +01:00
Sergio Martins
8cd05c7314 Add Platform::createDefaultFrameworkWidgetFactory() 2022-04-10 23:54:52 +01:00
Sergio Martins
ec0e841bb8 Introduce qtwidgets/FrameworkWidgetFactory_qtwidgets
It doesn't scale to support all platforms with ifdefs, instead, use one
file per platform
2022-04-10 21:15:10 +01:00
Sergio Martins
613a18f60c Delete operator== for ViewWrapper
Fixes a bug in the tests too
2022-04-10 20:47:33 +01:00
Sergio Martins
d6fd54cec4 Por all usages of QWindop/windowHandle to KDDockWidgets::Window
Removes a lot of asQWidget() code and is also prepared for non-Qt
views.
2022-04-09 19:21:56 +01:00
Sergio Martins
4e47518a3f Merge branch '1.6' 2022-04-08 14:27:28 +01:00
Sergio Martins
47f773ab7c Use FloatingWindow::isMaximizedOverride() instead of isMaximized()
This is for issue #286.
Allows users to workaround buggy window managers.
2022-04-08 12:17:37 +01:00
Sergio Martins
5a8f176860 Add Window
A non-Qt abstraction around QWindow
2022-04-08 11:45:15 +01:00
Sergio Martins
8cfb10ef10 Use View::setParent() instead of QWidget::setParent() 2022-04-07 22:54:50 +01:00
Sergio Martins
95671f9d9a Add Platform_qt, a baseclass for both Qt frontends
So we can share some code between QtQuick and QtWidgets
2022-04-07 23:48:40 +01:00
Sergio Martins
427af43904 Remove some QtWidgetisms from DockRegistry 2022-04-07 23:16:43 +01:00
Sergio Martins
4944ad5882 Add Platform::qobjectAsView()
to be removed once we port away from Qt, but needed for now to
support QtQuick
2022-04-07 23:10:01 +01:00
Sergio Martins
59f9824cc2 Fix typo during porting of test 2022-04-07 22:48:09 +01:00
Sergio Martins
71f0b644f2 Port away from including TitleBar_qtwidgets in tests 2022-04-07 22:43:56 +01:00
Sergio Martins
b60b54327b Port away from Item::guestAsQObject()
Use Item::guestView() instead.
2022-04-07 22:27:22 +01:00
Sergio Martins
0f2da43737 Rename guestWidget to guestView
As we deal in View now
2022-04-07 20:12:47 +01:00
Sergio Martins
558bd42447 tests: Remove more QWidget dependencies 2022-04-07 00:49:36 +01:00
Sergio Martins
7107bfe3e6 Remove _qtwidget include from utils.h 2022-04-07 00:40:25 +01:00
Sergio Martins
be150c1c52 Port DockRegistry away from QGuiApplication::focusObjectChanged
Use the Qt agnostic way, from Platform.h
2022-04-07 00:24:06 +01:00
Sergio Martins
9f4cb1a13e Port FocusScope away from QGuiApplication 2022-04-05 23:01:29 +01:00
Sergio Martins
0addad590e ViewGuard: Add a -> const operator too
So we can call it if const
2022-04-05 23:00:20 +01:00
Sergio Martins
793e48150a Don't access qApp directly from Platform's ctor
QApplication might not be created yet, so delay it
With a timer for now. Don't guarantee this will stay.
Explicit init by the user might be an alternative.
2022-04-05 22:29:01 +01:00
Sergio Martins
3ba4bc2d08 Add Platform::focusedView() and respective signal
Implemented as QGuiApplication::focusObjectChanged() for Qt,
other frontends will have their own impl.
2022-04-05 21:53:52 +01:00
Sergio Martins
43faf85eb4 Add View::isNull()
ViewWrappers don't have ownership of the gui element.
The gui element might have been deleted, leaving us with a
stale wrapper

For impl simply use a QPointer in the QtWidgets and QtQuick
backends
2022-04-05 21:50:21 +01:00
Sergio Martins
ad3febd87e Add copyright headers to tst_viewguard 2022-04-05 21:29:35 +01:00
Sergio Martins
3e4d172765 ViewGuard: Add a copy-ctor 2022-04-05 21:29:35 +01:00
Waqar Ahmed
607ec01feb Extend tst_viewguard to test signal trigger after destruction 2022-04-06 01:13:50 +05:00
Sergio Martins
dc14a309a7 ViewGuard: Fix potential crash if the ViewGuard is deleted.
There was nothing disconnecting from the lambda.
Probably KDBindings needs a ConnectionHolder RAII class
2022-04-05 20:28:05 +01:00
Sergio Martins
fdc56b938e ViewGuard: Fix ctor and assign operator having different behaviours
The difference was very small: The ctor honoured View::inDtor()
while the assign op didn't. It's easy to make them behave the same
by creating a setView() method

As a side-effect the duplicate connect() is also gone now
2022-04-05 20:25:14 +01:00
Sergio Martins
4b62714ef5 ViewGuard: Fix clear() not disconnecting
When clear is called we should disconnect the signal, as it won't
be needed anymore. Benign though.
2022-04-05 20:18:09 +01:00
Sergio Martins
2763aec6c2 ViewGuard: Fix English typo in comment 2022-04-05 20:15:05 +01:00
Sergio Martins
73b874ec0b Remove stray qDebug from Platform.cpp 2022-04-05 20:10:24 +01:00
Sergio Martins
124b521308 ViewGuard: Add copyright headers
Some formatting too.
2022-04-05 20:09:24 +01:00
Sergio Martins
e09d4e2d3b Merge branch '1.6' 2022-04-05 17:27:37 +01:00
Sergio Martins
0897263fc9 Merge branch '1.6' 2022-04-05 17:14:21 +01:00
Albert Astals Cid
570f2c7e30 Fix position of right overlay dockwidgets when there's a toolbar on the left 2022-04-05 17:11:01 +01:00
Waqar Ahmed
b573d3f0f7 Introduce ViewGuard: A weak ptr to View 2022-04-05 17:05:17 +05:00
Sergio Martins
862c5f21d4 Update ChangeLog
For 1305dee081
Fixes #286

I might backport to 1.6 if I'm happy with it
2022-04-05 12:21:01 +01:00
Sergio Martins
1305dee081 Linux: Fix dragging of maximized floating windows
They should restore their normal size when the drag starts
2022-04-05 12:18:57 +01:00
Waqar Ahmed
84497f422d Fix fallthrough warning 2022-04-05 10:11:46 +01:00
Sergio Martins
ccd7557c75 Add View::beingDestroyed signal
It's emitted in ~View
2022-04-05 10:11:37 +01:00
Sergio Martins
1116eff816 Don't create ViewWrappers with nullptr
Instead return a null shared ptr
2022-04-04 22:36:16 +01:00
Sergio Martins
55ab08129a Deal the wrappers in shared_ptr instead of unique_ptr
Easier to pass around and better for our use case, where we
actual can have shared usage
2022-04-04 22:14:19 +01:00
Sergio Martins
c94705593f Update qtquick stubs
Not compilable yet, but not in cmake either
2022-04-04 21:54:27 +01:00
Sergio Martins
4f0f82f6b4 Add ViewWrapper_qtquick stub 2022-04-04 21:52:41 +01:00
Sergio Martins
b76e45064f Add View_qtquick stub 2022-04-04 19:06:17 +01:00
Sergio Martins
97653f03be qtquick: Move old (unported) files to old/ folder
We'll start moving them to views/ and cleaning/porting them
2022-04-04 18:35:12 +01:00
Waqar Ahmed
96f3100f77 Cleanup nlohmann_qt_helpers 2022-04-04 22:27:29 +05:00
Waqar Ahmed
06501c8a70 Header include guards for nlohmann_qt_helpers 2022-04-04 22:20:59 +05:00
Waqar Ahmed
dc93db9276 Add nlohmann QDebug helper 2022-04-04 22:20:59 +05:00
Waqar Ahmed
d6e678883c remove toVariantMap/fromVariantMap functions 2022-04-04 21:51:16 +05:00
Waqar Ahmed
3c424474ee Restore layout using nlohmann directly 2022-04-04 21:51:16 +05:00
Sergio Martins
631736b202 Abstract away a call to qApp->activePopupWidget()
It's now generic and doesn't depend on QApplication.
Removes an ifdef.
2022-04-04 16:43:01 +01:00
Sergio Martins
495ef0dd6a Move QmlTypes references out of DockRegistry
As it's specific to QtQuick
2022-04-04 16:36:17 +01:00
Sergio Martins
2a379d8735 Add Platform_qtquick
CMake hacked for now. Not sure if we should allow building
both QtWidgets and QtQuick frontends at the same time
2022-04-04 16:30:57 +01:00
Sergio Martins
6fcc55ce60 Add missing include 2022-04-04 16:30:41 +01:00
Sergio Martins
a36f85aae3 Add Platform and Platform_qtwidgets
So we can start removing QtWidgets vs QtQuick ifdefs.
Each "platform" will implement the differences
2022-04-04 16:21:35 +01:00
Sergio Martins
ac5cb637e7 Move DebugWindow to qtwidgets
As it's QtWidgets specific
2022-04-04 14:51:15 +01:00
Allen Winter
185ef5eb63 appveyor.yml - exclude wip/v2 branch 2022-04-04 14:51:15 +01:00
Waqar Ahmed
46b4e50a23 Save layout directly using nlohmann 2022-04-04 12:28:06 +05:00
Sergio Martins
e593233b8f Renamed views_qtwidgets/ into qtwidgets/views/
As there will be some files that are specific to QtWidgets and
but aren't views
2022-04-03 23:51:02 +01:00
Sergio Martins
852ff762c5 Rename views_qtquick/ qtquick/views/ 2022-04-03 23:44:31 +01:00
Sergio Martins
c12b0c161f Port layoutlinter away from direct QtWidget dependencies 2022-04-03 23:43:02 +01:00
Sergio Martins
84fb080d13 Remove more QWidget dependencies 2022-04-03 23:40:01 +01:00
Sergio Martins
81e5d14e4f Cleanup DropArea and base classes re receiving QWidget
They receive View now
2022-04-03 23:19:53 +01:00
Sergio Martins
ad1b77f79e Add MainWindow view interface 2022-04-03 22:25:57 +01:00
Sergio Martins
6cbf7247ce Fix crash, was mis-ported 2022-04-03 21:29:04 +01:00
Sergio Martins
d5700d94e6 MainWindow controller now receives View parent instead of QWidget 2022-04-03 21:23:03 +01:00
Sergio Martins
e9f287e2d7 More porting away from _qtwidgets 2022-04-03 21:09:37 +01:00
Sergio Martins
79f9f72ef4 DockWidget: decouple more from QtWidgets 2022-04-03 20:06:31 +01:00
Sergio Martins
a70b419c34 Remove one usage of DockWidget_qtwidgets 2022-04-03 00:23:39 +01:00
Sergio Martins
3cdd33f42f Add Frame view interface 2022-04-02 23:57:48 +01:00
Sergio Martins
2f0cbf83e9 Added SideBar view interface 2022-04-02 22:47:26 +01:00
Sergio Martins
f2aaf65674 Added TabBar view interface
Removes some dependencies to QtWidget
2022-04-02 22:38:33 +01:00
Sergio Martins
5681a5a231 Add a Stack view interface
So that stack controller doesn't depend on QtWidgets
2022-04-02 19:36:25 +01:00
Sergio Martins
aab3de29e1 Add a title bar interface, so we don't need to depend on TitleBar_qtwidgets 2022-04-02 18:50:35 +01:00
Sergio Martins
08d84337e7 Remove some unneeded includes 2022-04-02 15:45:06 +01:00
Sergio Martins
9b18ffb05c Port away from asQWidget()->screen(), use screen() directly 2022-04-02 15:45:00 +01:00
Sergio Martins
dcdd9333d4 Remove a bunch of asQWidget() calls 2022-04-02 15:34:38 +01:00
Waqar Ahmed
7bb363d3b2 Start moving layout saving to use nlohmann without involving Qt 2022-04-02 00:41:15 +05:00
Waqar Ahmed
c8127c1b36 Add QRect, QSize, QStringList nlohmann helpers 2022-04-02 00:40:20 +05:00
Waqar Ahmed
57dc7396ee Allow using system nlohmann 2022-04-01 23:47:27 +05:00
Waqar Ahmed
c781e82c37 Move nlohmann_qt_helpers.h to src 2022-04-01 23:45:15 +05:00
Waqar Ahmed
ea1fbf021d Move nlohmann into a subdirectory of 3rdparty
This helps us to use system one.
2022-04-01 23:44:35 +05:00
Sergio Martins
a754743014 More porting away from using Frame_qtwidgets directly in backend 2022-03-31 23:40:20 +01:00
Sergio Martins
c95d857483 Port away from casting to Frame_qtwidgets in most places
it's generic now
2022-03-31 23:17:27 +01:00
Sergio Martins
8ea346ca4a Added View::asFrameController() 2022-03-31 18:39:52 +01:00
Sergio Martins
1b3f90d73f Port away from casting to FloatingWindow_qtwidgets in the backend
Backend shouldn't know _qtwidget types exist
2022-03-31 18:36:40 +01:00
Sergio Martins
6687485e4c Introduce View::handle() and View::equals()
So we can compare two windows without calling asQWidget().
2022-03-31 17:34:37 +01:00
Sergio Martins
79abef21a5 Introduce View::parentView()
Similar to QWidget::parentWidget(), but not tied to QWidgets.

Allows to start removing some asQWidget() calls, as seen in Frame::floatingWindow(),
did it for POC.

Still need to find a generic way to compare 2 QWidget pointers
2022-03-31 16:47:37 +01:00
Sergio Martins
3fe1a8e79f Add View::asFloatingWindowController() 2022-03-31 16:27:37 +01:00
Sergio Martins
076125e0cf Add Controller::is() 2022-03-31 12:37:07 +01:00
Sergio Martins
0d8479b206 Add Controller::type() 2022-03-31 12:28:34 +01:00
Sergio Martins
cb2930f0e9 Move Type enum out of View, into KDDockWidgets namespace 2022-03-31 11:45:28 +01:00
Sergio Martins
2574e91634 Add convenience View::is(Type) 2022-03-30 23:09:08 +01:00
Sergio Martins
17cac581b8 Don't access side bar controller before it's initialized
As detected by UBSAN
2022-03-30 19:57:59 +01:00
Sergio Martins
b6bc3810bd tests: Remove unneeded deletion of top-level windows
They are deleted automatically nowadays
2022-03-30 19:36:17 +01:00
Sergio Martins
15cb93ed43 Port away from Controller::window() returning a QWidget
It now returns a ViewWrapper, which is agnostic to QtWidgets
2022-03-30 19:30:18 +01:00
Sergio Martins
bc09ec8a6a Merge branch '1.6' 2022-03-30 15:34:58 +01:00
Allen Winter
1354fa8a4a appveyor.yml - exclude wip/v2 branch 2022-03-30 10:30:10 -04:00
Sergio Martins
9d8d6f33ef Update ChangeLog with 3rdparty JSON library dependency 2022-03-30 11:51:31 +01:00
Sergio Martins
15601fc3c9 Split MainWindow into view/controller 2022-03-30 11:51:31 +01:00
Waqar Ahmed
eb3ad6b5a3 Use nlohmann for layout save/restore instead of QJson* 2022-03-30 11:51:26 +01:00
Waqar Ahmed
2434455d41 Add nlohmann helpers for qt 2022-03-30 11:51:13 +01:00
Waqar Ahmed
62fe37be9f Add nlohmann::json 2022-03-30 11:50:45 +01:00
Sergio Martins
f2957e35d5 Moved MainWindow into Controllers namespace
All renamings and movings are done, next step is to make the controller
a proper controller, and same for the view.
2022-03-25 11:30:40 +00:00
Sergio Martins
ba08d0c131 Fix clang build due to -Wweak-vtables
That's to be fixed in KDBindings first
2022-03-25 11:30:04 +00:00
Sergio Martins
65a6201121 Fix unused private field warning on clang
More methods to be implemented soon, but let's have at least 1
now to get rid of the warning
2022-03-25 11:29:49 +00:00
Sergio Martins
9fba1e9799 Rename Controller::DockWidgetBase to Controller::DockWidget
As done for other controllers
2022-03-25 10:53:02 +00:00
Sergio Martins
8656108e81 Renamed MainWindowBase to MainWindow
As done for other controllers
2022-03-25 10:47:20 +00:00
Sergio Martins
63b5109113 Rename Views::MainWindow to Views::MainWindow_qtwidgets
As done for other views
2022-03-25 10:41:46 +00:00
Sergio Martins
264b08a731 Move MainWindow view into Views namespace 2022-03-25 10:40:16 +00:00
Sergio Martins
0c686c1339 Renamed MainWindowBase.h to MainWindow.h
As done for other controllers
2022-03-25 10:30:07 +00:00
Sergio Martins
27007184aa Rename MainWindow.h to MainWindow_qtwidgets.h
Just like the other views.
2022-03-25 10:27:25 +00:00
Sergio Martins
7e2f448ae1 Moved MainWindowBase/MainWindow into controllers/view folder
This is just the move, not ported yet
2022-03-25 10:21:07 +00:00
Sergio Martins
90a9159748 Introduce ViewWrapper - a non-owning view
In many cases we need to access widgets that weren't created by
KDDW, in that case we have no View. Since all our APIs want to
deal in View and not in QWidget, we need a way to wrap stuff like
QWidget::window() and windowHandle()

All methods are unimplemented. Will only implement those that
are required/used.
2022-03-25 10:03:46 +00:00
Sergio Martins
e0e6d1fd3e Merge both Logging_p.cpp into the same one
the multisplitter abstraction is no longer the way we want to
abstract the framework
2022-03-24 16:59:50 +00:00
Sergio Martins
123fcdde1f Remove unused backend_temp_includes/ folder 2022-03-24 16:53:27 +00:00
Sergio Martins
15956ab222 Move all the QtQuick files to views_qtquick/
It's not ported yet, bet at least they are in their final folder
and not polutting the rest
2022-03-24 16:43:27 +00:00
Sergio Martins
c6d95c42a8 Split most widgets into a Controller and a View
Controllers don't have any GUI and don't depend on the frontend
technology.

Views are implemented in a specific GUI tech (QtWidgets, QtQuick, etc).

For now only QtWidgets work. There's still a lot to decouple.

This will make it easier to introduce non-Qt backends.
2022-03-24 16:05:37 +00:00
Allen Winter
fe7497ab92 Merge branch '1.6' 2022-03-15 08:09:25 -04:00
Allen Winter
030b3c34d2 CMakeLists.txt, Changelog - open for version 1.7 2022-03-15 08:04:35 -04:00
Sergio Martins
ca3fe4070a Port layouting signals to KDBindings 2022-02-12 16:15:07 +00:00
Sergio Martins
bef7aab7f6 Move kdbindings to src/3rdparty 2022-02-12 14:45:12 +00:00
Sergio Martins
d4bcc96f2f Add KDBindings to 3rdparty
To replace Qt in the backend.
2022-02-12 14:45:12 +00:00
Sergio Martins
b5003f8fb8 Make sure the layouting builds standalone
Goal will be for it to be C++ only, eventually.
backend_temp_includes/ is to be removed, but required to build currently.
2022-02-12 14:45:12 +00:00
750 changed files with 142859 additions and 22864 deletions

View File

@@ -47,7 +47,7 @@ AlignAfterOpenBracket: true
AlwaysBreakBeforeMultilineStrings: false
AlwaysBreakTemplateDeclarations: true
BinPackParameters: true
ColumnLimit: 0
ColumnLimit: 100
Cpp11BracedListStyle: false
DerivePointerBinding: false
ExperimentalAutoDetectBinPacking: false

View File

@@ -49,7 +49,7 @@ with section("format"):
# If a positional argument group contains more than this many arguments, then
# force it to a vertical layout.
max_pargs_hwrap = 4
max_pargs_hwrap = 6
# If a cmdline positional group consumes more than this many lines without
# nesting, then invalidate the layout (and nest)
@@ -94,8 +94,7 @@ with section("format"):
keyword_case = 'upper'
# A list of command names which should always be wrapped
always_wrap = ["add_executable", "add_library",
"target_link_libraries", "target_include_directories", "install"]
always_wrap = []
# If true, the argument lists which are known to be sortable will be sorted
# lexicographicall
@@ -103,7 +102,7 @@ with section("format"):
# If true, the parsers may infer whether or not an argument list is sortable
# (without annotation).
autosort = True
autosort = False
# By default, if cmake-format cannot successfully fit everything into the
# desired linewidth it will apply the last, most agressive attempt that it

View File

@@ -1,4 +1,4 @@
[codespell]
skip = ./build-*,.git,*.svg,rc_assets.py
skip = ./build-*,.git,*.svg,rc_assets.py,./src/flutter/generated*
interactive = 3
ignore-words-list = overlay,overlayed
ignore-words-list = overlay,overlayed,seh,sharable

7
.gitignore vendored
View File

@@ -67,3 +67,10 @@ kddockwidgets_minimal_example
.vscode
/.cache
/compile_commands.json
/site
.DS_Store
.packages
pubspec.lock
.dart_tool
mjb_rejected_*
mjb_rejected_classes.log

3
.krazy
View File

@@ -16,9 +16,6 @@ EXCLUDE style
SKIP /fwd_headers/
SKIP Doxyfile.cmake
#skip some example files
SKIP /examples/qtquick/CMakeFiles/
#skip CMake files
SKIP /KDDockWidgetsConfig.cmake.in
#skip more files

View File

@@ -1,9 +1,9 @@
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
exclude: ^(cmake/ECM|cmake/KDAB/)
exclude: ^(cmake/ECM|cmake/KDAB/|src/3rdparty/)
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.3.0
rev: v3.2.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
@@ -13,22 +13,22 @@ repos:
args: [--allow-multiple-documents]
- id: check-json
- repo: https://github.com/pre-commit/mirrors-clang-format
rev: v14.0.0
rev: v14.0.6
hooks:
- id: clang-format
exclude: (.json)
- repo: https://github.com/PyCQA/pylint
rev: v2.15.2
rev: v2.15.3
hooks:
- id: pylint
exclude: ^(.cmake-format.py|conan/conanfile.py)
additional_dependencies: ["PySide2", "PySide6"]
- repo: https://github.com/pre-commit/mirrors-autopep8
rev: v1.7.0
rev: v1.6.0
hooks:
- id: autopep8
- repo: https://github.com/codespell-project/codespell
rev: v2.2.1
rev: v2.1.0
hooks:
- id: codespell
- repo: https://github.com/cheshirekow/cmake-format-precommit

View File

@@ -140,8 +140,6 @@ disable=print-statement,
exception-escape,
comprehension-escape,
consider-using-f-string,
useless-option-value,
unknown-option-value,
R0801,I1101,E0401
# Enable the message, report, category or checker with the given id(s). You can

View File

@@ -9,12 +9,12 @@ Copyright: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@k
License: GPL-2.0-only OR GPL-3.0-only
#misc documentation
Files: CONTRIBUTORS.txt Changelog README.md README-QtQuick.md README-WASM.md README-Wayland.md README-bindings.md README-troubleshooting conan/README.txt python/examples/README.txt python/examples-qt6/README.txt docs/KDDockWidgets-CopyrightAssignmentForm.pdf *.html
Files: CONTRIBUTORS.txt Changelog README.md README-QtQuick.md README-WASM.md README-Wayland.md README-bindings.md README-troubleshooting conan/README.txt python/examples/README.txt python/examples-qt6/README.txt docs_devel/*.md docs/KDDockWidgets-CopyrightAssignmentForm.pdf *.html
Copyright: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
License: GPL-2.0-only OR GPL-3.0-only
#misc config files
Files: .pre-commit-config.yaml .codespellrc .krazy .cmake-format .clang-format .clazy .gitignore .mdlrc .mdlrc.rb .pep8 .pylintrc appveyor.yml code.dev-*.code-workspace docs/api/Doxyfile.cmake distro/*
Files: .pre-commit-config.yaml .codespellrc .krazy .cmake-format .clang-format .clazy .gitignore .mdlrc .mdlrc.rb .pep8 .pylintrc appveyor.yml mkdocs.yml code.dev-*.code-workspace code.dev*.code-workspace docs/api/Doxyfile.cmake distro/* *.yaml
Copyright: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
License: BSD-3-Clause
@@ -27,3 +27,12 @@ License: GPL-2.0-only OR GPL-3.0-only
Files: cmake/ECM/modules/*
Copyright: The KDE Project
License: BSD-3-Clause
#3rdparty C++
Files: src/3rdparty/kdbindings/genindex_array.h
Copyright: 2021 Jeremy Burns
License: MIT
Files: src/3rdparty/doctest/doctest.h
Copyright: 2016-2021 Viktor Kirilov <vik.kirilov@gmail.com>
License: MIT

View File

@@ -11,63 +11,48 @@
# Pass the following variables to cmake to control the build:
#
# -DKDDockWidgets_QT6=[true|false]
# Build against Qt6 rather than Qt5
# Default=false (Qt5 will be used even if Qt6 is available)
# -DKDDockWidgets_QT6=[true|false] Build against Qt6 rather than Qt5
# Default=false (Qt5 will be used even if Qt6 is available)
#
# -DKDDockWidgets_STATIC=[true|false]
# Build static versions of the libraries
# Default=false
# -DKDDockWidgets_STATIC=[true|false] Build static versions of the libraries
# Default=false
#
# -DKDDockWidgets_TESTS=[true|false]
# Build the test harness.
# Currently ignored (except for Python bindings) unless KDDockWidgets_DEVELOPER_MODE=True.
# Default=false
# -DKDDockWidgets_TESTS=[true|false] Build the test harness. Currently ignored
# (except for Python bindings) unless KDDockWidgets_DEVELOPER_MODE=True.
# Default=false
#
# -DKDDockWidgets_EXAMPLES=[true|false]
# Build the examples.
# Default=true
# -DKDDockWidgets_EXAMPLES=[true|false] Build the examples. Default=true
#
# -DKDDockWidgets_DOCS=[true|false]
# Build the API documentation. Enables the 'docs' build target.
# Default=false
# -DKDDockWidgets_DOCS=[true|false] Build the API documentation. Enables the
# 'docs' build target. Default=false
#
# -DKDDockWidgets_QTQUICK=[true|false]
# Build for QtQuick instead of QtWidgets.
# Default=false
# -DKDDockWidgets_PYTHON_BINDINGS=[true|false] Build/Generate python bindings.
# Always false for Debug builds (If your shiboken or pyside is installed in a
# non-standard locations try passing the SHIBOKEN_CUSTOM_PREFIX and
# PYSIDE_CUSTOM_PREFIX variables.) Default=false
#
# -DKDDockWidgets_PYTHON_BINDINGS=[true|false]
# Build/Generate python bindings. Always false for Debug builds
# (If your shiboken or pyside is installed in a non-standard locations
# try passing the SHIBOKEN_CUSTOM_PREFIX and PYSIDE_CUSTOM_PREFIX variables.)
# Default=false
#
# -DKDDockWidgets_PYTHON_BINDINGS_INSTALL_PREFIX=[path]
# Set an alternative install path for Python bindings
# Default=CMAKE_INSTALL_PREFIX
# -DKDDockWidgets_PYTHON_BINDINGS_INSTALL_PREFIX=[path] Set an alternative
# install path for Python bindings Default=CMAKE_INSTALL_PREFIX
# ## DO NOT USE IF YOU ARE AN END-USER. FOR THE DEVELOPERS ONLY!!
## Special CMake Options for Developers
# ## DO NOT USE IF YOU ARE AN END-USER. FOR THE DEVELOPERS ONLY!! # Special
# CMake Options for Developers
#
# -DKDDockWidgets_DEVELOPER_MODE=[true|false]
# Configure the build for a developer setup.
# Enables some features that are not geared towards end-users.
# Forces the test harness to be built.
# Default=false
# -DKDDockWidgets_DEVELOPER_MODE=[true|false] Configure the build for a
# developer setup. Enables some features that are not geared towards end-users.
# Forces the test harness to be built. Default=false
#
# -DKDDockWidgets_WERROR=[true|false]
# Compile with the -Werror gcc/clang option (always true for developer-mode)
# Default=false
# -DKDDockWidgets_WERROR=[true|false] Compile with the -Werror gcc/clang option
# (always true for developer-mode) Default=false
#
# -DKDDockWidgets_LINTER=[true|false]
# Build the layout linter.
# Ignored unless KDDockWidgets_DEVELOPER_MODE=True
# Default=true
# -DKDDockWidgets_LINTER=[true|false] Build the layout linter. Ignored unless
# KDDockWidgets_DEVELOPER_MODE=True Default=true
#
# -DKDDockWidgets_FUZZER=[true|false]
# Build the fuzzer.
# Ignored unless KDDockWidgets_DEVELOPER_MODE=True
# Default=true
# -DKDDockWidgets_CODE_COVERAGE=[true|false] Enable coverage reporting. Ignored
# unless KDDockWidgets_DEVELOPER_MODE=True Default=false
#
# -DKDDockWidgets_FRONTENDS='qtwidgets;qtquick' Semicolon separated list of
# frontends to enable. If not specified, frontends will be enabled based on
# availability of libraries on your system.
cmake_minimum_required(VERSION 3.12)
@@ -76,6 +61,7 @@ set(KDAB_INSTALL
True
CACHE INTERNAL "Install to default KDAB Location"
)
if(DEFINED CMAKE_INSTALL_PREFIX)
if(NOT "${CMAKE_INSTALL_PREFIX}" STREQUAL "")
set(KDAB_INSTALL
@@ -92,96 +78,170 @@ project(
LANGUAGES CXX
)
set(${PROJECT_NAME}_VERSION_MAJOR 1)
set(${PROJECT_NAME}_VERSION_MINOR 6)
set(${PROJECT_NAME}_VERSION_PATCH 95)
set(${PROJECT_NAME}_VERSION
${${PROJECT_NAME}_VERSION_MAJOR}.${${PROJECT_NAME}_VERSION_MINOR}.${${PROJECT_NAME}_VERSION_PATCH}
)
set(PROJECT_VERSION ${${PROJECT_NAME}_VERSION}) #PROJECT_VERSION is needed by some ECM modules
set(${PROJECT_NAME}_SOVERSION "1.7")
set(KDDockWidgets_VERSION_MAJOR 2)
set(KDDockWidgets_VERSION_MINOR 0)
set(KDDockWidgets_VERSION_PATCH 9)
set(KDDockWidgets_VERSION ${KDDockWidgets_VERSION_MAJOR}.${KDDockWidgets_VERSION_MINOR}.${KDDockWidgets_VERSION_PATCH})
set(PROJECT_VERSION ${KDDockWidgets_VERSION}) # PROJECT_VERSION is needed by some ECM modules
set(KDDockWidgets_SOVERSION "2.0")
include(FeatureSummary)
option(${PROJECT_NAME}_QT6 "Build against Qt 6" OFF)
option(${PROJECT_NAME}_DEVELOPER_MODE "Developer Mode" OFF)
option(${PROJECT_NAME}_PYTHON_BINDINGS "Build python bindings" OFF)
option(${PROJECT_NAME}_QTQUICK "Build for QtQuick instead of QtWidgets" OFF)
option(${PROJECT_NAME}_STATIC "Build statically" OFF)
option(${PROJECT_NAME}_TESTS "Build the tests" OFF)
option(${PROJECT_NAME}_EXAMPLES "Build the examples" ON)
option(${PROJECT_NAME}_DOCS "Build the API documentation" OFF)
option(${PROJECT_NAME}_WERROR "Use -Werror (will be true for developer-mode unconditionally)" OFF)
option(${PROJECT_NAME}_X11EXTRAS
"Link with QtX11Extras to detect if the compositor supports transparency. Not applicable to non-Linux or Qt6."
option(KDDockWidgets_QT6 "Build against Qt 6" OFF)
option(KDDockWidgets_DEVELOPER_MODE "Developer Mode" OFF)
option(KDDockWidgets_PYTHON_BINDINGS "Build python bindings" OFF)
option(KDDockWidgets_STATIC "Build statically" OFF)
option(KDDockWidgets_TESTS "Build the tests" OFF)
option(KDDockWidgets_EXAMPLES "Build the examples" ON)
option(KDDockWidgets_DOCS "Build the API documentation" OFF)
option(KDDockWidgets_WERROR "Use -Werror (will be true for developer-mode unconditionally)" OFF)
option(KDDockWidgets_X11EXTRAS
"Link against QtX11Extras to detect if the compositor supports transparency. Not applicable on non-Linux or Qt6."
ON
)
option(${PROJECT_NAME}_XLib "On Linux, link against XLib, for a more robust window z-order detection." OFF)
option(KDDockWidgets_XLib "On Linux, link against XLib, for a more robust window z-order detection." OFF)
option(KDDockWidgets_CODE_COVERAGE "Enable coverage reporting" OFF)
option(KDDockWidgets_FRONTENDS "Semicolon separated list of frontends to enable" "")
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake/ECM/modules")
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake/KDAB/modules")
# Set a default build type if none was specified
set(default_build_type "Release")
if(EXISTS "${CMAKE_SOURCE_DIR}/.git" OR ${PROJECT_NAME}_DEVELOPER_MODE)
if(EXISTS "${CMAKE_SOURCE_DIR}/.git" OR KDDockWidgets_DEVELOPER_MODE)
set(default_build_type "Debug")
endif()
if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
message(STATUS "Setting build type to ${default_build_type} as none was specified.")
set(CMAKE_BUILD_TYPE
"${default_build_type}"
CACHE STRING "Choose the type of build." FORCE
)
# Set the possible values of build type for cmake-gui
set_property(
CACHE CMAKE_BUILD_TYPE
PROPERTY STRINGS
"Debug"
"Release"
"MinSizeRel"
"RelWithDebInfo"
)
set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS "Debug" "Release" "MinSizeRel" "RelWithDebInfo")
endif()
if(${PROJECT_NAME}_XLib)
if(KDDockWidgets_XLib)
add_definitions(-DKDDockWidgets_XLIB)
endif()
if(${PROJECT_NAME}_QT6)
if(MSVC AND MSVC_TOOLSET_VERSION LESS 142)
message(FATAL_ERROR "VS 2019 is the minimum required toolset")
endif()
if(KDDockWidgets_QT6)
set(Qt_VERSION_MAJOR 6)
set(QT_MIN_VERSION "6.2.0")
set(${PROJECT_NAME}_LIBRARY_QTID "-qt6")
set(KDDockWidgets_LIBRARY_QTID "-qt6")
else()
set(Qt_VERSION_MAJOR 5)
set(QT_MIN_VERSION "5.15")
set(${PROJECT_NAME}_LIBRARY_QTID "")
set(KDDockWidgets_LIBRARY_QTID "")
endif()
find_package(Qt${Qt_VERSION_MAJOR} ${QT_MIN_VERSION} NO_MODULE REQUIRED COMPONENTS Widgets Test)
include(KDQtInstallPaths) #to set QT_INSTALL_FOO variables
set(${PROJECT_NAME}_DEPS "widgets")
if(${PROJECT_NAME}_QTQUICK)
find_package(Qt${Qt_VERSION_MAJOR} NO_MODULE REQUIRED COMPONENTS Quick QuickControls2)
add_definitions(-DKDDOCKWIDGETS_QTQUICK)
set(${PROJECT_NAME}_DEPS "${${PROJECT_NAME}_DEPS} quick quickcontrols2")
# BEGIN frontend enabling
if(KDDockWidgets_FRONTENDS)
set(KDDockWidgets_ALL_FRONTENDS "qtwidgets;qtquick;dummy;flutter")
foreach(frontend ${KDDockWidgets_FRONTENDS})
if(NOT ${frontend} IN_LIST KDDockWidgets_ALL_FRONTENDS)
message(FATAL_ERROR "Unknown frontend ${frontend}")
endif()
endforeach()
endif()
if(KDDockWidgets_FRONTENDS)
# qtwidgets
if("qtwidgets" IN_LIST KDDockWidgets_FRONTENDS)
find_package(Qt${Qt_VERSION_MAJOR} ${QT_MIN_VERSION} NO_MODULE REQUIRED COMPONENTS Widgets)
set(KDDW_FRONTEND_QTWIDGETS ON)
endif()
# qtquick
if("qtquick" IN_LIST KDDockWidgets_FRONTENDS)
find_package(Qt${Qt_VERSION_MAJOR} ${QT_MIN_VERSION} NO_MODULE REQUIRED COMPONENTS Quick QuickControls2)
set(KDDW_FRONTEND_QTQUICK ON)
endif()
# dummy
if("dummy" IN_LIST KDDockWidgets_FRONTENDS)
# For now dummy still depends on Qt
find_package(Qt${Qt_VERSION_MAJOR} ${QT_MIN_VERSION} NO_MODULE REQUIRED COMPONENTS Gui)
set(KDDW_FRONTEND_DUMMY ON)
endif()
# flutter
if("flutter" IN_LIST KDDockWidgets_FRONTENDS)
# For now flutter still depends on Qt
find_package(Qt${Qt_VERSION_MAJOR} ${QT_MIN_VERSION} NO_MODULE REQUIRED COMPONENTS Gui)
set(KDDW_FRONTEND_FLUTTER ON)
endif()
else()
add_definitions(-DKDDOCKWIDGETS_QTWIDGETS)
set(ENABLED_FRONTENDS "")
message("No frontends specified explicitly.")
# qtwidgets
find_package(Qt${Qt_VERSION_MAJOR} ${QT_MIN_VERSION} NO_MODULE COMPONENTS Widgets Quick QuickControls2)
if(Qt${Qt_VERSION_MAJOR}Widgets_FOUND)
list(APPEND ENABLED_FRONTENDS "qtwidgets")
set(KDDW_FRONTEND_QTWIDGETS ON)
endif()
# qtquick
if(Qt${Qt_VERSION_MAJOR}Quick_FOUND AND Qt${Qt_VERSION_MAJOR}QuickControls2_FOUND)
list(APPEND ENABLED_FRONTENDS "qtquick")
set(KDDW_FRONTEND_QTQUICK ON)
endif()
if(NOT ENABLED_FRONTENDS)
message(FATAL_ERROR "Failed to enable any frontends. Please install the required libraries and try again.")
endif()
message("Following frontends have been enabled:")
foreach(frontend ${ENABLED_FRONTENDS})
message("* ${frontend}")
endforeach()
endif()
# END frontend enabling
include(KDQtInstallPaths) # to set QT_INSTALL_FOO variables
add_definitions(-DQT_NO_KEYWORDS)
option(KDockWidgets_PRETTY_QTWIDGETS_HEADERS
"Install DockWidget.h and MainWindow.h as synonyms to the *_qtwidgets.h counterparts."
${KDDW_FRONTEND_QTWIDGETS}
)
if(KDDW_FRONTEND_QTWIDGETS)
set(KDDockWidgets_DEPS "widgets")
endif()
if(KDDW_FRONTEND_QTQUICK)
set(KDDockWidgets_DEPS "${KDDockWidgets_DEPS} quick quickcontrols2")
endif()
if(NOT WIN32
AND NOT APPLE
AND NOT EMSCRIPTEN
AND NOT ${PROJECT_NAME}_QT6
AND ${PROJECT_NAME}_X11EXTRAS
AND NOT KDDockWidgets_QT6
AND KDDockWidgets_X11EXTRAS
)
set(${PROJECT_NAME}_DEPS "${${PROJECT_NAME}_DEPS} x11extras")
set(KDDockWidgets_DEPS "${KDDockWidgets_DEPS} x11extras")
endif()
#Always build the test harness in developer-mode
if(${PROJECT_NAME}_DEVELOPER_MODE)
set(${PROJECT_NAME}_TESTS ON)
set(${PROJECT_NAME}_WERROR ON)
# Always build the test harness in developer-mode
if(KDDockWidgets_DEVELOPER_MODE)
set(KDDockWidgets_TESTS ON)
set(KDDockWidgets_WERROR ON)
include(ECMEnableSanitizers)
# find_package(doctest REQUIRED) TODOm3
endif()
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
@@ -190,10 +250,8 @@ else()
set(IS_CLANG_BUILD FALSE)
endif()
if(${PROJECT_NAME}_QTQUICK)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
endif()
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
@@ -205,7 +263,7 @@ set(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
# Sets compiler flags for the specified target, taking platform into consideration.
macro(set_compiler_flags targetName)
if(${PROJECT_NAME}_DEVELOPER_MODE)
if(KDDockWidgets_DEVELOPER_MODE)
target_compile_definitions(
${targetName}
PUBLIC DOCKS_DEVELOPER_MODE
@@ -222,7 +280,7 @@ macro(set_compiler_flags targetName)
endif()
# Enable -Werror
if(${PROJECT_NAME}_WERROR AND (NOT MSVC OR IS_CLANG_BUILD)) # clang-cl accepts these too
if(KDDockWidgets_WERROR AND (NOT MSVC OR IS_CLANG_BUILD)) # clang-cl accepts these too
target_compile_options(${targetName} PRIVATE -Werror -Wundef -Wno-error=deprecated-declarations)
endif()
endmacro()
@@ -236,6 +294,7 @@ if((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE)
set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--fatal-warnings ${CMAKE_MODULE_LINKER_FLAGS}")
string(TOUPPER "CMAKE_CXX_FLAGS_${CMAKE_BUILD_TYPE}" compileflags)
if("${CMAKE_CXX_FLAGS} ${${compileflags}}" MATCHES "-fsanitize")
set(sanitizers_enabled TRUE)
else()
@@ -252,21 +311,21 @@ if((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE)
endif()
endif()
if(${PROJECT_NAME}_STATIC)
set(${PROJECT_NAME}_LIBRARY_MODE "STATIC")
if(KDDockWidgets_STATIC)
set(KDDockWidgets_LIBRARY_MODE "STATIC")
else()
set(${PROJECT_NAME}_LIBRARY_MODE "SHARED")
set(KDDockWidgets_LIBRARY_MODE "SHARED")
endif()
if(KDAB_INSTALL)
if(UNIX)
set(CMAKE_INSTALL_PREFIX
"/usr/local/KDAB/${PROJECT_NAME}-${${PROJECT_NAME}_VERSION}"
"/usr/local/KDAB/KDDockWidgets-${KDDockWidgets_VERSION}"
CACHE INTERNAL "Install to default KDAB Location"
)
elseif(WIN32)
set(CMAKE_INSTALL_PREFIX
"C:\\KDAB\\${PROJECT_NAME}-${${PROJECT_NAME}_VERSION}"
"C:\\KDAB\\KDDockWidgets-${KDDockWidgets_VERSION}"
CACHE INTERNAL "Install to default KDAB Location"
)
endif()
@@ -276,9 +335,9 @@ endif()
include(KDInstallLocation)
if(CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR)
set(${PROJECT_NAME}_IS_ROOT_PROJECT TRUE)
set(KDDockWidgets_IS_ROOT_PROJECT TRUE)
message(STATUS "Building ${PROJECT_NAME} ${${PROJECT_NAME}_VERSION} in ${CMAKE_BUILD_TYPE} mode. "
message(STATUS "Building KDDockWidgets ${KDDockWidgets_VERSION} in ${CMAKE_BUILD_TYPE} mode. "
"Installing to ${CMAKE_INSTALL_PREFIX}"
)
@@ -289,18 +348,18 @@ if(CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR)
install(FILES LICENSE.txt README.md DESTINATION ${INSTALL_DOC_DIR})
install(DIRECTORY LICENSES DESTINATION ${INSTALL_DOC_DIR})
# Generate .pri file for qmake users (except when using the VS generator)
# Generate .pri file for qmake users
if(NOT CMAKE_CONFIGURATION_TYPES)
if(Qt_VERSION_MAJOR EQUAL 5 OR (Qt_VERSION_MAJOR EQUAL 6 AND Qt6Core_VERSION VERSION_GREATER "6.2"))
include(ECMGeneratePriFile)
set(PROJECT_VERSION_STRING ${${PROJECT_NAME}_VERSION})
set(PROJECT_VERSION_STRING ${KDDockWidgets_VERSION})
ecm_generate_pri_file(
BASE_NAME
KDDockWidgets
LIB_NAME
kddockwidgets${${PROJECT_NAME}_LIBRARY_QTID}
DEPS
${${PROJECT_NAME}_DEPS}
${KDDockWidgets_DEPS}
FILENAME_VAR
pri_filename
INCLUDE_INSTALL_DIR
@@ -310,50 +369,67 @@ if(CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR)
endif()
endif()
else()
#Always disable tests, examples, docs when used as a submodule
set(${PROJECT_NAME}_IS_ROOT_PROJECT FALSE)
set(${PROJECT_NAME}_TESTS FALSE)
set(${PROJECT_NAME}_EXAMPLES FALSE)
set(${PROJECT_NAME}_DOCS FALSE)
# Always disable tests, examples, docs when used as a submodule
set(KDDockWidgets_IS_ROOT_PROJECT FALSE)
set(KDDockWidgets_TESTS FALSE)
set(KDDockWidgets_EXAMPLES FALSE)
set(KDDockWidgets_DOCS FALSE)
endif()
if(${PROJECT_NAME}_TESTS)
if(KDDockWidgets_TESTS)
enable_testing()
endif()
add_subdirectory(src)
if(${PROJECT_NAME}_PYTHON_BINDINGS)
if(CMAKE_BUILD_TYPE MATCHES "^[Dd]eb" OR ${PROJECT_NAME}_STATIC)
if(KDDockWidgets_PYTHON_BINDINGS)
if(CMAKE_BUILD_TYPE MATCHES "^[Dd]eb" OR KDDockWidgets_STATIC)
message(FATAL_ERROR "** Python Bindings are disabled in debug or static builds.")
endif()
if(CMAKE_UNITY_BUILD)
message(FATAL_ERROR "** Python Bindings are disabled in Unity builds. " "Try again with CMAKE_UNITY_BUILD=OFF")
message(FATAL_ERROR "** Python Bindings are disabled in Unity builds. Try again with CMAKE_UNITY_BUILD=OFF")
endif()
endif()
if(${PROJECT_NAME}_PYTHON_BINDINGS)
add_subdirectory(python)
endif()
if(${PROJECT_NAME}_EXAMPLES)
if(${PROJECT_NAME}_QTQUICK)
if(KDDockWidgets_EXAMPLES)
if(KDDW_FRONTEND_QTQUICK)
add_subdirectory(examples/qtquick)
else()
endif()
if(KDDW_FRONTEND_QTWIDGETS)
add_subdirectory(examples/dockwidgets)
add_subdirectory(examples/minimal)
add_subdirectory(examples/minimal-mdi)
add_subdirectory(examples/mdi)
add_subdirectory(examples/mdi_with_docking)
set_compiler_flags(kddockwidgets_example)
set_compiler_flags(kddockwidgets_minimal_example)
set_compiler_flags(kddockwidgets_mdi_with_docking_example)
set_compiler_flags(qtwidgets_dockwidgets)
set_compiler_flags(qtwidgets_minimal)
set_compiler_flags(qtwidgets_mdi_with_docking)
set_target_properties(
qtwidgets_dockwidgets PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/"
)
set_target_properties(
qtwidgets_mdi_with_docking PROPERTIES RUNTIME_OUTPUT_DIRECTORY
"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/"
)
set_target_properties(
qtwidgets_mdi PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/"
)
set_target_properties(
qtwidgets_minimal PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/"
)
endif()
endif()
if(${PROJECT_NAME}_TESTS)
if(${PROJECT_NAME}_DEVELOPER_MODE)
if(KDDockWidgets_TESTS)
if(KDDockWidgets_DEVELOPER_MODE)
add_subdirectory(tests)
# tst_docks.exe is pretty big (160 tests), so split it in more runs so we can use threads.
# tst_docks.exe is pretty big (160 tests), so split it in more runs so we
# can use threads.
add_test(NAME tst_docks0 COMMAND tests_launcher 0 5)
add_test(NAME tst_docks1 COMMAND tests_launcher 1 5)
add_test(NAME tst_docks2 COMMAND tests_launcher 2 5)
@@ -377,19 +453,35 @@ if(${PROJECT_NAME}_TESTS)
add_test(NAME tst_docks20 COMMAND tests_launcher 19 5)
add_test(NAME tst_docks21 COMMAND tests_launcher 20 5) # one more for rounding leftovers
if(NOT ${PROJECT_NAME}_QTQUICK)
# tst_multisplitter depends on QWidget
add_test(NAME tst_multisplitter COMMAND tst_multisplitter)
add_test(NAME tst_view COMMAND tst_view)
add_test(NAME tst_window COMMAND tst_window)
add_test(NAME tst_droparea COMMAND tst_droparea)
add_test(NAME tst_platform COMMAND tst_platform)
add_test(NAME tst_viewguard COMMAND tst_viewguard)
add_test(NAME tst_group COMMAND tst_group)
add_test(NAME tst_titlebar COMMAND tst_titlebar)
add_test(NAME tst_stack COMMAND tst_stack)
add_test(NAME tst_tabbar COMMAND tst_tabbar)
add_test(NAME tst_separator COMMAND tst_separator)
add_test(NAME tst_floatingwindow COMMAND tst_floatingwindow)
add_test(NAME tst_dockwidget COMMAND tst_dockwidget)
add_test(NAME tst_multisplitter COMMAND tst_multisplitter)
if(KDDW_FRONTEND_QTWIDGETS)
add_test(NAME tst_qtwidgets COMMAND tst_qtwidgets)
endif()
if(KDDW_FRONTEND_QTQUICK)
add_test(NAME tst_qtquick COMMAND tst_qtquick)
endif()
endif()
endif()
if(${PROJECT_NAME}_DOCS)
if(KDDockWidgets_DOCS)
add_subdirectory(docs) # needs to go last, in case there are build source files
endif()
if(${PROJECT_NAME}_IS_ROOT_PROJECT)
if(KDDockWidgets_IS_ROOT_PROJECT)
# Add uninstall target (not for submodules since parent projects typically have uninstall too)
include(ECMUninstallTarget)
endif()

View File

@@ -9,11 +9,12 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_FUZZER" : "OFF"
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "OFF",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick;dummy"
},
"warnings" : {
"uninitialized" : true
"warnings": {
"uninitialized": true
}
},
{
@@ -25,12 +26,47 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_FUZZER" : "OFF",
"ECM_ENABLE_SANITIZERS" : "'address;undefined'"
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "OFF",
"ECM_ENABLE_SANITIZERS": "'address;undefined'",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick;dummy"
},
"warnings" : {
"uninitialized" : true
"warnings": {
"uninitialized": true
}
},
{
"name": "dev-flutter",
"displayName": "dev-flutter",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-dev-flutter",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "OFF",
"KDDockWidgets_FRONTENDS": "flutter",
"ECM_ENABLE_SANITIZERS": "'address;undefined'"
},
"warnings": {
"uninitialized": true
}
},
{
"name": "dev-lcov",
"displayName": "dev-lcov",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-dev-lcov",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "OFF",
"KDDockWidgets_CODE_COVERAGE": "ON",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
},
"warnings": {
"uninitialized": true
}
},
{
@@ -41,27 +77,12 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_WERROR": "ON",
"KDDockWidgets_EXAMPLES" : "OFF"
"KDDockWidgets_EXAMPLES": "OFF",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick;dummy;flutter"
},
"environment": {
"CXX": "clazy",
"CCACHE_DISABLE" : "ON"
}
},
{
"name": "clazy-qtquick",
"displayName": "clazy-qtquick",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-clazy-qtquick",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_EXAMPLES" : "OFF",
"KDDockWidgets_WERROR": "ON",
"KDDockWidgets_QTQUICK": "ON"
},
"environment": {
"CXX": "clazy",
"CCACHE_DISABLE" : "ON"
"CCACHE_DISABLE": "ON"
}
},
{
@@ -70,7 +91,9 @@
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-release",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release"
"CMAKE_BUILD_TYPE": "Release",
"CMAKE_UNITY_BUILD": "OFF",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
}
},
{
@@ -80,31 +103,9 @@
"binaryDir": "${sourceDir}/build-release-no-x11extras",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_X11EXTRAS" : "OFF"
}
},
{
"name": "release-qtquick",
"displayName": "release-qtquick",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-release-qtquick",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_QTQUICK": "ON"
}
},
{
"name": "dev-qtquick",
"displayName": "dev-qtquick",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-dev-qtquick",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_QTQUICK": "ON",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"ECM_ENABLE_SANITIZERS" : "'address;undefined'",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_FUZZER" : "OFF"
"CMAKE_UNITY_BUILD": "OFF",
"KDDockWidgets_X11EXTRAS": "OFF",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
}
},
{
@@ -114,7 +115,9 @@
"binaryDir": "${sourceDir}/build-python",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_PYTHON_BINDINGS": "ON"
"KDDockWidgets_PYTHON_BINDINGS": "ON",
"CMAKE_UNITY_BUILD": "OFF",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
}
},
{
@@ -122,20 +125,10 @@
"displayName": "static",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-static",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_STATIC": "ON"
}
},
{
"name": "static-qtquick",
"displayName": "static-qtquick",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-static-qtquick",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_STATIC": "ON",
"KDDockWidgets_QTQUICK": "ON"
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
}
},
{
@@ -146,7 +139,9 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_QT6": "ON",
"CMAKE_PREFIX_PATH" : "$env{QT6_DIR}"
"CMAKE_UNITY_BUILD": "OFF",
"CMAKE_PREFIX_PATH": "$env{QT6_DIR}",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
},
"environment": {
"PATH": "$env{QT6_DIR}/bin:$penv{PATH}"
@@ -161,9 +156,10 @@
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_QT6": "ON",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_FUZZER" : "OFF",
"CMAKE_PREFIX_PATH" : "$env{QT6_DIR}"
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "OFF",
"CMAKE_PREFIX_PATH": "$env{QT6_DIR}",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick;dummy"
},
"environment": {
"PATH": "$env{QT6_DIR}/bin:$penv{PATH}"
@@ -178,50 +174,16 @@
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_QT6": "ON",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"ECM_ENABLE_SANITIZERS" : "'address;undefined'",
"KDDockWidgets_FUZZER" : "OFF",
"CMAKE_PREFIX_PATH" : "$env{QT6_DIR}"
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"ECM_ENABLE_SANITIZERS": "'address;undefined'",
"KDDockWidgets_FUZZER": "OFF",
"CMAKE_PREFIX_PATH": "$env{QT6_DIR}",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick;dummy"
},
"environment": {
"PATH": "$env{QT6_DIR}/bin:$penv{PATH}"
}
},
{
"name": "release-qtquick6",
"displayName": "release-qtquick6",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-release-qtquick6",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_QTQUICK": "ON",
"KDDockWidgets_QT6": "ON",
"CMAKE_PREFIX_PATH" : "$env{QT6_DIR}"
},
"environment": {
"PATH": "$env{QT6_DIR}/bin:$penv{PATH}"
}
},
{
"name": "dev-qtquick6",
"displayName": "dev-qtquick6",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-dev-qtquick6",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_QTQUICK": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"ECM_ENABLE_SANITIZERS" : "'address;undefined'",
"KDDockWidgets_QT6": "ON",
"CMAKE_PREFIX_PATH" : "$env{QT6_DIR}"
},
"environment": {
"PATH": "$env{QT6_DIR}/bin:$penv{PATH}",
"QML2_IMPORT_PATH" : "$env{QT6_DIR}/imports:$env{QT6_DIR}/qml",
"LD_LIBRARY_PATH" : "$env{QT6_DIR}/lib"
}
},
{
"name": "dev-clangcl",
"displayName": "dev-clangcl",
@@ -230,30 +192,12 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_FUZZER" : "ON"
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "ON",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
},
"warnings" : {
"uninitialized" : true
},
"environment": {
"CC": "clang-cl",
"CXX": "clang-cl"
}
},
{
"name": "dev-qtquick-clangcl",
"displayName": "dev-qtquick-clangcl",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-dev-qtquick-clangcl",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"KDDockWidgets_FUZZER" : "OFF",
"KDDockWidgets_QTQUICK": "ON"
},
"warnings" : {
"uninitialized" : true
"warnings": {
"uninitialized": true
},
"environment": {
"CC": "clang-cl",
@@ -268,12 +212,13 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"KDDockWidgets_FUZZER" : "ON",
"KDDockWidgets_FUZZER": "ON",
"KDDockWidgets_QT6": "ON",
"CMAKE_PREFIX_PATH" : "$env{QT6_DIR}"
"CMAKE_PREFIX_PATH": "$env{QT6_DIR}",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
},
"warnings" : {
"uninitialized" : true
"warnings": {
"uninitialized": true
},
"environment": {
"CC": "clang-cl",
@@ -281,30 +226,6 @@
"PATH": "$env{QT6_DIR}/bin:$penv{PATH}"
}
},
{
"name": "dev-qtquick-clangcl6",
"displayName": "dev-qtquick-clangcl6",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build-dev-qtquick-clangcl6",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"KDDockWidgets_FUZZER" : "OFF",
"KDDockWidgets_QTQUICK": "ON",
"KDDockWidgets_QT6": "ON",
"CMAKE_PREFIX_PATH" : "$env{QT6_DIR}"
},
"warnings" : {
"uninitialized" : true
},
"environment": {
"CC": "clang-cl",
"CXX": "clang-cl",
"PATH": "$env{QT6_DIR}/bin:$penv{PATH}",
"QML2_IMPORT_PATH" : "$env{QT6_DIR}/imports:$env{QT6_DIR}/qml",
"LD_LIBRARY_PATH" : "$env{QT6_DIR}/lib"
}
},
{
"name": "dev-time-trace",
"displayName": "dev-time-trace",
@@ -313,18 +234,19 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_FUZZER" : "OFF",
"CMAKE_C_FLAGS_INIT" : "-ftime-trace",
"CMAKE_CXX_FLAGS_INIT": "-ftime-trace"
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "OFF",
"CMAKE_C_FLAGS_INIT": "-ftime-trace",
"CMAKE_CXX_FLAGS_INIT": "-ftime-trace",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
},
"warnings" : {
"uninitialized" : true
"warnings": {
"uninitialized": true
},
"environment": {
"CC": "clang",
"CXX": "clang++",
"CCACHE_DISABLE" : "ON"
"CCACHE_DISABLE": "ON"
}
},
{
@@ -335,107 +257,138 @@
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
"KDDockWidgets_FUZZER" : "OFF",
"KDDockWidgets_QT6" : "ON",
"CMAKE_C_FLAGS_INIT" : "-ftime-trace",
"CMAKE_CXX_FLAGS_INIT": "-ftime-trace"
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
"KDDockWidgets_FUZZER": "OFF",
"KDDockWidgets_QT6": "ON",
"CMAKE_C_FLAGS_INIT": "-ftime-trace",
"CMAKE_CXX_FLAGS_INIT": "-ftime-trace",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
},
"warnings" : {
"uninitialized" : true
"warnings": {
"uninitialized": true
},
"environment": {
"CC": "clang",
"CXX": "clang++",
"CCACHE_DISABLE" : "ON"
"CCACHE_DISABLE": "ON"
}
},
{
"name": "ci-dev-qtwidgets-qt5",
"displayName": "ci-dev-qtwidgets-qt5",
"description": "Qt5 QtWidgets dev-mode build",
"binaryDir": "${sourceDir}/build-ci-dev-qtwidgets-qt5",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_BUILD_TYPE": "Debug"
}
},
{
"name": "ci-dev-qtquick-qt5",
"displayName": "ci-dev-qtquick-qt5",
"description": "Qt5 QtQuick dev-mode build",
"binaryDir": "${sourceDir}/build-ci-dev-qtquick-qt5",
"name": "ci-dev-qt5",
"displayName": "ci-dev-qt5",
"description": "Qt5 dev-mode build",
"binaryDir": "${sourceDir}/build-ci-dev-qt5",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_QTQUICK": "ON"
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
}
},
{
"name": "ci-release-qt5",
"displayName": "ci-release-qt5",
"description": "Qt5 non dev-mode build",
"binaryDir": "${sourceDir}/build-ci-release-qt5",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
}
},
{
"name": "ci-qtwidgets-qt5",
"displayName": "ci-qtwidgets-qt5",
"description": "Qt5 QtWidgets release build",
"description": "Qt5 build which excludes QtQuick",
"binaryDir": "${sourceDir}/build-ci-qtwidgets-qt5",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release"
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_FRONTENDS": "qtwidgets"
}
},
{
"name": "ci-qtquick-qt5",
"displayName": "ci-qtquick-qt5",
"description": "Qt5 QtQuick release build",
"description": "Qt5 build which excludes QtWidgets",
"binaryDir": "${sourceDir}/build-ci-qtquick-qt5",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_QTQUICK": "ON"
"KDDockWidgets_FRONTENDS": "qtquick"
}
},
{
"name": "ci-dev-qtwidgets-qt6",
"displayName": "ci-dev-qtwidgets-qt6",
"description": "Qt6 dev-mode",
"binaryDir": "${sourceDir}/build-ci-dev-qtwidgets-qt6",
"name": "ci-dummy",
"displayName": "ci-dummy",
"description": "Builds only the dummy frontend. Tests that build passes without Qt.",
"binaryDir": "${sourceDir}/build-ci-dummy",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_FRONTENDS": "dummy",
"KDDockWidgets_QT6": "ON"
}
},
{
"name": "ci-dev-qtquick-qt6",
"displayName": "ci-dev-qtquick-qt6",
"name": "ci-flutter",
"displayName": "ci-flutter",
"description": "Builds only the flutter frontend. Tests that build passes without Qt.",
"binaryDir": "${sourceDir}/build-ci-flutter",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_FRONTENDS": "flutter",
"KDDockWidgets_QT6": "ON"
}
},
{
"name": "ci-dev-qt6",
"displayName": "ci-dev-qt6",
"description": "Qt6 dev-mode",
"binaryDir": "${sourceDir}/build-ci-dev-qtquick-qt6",
"binaryDir": "${sourceDir}/build-ci-dev-qt6",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "ON",
"CMAKE_BUILD_TYPE": "Debug",
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick",
"KDDockWidgets_QT6": "ON"
}
},
{
"name": "ci-release-qt6",
"description": "Qt6 non dev-mode",
"displayName": "ci-release-qt6",
"binaryDir": "${sourceDir}/build-ci-release-qt6",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_QT6": "ON",
"KDDockWidgets_QTQUICK": "ON"
"KDDockWidgets_FRONTENDS": "qtwidgets;qtquick"
}
},
{
"name": "ci-qtwidgets-qt6",
"description": "Qt6 QtWidgets release build",
"description": "Qt6 build which excludes QtQuick",
"displayName": "ci-qtwidgets-qt6",
"binaryDir": "${sourceDir}/build-ci-qtwidgets-qt6",
"generator": "Ninja",
"cacheVariables": {
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_QT6": "ON"
"KDDockWidgets_QT6": "ON",
"KDDockWidgets_FRONTENDS": "qtwidgets"
}
},
{
"name": "ci-qtquick-qt6",
"description": "Qt6 QtQuick release build",
"description": "Qt6 build which excludes QtWidgets",
"displayName": "ci-qtquick-qt6",
"binaryDir": "${sourceDir}/build-ci-qtquick-qt6",
"generator": "Ninja",
@@ -443,23 +396,8 @@
"KDDockWidgets_DEVELOPER_MODE": "OFF",
"CMAKE_BUILD_TYPE": "Release",
"KDDockWidgets_QT6": "ON",
"KDDockWidgets_QTQUICK": "ON"
"KDDockWidgets_FRONTENDS": "qtquick"
}
},
{
"name": "ci-static",
"inherits":["static"],
"binaryDir": "${sourceDir}/build-ci-static"
},
{
"name": "ci-static-qtquick",
"inherits":["static-qtquick"],
"binaryDir": "${sourceDir}/build-ci-static-qtquick"
},
{
"name": "ci-python",
"inherits":["python"],
"binaryDir": "${sourceDir}/build-python"
}
],
"buildPresets": [
@@ -467,16 +405,8 @@
"name": "clazy",
"configurePreset": "clazy",
"environment": {
"CLAZY_CHECKS" : "level2,detaching-member,heap-allocated-small-trivial-type,isempty-vs-count,qstring-varargs,qvariant-template-instantiation,raw-environment-function,reserve-candidates,signal-with-return-value,thread-with-slots,no-ctor-missing-parent-argument,no-missing-typeinfo",
"CCACHE_DISABLE" : "ON"
}
},
{
"name": "clazy-qtquick",
"configurePreset": "clazy-qtquick",
"environment": {
"CLAZY_CHECKS" : "level2,detaching-member,heap-allocated-small-trivial-type,isempty-vs-count,qstring-varargs,qvariant-template-instantiation,raw-environment-function,reserve-candidates,signal-with-return-value,thread-with-slots,no-ctor-missing-parent-argument,no-missing-typeinfo",
"CCACHE_DISABLE" : "ON"
"CLAZY_CHECKS": "level2,detaching-member,heap-allocated-small-trivial-type,isempty-vs-count,qstring-varargs,qvariant-template-instantiation,raw-environment-function,reserve-candidates,signal-with-return-value,thread-with-slots,no-ctor-missing-parent-argument,no-missing-typeinfo",
"CCACHE_DISABLE": "ON"
}
}
]

View File

@@ -1,3 +1,14 @@
* v2.0.0 (unreleased)
- Architecture rewrite to support more frontends besides QtWidgets and QtQuick.
2.0 isn't very interesting for users, but will allow developers to make KDDW
support other GUI frameworks more easily. Also QtQuick is now better integrated,
without being shoehorned with ifdefs into the QtWidgets implementation.
- Split into a view/controller architecture
- Non-gui logic moved to controllers
- Each controller has a gui counter part, implemented for each supported frontend
- Uses nlohmann JSON library (MIT) instead of QJsonDocument, for saving/restoring layouts
- Added Config::setStartDragDistance()
* v1.7.0 (unreleased)
- Introduce DockWidget::setFloatingWindowFlags(flags). Allows for different
FloatingWindows to have different window flags. For example, some having
@@ -43,7 +54,7 @@
- FloatingWindow now honours the dockwidget's max-size, if there's a single
dock widget docked. Tabbed cases are more difficult since QStackedLayout doesn't
propagate size constraints.
- Added MainWindowBase::frameCountChanged()
- Added MainWindowBase::groupCountChanged()
- Introduced Config::setDropIndicatorsInhibited(), which allows you to disable support
for drop indicators while dragging.
- Fixed embedding the main window into a non-kddw main window (#204, #168)

View File

@@ -2,7 +2,7 @@ GNU GENERAL PUBLIC LICENSE
Version 2, June 1991
Copyright (C) 1989, 1991 Free Software Foundation, Inc.
Copyright (C) 1989, 1991 Free Software Foundation, Inc.
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA

9
LICENSES/MIT.txt Normal file
View File

@@ -0,0 +1,9 @@
MIT License
Copyright (c) <year> <copyright holders>
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

View File

@@ -2,28 +2,6 @@
These are the instructions for building the Python bindings for KDDockWidgets.
Currently unsupported:
- debug builds
- builds against Qt debug libraries
- static builds
- python2 bindings
- only some 32-bit platforms are supported. see <https://wiki.qt.io/Qt_for_Python>
Also, there are no plans to support the qmake buildsystem.
## Prerequisites
You will need:
- a compiler with C++14 support (C++17 for Qt6 builds)
- Python3.7 or higher
- Qt5 version 5.12 or higher
- Qt6 version 6.2 or higher
- QtForPython provided by the Qt project.
## Install PySide2 for Qt5
Make sure you have PySide2, shiboken2 and shiboken2-generator installed.
As this time, you cannot get shiboken2-generator because the wheels are not on PyPi.
To use the wheels do this:
@@ -35,49 +13,37 @@ To use the wheels do this:
shiboken2 pyside2 shiboken2_generator
```
For more info visit <https://doc.qt.io/qtforpython/shiboken2/gettingstarted.html>
afterwards run:
```bash
pip3 list | grep PySide
```
For more info visit <https://doc.qt.io/qtforpython/shiboken2/gettingstarted.html>.
afterwards run 'pip3 list | grep PySide2'
Note the version *must* match the same Qt you intend to use when building KDDockWidgets.
## Install PySide6 for Qt6
Not supported:
Follow the same instructions as [the previous section](#Install PySide2 for Qt5),
except installing `shiboken6 pyside6 shiboken6_generator` with pip3.
- debug builds
- static builds
- python2 bindings
- only some 32-bit platforms are supported (see <https://wiki.qt.io/Qt_for_Python>)
## Building KDDockWidgets Python Bindings
Tell CMake to build the bindings by passing the `-DKDDockWidgets_PYTHON_BINDINGS=True' option,
followed by the make command.
Tell CMake to build the bindings by passing the `-DKDDockWidgets_PYTHON_BINDINGS=True' option.
Then run `cmake --build` as usual.
The bindings will be installed to `CMAKE_INSTALL_PREFIX`, which might require setting
the `PYTHONPATH` env variable to point to that path when running applications.
For example, if you install to the default location on linux you would:
```bash
export PYTHONPATH=/usr/local/KDAB/KDDockWidgets-1.7.0/lib64/python3.10/site-packages
```
Alternatively, configure the bindings install location by passing (for example)
`-DKDDockWidgets_PYTHON_BINDINGS_INSTALL_PREFIX=/usr/lib/python3.8/site-packages` to CMake
and adjust to the PYTHONPATH accordingly, as necessary.
The bindings will be installed to the passed `-DCMAKE_INSTALL_PREFIX`, which
might require setting the `PYTHONPATH` env variable to point to that path when
running applications. Alternatively, configure the bindings install location
by passing `-DKDDockWidgets_PYTHON_BINDINGS_INSTALL_PREFIX=/usr/lib/python3.8/site-packages`
to CMake (adjust to the python path on your system).
To run the KDDW python example
```bash
export PYTHONPATH=/usr/local/KDAB/KDDockWidgets-1.7.0/lib64/python3.10/site-packages # adapt as needed
export PYTHONPATH=/kddw/install/path # Only if needed
cd python/examples/
rcc -g python -o rc_assets.py ../../examples/dockwidgets/resources_example.qrc
python3 main.py
```
### Build Issues
Build Issues
- If you see errors like "Unable to locate Clang's built-in include directory"
then first mROUBLESHOOTINGake sure you have llvm installed. If you still have problems try

View File

@@ -2,8 +2,9 @@
[![Build Status](https://travis-ci.com/KDAB/KDDockWidgets.svg?branch=master)](https://travis-ci.com/KDAB/KDDockWidgets)
> ⚠️⚠️: If you're using QtQuick/QML it's recommended to use 2.0 branch. 1.x will continue
> to receive bug fixes for a long time but only for QtWidgets frontend.
> ⚠️⚠️: 2.0 is under development, there might be API breaks before release.
> Stick with version 1.6 if you're using QtWidgets. However, if you're using
> QtQuick it's better to base on 2.0, as 1.6 won't be receiving much QtQuick development.
`KDDockWidgets` is a Qt dock widget library written by KDAB, suitable for replacing
`QDockWidget` and implementing advanced functionalities missing in Qt.
@@ -79,7 +80,7 @@ To build KDDockWidgets you'll need:
- CMake
- Qt 5.15.x or Qt6 >= 6.2
- Ninja (Other generators might work but are untested)
- C++17 capable compiler
- C++17 capable compiler. Minimum VS2019 on Windows.
- Qt Widgets module
- Qt X11Extras module if on Linux/X11
- Qt Quick and QuickControls2 modules if using the QtQuick support
@@ -100,6 +101,15 @@ Adapt the instructions to suit your cmake generator and operating system.
cmake --build . --target install
```
Now build and run the example:
```bash
cd path/to/kddockwidgets/examples/dockwidgets/
cmake -G Ninja -DCMAKE_PREFIX_PATH=/path/where/to/install
cmake --build .
./bin/examples/qtwidgets_dockwidgets
```
The installation directory defaults to `c:\KDAB\KDDockWidgets-<version>` on Windows
and `/usr/local/KDAB/KDDockWidgets-<version>` on non-Windows.
@@ -147,18 +157,16 @@ Please refer to [README-bindings.md](README-bindings.md).
## Versioning
There's currently two lines of development: `v1` which is very mature and stable and `v2` which is an
ongoing effort to make KDDW support multiple "frontends" (QtWidgets, QtQuick and even non-Qt technologies,
like flutter).
There's currently two lines of development: `v1` which is very mature and stable and `v2` which is an ongoing effort to make
KDDW support multiple "frontends" (QtWidgets, QtQuick and even non-Qt technologies, like flutter).
1.x will be supported for many years to come, at least for bug fixes and small features.
Use `v1.6.0` tag for the latest stable.
Use `v1.6.0` tag for the latest stable.<br>
Use `2.0` if you need non-QtWidgets support, for example `QtQuick/QML`. While `1.6` has support for `QtQuick/QML`
it won't be receiving bug fixes. `2.0` is under active development, you might encounter minor source/ABI
incompatibilities. Despite that, it is pretty stable, and all 200 unit-tests pass.
Use `2.0` if you need non-QtWidgets support, for example `QtQuick/QML`. While `1.6` has support for `QtQuick/QML` it won't be receiving bug fixes. `2.0` is under active development, you might encounter minor source/ABI incompatibilities. Despite that,
it is pretty stable, and all 200 unit-tests pass.
We'll try to remain source-compatible across versions (except for the v1 -> v2 jump).
We'll try to remain source-compatible across versions (except for the v1 -> v2 jump).<br>
API will get a deprecation notice before being removed in the next version. Note that this
compatibility effort is only for the public API. Private API (headers ending
in _p.h) might change so you shouldn't depend on them. Private API is only
@@ -171,8 +179,8 @@ your application whenever updating KDDW.
## Styling
Almost all private widgets used by KDDW can be derived by the user to give them
a custom look. That's done by providing your own FrameworkWidgetFactory. Run
"kddockwidgets_example -p" to see that in action.
a custom look. That's done by providing your own ViewFactory. Run
"examples/qtwidgets_dockwidgets -p" to see that in action.
Qt StyleSheets are not, and will not, be supported. See the comments in
`examples/dockwidgets/MyTitleBar_CSS.h` for why. You can however use some minimal

0
a Normal file
View File

View File

@@ -52,8 +52,9 @@ install:
before_build:
- cmd: call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvars64.bat"
- cmd: set PATH=C:\Qt\6.2\msvc2019_64\bin;C:\Qt\5.15\msvc2019_64\bin;%PATH%
- sh: if [ "`uname -s`" = "Darwin" ]; then export PATH=$HOME/Qt/6.2/macos/bin:$HOME/Qt/5.15/clang_64/bin:$PATH; else export PATH=$HOME/Qt/6.2/gcc_64/bin:$HOME/Qt/5.15/gcc_64/bin:$PATH; fi
- cmd: set PATH=C:\Qt\6.3\msvc2019_64\bin;C:\Qt\5.15\msvc2019_64\bin;%PATH%
- sh: export QT_QUICK_BACKEND=software
- sh: if [ "`uname -s`" = "Darwin" ]; then export PATH=$HOME/Qt/6.3/macos/bin:$HOME/Qt/5.15/clang_64/bin:$PATH; else export PATH=$HOME/Qt/6.3/gcc_64/bin:$HOME/Qt/5.15/gcc_64/bin:$PATH; fi
build_script:
- mkdir build
@@ -64,7 +65,7 @@ build_script:
- cmd: cmake --build . --target install
- sh: sudo cmake --build . --target install
- cmd: set PATH=.\bin;%PATH%
- ctest --test-dir .
- ctest --test-dir . -V
# to disable automatic builds
#build: off

View File

@@ -30,7 +30,7 @@ if(NOT INSTALL_DATADIR)
set(INSTALL_DATADIR ${CMAKE_INSTALL_DATADIR})
endif()
if(NOT INSTALL_DOC_DIR)
set(INSTALL_DOC_DIR ${CMAKE_INSTALL_DOCDIR}${${PROJECT_NAME}_LIBRARY_QTID})
set(INSTALL_DOC_DIR ${CMAKE_INSTALL_DOCDIR}${KDDockWidgets_LIBRARY_QTID})
endif()
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)

View File

@@ -1,148 +0,0 @@
{
"folders": [
{
"path": "."
}
],
"settings": {
"C_Cpp.default.compileCommands": "${workspaceFolder}/build-dev-qtquick/compile_commands.json",
"C_Cpp.default.cStandard": "c17",
"files.trimTrailingWhitespace": true,
"editor.formatOnType": true,
"C_Cpp.autocompleteAddParentheses": true,
"cmake.copyCompileCommands": "${workspaceFolder}/compile_commands.json"
},
"launch": {
"version": "0.2.0",
"configurations": [
{
"name": "gdb-kddockwidgets_customtitlebar_quick",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_customtitlebar_quick",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "gdb-kddockwidgets_example_mdi_quick",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_example_mdi_quick",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "gdb-kddockwidgets_example_quick",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_example_quick",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "gdb-tst_docks",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-kddockwidgets_customtitlebar_quick",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_customtitlebar_quick",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-kddockwidgets_example_mdi_quick",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_example_mdi_quick",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-kddockwidgets_example_quick",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_example_quick",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-tst_docks",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_customtitlebar_quick",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_customtitlebar_quick",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_example_mdi_quick",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_example_mdi_quick",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_example_quick",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/kddockwidgets_example_quick",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-tst_docks",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev-qtquick/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
}
]
}
}

View File

@@ -1,100 +0,0 @@
{
"folders": [
{
"path": "."
}
],
"settings": {
"C_Cpp.default.compileCommands": "${workspaceFolder}/build-dev/compile_commands.json",
"C_Cpp.default.cStandard": "c17",
"files.trimTrailingWhitespace": true,
"editor.formatOnType": true,
"C_Cpp.autocompleteAddParentheses": true,
"cmake.copyCompileCommands": "${workspaceFolder}/compile_commands.json"
},
"launch": {
"version": "0.2.0",
"configurations": [
{
"name": "kddockwidgets_example",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/kddockwidgets_example",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "kddockwidgets_minimal_example",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/kddockwidgets_minimal_example",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "kddockwidgets_minimal_mdi_example",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/kddockwidgets_minimal_mdi_example",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "kddockwidgets_mdi_with_docking_example",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/kddockwidgets_mdi_with_docking_example",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "tst_docks",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "msvc-kddockwidgets_example",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/kddockwidgets_example",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_minimal_example",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/kddockwidgets_minimal_example",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_minimal_mdi_example",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/kddockwidgets_minimal_mdi_example",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-tst_docks",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
}
]
}
}

View File

@@ -1,148 +0,0 @@
{
"folders": [
{
"path": "."
}
],
"settings": {
"C_Cpp.default.compileCommands": "${workspaceFolder}/build-dev6/compile_commands.json",
"C_Cpp.default.cStandard": "c17",
"files.trimTrailingWhitespace": true,
"editor.formatOnType": true,
"C_Cpp.autocompleteAddParentheses": true,
"cmake.copyCompileCommands": "${workspaceFolder}/compile_commands.json"
},
"launch": {
"version": "0.2.0",
"configurations": [
{
"name": "gdb-kddockwidgets_example",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_example",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "gdb-kddockwidgets_minimal_example",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_minimal_example",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "gdb-kddockwidgets_minimal_mdi_example",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_minimal_mdi_example",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "gdb-tst_docks",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "gdb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-kddockwidgets_example",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_example",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-kddockwidgets_minimal_example",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_minimal_example",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-kddockwidgets_minimal_mdi_example",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_minimal_mdi_example",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "lldb-tst_docks",
"type": "cppdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"MIMode": "lldb",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_example",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_example",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_minimal_example",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_minimal_example",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-kddockwidgets_minimal_mdi_example",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/kddockwidgets_minimal_mdi_example",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-tst_docks",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
}
]
}
}

176
code.dev.code-workspace Normal file
View File

@@ -0,0 +1,176 @@
{
"folders": [
{
"name": "kddockwidgets",
"path": "."
},
{
"path": "/data/sources/kddockwidgets-flutter-example"
}
],
"settings": {
"C_Cpp.default.compileCommands": "${workspaceFolder:kddockwidgets}/build-dev/compile_commands.json",
"C_Cpp.default.cStandard": "c17",
"files.trimTrailingWhitespace": true,
"editor.formatOnSave": true,
"C_Cpp.autocompleteAddParentheses": true,
"clangd.arguments": [
"-header-insertion=never"
],
"todo-tree.tree.scanMode": "workspace only",
"todo-tree.tree.disableCompactFolders": false,
"todo-tree.tree.showBadges": true,
"todo-tree.general.tags": [
"BUG",
"HACK",
"FIXME",
"TODO",
"XXX",
"[ ]",
"[x]",
"TODOm2",
"TODOm3",
"TODOm4"
],
"testMate.cpp.test.executables": "{build-dev}/**/*{tst}*",
"todo-tree.filtering.excludeGlobs": [
"**/ECM",
"**/3rdparty"
],
"cmake.copyCompileCommands": "${workspaceFolder:kddockwidgets}/compile_commands.json"
},
"launch": {
"version": "0.2.0",
"configurations": [
{
"name": "qtwidgets_dockwidgets",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/examples/qtwidgets_dockwidgets",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "qtwidgets_minimal",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/examples/qtwidgets_minimal",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "qtwidgets_mdi",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/examples/qtwidgets_mdi",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "qtwidgets_mdi_with_docking",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/examples/qtwidgets_mdi_with_docking",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "qtquick_dockwidgets",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/examples/qtquick_dockwidgets",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "qtquick_customtitlebar",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/examples/qtquick_customtitlebar",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_docks",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_droparea",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_droparea",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_dockwidget",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_dockwidget",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_group",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_group",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_separator",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_separator",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_stack",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_stack",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_tabbar",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_tabbar",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_floatingwindow",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_floatingwindow",
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_qtwidgets",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_qtwidgets",
"args": [
"tst_mainWindowAlwaysHasCentralWidget"
],
"cwd": "${workspaceFolder:kddockwidgets}"
},
{
"name": "tst_qtquick",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder:kddockwidgets}/build-dev/bin/tst_qtquick",
"args": [],
"cwd": "${workspaceFolder:kddockwidgets}"
}
]
}
}

142
code.dev6.code-workspace Normal file
View File

@@ -0,0 +1,142 @@
{
"folders": [
{
"path": "."
}
],
"settings": {
"C_Cpp.default.compileCommands": "${workspaceFolder}/build-dev6/compile_commands.json",
"C_Cpp.default.cStandard": "c17",
"files.trimTrailingWhitespace": true,
"editor.formatOnSave": true,
"C_Cpp.autocompleteAddParentheses": true,
"clangd.arguments": [
"-header-insertion=never"
],
"todo-tree.tree.scanMode": "workspace only",
"todo-tree.tree.disableCompactFolders": false,
"todo-tree.tree.showBadges": true,
"todo-tree.filtering.excludeGlobs": [
"**/ECM",
"**/3rdparty"
],
"todo-tree.general.tags": [
"BUG",
"HACK",
"FIXME",
"TODO",
"XXX",
"[ ]",
"[x]",
"TODOm2",
"TODOm3",
"TODOm4"
],
"testMate.cpp.test.executables": "{build-dev6}/**/*{tst}*"
},
"launch": {
"version": "0.2.0",
"configurations": [
{
"name": "qtwidgets_dockwidgets",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtwidgets_dockwidgets",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "qtwidgets_minimal",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtwidgets_minimal",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "qtwidgets_mdi",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtwidgets_mdi",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "qtwidgets_mdi_with_docking",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtwidgets_mdi_with_docking",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "qtquick_dockwidgets",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtquick_dockwidgets",
"args": [],
"cwd": "${workspaceFolder}"
},
{
"name": "tst_docks",
"type": "lldb",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/tst_docks",
"args": [
"tst_addMDIDockWidget"
],
"cwd": "${workspaceFolder}"
},
{
"name": "msvc-qtwidgets_dockwidgets",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtwidgets_dockwidgets",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-qtwidgets_minimal",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtwidgets_minimal",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-qtwidgets_mdi",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtwidgets_mdi",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-qtquick_dockwidgets",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/examples/qtquick_dockwidgets.exe",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
},
{
"name": "msvc-tst_docks",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build-dev6/bin/tst_docks",
"args": [],
"cwd": "${workspaceFolder}",
"stopAtEntry": false,
"externalConsole": false
}
]
}
}

View File

@@ -12,7 +12,7 @@ from conans import ConanFile, CMake, tools
class KDDockWidgetsConan(ConanFile):
name = "kddockwidgets"
version = "1.6.95"
version = "1.5.0"
default_user = "kdab"
default_channel = "stable"
license = ("https://raw.githubusercontent.com/KDAB/KDDockWidgets/master/LICENSES/GPL-2.0-only.txt",

View File

@@ -1,9 +1,3 @@
kddockwidgets (1.6.0) release candidate; urgency=high
* 1.6.0 final
-- Allen Winter <allen.winter@kdab.com> Wed, 14 Sep 2022 11:40:00 -0500
kddockwidgets (1.5.0) release candidate; urgency=high
* 1.5.0 final

View File

@@ -1,4 +1,3 @@
#!/usr/bin/make -f
DEB_CMAKE_EXTRA_FLAGS = -DCMAKE_BUILD_TYPE=Release
include /usr/share/cdbs/1/rules/debhelper.mk
include /usr/share/cdbs/1/class/cmake.mk

View File

@@ -1,10 +1,10 @@
Format: 1.0
Source: kddockwidgets
Version: 1.6.0-1
Version: 1.5.0-1
Binary: kddockwidgets
Maintainer: Allen Winter <allen.winter@kdab.com>
Architecture: any
Build-Depends: debhelper (>=9), cdbs, cmake, qtbase5-dev, qtbase5-private-dev, libqt5x11extras5-dev, libfontconfig-dev, libfreetype-dev
Files:
00000000000000000000000000000000 00000 qt5-kddockwidgets-1.6.0.tar.gz
00000000000000000000000000000000 00000 qt5-kddockwidgets-1.5.0.tar.gz

View File

@@ -1,5 +1,5 @@
Name: qt5-kddockwidgets
Version: 1.6.0
Version: 1.5.0
Release: 1
Summary: KDAB's Dock Widget Framework for Qt5
Source0: %{name}-%{version}.tar.gz
@@ -98,8 +98,6 @@ cmake . -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release
%{_libdir}/libkddockwidgets.so
%changelog
* Wed Sep 14 2022 Allen Winter <allen.winter@kdab.com> 1.6.0
1.6.0 final
* Mon Nov 24 2021 Allen Winter <allen.winter@kdab.com> 1.5.0
1.5.0 final
* Fri Jul 16 2021 Allen Winter <allen.winter@kdab.com> 1.4.0

View File

@@ -1,10 +1,10 @@
Format: 1.0
Source: kddockwidgets
Version: 1.6.0-1
Version: 1.5.0-1
Binary: kddockwidgets
Maintainer: Allen Winter <allen.winter@kdab.com>
Architecture: any
Build-Depends: debhelper (>=9), cdbs, cmake, qt6-base-dev, qt6-base-private-dev, libgl1-mesa-dev, libfontconfig-dev, libfreetype-dev
Files:
00000000000000000000000000000000 00000 qt6-kddockwidgets-1.6.0.tar.gz
00000000000000000000000000000000 00000 qt6-kddockwidgets-1.5.0.tar.gz

View File

@@ -1,5 +1,5 @@
Name: qt6-kddockwidgets
Version: 1.6.0
Version: 1.5.0
Release: 1
Summary: KDAB's Dock Widget Framework for Qt6
Source0: %{name}-%{version}.tar.gz
@@ -18,7 +18,7 @@ BuildRequires: libqt6-qtbase-devel libqt6-qtbase-private-headers-devel libqt6-q
%endif
%if %{defined fedora}
BuildRequires: gcc-c++ qt6-qtbase-devel qt6-qtbase-private-devel desktop-file-utils libxkbcommon-devel util-linux
BuildRequires: gcc-c++ qt6-qtbase-devel qt6-qtbase-private-devel desktop-file-utils libxkbcommon-devel
%endif
%if %{defined rhel}
@@ -79,21 +79,14 @@ cmake . -DCMAKE_INSTALL_PREFIX=/usr -DKDDockWidgets_QT6=True -DCMAKE_BUILD_TYPE=
%files devel
%defattr(-,root,root,-)
%if 0%{?fedora} > 35
%{_libdir}/qt6/mkspecs/modules/*
%endif
#%dir %{_prefix}/share/mkspecs
#%dir %{_prefix}/share/mkspecs/features
#%{_prefix}/share/mkspecs/features/kddockwidgets.prf
%dir %{_includedir}/kddockwidgets-qt6
%{_includedir}/kddockwidgets-qt6/kddockwidgets/*
%dir %{_libdir}/cmake/KDDockWidgets-qt6
%{_libdir}/cmake/KDDockWidgets-qt6/*
%{_libdir}/libkddockwidgets-qt6.so
#%{_prefix}/mkspecs/modules/* ECMGeneratePriFile isn't ported to Qt6 yet
%changelog
* Wed Sep 14 2022 Allen Winter <allen.winter@kdab.com> 1.6.0
1.6.0 final
* Mon Nov 24 2021 Allen Winter <allen.winter@kdab.com> 1.5.0
1.5.0 final
* Fri Jul 16 2021 Allen Winter <allen.winter@kdab.com> 1.4.0

View File

@@ -14,7 +14,7 @@
# $ docker build -t kddw-pyside2 .
# $ docker run -it -v ~/Qt/5.15.2/gcc_64/:/Qt/ -v /tmp/.X11-unix:/tmp/.X11-unix kddw-pyside2
# git checkout 1.6
# git checkout 2.0
# cmake --preset=python -G Ninja . && cd build-python/ && ninja
# Test with:

View File

@@ -40,16 +40,17 @@ endif()
file(GLOB _dox_deps *.dox *.html)
set(DOXYGEN_OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR})
#apidox generation using doxygen
# apidox generation using doxygen
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/Doxyfile.cmake ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile)
add_custom_command(
OUTPUT ${DOXYGEN_OUTPUT_DIR}/qch/kddockwidgets-api.qch
COMMAND ${DOXYGEN_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile
#handle a bug in doxygen where image files referred to in markdown are not copied the output
# handle a bug in doxygen where image files referred to in markdown are not
# copied the output
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_CURRENT_SOURCE_DIR}/../../screencap.gif
${DOXYGEN_OUTPUT_DIR}/html
#copy some files by-hand that are referred to by the markdown README
# copy some files by-hand that are referred to by the markdown README
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_SOURCE_DIR}/README-bindings.md ${DOXYGEN_OUTPUT_DIR}/html
COMMAND ${CMAKE_COMMAND} -E make_directory ${DOXYGEN_OUTPUT_DIR}/html/LICENSES
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_SOURCE_DIR}/LICENSES/GPL-2.0-only.txt
@@ -67,7 +68,7 @@ add_custom_command(
add_custom_target(
kddockwidgets-api.qch ALL
DEPENDS ${DOXYGEN_OUTPUT_DIR}/qch/kddockwidgets-api.qch
COMMENT "Target generate the .qch file"
COMMENT "Target to generate the .qch file"
)
add_custom_target(
docs
@@ -79,11 +80,5 @@ set(QCH_INSTALL_DIR
${INSTALL_DOC_DIR}
CACHE STRING "Install location of Qt Assistant help files."
)
install(
FILES ${DOXYGEN_OUTPUT_DIR}/qch/kddockwidgets-api.qch
DESTINATION ${QCH_INSTALL_DIR}
)
install(
FILES ${DOXYGEN_OUTPUT_DIR}/kddockwidgets.tags
DESTINATION ${INSTALL_DOC_DIR}
)
install(FILES ${DOXYGEN_OUTPUT_DIR}/qch/kddockwidgets-api.qch DESTINATION ${QCH_INSTALL_DIR})
install(FILES ${DOXYGEN_OUTPUT_DIR}/kddockwidgets.tags DESTINATION ${INSTALL_DOC_DIR})

View File

@@ -845,7 +845,6 @@ WARN_LOGFILE = doxygen.log
# Note: If this tag is empty the current directory is searched.
INPUT = "@CMAKE_SOURCE_DIR@/README.md" \
"@CMAKE_SOURCE_DIR@/README-bindings.md" \
"@CMAKE_SOURCE_DIR@/src"
# This tag can be used to specify the character encoding of the source files

1
docs_devel/about.md Normal file
View File

@@ -0,0 +1 @@
# About

82
docs_devel/concepts.md Normal file
View File

@@ -0,0 +1,82 @@
# Concepts
Before digging into code we need to learn some high level concepts which will make it easy
to learn the API afterwards.
## Views or Widgets
A view, or widget is the most basic GUI element usually provided by your framework.
KDDockWidget's has its roots in the Qt QWidget GUI framework, hence the term widget
will appear in many places. However, since KDDW's goal is to support other GUI toolkits,
we've introduced a more generic term, view.
For the QtWidget frontend, a view will be internally implemented as a QWidget, while for
the QtQuick frontend it will be implemented as a QQuickItem.
## Guest View
This is the view that the user (library user) wants to dock. It has some custom content that
is only relevant for the application. From KDDW's perspective we don't care what's inside,
we'll just help dock it.
## DockWidget
The DockWidget is a visual container for the Guest, in other words, its visual parent.
Visually, DockWidget and Guest might be indistinguishable, except for some margin added by
DockWidget. One reason to have this extra indirection is that it allows us to have a common API
to deal with the Guest. Since guest is provided by the application developer it doesn't have any interface.
## TitleBar
A TitleBar is the area that has the dock widget title and the float and close buttons.
Usually KDDW won't use native OS title bars but draw its own.
## TabBar
DockWidgets can be grouped together in tabs. A tab bar is just a group of tabs.
In Qt this is something like QTabBar.
## Stack
A stack is closely related to TabBar. A stack is a group of dock widgets where only one is visible
at a time, the visible one is controlled by the current tab. In Qt this would be QTabWidget.
## Frame
The Frame is a container that ties the previous concepts all together.
It's composed of 1 or more tabbed DockWidgets, a TitleBar, a Stack and a TabBar.
## Layout
Represents a docking layout. Currently 2 are supported, the traditional nested docking with
resizable splitters (this is the default), implemented by MultiSplitter. And a MDI layout, where
the dock widgets can be arbitrary positioned and even overlap inside an area.
The layouts deal in Frame. You add Frame objects to a layout.
## Separator
A visual separator between two widgets, which allows the user to resize dock widgets with mouse.
## FloatingWindow
When a dock widget isn't embedded into a window it's said to be floating. It's its own
top-level native window. This class ties all the previous together. It contains one layout, which
contains multiple groups.
## MainWindow
Not much different from FloatingWindow technically, but users will often add status bar, tool bar
and menu bars to a main window, while FloatingWindow is just an utility window (Qt::Tool).
MainWindow also has support for a SideBar.
## SideBar
A side bar is a place in the MainWindow where you can "minimize" dock widgets.
It's also called the auto-hide future. When you send a dock widget to the sidebar it will close
but show a button in the sidebar, if you press it, it will show the dock widget as an overlay.
## Drop Indicators
When dragging a dock widgets, KDDW will highlight the places where you can drop it, so
it embeds in the correct position.

1
docs_devel/index.md Normal file
View File

@@ -0,0 +1 @@
# Welcome to KDDockWidgets

View File

@@ -0,0 +1,11 @@
# Creating a new frontend
- Copy `src/dummy/` into `src/yourfrontend/`
- Rename the files from `_dummy` to `_yourfrontend`
- Edit `CMakeLists.txt` and `src/CMakeLists.txt`
- Edit the `FrontendType` enum in `KDDockWidgets.h` and add a new enumerator for your frontend
- Edit `Platform::frontendTypes()` in `Platform.cpp` and honour your new enumerator, properly ifdefed
- In `Platform.cpp` add the needed `#include "yourplatform/Platform_yourplatform.h` include
- Edit `Platform::tests_initPlatform()` and add your enumerator
- Edit `Platform_yourfrontend::name()` to return an ID for your frontend
- Run `./bin/tst_platform -tc="Platform::Platform,Platform::name"` , make sure it passes

View File

@@ -10,30 +10,20 @@
#
cmake_minimum_required(VERSION 3.7)
project(kddockwidgets_example)
project(qtwidgets_dockwidgets)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before
# if you want to look for a specific Qt version for instance.
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/resources_example.qrc)
add_executable(
kddockwidgets_example
${RESOURCES_EXAMPLE_SRC}
main.cpp
MyFrameworkWidgetFactory.cpp
MyMainWindow.cpp
MyWidget.cpp
)
add_executable(qtwidgets_dockwidgets main.cpp MyViewFactory.cpp MyMainWindow.cpp MyWidget.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(
kddockwidgets_example
PRIVATE KDAB::kddockwidgets
)
target_link_libraries(qtwidgets_dockwidgets PRIVATE KDAB::kddockwidgets)

View File

@@ -1,106 +0,0 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "MyFrameworkWidgetFactory.h"
#include "MyTitleBar_CSS.h"
#include <kddockwidgets/FrameworkWidgetFactory.h>
#include <kddockwidgets/private/TabWidget_p.h>
#include <kddockwidgets/private/widgets/FrameWidget_p.h>
#include <kddockwidgets/private/widgets/TabBarWidget_p.h>
#include <kddockwidgets/private/widgets/TabWidgetWidget_p.h>
#include <kddockwidgets/private/widgets/TitleBarWidget_p.h>
#include <kddockwidgets/private/multisplitter/Separator_qwidget.h>
#include <QApplication>
// clazy:excludeall=missing-qobject-macro,ctor-missing-parent-argument
class MyTitleBar : public KDDockWidgets::TitleBarWidget
{
public:
explicit MyTitleBar(KDDockWidgets::Frame *frame)
: KDDockWidgets::TitleBarWidget(frame)
{
init();
}
explicit MyTitleBar(KDDockWidgets::FloatingWindow *fw)
: KDDockWidgets::TitleBarWidget(fw)
{
init();
}
~MyTitleBar() override;
void init()
{
setFixedHeight(60);
}
void paintEvent(QPaintEvent *) override
{
QPainter p(this);
QPen pen(Qt::black);
const QColor focusedBackgroundColor = Qt::yellow;
const QColor backgroundColor = focusedBackgroundColor.darker(115);
QBrush brush(isFocused() ? focusedBackgroundColor : backgroundColor);
pen.setWidth(4);
p.setPen(pen);
p.setBrush(brush);
p.drawRect(rect().adjusted(4, 4, -4, -4));
QFont f = qApp->font();
f.setPixelSize(30);
f.setBold(true);
p.setFont(f);
p.drawText(QPoint(10, 40), title());
}
};
MyTitleBar::~MyTitleBar() = default;
// Inheriting from SeparatorWidget instead of Separator as it handles moving and mouse cursor changing
class MySeparator : public Layouting::SeparatorWidget
{
public:
explicit MySeparator(Layouting::Widget *parent)
: Layouting::SeparatorWidget(parent)
{
}
~MySeparator() override;
void paintEvent(QPaintEvent *) override
{
QPainter p(this);
p.fillRect(QWidget::rect(), Qt::cyan);
}
};
MySeparator::~MySeparator() = default;
KDDockWidgets::TitleBar *CustomWidgetFactory::createTitleBar(KDDockWidgets::Frame *frame) const
{
// Feel free to return MyTitleBar_CSS here instead, but just for education purposes!
return new MyTitleBar(frame);
}
KDDockWidgets::TitleBar *CustomWidgetFactory::createTitleBar(KDDockWidgets::FloatingWindow *fw) const
{
// Feel free to return MyTitleBar_CSS here instead, but just for education purposes!
return new MyTitleBar(fw);
}
Layouting::Separator *CustomWidgetFactory::createSeparator(Layouting::Widget *parent) const
{
return new MySeparator(parent);
}

View File

@@ -1,27 +0,0 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kddockwidgets/FrameworkWidgetFactory.h>
#include <QPainter>
// clazy:excludeall=ctor-missing-parent-argument
class CustomWidgetFactory : public KDDockWidgets::DefaultWidgetFactory
{
Q_OBJECT
public:
KDDockWidgets::TitleBar *createTitleBar(KDDockWidgets::Frame *frame) const override;
KDDockWidgets::TitleBar *createTitleBar(KDDockWidgets::FloatingWindow *fw) const override;
Layouting::Separator *createSeparator(Layouting::Widget *parent = nullptr) const override;
};

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -45,11 +45,11 @@ static MyWidget *newMyWidget()
}
MyMainWindow::MyMainWindow(const QString &uniqueName, KDDockWidgets::MainWindowOptions options,
bool dockWidget0IsNonClosable, bool nonDockableDockWidget9, bool restoreIsRelative,
bool maxSizeForDockWidget8, bool dockwidget5DoesntCloseBeforeRestore,
bool dock0BlocksCloseEvent,
bool dockWidget0IsNonClosable, bool nonDockableDockWidget9,
bool restoreIsRelative, bool maxSizeForDockWidget8,
bool dockwidget5DoesntCloseBeforeRestore, bool dock0BlocksCloseEvent,
const QString &affinityName, QWidget *parent)
: MainWindow(uniqueName, options, parent)
: KDDockWidgets::Views::MainWindow_qtwidgets(uniqueName, options, parent)
, m_dockWidget0IsNonClosable(dockWidget0IsNonClosable)
, m_dockWidget9IsNonDockable(nonDockableDockWidget9)
, m_restoreIsRelative(restoreIsRelative)
@@ -73,10 +73,11 @@ MyMainWindow::MyMainWindow(const QString &uniqueName, KDDockWidgets::MainWindowO
count++;
auto w = newMyWidget();
w->setGeometry(100, 100, 400, 400);
auto dock = new KDDockWidgets::DockWidget(QStringLiteral("new dock %1").arg(count));
auto dock = new KDDockWidgets::Views::DockWidget_qtwidgets(
QStringLiteral("new dock %1").arg(count));
dock->setWidget(w);
dock->resize(600, 600);
dock->show();
dock->resize(QSize(600, 600));
dock->open();
});
auto saveLayoutAction = fileMenu->addAction(QStringLiteral("Save Layout"));
@@ -103,12 +104,13 @@ MyMainWindow::MyMainWindow(const QString &uniqueName, KDDockWidgets::MainWindowO
});
auto layoutEqually = fileMenu->addAction(QStringLiteral("Layout Equally"));
connect(layoutEqually, &QAction::triggered, this, &MainWindow::layoutEqually);
connect(layoutEqually, &QAction::triggered, this, [this] { this->layoutEqually(); });
auto quitAction = fileMenu->addAction(QStringLiteral("Quit"));
connect(quitAction, &QAction::triggered, qApp, &QApplication::quit);
QAction *toggleDropIndicatorSupport = miscMenu->addAction(QStringLiteral("Toggle Drop Indicator Support"));
QAction *toggleDropIndicatorSupport =
miscMenu->addAction(QStringLiteral("Toggle Drop Indicator Support"));
toggleDropIndicatorSupport->setCheckable(true);
toggleDropIndicatorSupport->setChecked(true);
connect(toggleDropIndicatorSupport, &QAction::toggled, this, [](bool checked) {
@@ -134,8 +136,8 @@ void MyMainWindow::createDockWidgets()
const int numDockWidgets = m_dockWidget9IsNonDockable ? 10 : 9;
// Create 9 KDDockWidget::DockWidget and the respective widgets they're hosting (MyWidget instances)
// Create 9 KDDockWidget::DockWidget and the respective widgets they're hosting (MyWidget
// instances)
for (int i = 0; i < numDockWidgets; i++)
m_dockwidgets << newDockWidget();
@@ -157,31 +159,34 @@ void MyMainWindow::createDockWidgets()
m_dockwidgets[6]->addDockWidgetAsTab(m_dockwidgets.at(7));
// Floating windows also support nesting, here we add 8 to the bottom of the group
m_dockwidgets[6]->addDockWidgetToContainingWindow(m_dockwidgets.at(8), KDDockWidgets::Location_OnBottom);
m_dockwidgets[6]->addDockWidgetToContainingWindow(m_dockwidgets.at(8),
KDDockWidgets::Location_OnBottom);
auto floatingWindow = m_dockwidgets.at(6)->window();
auto floatingWindow = m_dockwidgets.at(6)->rootView();
floatingWindow->move(100, 100);
}
KDDockWidgets::DockWidgetBase *MyMainWindow::newDockWidget()
KDDockWidgets::Views::DockWidget_qtwidgets *MyMainWindow::newDockWidget()
{
static int count = 0;
// Passing options is optional, we just want to illustrate Option_NotClosable here
KDDockWidgets::DockWidget::Options options = KDDockWidgets::DockWidget::Option_None;
KDDockWidgets::DockWidget::LayoutSaverOptions layoutSaverOptions = KDDockWidgets::DockWidget::LayoutSaverOption::None;
KDDockWidgets::DockWidgetOptions options = KDDockWidgets::DockWidgetOption_None;
KDDockWidgets::LayoutSaverOptions layoutSaverOptions = KDDockWidgets::LayoutSaverOption::None;
if (count == 0 && m_dockWidget0IsNonClosable)
options |= KDDockWidgets::DockWidget::Option_NotClosable;
options |= KDDockWidgets::DockWidgetOption_NotClosable;
if (count == 9 && m_dockWidget9IsNonDockable)
options |= KDDockWidgets::DockWidget::Option_NotDockable;
options |= KDDockWidgets::DockWidgetOption_NotDockable;
if (count == 5 && m_dockwidget5DoesntCloseBeforeRestore)
layoutSaverOptions |= KDDockWidgets::DockWidget::LayoutSaverOption::Skip;
layoutSaverOptions |= KDDockWidgets::LayoutSaverOption::Skip;
auto dock = new KDDockWidgets::DockWidget(QStringLiteral("DockWidget #%1").arg(count), options, layoutSaverOptions);
dock->setAffinities(affinities()); // optional, just to show the feature. Pass -mi to the example to see incompatible dock widgets
auto dock = new KDDockWidgets::Views::DockWidget_qtwidgets(
QStringLiteral("DockWidget #%1").arg(count), options, layoutSaverOptions);
dock->setAffinities(affinities()); // optional, just to show the feature. Pass -mi to the
// example to see incompatible dock widgets
if (count == 1)
dock->setIcon(QIcon::fromTheme(QStringLiteral("mail-message")));
@@ -197,13 +202,13 @@ KDDockWidgets::DockWidgetBase *MyMainWindow::newDockWidget()
dock->setWidget(myWidget);
if (dock->options() & KDDockWidgets::DockWidget::Option_NotDockable) {
if (dock->options() & KDDockWidgets::DockWidgetOption_NotDockable) {
dock->setTitle(QStringLiteral("DockWidget #%1 (%2)").arg(count).arg("non dockable"));
} else {
dock->setTitle(QStringLiteral("DockWidget #%1").arg(count));
}
dock->resize(600, 600);
dock->resize(QSize(600, 600));
m_toggleMenu->addAction(dock->toggleAction());
dock->toggleAction()->setShortcut(QStringLiteral("ctrl+%1").arg(count));

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -14,20 +14,22 @@
#include <kddockwidgets/DockWidget.h>
#include <kddockwidgets/MainWindow.h>
class MyMainWindow : public KDDockWidgets::MainWindow
class MyMainWindow : public KDDockWidgets::Views::MainWindow_qtwidgets
{
Q_OBJECT
public:
explicit MyMainWindow(const QString &uniqueName, KDDockWidgets::MainWindowOptions options,
bool dockWidget0IsNonClosable, bool nonDockableDockWidget9, bool restoreIsRelative,
bool maxSizeForDockWidget8, bool dockwidget5DoesntCloseBeforeRestore, bool dock0BlocksCloseEvent,
const QString &affinityName = {}, // Usually not needed. Just here to show the feature.
bool dockWidget0IsNonClosable, bool nonDockableDockWidget9,
bool restoreIsRelative, bool maxSizeForDockWidget8,
bool dockwidget5DoesntCloseBeforeRestore, bool dock0BlocksCloseEvent,
const QString &affinityName = {}, // Usually not needed. Just here to show
// the feature.
QWidget *parent = nullptr);
~MyMainWindow() override;
private:
void createDockWidgets();
KDDockWidgets::DockWidgetBase *newDockWidget();
KDDockWidgets::Views::DockWidget_qtwidgets *newDockWidget();
QMenu *m_toggleMenu = nullptr;
const bool m_dockWidget0IsNonClosable;
const bool m_dockWidget9IsNonDockable;
@@ -35,5 +37,5 @@ private:
const bool m_maxSizeForDockWidget8;
const bool m_dockwidget5DoesntCloseBeforeRestore;
const bool m_dock0BlocksCloseEvent;
KDDockWidgets::DockWidget::List m_dockwidgets;
QVector<KDDockWidgets::Views::DockWidget_qtwidgets *> m_dockwidgets;
};

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -14,15 +14,16 @@
#pragma once
#include <kddockwidgets/private/widgets/TitleBarWidget_p.h>
#include <kddockwidgets/views/TitleBar_qtwidgets.h>
#include <kddockwidgets/controllers/TitleBar.h>
/**
* @brief Shows how to implement a custom titlebar which uses "Qt StyleSheets".
*
* Derive from KDDockWidgets::DefaultWidgetFactory and override the two createTitleBar() methods.
* Derive from KDDockWidgets::ViewFactory_qtwidgets and override the createTitleBar() method.
*
* To try it out, modify examples/dockwidgets/MyFrameworkWidgetFactory.cpp to return a MyTitleBar_CSS instance.
* Run the example with: ./bin/kddockwidgets_example -p
* To try it out, modify examples/dockwidgets/MyViewFactory.cpp to return a MyTitleBar_CSS instance.
* Run the example with: ./bin/examples/qtwidgets_dockwidgets -p
*
* WARNINGS:
* - Qt StyleSheets are not recommended for new applications. Often you are able to style 90% of
@@ -30,27 +31,29 @@
* - The Qt maintainers have manifested intention to deprecated stylesheets.
* - Stylesheets are supported for built-in QWidgets (QPushButton, QComboBox, etc.), any widget
* that's not in Qt needs to be crafted by the user, that includes, for example, having to paint
* your background manually. KDDockWidget::TitleBarWidget does this for your convenience though.
* your background manually. KDDockWidget::Views::TitleBar_qtwidgets does this for your
* convenience though.
* - Qt stylesheets don't react to property changes (known old bug in Qt), for example:
* QLineEdit[readOnly="true"] { color: gray }
* this won't trigger when readOnly changes to false, you need to set/unset. This is QTBUG-51236
* - KDDockWidgets::TitleBarWidget::isFocused is a property, there for needs to workaround the
* above bug by unsetting the sheet and setting it again.
* - KDDockWidget::Views::TitleBar_qtwidgets::isFocused is a property, there for needs to
* workaround the above bug by unsetting the sheet and setting it again.
*/
class MyTitleBar_CSS : public KDDockWidgets::TitleBarWidget
class MyTitleBar_CSS : public KDDockWidgets::Views::TitleBar_qtwidgets
{
public:
explicit MyTitleBar_CSS(KDDockWidgets::Frame *frame)
: KDDockWidgets::TitleBarWidget(frame)
explicit MyTitleBar_CSS(KDDockWidgets::Controllers::TitleBar *controller,
View *parent = nullptr)
: KDDockWidgets::Views::TitleBar_qtwidgets(controller, parent)
{
init();
initStyleSheet();
connect(controller, &KDDockWidgets::Controllers::TitleBar::isFocusedChanged, this, [this] {
// Workaround QTBUG-51236, this makes the [isFocused=true] syntax useful
setStyleSheet(QString());
initStyleSheet();
});
}
explicit MyTitleBar_CSS(KDDockWidgets::FloatingWindow *fw)
: KDDockWidgets::TitleBarWidget(fw)
{
init();
}
~MyTitleBar_CSS() override;
@@ -67,16 +70,6 @@ public:
"background: green"
"}"));
}
void init()
{
initStyleSheet();
connect(this, &KDDockWidgets::TitleBar::isFocusedChanged, this, [this] {
// Workaround QTBUG-51236, this makes the [isFocused=true] syntax useful
setStyleSheet(QString());
initStyleSheet();
});
}
};
MyTitleBar_CSS::~MyTitleBar_CSS()

View File

@@ -0,0 +1,93 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "MyViewFactory.h"
#include "MyTitleBar_CSS.h"
#include <kddockwidgets/views/TitleBar_qtwidgets.h>
#include <kddockwidgets/views/Separator_qtwidgets.h>
#include <QApplication>
#include <QPainter>
// clazy:excludeall=missing-qobject-macro,ctor-missing-parent-argument
class MyTitleBar : public KDDockWidgets::Views::TitleBar_qtwidgets
{
public:
explicit MyTitleBar(KDDockWidgets::Controllers::TitleBar *controller, View *parent = nullptr)
: KDDockWidgets::Views::TitleBar_qtwidgets(controller, parent)
, m_controller(controller)
{
setFixedHeight(60);
}
~MyTitleBar() override;
void paintEvent(QPaintEvent *) override
{
QPainter p(this);
QPen pen(Qt::black);
const QColor focusedBackgroundColor = Qt::yellow;
const QColor backgroundColor = focusedBackgroundColor.darker(115);
QBrush brush(m_controller->isFocused() ? focusedBackgroundColor : backgroundColor);
pen.setWidth(4);
p.setPen(pen);
p.setBrush(brush);
p.drawRect(rect().adjusted(4, 4, -4, -4));
QFont f = qGuiApp->font();
f.setPixelSize(30);
f.setBold(true);
p.setFont(f);
p.drawText(QPoint(10, 40), m_controller->title());
}
private:
KDDockWidgets::Controllers::TitleBar *const m_controller;
};
MyTitleBar::~MyTitleBar() = default;
// Inheriting from SeparatorWidget instead of Separator as it handles moving and mouse cursor
// changing
class MySeparator : public KDDockWidgets::Views::Separator_qtwidgets
{
public:
explicit MySeparator(KDDockWidgets::Controllers::Separator *controller, View *parent)
: KDDockWidgets::Views::Separator_qtwidgets(controller, parent)
{
}
~MySeparator() override;
void paintEvent(QPaintEvent *) override
{
QPainter p(this);
p.fillRect(QWidget::rect(), Qt::cyan);
}
};
MySeparator::~MySeparator() = default;
KDDockWidgets::View *
CustomWidgetFactory::createTitleBar(KDDockWidgets::Controllers::TitleBar *controller,
KDDockWidgets::View *parent) const
{
// Feel free to return MyTitleBar_CSS here instead, but just for education purposes!
return new MyTitleBar(controller, parent);
}
KDDockWidgets::View *
CustomWidgetFactory::createSeparator(KDDockWidgets::Controllers::Separator *controller,
KDDockWidgets::View *parent) const
{
return new MySeparator(controller, parent);
}

View File

@@ -0,0 +1,26 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kddockwidgets/ViewFactory_qtwidgets.h>
// clazy:excludeall=ctor-missing-parent-argument
class CustomWidgetFactory : public KDDockWidgets::ViewFactory_qtwidgets
{
Q_OBJECT
public:
KDDockWidgets::View *createTitleBar(KDDockWidgets::Controllers::TitleBar *,
KDDockWidgets::View *parent) const override;
KDDockWidgets::View *createSeparator(KDDockWidgets::Controllers::Separator *,
KDDockWidgets::View *parent = nullptr) const override;
};

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -62,8 +62,7 @@ void MyWidget::drawLogo(QPainter &p)
const int proposedHeight = int(maxWidth * ratio);
const int width = proposedHeight <= maxHeight ? maxWidth
: int(maxHeight / ratio);
const int width = proposedHeight <= maxHeight ? maxWidth : int(maxHeight / ratio);
const int height = int(width * ratio);
QRect targetLogoRect(0, 0, width, height);
@@ -86,7 +85,8 @@ void MyWidget::closeEvent(QCloseEvent *ev)
}
MyWidget1::MyWidget1(MyWidget::QWidget *parent)
: MyWidget(QStringLiteral(":/assets/triangles.png"), QStringLiteral(":/assets/KDAB_bubble_white.png"), parent)
: MyWidget(QStringLiteral(":/assets/triangles.png"),
QStringLiteral(":/assets/KDAB_bubble_white.png"), parent)
{
}
@@ -112,7 +112,8 @@ void MyWidget2::paintEvent(QPaintEvent *)
}
MyWidget3::MyWidget3(MyWidget::QWidget *parent)
: MyWidget(QStringLiteral(":/assets/base.png"), QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"), parent)
: MyWidget(QStringLiteral(":/assets/base.png"),
QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"), parent)
, m_triangle(QImage(QStringLiteral(":/assets/tri.png")))
{
}
@@ -124,7 +125,8 @@ void MyWidget3::paintEvent(QPaintEvent *)
p.drawImage(m_background.rect(), m_background, m_background.rect());
const QRect targetRect = QRect({ width() - m_triangle.width(), height() - m_triangle.height() }, m_triangle.size());
const QRect targetRect =
QRect({ width() - m_triangle.width(), height() - m_triangle.height() }, m_triangle.size());
p.drawImage(targetRect, m_triangle, m_triangle.rect());
drawLogo(p);

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -24,7 +24,8 @@ class MyWidget : public QWidget
{
Q_OBJECT
public:
explicit MyWidget(const QString &backgroundFile, const QString &logoFile, QWidget *parent = nullptr);
explicit MyWidget(const QString &backgroundFile, const QString &logoFile,
QWidget *parent = nullptr);
~MyWidget();
// These two are just for demonstrating how to block the close event, if desired

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -11,16 +11,19 @@
#include "MyWidget.h"
#include "MyMainWindow.h"
#include "MyFrameworkWidgetFactory.h"
#include "MyViewFactory.h"
#include <algorithm>
#include <kddockwidgets/Config.h>
#include <kddockwidgets/ViewFactory.h>
#include <kddockwidgets/controllers/DockWidget.h>
#include <QStyleFactory>
#include <QApplication>
#include <QDebug>
#include <QCommandLineParser>
#include <algorithm>
// clazy:excludeall=qstring-allocations
using namespace KDDockWidgets;
@@ -32,10 +35,11 @@ int main(int argc, char **argv)
QApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);
#endif
QApplication app(argc, argv);
app.setOrganizationName(QStringLiteral("KDAB"));
app.setApplicationName(QStringLiteral("Test app"));
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtWidgets);
QCommandLineParser parser;
parser.setApplicationDescription("KDDockWidgets example application");
parser.addHelpOption();
@@ -43,110 +47,184 @@ int main(int argc, char **argv)
// Fusion looks better in general, but feel free to change
qApp->setStyle(QStyleFactory::create(QStringLiteral("Fusion")));
QCommandLineOption customStyle("p", QCoreApplication::translate("main", "Shows how to style framework internals via FrameworkWidgetFactory"));
QCommandLineOption customStyle(
"p",
QCoreApplication::translate("main",
"Shows how to style framework internals via ViewFactory"));
parser.addOption(customStyle);
QCommandLineOption reorderTabsOption("r", QCoreApplication::translate("main", "Support re-ordering tabs with mouse"));
QCommandLineOption reorderTabsOption(
"r", QCoreApplication::translate("main", "Support re-ordering tabs with mouse"));
parser.addOption(reorderTabsOption);
QCommandLineOption noTitleBars("t", QCoreApplication::translate("main", "Hide titlebars when tabs are visible"));
QCommandLineOption noTitleBars(
"t", QCoreApplication::translate("main", "Hide titlebars when tabs are visible"));
parser.addOption(noTitleBars);
QCommandLineOption alwaysTitleBarWhenFloating("q", QCoreApplication::translate("main", "Don't hide title bars if floating, even if Flag_HideTitleBarWhenTabsVisible is specified."));
QCommandLineOption alwaysTitleBarWhenFloating(
"q",
QCoreApplication::translate("main",
"Don't hide title bars if floating, even if "
"Flag_HideTitleBarWhenTabsVisible is specified."));
parser.addOption(alwaysTitleBarWhenFloating);
QCommandLineOption alwaysTabs("z", QCoreApplication::translate("main", "Show tabs even if there's only one"));
QCommandLineOption alwaysTabs(
"z", QCoreApplication::translate("main", "Show tabs even if there's only one"));
parser.addOption(alwaysTabs);
QCommandLineOption lazyResizeOption("l", QCoreApplication::translate("main", "Use lazy resize"));
QCommandLineOption lazyResizeOption("l",
QCoreApplication::translate("main", "Use lazy resize"));
parser.addOption(lazyResizeOption);
QCommandLineOption multipleMainWindows("m", QCoreApplication::translate("main", "Shows two multiple main windows"));
QCommandLineOption multipleMainWindows(
"m", QCoreApplication::translate("main", "Shows two multiple main windows"));
parser.addOption(multipleMainWindows);
QCommandLineOption incompatibleMainWindows("i", QCoreApplication::translate("main", "Only usable with -m. Make the two main windows incompatible with each other. (Illustrates (MainWindowBase::setAffinityName))"));
QCommandLineOption incompatibleMainWindows(
"i",
QCoreApplication::translate(
"main",
"Only usable with -m. Make the two main windows incompatible with each other. "
"(Illustrates (MainWindowBase::setAffinityName))"));
parser.addOption(incompatibleMainWindows);
QCommandLineOption tabsHaveCloseButton("c", QCoreApplication::translate("main", "Tabs have a close button"));
QCommandLineOption tabsHaveCloseButton(
"c", QCoreApplication::translate("main", "Tabs have a close button"));
parser.addOption(tabsHaveCloseButton);
QCommandLineOption nonClosableDockWidget("n", QCoreApplication::translate("main", "DockWidget #0 will be non-closable"));
QCommandLineOption nonClosableDockWidget(
"n", QCoreApplication::translate("main", "DockWidget #0 will be non-closable"));
parser.addOption(nonClosableDockWidget);
QCommandLineOption relativeRestore("s", QCoreApplication::translate("main", "Don't restore main window geometry, restore dock widgets in relative sizes"));
QCommandLineOption relativeRestore(
"s",
QCoreApplication::translate(
"main", "Don't restore main window geometry, restore dock widgets in relative sizes"));
parser.addOption(relativeRestore);
QCommandLineOption doubleClickMaximize("x", QCoreApplication::translate("main", "Double clicking a title bar will maximize a floating window"));
QCommandLineOption doubleClickMaximize(
"x",
QCoreApplication::translate("main",
"Double clicking a title bar will maximize a floating window"));
parser.addOption(doubleClickMaximize);
QCommandLineOption nonDockable("d", QCoreApplication::translate("main", "DockWidget #9 will be non-dockable"));
QCommandLineOption nonDockable(
"d", QCoreApplication::translate("main", "DockWidget #9 will be non-dockable"));
parser.addOption(nonDockable);
QCommandLineOption maximizeButtonOption("b", QCoreApplication::translate("main", "Floating dockWidgets have maximize/restore buttons instead of float/dock button"));
QCommandLineOption maximizeButtonOption(
"b",
QCoreApplication::translate(
"main",
"Floating dockWidgets have maximize/restore buttons instead of float/dock button"));
parser.addOption(maximizeButtonOption);
QCommandLineOption minimizeButtonOption("k", QCoreApplication::translate("main", "Floating dockWidgets have a minimize button. Implies not being an utility window (~Qt::Tool)"));
QCommandLineOption minimizeButtonOption(
"k",
QCoreApplication::translate("main",
"Floating dockWidgets have a minimize button. Implies not "
"being an utility window (~Qt::Tool)"));
parser.addOption(minimizeButtonOption);
QCommandLineOption segmentedIndicators("y", QCoreApplication::translate("main", "Use segmented indicators instead of classical"));
QCommandLineOption segmentedIndicators(
"y", QCoreApplication::translate("main", "Use segmented indicators instead of classical"));
parser.addOption(segmentedIndicators);
QCommandLineOption noUtilityWindows("u", QCoreApplication::translate("main", "FloatingWindows will be normal windows instead of utility windows"));
QCommandLineOption noUtilityWindows(
"u",
QCoreApplication::translate(
"main", "FloatingWindows will be normal windows instead of utility windows"));
parser.addOption(noUtilityWindows);
QCommandLineOption keepAbove("o", QCoreApplication::translate("main", "FloatingWindows will have Qt::WindowStaysOnTopHint. Implies not being an utility window (try it with -u too)"));
QCommandLineOption keepAbove(
"o",
QCoreApplication::translate("main",
"FloatingWindows will have Qt::WindowStaysOnTopHint. Implies "
"not being an utility window (try it with -u too)"));
parser.addOption(keepAbove);
parser.addPositionalArgument("savedlayout", QCoreApplication::translate("main", "loads the specified json file at startup"));
parser.addPositionalArgument(
"savedlayout",
QCoreApplication::translate("main", "loads the specified json file at startup"));
#ifdef KDDOCKWIDGETS_SUPPORTS_NESTED_MAINWINDOWS
QCommandLineOption dockableMainWindows("j", QCoreApplication::translate("main", "Allow main windows to be docked inside other main windows"));
QCommandLineOption dockableMainWindows(
"j",
QCoreApplication::translate("main",
"Allow main windows to be docked inside other main windows"));
parser.addOption(dockableMainWindows);
#endif
QCommandLineOption maxSizeOption("g", QCoreApplication::translate("main", "Make dock #8 have a max-size of 200x200."));
QCommandLineOption maxSizeOption(
"g", QCoreApplication::translate("main", "Make dock #8 have a max-size of 200x200."));
parser.addOption(maxSizeOption);
QCommandLineOption centralFrame("f", QCoreApplication::translate("main", "Persistent central frame"));
QCommandLineOption centralFrame(
"f", QCoreApplication::translate("main", "Persistent central group"));
QCommandLineOption autoHideSupport("w", QCoreApplication::translate("main", "Enables auto-hide/minimization to side-bar support"));
QCommandLineOption autoHideSupport(
"w",
QCoreApplication::translate("main", "Enables auto-hide/minimization to side-bar support"));
parser.addOption(autoHideSupport);
QCommandLineOption closeOnlyCurrentTab("close-only-current-tab",
QCoreApplication::translate("main", "The title bar's close button will only close the current tab instead of all. Illustrates using Config::Flag_CloseOnlyCurrentTab"));
QCommandLineOption closeOnlyCurrentTab(
"close-only-current-tab",
QCoreApplication::translate(
"main",
"The title bar's close button will only close the current tab instead of all. "
"Illustrates using Config::Flag_CloseOnlyCurrentTab"));
parser.addOption(closeOnlyCurrentTab);
QCommandLineOption dontCloseBeforeRestore("dont-close-widget-before-restore", // krazy:exclude=spelling
QCoreApplication::translate("main", "DockWidget #5 won't be closed before a restore. Illustrates LayoutSaverOption::DontCloseBeforeRestore"));
QCommandLineOption dontCloseBeforeRestore(
"dont-close-widget-before-restore", // krazy:exclude=spelling
QCoreApplication::translate("main",
"DockWidget #5 won't be closed before a restore. Illustrates "
"LayoutSaverOption::DontCloseBeforeRestore"));
parser.addOption(dontCloseBeforeRestore);
QCommandLineOption blockCloseEvent("block-close-event",
QCoreApplication::translate("main", "DockWidget #0 will block close events"));
QCommandLineOption blockCloseEvent(
"block-close-event",
QCoreApplication::translate("main", "DockWidget #0 will block close events"));
parser.addOption(blockCloseEvent);
QCommandLineOption showButtonsInTabBarIfTitleBarHidden("show-buttons-in-tabbar-if-titlebar-hidden",
QCoreApplication::translate("main", "If we're not using title bars we'll still show the close and float button in the tab bar"));
QCommandLineOption showButtonsInTabBarIfTitleBarHidden(
"show-buttons-in-tabbar-if-titlebar-hidden",
QCoreApplication::translate("main",
"If we're not using title bars we'll still show the close and "
"float button in the tab bar"));
parser.addOption(showButtonsInTabBarIfTitleBarHidden);
QCommandLineOption centralWidget("central-widget",
QCoreApplication::translate("main", "The main window will have a non-detachable central widget"));
QCommandLineOption centralWidget(
"central-widget",
QCoreApplication::translate("main",
"The main window will have a non-detachable central widget"));
parser.addOption(centralWidget);
QCommandLineOption ctxtMenuOnTabs("allow-switch-tabs-via-menu",
QCoreApplication::translate("main", "Allow switching tabs via context menu in tabs area"));
QCommandLineOption ctxtMenuOnTabs(
"allow-switch-tabs-via-menu",
QCoreApplication::translate("main", "Allow switching tabs via context menu in tabs area"));
parser.addOption(ctxtMenuOnTabs);
QCommandLineOption hideCertainDockingIndicators("hide-certain-docking-indicators",
QCoreApplication::translate("main", "Illustrates usage of Config::setDropIndicatorAllowedFunc()"));
QCommandLineOption hideCertainDockingIndicators(
"hide-certain-docking-indicators",
QCoreApplication::translate("main",
"Illustrates usage of Config::setDropIndicatorAllowedFunc()"));
parser.addOption(hideCertainDockingIndicators);
#if defined(DOCKS_DEVELOPER_MODE)
parser.addOption(centralFrame);
QCommandLineOption noQtTool("no-qttool", QCoreApplication::translate("main", "(internal) Don't use Qt::Tool"));
QCommandLineOption noParentForFloating("no-parent-for-floating", QCoreApplication::translate("main", "(internal) FloatingWindows won't have a parent"));
QCommandLineOption nativeTitleBar("native-title-bar", QCoreApplication::translate("main", "(internal) FloatingWindows a native title bar"));
QCommandLineOption noDropIndicators("no-drop-indicators", QCoreApplication::translate("main", "(internal) Don't use any drop indicators"));
QCommandLineOption noQtTool(
"no-qttool", QCoreApplication::translate("main", "(internal) Don't use Qt::Tool"));
QCommandLineOption noParentForFloating(
"no-parent-for-floating",
QCoreApplication::translate("main", "(internal) FloatingWindows won't have a parent"));
QCommandLineOption nativeTitleBar(
"native-title-bar",
QCoreApplication::translate("main", "(internal) FloatingWindows a native title bar"));
QCommandLineOption noDropIndicators(
"no-drop-indicators",
QCoreApplication::translate("main", "(internal) Don't use any drop indicators"));
parser.addOption(noQtTool);
parser.addOption(noParentForFloating);
@@ -154,7 +232,8 @@ int main(int argc, char **argv)
parser.addOption(noDropIndicators);
#if defined(Q_OS_WIN)
QCommandLineOption noAeroSnap("no-aero-snap", QCoreApplication::translate("main", "(internal) Disable AeroSnap"));
QCommandLineOption noAeroSnap(
"no-aero-snap", QCoreApplication::translate("main", "(internal) Disable AeroSnap"));
parser.addOption(noAeroSnap);
#endif
#else
@@ -164,22 +243,22 @@ int main(int argc, char **argv)
parser.process(app);
if (parser.isSet(customStyle)) {
Config::self().setFrameworkWidgetFactory(new CustomWidgetFactory()); // Sets our custom factory
Config::self().setViewFactory(new CustomWidgetFactory()); // Sets our custom factory
// Increase the separator size, just for demo
Config::self().setSeparatorThickness(10);
}
if (parser.isSet(segmentedIndicators))
KDDockWidgets::DefaultWidgetFactory::s_dropIndicatorType = KDDockWidgets::DropIndicatorType::Segmented;
KDDockWidgets::ViewFactory::s_dropIndicatorType =
KDDockWidgets::DropIndicatorType::Segmented;
MainWindowOptions options = MainWindowOption_None;
auto flags = KDDockWidgets::Config::self().flags();
#if defined(DOCKS_DEVELOPER_MODE)
auto internalFlags = KDDockWidgets::Config::self().internalFlags();
options = parser.isSet(centralFrame) ? MainWindowOption_HasCentralFrame
: MainWindowOption_None;
options = parser.isSet(centralFrame) ? MainWindowOption_HasCentralFrame : MainWindowOption_None;
if (parser.isSet(centralWidget))
options |= MainWindowOption_HasCentralWidget;
@@ -197,7 +276,7 @@ int main(int argc, char **argv)
flags |= KDDockWidgets::Config::Flag_NativeTitleBar;
if (parser.isSet(noDropIndicators))
KDDockWidgets::DefaultWidgetFactory::s_dropIndicatorType = KDDockWidgets::DropIndicatorType::None;
KDDockWidgets::ViewFactory::s_dropIndicatorType = KDDockWidgets::DropIndicatorType::None;
#if defined(Q_OS_WIN)
if (parser.isSet(noAeroSnap))
@@ -227,13 +306,16 @@ int main(int argc, char **argv)
if (parser.isSet(alwaysTitleBarWhenFloating)) {
flags |= KDDockWidgets::Config::Flag_AlwaysTitleBarWhenFloating;
if (!(flags & KDDockWidgets::Config::Flag_HideTitleBarWhenTabsVisible)) {
qWarning() << "Flag_AlwaysTitleBarWhenFloating is unneeded if Flag_HideTitleBarWhenTabsVisible isn't used."
qWarning() << "Flag_AlwaysTitleBarWhenFloating is unneeded if "
"Flag_HideTitleBarWhenTabsVisible isn't used."
<< "As floating windows already have title bars by default.";
}
}
if (parser.isSet(customStyle) || qEnvironmentVariableIsSet("KDDW_DEBUG_FOCUS"))
flags |= KDDockWidgets::Config::Flag_TitleBarIsFocusable; // also showing title bar focus with -p, just to not introduce another switch
flags |= KDDockWidgets::Config::Flag_TitleBarIsFocusable; // also showing title bar focus
// with -p, just to not introduce
// another switch
if (parser.isSet(reorderTabsOption))
flags |= KDDockWidgets::Config::Flag_AllowReorderTabs;
@@ -264,16 +346,19 @@ int main(int argc, char **argv)
if (parser.isSet(hideCertainDockingIndicators)) {
// Here we exemplify adding a restriction to "Dock Widget 8"
// Dock widget 8 will only be allowed to dock to the outer areasa
// Dock widget 8 will only be allowed to dock to the outer areas
auto func = [](KDDockWidgets::DropLocation location,
const KDDockWidgets::DockWidgetBase::List &source,
const KDDockWidgets::DockWidgetBase::List &target,
KDDockWidgets::DropArea *) {
Q_UNUSED(target); // When dragging into a tab, 'target' would have the list of already tabbed dock widgets
const KDDockWidgets::Controllers::DockWidget::List &source,
const KDDockWidgets::Controllers::DockWidget::List &target,
Controllers::DropArea *) {
Q_UNUSED(target); // When dragging into a tab, 'target' would have the list of already
// tabbed dock widgets
const bool isDraggingDW8 = std::find_if(source.cbegin(), source.cend(), [](KDDockWidgets::DockWidgetBase *dw) {
return dw->uniqueName() == QLatin1String("DockWidget #8");
})
const bool isDraggingDW8 =
std::find_if(source.cbegin(), source.cend(),
[](KDDockWidgets::Controllers::DockWidget *dw) {
return dw->uniqueName() == QLatin1String("DockWidget #8");
})
!= source.cend();
return (location & KDDockWidgets::DropLocation_Outter) || !isDraggingDW8;
@@ -307,19 +392,21 @@ int main(int argc, char **argv)
if (usesMainWindowsWithAffinity) {
if (usesDockableMainWindows) {
qWarning() << "MainWindows with affinity option is incompatible with Dockable Main Windows option";
qWarning() << "MainWindows with affinity option is incompatible with Dockable Main "
"Windows option";
return 1;
}
// By default a dock widget can dock into any main window.
// By setting an affinity name we can prevent that. Dock widgets of different affinities are incompatible.
const QString affinity = parser.isSet(incompatibleMainWindows) ? QStringLiteral("affinity1")
: QString();
// By setting an affinity name we can prevent that. Dock widgets of different affinities are
// incompatible.
const QString affinity =
parser.isSet(incompatibleMainWindows) ? QStringLiteral("affinity1") : QString();
auto mainWindow2 = new MyMainWindow(QStringLiteral("MyMainWindow-2"), options,
nonClosableDockWidget0, nonDockableDockWidget9,
restoreIsRelative, maxSizeForDockWidget8,
dontCloseDockWidget5BeforeRestore, dock0BlocksCloseEvent, affinity);
auto mainWindow2 =
new MyMainWindow(QStringLiteral("MyMainWindow-2"), options, nonClosableDockWidget0,
nonDockableDockWidget9, restoreIsRelative, maxSizeForDockWidget8,
dontCloseDockWidget5BeforeRestore, dock0BlocksCloseEvent, affinity);
if (affinity.isEmpty())
mainWindow2->setWindowTitle("Main Window 2");
else
@@ -328,22 +415,22 @@ int main(int argc, char **argv)
mainWindow2->resize(1200, 1200);
mainWindow2->show();
} else if (usesDockableMainWindows) {
auto mainWindowDockWidget = new DockWidget(QStringLiteral("MyMainWindow-2-DW"));
auto mainWindowDockWidget =
new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyMainWindow-2-DW"));
const QString affinity = QStringLiteral("Inner-DockWidgets-2");
auto dockableMainWindow = new MyMainWindow(QStringLiteral("MyMainWindow-2"), options,
false, false, restoreIsRelative, false,
false, false, affinity);
auto dockableMainWindow =
new MyMainWindow(QStringLiteral("MyMainWindow-2"), options, false, false,
restoreIsRelative, false, false, false, affinity);
dockableMainWindow->setAffinities({ affinity });
dockableMainWindow->setStyleSheet(QStringLiteral("background: yellow"));
dockableMainWindow->setWindowTitle("Dockable Main Window");
dockableMainWindow->show();
mainWindowDockWidget->setWidget(dockableMainWindow);
mainWindowDockWidget->show();
mainWindowDockWidget->resize(800, 800);
mainWindowDockWidget->open();
mainWindowDockWidget->resize(QSize(800, 800));
}
const QStringList args = parser.positionalArguments();

View File

@@ -10,15 +10,15 @@
#
cmake_minimum_required(VERSION 3.7)
project(kddockwidgets_minimal_mdi_example)
project(qtwidgets_mdi)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before
# if you want to look for a specific Qt version for instance.
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
@@ -27,12 +27,6 @@ set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/../dockwidgets/resources_e
# Just to reuse MyWidget.h
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../dockwidgets/)
add_executable(
kddockwidgets_minimal_mdi_example
${RESOURCES_EXAMPLE_SRC} ../dockwidgets/MyWidget.cpp main.cpp
)
add_executable(qtwidgets_mdi main.cpp ../dockwidgets/MyWidget.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(
kddockwidgets_minimal_mdi_example
PRIVATE KDAB::kddockwidgets
)
target_link_libraries(qtwidgets_mdi PRIVATE KDAB::kddockwidgets)

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -11,8 +11,8 @@
#include "MyWidget.h"
#include <kddockwidgets/views/MainWindowMDI_qtwidgets.h>
#include <kddockwidgets/DockWidget.h>
#include <kddockwidgets/MainWindowMDI.h>
#include <QStyleFactory>
#include <QApplication>
@@ -30,26 +30,28 @@ int main(int argc, char **argv)
app.setOrganizationName(QStringLiteral("KDAB"));
app.setApplicationName(QStringLiteral("Test app"));
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtWidgets);
// Fusion looks better in general, but feel free to change
qApp->setStyle(QStyleFactory::create(QStringLiteral("Fusion")));
// # 1. Create our main window
KDDockWidgets::MainWindowMDI mainWindow(QStringLiteral("MyMainWindow"));
KDDockWidgets::Views::MainWindowMDI_qtwidgets mainWindow(QStringLiteral("MyMainWindow"));
mainWindow.setWindowTitle("Main Window");
mainWindow.resize(1200, 1200);
mainWindow.show();
// # 2. Create a dock widget, it needs a unique name
auto dock1 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock1"));
auto dock1 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock1"));
auto widget1 = new MyWidget1();
dock1->setWidget(widget1);
auto dock2 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock2"));
auto dock2 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock2"));
auto widget2 = new MyWidget2();
dock2->setWidget(widget2);
auto dock3 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock3"));
auto dock3 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock3"));
auto widget3 = new MyWidget3();
dock3->setWidget(widget3);

View File

@@ -10,15 +10,15 @@
#
cmake_minimum_required(VERSION 3.7)
project(kddockwidgets_mdi_with_docking_example)
project(qtwidgets_mdi_with_docking)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before
# if you want to look for a specific Qt version for instance.
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
@@ -27,12 +27,6 @@ set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/../dockwidgets/resources_e
# Just to reuse MyWidget.h
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../dockwidgets/)
add_executable(
kddockwidgets_mdi_with_docking_example
${RESOURCES_EXAMPLE_SRC} ../dockwidgets/MyWidget.cpp main.cpp
)
add_executable(qtwidgets_mdi_with_docking main.cpp ../dockwidgets/MyWidget.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(
kddockwidgets_mdi_with_docking_example
PRIVATE KDAB::kddockwidgets
)
target_link_libraries(qtwidgets_mdi_with_docking PRIVATE KDAB::kddockwidgets)

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -11,9 +11,9 @@
#include "MyWidget.h"
#include <kddockwidgets/DockWidget.h>
#include <kddockwidgets/MainWindow.h>
#include <kddockwidgets/MDIArea.h>
#include <kddockwidgets/DockWidget.h>
#include <kddockwidgets/views/MDIArea_qtwidgets.h>
#include <QStyleFactory>
#include <QApplication>
@@ -32,11 +32,16 @@ int main(int argc, char **argv)
app.setOrganizationName(QStringLiteral("KDAB"));
app.setApplicationName(QStringLiteral("App supporting both docking and a MDI area"));
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtWidgets);
QCommandLineParser parser;
parser.setApplicationDescription("KDDockWidgets MDI mixed with normal docking");
parser.addHelpOption();
QCommandLineOption nestedDocking("n", QCoreApplication::translate("main", "The MDI dock widgets will serve as drop areas, allowing for further nesting"));
QCommandLineOption nestedDocking(
"n",
QCoreApplication::translate(
"main", "The MDI dock widgets will serve as drop areas, allowing for further nesting"));
parser.addOption(nestedDocking);
parser.process(app);
@@ -46,50 +51,51 @@ int main(int argc, char **argv)
// # 1. Create our main window
KDDockWidgets::MainWindow mainWindow(QStringLiteral("MyMainWindow"), KDDockWidgets::MainWindowOption_HasCentralWidget);
KDDockWidgets::Views::MainWindow_qtwidgets mainWindow(
QStringLiteral("MyMainWindow"), KDDockWidgets::MainWindowOption_HasCentralWidget);
mainWindow.setWindowTitle("Main Window");
mainWindow.resize(1600, 1200);
mainWindow.show();
// # 2. Create a dock widget, it needs a unique name
auto dock1 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock1"));
auto dock1 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock1"));
auto widget1 = new MyWidget1();
dock1->setWidget(widget1);
auto dock2 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock2"));
auto dock2 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock2"));
auto widget2 = new MyWidget2();
dock2->setWidget(widget2);
// # 3. Dock them
mainWindow.addDockWidget(dock1, KDDockWidgets::Location_OnLeft, nullptr, KDDockWidgets::InitialOption(QSize(300, 0)));
mainWindow.addDockWidget(dock2, KDDockWidgets::Location_OnBottom, nullptr, KDDockWidgets::InitialOption(QSize(0, 300)));
mainWindow.addDockWidget(dock1, KDDockWidgets::Location_OnLeft, nullptr,
KDDockWidgets::InitialOption(QSize(300, 0)));
mainWindow.addDockWidget(dock2, KDDockWidgets::Location_OnBottom, nullptr,
KDDockWidgets::InitialOption(QSize(0, 300)));
KDDockWidgets::DockWidgetBase::Options options = {};
KDDockWidgets::DockWidgetOptions options = {};
if (parser.isSet(nestedDocking)) {
options |= KDDockWidgets::DockWidgetBase::Option_MDINestable;
options |= KDDockWidgets::DockWidgetOption_MDINestable;
}
// 4. Create our MDI widgets, which will go into the MDI area
auto mdiWidget1 = new KDDockWidgets::DockWidget(QStringLiteral("MDI widget1"), options);
auto mdiWidget1 =
new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MDI widget1"), options);
mdiWidget1->setWidget(new MyWidget1());
auto mdiWidget2 = new KDDockWidgets::DockWidget(QStringLiteral("MDI widget2"), options);
auto mdiWidget2 =
new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MDI widget2"), options);
mdiWidget2->setWidget(new MyWidget2());
auto mdiWidget3 = new KDDockWidgets::DockWidget(QStringLiteral("MDI widget3"), options);
auto widget3 = new MyWidget3();
mdiWidget3->setWidget(widget3);
auto mdiWidget3 =
new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MDI widget3"), options);
mdiWidget3->setWidget(new MyWidget3());
// Just for my personal testing: Overkill to add an option
// widget3->blockCloseEvent();
auto mdiArea = new KDDockWidgets::MDIArea();
auto mdiArea = new KDDockWidgets::Views::MDIArea_qtwidgets();
mainWindow.setPersistentCentralWidget(mdiArea);
mdiArea->addDockWidget(mdiWidget1, QPoint(10, 10));
mdiArea->addDockWidget(mdiWidget2, QPoint(50, 50));
mdiArea->addDockWidget(mdiWidget3, QPoint(110, 110));
return app.exec();
}

View File

@@ -10,26 +10,20 @@
#
cmake_minimum_required(VERSION 3.7)
project(kddockwidgets_minimal_example)
project(qtwidgets_minimal)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before
# if you want to look for a specific Qt version for instance.
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/../dockwidgets/resources_example.qrc)
add_executable(
kddockwidgets_minimal_example
${RESOURCES_EXAMPLE_SRC} ../dockwidgets/MyWidget.cpp main.cpp
)
add_executable(qtwidgets_minimal main.cpp MyWidget.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(
kddockwidgets_minimal_example
PRIVATE KDAB::kddockwidgets
)
target_link_libraries(qtwidgets_minimal PRIVATE KDAB::kddockwidgets)

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -61,8 +61,7 @@ void MyWidget::drawLogo(QPainter &p)
const int proposedHeight = int(maxWidth * ratio);
const int width = proposedHeight <= maxHeight ? maxWidth
: int(maxHeight / ratio);
const int width = proposedHeight <= maxHeight ? maxWidth : int(maxHeight / ratio);
const int height = int(width * ratio);
QRect targetLogoRect(0, 0, width, height);
@@ -71,7 +70,8 @@ void MyWidget::drawLogo(QPainter &p)
}
MyWidget1::MyWidget1(MyWidget::QWidget *parent)
: MyWidget(QStringLiteral(":/assets/triangles.png"), QStringLiteral(":/assets/KDAB_bubble_white.png"), parent)
: MyWidget(QStringLiteral(":/assets/triangles.png"),
QStringLiteral(":/assets/KDAB_bubble_white.png"), parent)
{
}
@@ -97,7 +97,8 @@ void MyWidget2::paintEvent(QPaintEvent *)
}
MyWidget3::MyWidget3(MyWidget::QWidget *parent)
: MyWidget(QStringLiteral(":/assets/base.png"), QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"), parent)
: MyWidget(QStringLiteral(":/assets/base.png"),
QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"), parent)
, m_triangle(QImage(QStringLiteral(":/assets/tri.png")))
{
}
@@ -109,7 +110,8 @@ void MyWidget3::paintEvent(QPaintEvent *)
p.drawImage(m_background.rect(), m_background, m_background.rect());
const QRect targetRect = QRect({ width() - m_triangle.width(), height() - m_triangle.height() }, m_triangle.size());
const QRect targetRect =
QRect({ width() - m_triangle.width(), height() - m_triangle.height() }, m_triangle.size());
p.drawImage(targetRect, m_triangle, m_triangle.rect());
drawLogo(p);

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -25,7 +25,8 @@ class MyWidget : public QWidget
Q_OBJECT
public:
MyWidget() = default;
explicit MyWidget(const QString &backgroundFile, const QString &logoFile, QWidget *parent = nullptr);
explicit MyWidget(const QString &backgroundFile, const QString &logoFile,
QWidget *parent = nullptr);
~MyWidget();
protected:

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -11,8 +11,8 @@
#include "MyWidget.h"
#include <kddockwidgets/DockWidget.h>
#include <kddockwidgets/MainWindow.h>
#include <kddockwidgets/DockWidget.h>
#include <QStyleFactory>
#include <QApplication>
@@ -28,41 +28,42 @@ int main(int argc, char **argv)
QApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);
#endif
QApplication app(argc, argv);
app.setOrganizationName(QStringLiteral("KDAB"));
app.setApplicationName(QStringLiteral("Test app"));
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtWidgets);
// Fusion looks better in general, but feel free to change
qApp->setStyle(QStyleFactory::create(QStringLiteral("Fusion")));
// # 1. Create our main window
KDDockWidgets::MainWindow mainWindow(QStringLiteral("MyMainWindow"));
KDDockWidgets::Views::MainWindow_qtwidgets mainWindow(QStringLiteral("MyMainWindow"));
mainWindow.setWindowTitle("Main Window");
mainWindow.resize(1200, 1200);
mainWindow.show();
// # 2. Create a dock widget, it needs a unique name
auto dock1 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock1"));
auto dock1 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock1"));
auto widget1 = new MyWidget();
dock1->setWidget(widget1);
auto dock2 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock2"));
auto dock2 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock2"));
auto widget2 = new MyWidget(QStringLiteral(":/assets/base.png"),
QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"));
dock2->setWidget(widget2);
auto dock3 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock3"));
auto dock3 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock3"));
auto widget3 = new MyWidget(QStringLiteral(":/assets/base.png"),
QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"));
dock3->setWidget(widget3);
auto dock4 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock4"));
auto dock4 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock4"));
auto widget4 = new MyWidget(QStringLiteral(":/assets/base.png"),
QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"));
dock4->setWidget(widget4);
auto dock5 = new KDDockWidgets::DockWidget(QStringLiteral("MyDock5"));
auto dock5 = new KDDockWidgets::Views::DockWidget_qtwidgets(QStringLiteral("MyDock5"));
auto widget5 = new MyWidget(QStringLiteral(":/assets/base.png"),
QStringLiteral(":/assets/KDAB_bubble_fulcolor.png"));
dock5->setWidget(widget5);
@@ -80,7 +81,7 @@ int main(int argc, char **argv)
// 5. dock5 will be its own top level (floating window)
dock5->show();
dock5->open();
return app.exec();
}

View File

@@ -8,10 +8,24 @@
# Contact KDAB at <info@kdab.com> for commercial licensing options.
#
add_subdirectory(customtitlebar)
add_subdirectory(dockwidgets)
add_subdirectory(mdi)
set_compiler_flags(qtquick_dockwidgets)
set_target_properties(
qtquick_dockwidgets PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/"
)
set_compiler_flags(kddockwidgets_example_quick)
set_compiler_flags(kddockwidgets_example_mdi_quick)
set_compiler_flags(kddockwidgets_customtitlebar_quick)
add_subdirectory(mdi)
set_compiler_flags(qtquick_mdi)
set_target_properties(qtquick_mdi PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/")
add_subdirectory(customtitlebar)
set_compiler_flags(qtquick_customtitlebar)
set_target_properties(
qtquick_customtitlebar PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/"
)
add_subdirectory(customtabbar)
set_compiler_flags(qtquick_customtabbar)
set_target_properties(
qtquick_customtabbar PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/examples/"
)

View File

@@ -0,0 +1,31 @@
#
# This file is part of KDDockWidgets.
#
# SPDX-FileCopyrightText: 2019-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
# Author: Sergio Martins <sergio.martins@kdab.com>
#
# SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
#
# Contact KDAB at <info@kdab.com> for commercial licensing options.
#
cmake_minimum_required(VERSION 3.7)
project(qtquick_customtabbar)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/resources_qtquick_example.qrc
${CMAKE_CURRENT_SOURCE_DIR}/../../dockwidgets/resources_example.qrc
)
add_executable(qtquick_customtabbar main.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(qtquick_customtabbar PRIVATE KDAB::kddockwidgets)

View File

@@ -0,0 +1,36 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
import QtQuick 2.9
Item {
anchors.fill: parent
property alias background: background.source
property alias logo: logo.source
Image {
id: background
anchors.fill: parent
fillMode: Image.PreserveAspectCrop
Image {
id: logo
fillMode: Image.PreserveAspectFit
anchors {
fill: parent
margins: 50
}
}
}
}

View File

@@ -9,4 +9,10 @@
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "../../DockWidgetBase.h"
import QtQuick 2.9
Guest {
anchors.fill: parent
background: "qrc:/assets/triangles.png"
logo: "qrc:/assets/KDAB_bubble_white.png"
}

View File

@@ -9,4 +9,9 @@
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "../../FrameworkWidgetFactory.h"
import QtQuick 2.9
Guest {
anchors.fill: parent
logo: "qrc:/assets/KDAB_bubble_blue.png"
}

View File

@@ -9,4 +9,10 @@
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "../../DockWidget.h"
import QtQuick 2.9
Guest {
anchors.fill: parent
background: "qrc:/assets/base.png"
logo: "qrc:/assets/KDAB_bubble_fulcolor.png"
}

View File

@@ -0,0 +1,95 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
import QtQuick 2.6
// Will be moved to a plugin in the future, if there's enough demand
import "qrc:/kddockwidgets/qtquick/views/qml/" as KDDW
/// Example of a QML Tab Bar that doesn't use QtQuick.Controls, just for demo purposes.
/// Se the comments named "#HERE#" for important things you shouldn't forget.
KDDW.TabBarBase {
id: root
implicitHeight: 30
currentTabIndex: 0
/// #HERE#. This function required in all derived tab bars. It's called by C++;
/// Returns the tab bar (QQuickItem*) at the specified index.
function getTabAtIndex(index) {
return tabBarRow.children[index];
}
/// #HERE#. This function required in all derived tab bars. It's called by C++;
/// Returns an int, with the index of the tab that's at the specified position.
function getTabIndexAtPosition(globalPoint) {
for (var i = 0; i < tabBarRow.children.length; ++i) {
var tab = tabBarRow.children[i];
var localPt = tab.mapFromGlobal(globalPoint.x, globalPoint.y);
if (tab.contains(localPt)) {
return i;
}
}
return -1;
}
Row {
id: tabBarRow
anchors.fill: parent
spacing: 2
/// Needed only if you want to style hovered tabs differently
property int hoveredIndex: -1;
/// ##HERE## The list of tabs is stored in a C++ model. This repeater populates our tab bar
Repeater {
model: root.groupCpp ? root.groupCpp.tabBar.dockWidgetModel : 0
Rectangle {
id: tab
height: parent.height
width: 100
color: (tabBarRow.hoveredIndex == index) ? "#ba7600" : "orange"
border.color: "black"
// ##HERE## Illustrating how to have a different style in case the tab is current
border.width: index == root.groupCpp.currentIndex ? 3 : 1
// ##HERE## The index of the tab. This is required in all custom tab bar implementations
// It is be used by "getTabAtIndex()" and "getTabIndexAtPosition()" functions
readonly property int tabIndex: index
Text {
anchors.centerIn: parent
text: title
}
/// ##HERE## Tells the C++ backend that the current tab should change
MouseArea {
anchors.fill: parent
onClicked: {
root.currentTabIndex = index;
}
}
}
}
Connections {
target: tabBarCpp
function onHoveredTabIndexChanged(index) {
tabBarRow.hoveredIndex = index;
}
}
}
}

View File

@@ -0,0 +1,74 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include <kddockwidgets/Config.h>
#include <kddockwidgets/views/DockWidget_qtquick.h>
#include <kddockwidgets/Platform_qtquick.h>
#include <kddockwidgets/ViewFactory_qtquick.h>
#include <kddockwidgets/private/DockRegistry.h>
#include <kddockwidgets/views/MainWindow_qtquick.h>
#include <QQuickView>
#include <QGuiApplication>
#include <QQmlApplicationEngine>
class CustomViewFactory : public KDDockWidgets::ViewFactory_qtquick
{
public:
~CustomViewFactory() override;
QUrl tabbarFilename() const override
{
return QUrl("qrc:/MyTabBar.qml");
}
};
CustomViewFactory::~CustomViewFactory() = default;
int main(int argc, char *argv[])
{
#ifdef Q_OS_WIN
QGuiApplication::setAttribute(Qt::AA_UseOpenGLES);
#endif
QGuiApplication app(argc, argv);
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtQuick);
auto &config = KDDockWidgets::Config::self();
auto flags = config.flags();
config.setFlags(flags);
config.setViewFactory(new CustomViewFactory());
QQmlApplicationEngine appEngine;
KDDockWidgets::Platform_qtquick::instance()->setQmlEngine(&appEngine);
appEngine.load((QUrl("qrc:/main.qml")));
auto dw1 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #1");
dw1->setGuestItem(QStringLiteral("qrc:/Guest1.qml"));
auto dw2 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #2");
dw2->setGuestItem(QStringLiteral("qrc:/Guest2.qml"));
auto dw3 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #3");
dw3->setGuestItem(QStringLiteral("qrc:/Guest3.qml"));
// Access the main area we created in QML with DockingArea {}
auto mainArea = KDDockWidgets::DockRegistry::self()->mainDockingAreas().constFirst();
mainArea->addDockWidget(dw1, KDDockWidgets::Location_OnTop);
dw1->addDockWidgetAsTab(dw2);
dw1->addDockWidgetAsTab(dw3);
return app.exec();
}

View File

@@ -0,0 +1,27 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
import QtQuick 2.6
import QtQuick.Controls 2.12
import com.kdab.dockwidgets 2.0 as KDDW
ApplicationWindow {
visible: true
width: 1000
height: 800
KDDW.DockingArea {
id: dockWidgetArea
anchors.fill: parent
uniqueName: "MyMainLayout"
}
}

View File

@@ -0,0 +1,10 @@
<RCC>
<qresource prefix="/">
<file>main.qml</file>
<file>Guest1.qml</file>
<file>Guest2.qml</file>
<file>Guest3.qml</file>
<file>Guest.qml</file>
<file>MyTabBar.qml</file>
</qresource>
</RCC>

View File

@@ -10,15 +10,15 @@
#
cmake_minimum_required(VERSION 3.7)
project(kddockwidgets_customtitlebar_quick)
project(qtquick_customtitlebar)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before
# if you want to look for a specific Qt version for instance.
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
@@ -26,12 +26,6 @@ set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/resources_qtquick_example.
${CMAKE_CURRENT_SOURCE_DIR}/../../dockwidgets/resources_example.qrc
)
add_executable(
kddockwidgets_customtitlebar_quick
${RESOURCES_EXAMPLE_SRC} main.cpp
)
add_executable(qtquick_customtitlebar main.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(
kddockwidgets_customtitlebar_quick
PRIVATE KDAB::kddockwidgets
)
target_link_libraries(qtquick_customtitlebar PRIVATE KDAB::kddockwidgets)

View File

@@ -10,27 +10,40 @@
*/
import QtQuick 2.9
import QtQuick.Controls 2.12
import QtQuick.Layouts 1.12
import QtQuick.Controls 1.5 as QQC1
import com.kdab.dockwidgets 2.0 as KDDW
Item {
anchors.fill: parent
property alias background: background.source
property alias logo: logo.source
property var background
property var logo
KDDW.LayoutSaver {
id: layoutSaver
}
Image {
id: background
anchors.fill: parent
fillMode: Image.PreserveAspectCrop
Rectangle {
anchors.fill: parent
color: "green"
Image {
id: logo
ColumnLayout {
Button {
text: "Save"
onClicked: {
layoutSaver.saveToFile ("/tmp/layout");
}
}
fillMode: Image.PreserveAspectFit
anchors {
fill: parent
margins: 50
}
}
}
Button {
text: "Restore"
onClicked: {
layoutSaver.restoreFromFile ("/tmp/layout");
}
}
}
}
}

View File

@@ -11,8 +11,8 @@
import QtQuick 2.6
// Will be moved to a plugin in the future
import "qrc:/kddockwidgets/private/quick/qml/" as KDDW
// Will be moved to a plugin in the future, if there's enough demand
import "qrc:/kddockwidgets/qtquick/views/qml/" as KDDW
KDDW.TitleBarBase {
id: root
@@ -32,6 +32,26 @@ KDDW.TitleBarBase {
}
}
Rectangle {
id: floatButton
visible: root.floatButtonVisible
radius: 5
color: "red"
height: root.height - 20
width: height
anchors {
right: closeButton.left
rightMargin: 10
verticalCenter: root.verticalCenter
}
MouseArea {
anchors.fill: parent
onClicked: {
root.floatButtonClicked();
}
}
}
Rectangle {
id: closeButton
enabled: root.closeButtonEnabled

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -11,18 +11,21 @@
#include <kddockwidgets/Config.h>
#include <kddockwidgets/DockWidgetQuick.h>
#include <kddockwidgets/private/DockRegistry_p.h>
#include <kddockwidgets/FrameworkWidgetFactory.h>
#include <kddockwidgets/views/DockWidget_qtquick.h>
#include <kddockwidgets/Platform_qtquick.h>
#include <kddockwidgets/ViewFactory_qtquick.h>
#include <kddockwidgets/private/DockRegistry.h>
#include <kddockwidgets/views/MainWindow_qtquick.h>
#include <QQuickView>
#include <QGuiApplication>
#include <QQmlApplicationEngine>
class CustomFrameworkWidgetFactory : public KDDockWidgets::DefaultWidgetFactory
class CustomViewFactory : public KDDockWidgets::ViewFactory_qtquick
{
public:
~CustomFrameworkWidgetFactory() override;
~CustomViewFactory() override;
QUrl titleBarFilename() const override
{
@@ -30,7 +33,7 @@ public:
}
};
CustomFrameworkWidgetFactory::~CustomFrameworkWidgetFactory() = default;
CustomViewFactory::~CustomViewFactory() = default;
int main(int argc, char *argv[])
{
@@ -38,34 +41,39 @@ int main(int argc, char *argv[])
QGuiApplication::setAttribute(Qt::AA_UseOpenGLES);
#endif
QGuiApplication app(argc, argv);
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtQuick);
auto &config = KDDockWidgets::Config::self();
auto flags = config.flags();
config.setFlags(flags);
config.setFrameworkWidgetFactory(new CustomFrameworkWidgetFactory());
config.setViewFactory(new CustomViewFactory());
QQmlApplicationEngine appEngine;
KDDockWidgets::Config::self().setQmlEngine(&appEngine);
KDDockWidgets::Platform_qtquick::instance()->setQmlEngine(&appEngine);
appEngine.load((QUrl("qrc:/main.qml")));
auto dw1 = new KDDockWidgets::DockWidgetQuick("Dock #1");
auto dw1 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #1");
dw1->setWidget(QStringLiteral("qrc:/Guest1.qml"));
dw1->setGuestItem(QStringLiteral("qrc:/Guest1.qml"));
dw1->resize(QSize(800, 800));
dw1->show();
// dw1->open();
auto dw2 = new KDDockWidgets::DockWidgetQuick("Dock #2");
dw2->setWidget(QStringLiteral("qrc:/Guest2.qml"));
auto dw2 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #2");
dw2->setGuestItem(QStringLiteral("qrc:/Guest2.qml"));
dw2->resize(QSize(800, 800));
dw2->show();
// dw2->open();
auto dw3 = new KDDockWidgets::DockWidgetQuick("Dock #3");
dw3->setWidget(QStringLiteral("qrc:/Guest3.qml"));
auto dw3 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #3");
dw3->setGuestItem(QStringLiteral("qrc:/Guest3.qml"));
dw1->addDockWidgetToContainingWindow(dw3, KDDockWidgets::Location_OnRight);
// dw1->addDockWidgetToContainingWindow(dw3, KDDockWidgets::Location_OnRight);
// Access the main area we created in QML with DockingArea {}
auto mainArea = KDDockWidgets::DockRegistry::self()->mainDockingAreas().constFirst();
mainArea->addDockWidget(dw1, KDDockWidgets::Location_OnTop);
mainArea->addDockWidget(dw2, KDDockWidgets::Location_OnTop);
mainArea->addDockWidget(dw3, KDDockWidgets::Location_OnTop);
KDDockWidgets::MainWindowBase *mainWindow = KDDockWidgets::DockRegistry::self()->mainwindows().constFirst();
mainWindow->addDockWidget(dw2, KDDockWidgets::Location_OnTop);
return app.exec();
}

View File

@@ -11,14 +11,14 @@
import QtQuick 2.6
import QtQuick.Controls 2.12
import com.kdab.dockwidgets 1.0 as KDDW
import com.kdab.dockwidgets 2.0 as KDDW
ApplicationWindow {
visible: true
width: 1000
height: 800
KDDW.MainWindowLayout {
KDDW.DockingArea {
id: dockWidgetArea
anchors.fill: parent

View File

@@ -10,15 +10,15 @@
#
cmake_minimum_required(VERSION 3.7)
project(kddockwidgets_example_quick)
project(qtquick_dockwidgets)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before
# if you want to look for a specific Qt version for instance.
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
@@ -26,12 +26,6 @@ set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/resources_qtquick_example.
${CMAKE_CURRENT_SOURCE_DIR}/../../dockwidgets/resources_example.qrc
)
add_executable(
kddockwidgets_example_quick
${RESOURCES_EXAMPLE_SRC} main.cpp
)
add_executable(qtquick_dockwidgets main.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(
kddockwidgets_example_quick
PRIVATE KDAB::kddockwidgets
)
target_link_libraries(qtquick_dockwidgets PRIVATE KDAB::kddockwidgets)

View File

@@ -10,7 +10,7 @@
*/
import QtQuick 2.9
import com.kdab.dockwidgets 1.0 as KDDW
import com.kdab.dockwidgets 2.0 as KDDW
Guest {
anchors.fill: parent

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -11,9 +11,11 @@
#include <kddockwidgets/Config.h>
#include <kddockwidgets/DockWidgetQuick.h>
#include <kddockwidgets/private/DockRegistry_p.h>
#include <kddockwidgets/FrameworkWidgetFactory.h>
#include <kddockwidgets/private/DockRegistry.h>
#include <kddockwidgets/ViewFactory.h>
#include <kddockwidgets/Platform_qtquick.h>
#include <kddockwidgets/views/DockWidget_qtquick.h>
#include "kddockwidgets/views/MainWindow_qtquick.h"
#include <QQmlApplicationEngine>
#include <QGuiApplication>
@@ -29,24 +31,45 @@ int main(int argc, char *argv[])
QGuiApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);
#endif
QGuiApplication app(argc, argv);
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtQuick);
QCommandLineParser parser;
parser.setApplicationDescription("KDDockWidgets example application");
parser.addHelpOption();
QCommandLineOption noTitleBars(
"t", QCoreApplication::translate("main", "Hide titlebars when tabs are visible"));
parser.addOption(noTitleBars);
QCommandLineOption alwaysTabs(
"z", QCoreApplication::translate("main", "Show tabs even if there's only one"));
parser.addOption(alwaysTabs);
#ifdef Q_OS_WIN
QCommandLineOption nativeTitleBar(
"native-title-bar",
QCoreApplication::translate("main", "(internal) FloatingWindows a native title bar"));
parser.addOption(nativeTitleBar);
#endif
#if defined(DOCKS_DEVELOPER_MODE)
QCommandLineOption noQtTool("no-qttool", QCoreApplication::translate("main", "(internal) Don't use Qt::Tool"));
QCommandLineOption noParentForFloating("no-parent-for-floating", QCoreApplication::translate("main", "(internal) FloatingWindows won't have a parent"));
QCommandLineOption nativeTitleBar("native-title-bar", QCoreApplication::translate("main", "(internal) FloatingWindows a native title bar"));
QCommandLineOption noDropIndicators("no-drop-indicators", QCoreApplication::translate("main", "(internal) Don't use any drop indicators"));
QCommandLineOption noQtTool(
"no-qttool", QCoreApplication::translate("main", "(internal) Don't use Qt::Tool"));
QCommandLineOption noParentForFloating(
"no-parent-for-floating",
QCoreApplication::translate("main", "(internal) FloatingWindows won't have a parent"));
QCommandLineOption noDropIndicators(
"no-drop-indicators",
QCoreApplication::translate("main", "(internal) Don't use any drop indicators"));
parser.addOption(noQtTool);
parser.addOption(noParentForFloating);
parser.addOption(nativeTitleBar);
parser.addOption(noDropIndicators);
#if defined(Q_OS_WIN)
QCommandLineOption noAeroSnap("no-aero-snap", QCoreApplication::translate("main", "(internal) Disable AeroSnap"));
QCommandLineOption noAeroSnap(
"no-aero-snap", QCoreApplication::translate("main", "(internal) Disable AeroSnap"));
parser.addOption(noAeroSnap);
#endif
#endif
@@ -63,10 +86,8 @@ int main(int argc, char *argv[])
if (parser.isSet(noParentForFloating))
internalFlags |= KDDockWidgets::Config::InternalFlag_DontUseParentForFloatingWindows;
if (parser.isSet(nativeTitleBar))
flags |= KDDockWidgets::Config::Flag_NativeTitleBar;
else if (parser.isSet(noDropIndicators))
KDDockWidgets::DefaultWidgetFactory::s_dropIndicatorType = KDDockWidgets::DropIndicatorType::None;
if (parser.isSet(noDropIndicators))
KDDockWidgets::ViewFactory::s_dropIndicatorType = KDDockWidgets::DropIndicatorType::None;
#if defined(Q_OS_WIN)
if (parser.isSet(noAeroSnap))
@@ -77,35 +98,48 @@ int main(int argc, char *argv[])
KDDockWidgets::Config::self().setInternalFlags(internalFlags);
#endif
#if defined(Q_OS_WIN)
// On Linux the title bar doesn't send us NonClient mouse events
if (parser.isSet(nativeTitleBar))
flags |= KDDockWidgets::Config::Flag_NativeTitleBar;
#endif
if (parser.isSet(noTitleBars))
flags |= KDDockWidgets::Config::Flag_HideTitleBarWhenTabsVisible;
if (parser.isSet(alwaysTabs))
flags |= KDDockWidgets::Config::Flag_AlwaysShowTabs;
// Set any required flags. The defaults are usually fine.
KDDockWidgets::Config::self().setFlags(flags);
// Create your engine which loads main.qml. A simple QQuickView would work too.
QQmlApplicationEngine appEngine;
KDDockWidgets::Config::self().setQmlEngine(&appEngine);
KDDockWidgets::Platform_qtquick::instance()->setQmlEngine(&appEngine);
appEngine.load((QUrl("qrc:/main.qml")));
// Below we illustrate usage of our C++ API. Alternative you can use declarative API.
// See main.qml for examples of dockwidgets created directly in QML
auto dw1 = new KDDockWidgets::DockWidgetQuick("Dock #1");
auto dw1 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #1");
dw1->setWidget(QStringLiteral("qrc:/Guest1.qml"));
dw1->setGuestItem(QStringLiteral("qrc:/Guest1.qml"));
dw1->resize(QSize(800, 800));
dw1->show();
dw1->open();
auto dw2 = new KDDockWidgets::DockWidgetQuick("Dock #2");
dw2->setWidget(QStringLiteral("qrc:/Guest2.qml"));
auto dw2 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #2");
dw2->setGuestItem(QStringLiteral("qrc:/Guest2.qml"));
dw2->resize(QSize(800, 800));
dw2->show();
dw2->open();
auto dw3 = new KDDockWidgets::DockWidgetQuick("Dock #3");
dw3->setWidget(QStringLiteral("qrc:/Guest3.qml"));
auto dw3 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #3");
dw3->setGuestItem(QStringLiteral("qrc:/Guest3.qml"));
dw1->addDockWidgetToContainingWindow(dw3, KDDockWidgets::Location_OnRight);
KDDockWidgets::MainWindowBase *mainWindow = KDDockWidgets::DockRegistry::self()->mainwindows().constFirst();
mainWindow->addDockWidget(dw2, KDDockWidgets::Location_OnTop);
// Access the main area we created in QML with DockingArea {}
auto mainArea = KDDockWidgets::DockRegistry::self()->mainDockingAreas().constFirst();
mainArea->addDockWidget(dw2, KDDockWidgets::Location_OnTop);
return app.exec();
}

View File

@@ -11,7 +11,7 @@
import QtQuick 2.6
import QtQuick.Controls 2.12
import com.kdab.dockwidgets 1.0 as KDDW
import com.kdab.dockwidgets 2.0 as KDDW
ApplicationWindow {
visible: true
@@ -73,7 +73,7 @@ ApplicationWindow {
}
}
KDDW.MainWindowLayout {
KDDW.DockingArea {
anchors.fill: parent
// Each main layout needs a unique id
@@ -109,6 +109,13 @@ ApplicationWindow {
color: "black"
}
}
KDDW.DockWidget {
id: dock7
uniqueName: "dock7"
Rectangle {
color: "green"
}
}
Component.onCompleted: {
// Add dock4 to the Bottom location
@@ -122,6 +129,10 @@ ApplicationWindow {
// See MainWindowInstantiator_p.h for the API
addDockWidget(dock6, KDDW.KDDockWidgets.Location_OnLeft, null,
Qt.size(500, 100), KDDW.KDDockWidgets.StartHidden);
// dock7 will be tabbed with dock7:
dock5.addDockWidgetAsTab(dock7);
}
}

View File

@@ -10,15 +10,15 @@
#
cmake_minimum_required(VERSION 3.7)
project(kddockwidgets_example_mdi_quick)
project(qtquick_mdi)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_INCLUDE_CURRENT_DIRS ON)
if(NOT TARGET kddockwidgets)
# This will look for Qt, do find_package yourself manually before
# if you want to look for a specific Qt version for instance.
# This will look for Qt, do find_package yourself manually before if you want
# to look for a specific Qt version for instance.
find_package(KDDockWidgets REQUIRED)
endif()
@@ -26,12 +26,6 @@ set(RESOURCES_EXAMPLE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/resources_qtquick_mdi_exam
${CMAKE_CURRENT_SOURCE_DIR}/../../dockwidgets/resources_example.qrc
)
add_executable(
kddockwidgets_example_mdi_quick
${RESOURCES_EXAMPLE_SRC} main.cpp
)
add_executable(qtquick_mdi main.cpp ${RESOURCES_EXAMPLE_SRC})
target_link_libraries(
kddockwidgets_example_mdi_quick
PRIVATE KDAB::kddockwidgets
)
target_link_libraries(qtquick_mdi PRIVATE KDAB::kddockwidgets)

View File

@@ -11,7 +11,7 @@
import QtQuick 2.9
import QtQuick.Controls 2.12
import com.kdab.dockwidgets 1.0 as KDDW
import com.kdab.dockwidgets 2.0 as KDDW
Guest {
anchors.fill: parent

View File

@@ -1,8 +1,8 @@
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-FileCopyrightText: 2020-2022 Klarälvdalens Datakonsult AB, a KDAB Group company
<info@kdab.com> Author: Sergio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
@@ -11,49 +11,53 @@
#include <kddockwidgets/Config.h>
#include <kddockwidgets/DockWidgetQuick.h>
#include <kddockwidgets/private/DockRegistry_p.h>
#include <kddockwidgets/FrameworkWidgetFactory.h>
#include <kddockwidgets/MainWindowMDI.h>
#include <kddockwidgets/views/DockWidget_qtquick.h>
#include <kddockwidgets/views/MainWindowMDI_qtquick.h>
#include <kddockwidgets/Platform_qtquick.h>
#include <kddockwidgets/private/DockRegistry.h>
#include <kddockwidgets/ViewFactory.h>
#include "kddockwidgets/controllers/MainWindow.h"
#include <QQmlApplicationEngine>
#include <QGuiApplication>
#include <QCommandLineParser>
// Foro my own debugging, until we have better API
#include "../../src/private/MDILayoutWidget_p.h"
int main(int argc, char *argv[])
{
#ifdef Q_OS_WIN
QGuiApplication::setAttribute(Qt::AA_UseOpenGLES);
#endif
QGuiApplication app(argc, argv);
KDDockWidgets::initFrontend(KDDockWidgets::FrontendType::QtQuick);
QCommandLineParser parser;
parser.setApplicationDescription("KDDockWidgets example application");
parser.addHelpOption();
QQmlApplicationEngine appEngine;
KDDockWidgets::Config::self().setQmlEngine(&appEngine);
KDDockWidgets::Platform_qtquick::instance()->setQmlEngine(&appEngine);
appEngine.load((QUrl("qrc:/main.qml")));
auto dw1 = new KDDockWidgets::DockWidgetQuick("Dock #1");
dw1->setWidget(QStringLiteral("qrc:/Guest1.qml"));
auto dw1 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #1");
dw1->setGuestItem(QStringLiteral("qrc:/Guest1.qml"));
dw1->resize(QSize(400, 400));
auto dw2 = new KDDockWidgets::DockWidgetQuick("Dock #2");
dw2->setWidget(QStringLiteral("qrc:/Guest2.qml"));
auto dw2 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #2");
dw2->setGuestItem(QStringLiteral("qrc:/Guest2.qml"));
dw2->resize(QSize(400, 400));
auto dw3 = new KDDockWidgets::DockWidgetQuick("Dock #3");
dw3->setWidget(QStringLiteral("qrc:/Guest3.qml"));
auto dw3 = new KDDockWidgets::Views::DockWidget_qtquick("Dock #3");
dw3->setGuestItem(QStringLiteral("qrc:/Guest3.qml"));
auto mainWindow = static_cast<KDDockWidgets::MainWindowMDI *>(KDDockWidgets::DockRegistry::self()->mainwindows().constFirst());
mainWindow->addDockWidget(dw1, QPoint(10, 10));
mainWindow->addDockWidget(dw2, QPoint(50, 50));
mainWindow->addDockWidget(dw3, QPoint(90, 90));
// See main.qml for how to add dock widgets from QML.
// Here's a low level C++ example just for educational purposes:
auto mainAreaView = KDDockWidgets::DockRegistry::self()->mainDockingAreas().constFirst();
auto mainAreaMDI = static_cast<KDDockWidgets::Views::MainWindowMDI_qtquick *>(mainAreaView);
mainAreaMDI->addDockWidget(dw1, QPoint(10, 10));
mainAreaMDI->addDockWidget(dw2, QPoint(50, 50));
mainAreaMDI->addDockWidget(dw3, QPoint(90, 90));
return app.exec();
}

View File

@@ -11,16 +11,29 @@
import QtQuick 2.6
import QtQuick.Controls 2.12
import com.kdab.dockwidgets 1.0 as KDDW
import com.kdab.dockwidgets 2.0 as KDDW
ApplicationWindow {
visible: true
width: 1000
height: 1200
KDDW.MainWindowLayout {
KDDW.MDIDockingArea {
id: dockingArea
anchors.fill: parent
uniqueName: "MyMainLayout"
options: KDDW.KDDockWidgets.MainWindowOption_MDI
}
KDDW.DockWidget {
id: greenDock
uniqueName: "greenDock"
Rectangle {
color: "green"
anchors.fill: parent
}
}
Component.onCompleted: {
dockingArea.addDockWidget(greenDock, Qt.point(200, 200));
}
}

8
mkdocs.yml Normal file
View File

@@ -0,0 +1,8 @@
site_name: KDDockWidgets
site_url: https://github.com/KDAB/KDDockWidgets/
docs_dir: docs_devel
nav:
- Home: index.md
- Concepts: concepts.md
- About: about.md
theme: readthedocs

View File

@@ -11,10 +11,10 @@
set(PYTHON_BINDING_NAMESPACE "PyKDDockWidgets")
# Just to fix warnings with --warn-uninitialized
if(NOT DEFINED SHIBOKEN_CUSTOM_PREFIX) #look for shiboken in a custom location
if(NOT DEFINED SHIBOKEN_CUSTOM_PREFIX) # look for shiboken in a custom location
set(SHIBOKEN_CUSTOM_PREFIX "")
endif()
if(NOT DEFINED PYSIDE_CUSTOM_PREFIX) #look for pyside in a custom location
if(NOT DEFINED PYSIDE_CUSTOM_PREFIX) # look for pyside in a custom location
set(PYSIDE_CUSTOM_PREFIX "")
endif()
@@ -34,11 +34,11 @@ find_package(PySide${PYSIDE_MAJOR_VERSION} ${QtWidgets_VERSION} EXACT REQUIRED)
if(NOT ${PROJECT_NAME}_PYTHON_BINDINGS_INSTALL_PREFIX)
set(${PROJECT_NAME}_PYTHON_BINDINGS_INSTALL_PREFIX "${CMAKE_INSTALL_PREFIX}")
endif()
set(Python3_VERSION_MAJORMINOR "${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}")
set(Python3_VERSION_MAJORMIONR "${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}")
set(BINDINGS_DIR "${INSTALL_LIBRARY_DIR}/python${Python3_VERSION_MAJORMINOR}/site-packages/${PYTHON_BINDING_NAMESPACE}")
set(${PROJECT_NAME}_PYTHON_BINDINGS_INSTALL_PREFIX "${${PROJECT_NAME}_PYTHON_BINDINGS_INSTALL_PREFIX}/${BINDINGS_DIR}")
include(KDPySide${PYSIDE_MAJOR_VERSION}ModuleBuild)
include(PySide${PYSIDE_MAJOR_VERSION}ModuleBuild)
add_subdirectory(PyKDDockWidgets)
if(${PROJECT_NAME}_TESTS)
add_subdirectory(tests)

View File

@@ -35,29 +35,23 @@ set(PyKDDockWidgets_include_paths
)
# A list of paths where shiboken should look for typesystem
set(PyKDDockWidgets_typesystem_paths # PySide path, this variable was exposed by FindPySide2.cmake
set(PyKDDockWidgets_typesystem_paths # PySide path, this variable was exposed by
# FindPySide2.cmake
${PYSIDE_TYPESYSTEMS}
)
# Include flags/path that will be set in 'target_include_directories'
set(PyKDDockWidgets_target_include_directories ${CMAKE_SOURCE_DIR}/src)
# Libraries that will be necessary to link the target, this will used in the command 'target_link_libraries'
set(PyKDDockWidgets_target_link_libraries
KDAB::kddockwidgets
Qt${Qt_VERSION_MAJOR}::Core
Qt${Qt_VERSION_MAJOR}::Gui
Qt${Qt_VERSION_MAJOR}::Widgets
${Python3_LIBRARIES}
# Libraries that will be necessary to link the target, this will used in the
# command 'target_link_libraries'
set(PyKDDockWidgets_target_link_libraries KDAB::kddockwidgets Qt${Qt_VERSION_MAJOR}::Core Qt${Qt_VERSION_MAJOR}::Gui
Qt${Qt_VERSION_MAJOR}::Widgets ${Python3_LIBRARIES}
)
# changes on these files should trigger a new generation
set(PyKDDockWidgets_DEPENDS
${CMAKE_CURRENT_SOURCE_DIR}/kddockwidgets_global.h
${CMAKE_SOURCE_DIR}/src/DockWidgetBase.h
${CMAKE_SOURCE_DIR}/src/DockWidget.h
${CMAKE_SOURCE_DIR}/src/MainWindowBase.h
${CMAKE_SOURCE_DIR}/src/MainWindow.h
${CMAKE_CURRENT_SOURCE_DIR}/kddockwidgets_global.h ${CMAKE_SOURCE_DIR}/src/DockWidget.h
${CMAKE_SOURCE_DIR}/src/DockWidget.h ${CMAKE_SOURCE_DIR}/src/MainWindow.h ${CMAKE_SOURCE_DIR}/src/MainWindow.h
${CMAKE_SOURCE_DIR}/src/LayoutSaver.h
)
@@ -78,9 +72,8 @@ create_python_bindings(
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/__init__.py.cmake ${CMAKE_CURRENT_BINARY_DIR}/__init__.py @ONLY)
# install
install(
FILES ${CMAKE_CURRENT_BINARY_DIR}/__init__.py $<TARGET_FILE:KDAB::kddockwidgets>
DESTINATION ${${PROJECT_NAME}_PYTHON_BINDINGS_INSTALL_PREFIX}
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/__init__.py $<TARGET_FILE:KDAB::kddockwidgets>
DESTINATION ${${PROJECT_NAME}_PYTHON_BINDINGS_INSTALL_PREFIX}
)
if(NOT WIN32)
install(FILES $<TARGET_LINKER_FILE:KDAB::kddockwidgets> $<TARGET_SONAME_FILE:KDAB::kddockwidgets>

View File

@@ -21,8 +21,8 @@
#define QT_WIDGETS_LIB
#endif
#include <kddockwidgets/MainWindowBase.h>
#include <kddockwidgets/MainWindow.h>
#include <kddockwidgets/DockWidgetBase.h>
#include <kddockwidgets/MainWindow.h>
#include <kddockwidgets/DockWidget.h>
#include <kddockwidgets/DockWidget.h>
#include <kddockwidgets/LayoutSaver.h>

View File

@@ -14,7 +14,7 @@
<namespace-type name="KDDockWidgets" visible="no">
<!-- this is used in a public virtual pure function we need to declare it
otherwise shiboken will ignore the function and will fail to create a wrapper -->
<primitive-type name="DropAreaWithCentralFrame"/>
<primitive-type name="DropArea"/>
<primitive-type name="SideBar"/>
<!-- Some plublic enum and flags -->

21
src/3rdparty/doctest/LICENSE.txt vendored Normal file
View File

@@ -0,0 +1,21 @@
The MIT License (MIT)
Copyright (c) 2016-2021 Viktor Kirilov
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

6816
src/3rdparty/doctest/doctest.h vendored Normal file

File diff suppressed because it is too large Load Diff

298
src/3rdparty/kdbindings/binding.h vendored Normal file
View File

@@ -0,0 +1,298 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kdbindings/node.h>
#include <kdbindings/node_operators.h>
#include <kdbindings/node_functions.h>
#include <kdbindings/make_node.h>
#include <kdbindings/binding_evaluator.h>
#include <kdbindings/property_updater.h>
namespace KDBindings {
/**
* @brief A combination of a root Node with an evaluator.
*
* A root Node is formed whenever multiple properties are combined inside
* a expression and an evaluator is responsible for re-evaluating such
* an expression whenever any of the constituent properties change.
*
* @tparam T The type of the value that the Binding expression evaluates to.
* @tparam EvaluatorT The type of the evaluator that is used to evaluate the Binding.
*/
template<typename T, typename EvaluatorT = BindingEvaluator>
class Binding : public PropertyUpdater<T>, public Private::Dirtyable
{
static_assert(
std::is_base_of<BindingEvaluator, EvaluatorT>::value,
"The EvaluatorT type must inherit from BindingEvaluator.");
public:
/**
* @brief Construct a new Binding with a specific evaluator.
*
* @param rootNode Represents that expression contained in the Binding.
* @param evaluator Used to evaluate the expression contained in the Binding.
*/
explicit Binding(Private::Node<T> &&rootNode, EvaluatorT const &evaluator)
: m_rootNode{ std::move(rootNode) }
, m_evaluator{ evaluator }
{
m_bindingId = m_evaluator.insert(this);
m_rootNode.setParent(this);
}
/** Destructs the Binding by deregistering it from its evaluator. */
~Binding() override
{
m_evaluator.remove(m_bindingId);
}
/** A Binding is not default constructible. */
Binding() = delete;
/** A Binding cannot be copy constructed. */
Binding(Binding const &other) = delete;
/** A Binding cannot be copy assigned. */
Binding &operator=(Binding const &other) = delete;
// Move construction would invalidate the this pointer passed to the evaluator
// in the constructor
/** A Binding can not be move constructed. */
Binding(Binding &&other) = delete;
/** A Binding can not be move assigned. */
Binding &operator=(Binding &&other) = delete;
/** Set the function that should be used to notify
* associated properties when the Binding re-evaluates.
*/
void setUpdateFunction(std::function<void(T &&)> const &updateFunction) override
{
m_propertyUpdateFunction = updateFunction;
}
/** Returns the current value of the Binding. */
T get() const override { return m_rootNode.evaluate(); }
/** Re-evaluates the value of the Binding and notifies all dependants of the change. */
void evaluate()
{
T value = m_rootNode.evaluate();
// Use this to update any associated property via the PropertyUpdater's update function
m_propertyUpdateFunction(std::move(value));
}
protected:
Private::Dirtyable **parentVariable() override { return nullptr; }
const bool *dirtyVariable() const override { return nullptr; }
/** The root Node of the Binding represents the expression contained by the Binding. */
Private::Node<T> m_rootNode;
/** The evaluator responsible for evaluating this Binding. */
EvaluatorT m_evaluator;
/** The function used to notify associated properties when the Binding re-evaluates */
std::function<void(T &&)> m_propertyUpdateFunction = [](T &&) {};
/** The id of the Binding, used for keeping track of the Binding in its evaluator. */
int m_bindingId = -1;
};
/**
* @brief Helper function to create a Binding from a Property.
*
* @tparam T The type of the value that the Binding expression evaluates to.
* @tparam EvaluatorT The type of the evaluator that is used to evaluate the Binding.
* @param evaluator The evaluator that is used to evaluate the Binding.
* @param property The Property to create a Binding from.
* @return std::unique_ptr<Binding<T, EvaluatorT>> A new Binding that is powered by the evaluator.
*
* *Note: For the difference between makeBinding and makeBoundProperty, see the
* ["Reassigning a Binding"](../../getting-started/data-binding/#reassigning-a-binding) section in the Getting Started guide.*
*/
template<typename T, typename EvaluatorT>
inline std::unique_ptr<Binding<T, EvaluatorT>> makeBinding(EvaluatorT &evaluator, Property<T> &property)
{
return std::make_unique<Binding<T, EvaluatorT>>(Private::makeNode(property), evaluator);
}
/**
* @brief Helper function to create a Binding from a root Node.
*
* @tparam T The type of the value that the Binding expression evaluates to.
* @tparam EvaluatorT The type of the evaluator that is used to evaluate the Binding.
* @param evaluator The evaluator that is used to evaluate the Binding.
* @param rootNode Represents the expression that will be evaluated by the Binding.
* @return std::unique_ptr<Binding<T, EvaluatorT>> A new Binding that combines the rootNode with the evaluator.
*
* *Note: For the difference between makeBinding and makeBoundProperty, see the
* ["Reassigning a Binding"](../../getting-started/data-binding/#reassigning-a-binding) section in the Getting Started guide.*
*/
template<typename T, typename EvaluatorT>
inline std::unique_ptr<Binding<T, EvaluatorT>> makeBinding(EvaluatorT &evaluator, Private::Node<T> &&rootNode)
{
return std::make_unique<Binding<T, EvaluatorT>>(std::move(rootNode), evaluator);
}
/**
* @brief Helper function to create a Binding from a function and its arguments.
*
* @tparam EvaluatorT The type of the evaluator that is used to evaluate the Binding.
* @param evaluator The evaluator that is used to evaluate the Binding.
* @tparam Func The type of the function - may be any type that implements operator().
* @param func The function object.
* @tparam Args The function argument types
* @param args The function arguments - Possible values include: Properties, Constants and Nodes
* They will be automatically unwrapped, i.e. a Property<T> will pass a value of type T to func.
* @return std::unique_ptr<Binding<ReturnType, EvaluatorT>> where ReturnType is the type that results from evaluationg func with the given arguments.
* The Binding will be powered by the new evaluator.
*
* *Note: For the difference between makeBinding and makeBoundProperty, see the
* ["Reassigning a Binding"](../../getting-started/data-binding/#reassigning-a-binding) section in the Getting Started guide.*
*/
template<typename EvaluatorT, typename Func, typename... Args, typename = std::enable_if_t<sizeof...(Args) != 0>, typename ResultType = Private::operator_node_result_t<Func, Args...>>
inline std::unique_ptr<Binding<ResultType, EvaluatorT>> makeBinding(EvaluatorT &evaluator, Func &&func, Args &&...args)
{
return std::make_unique<Binding<ResultType, EvaluatorT>>(Private::makeNode(std::forward<Func>(func), std::forward<Args>(args)...), evaluator);
}
/**
* @brief Provides a convenience for old-school, immediate mode Bindings.
*
* This works in conjunction with a do-nothing ImmediateBindingEvaluator class to update the
* result of the Binding immediately upon any of the dependent bindables (i.e. Property instances)
* notifying that they have changed. This can lead to a Property Binding being evaluated many
* times before the result is ever used in a typical GUI application.
*
* @tparam T The type of the value that the Binding expression evaluates to.
*/
template<typename T>
class Binding<T, ImmediateBindingEvaluator> : public Binding<T, BindingEvaluator>
{
public:
/**
* @brief Construct a new Binding with an immediate mode evaluator.
*
* @param rootNode Represents that expression contained in the Binding.
*/
explicit Binding(Private::Node<T> &&rootNode)
: Binding<T, BindingEvaluator>(std::move(rootNode), ImmediateBindingEvaluator::instance())
{
}
/** A Binding is not default constructible. */
Binding() = delete;
virtual ~Binding() = default;
/** A Binding cannot be copy constructed. */
Binding(Binding const &other) = delete;
/** A Binding cannot be copy assigned. */
Binding &operator=(Binding const &other) = delete;
/** A Binding can not be move constructed. */
Binding(Binding &&other) = delete;
/** A Binding can not be move assigned. */
Binding &operator=(Binding &&other) = delete;
void markDirty() override
{
Binding::evaluate();
}
};
/**
* @brief Helper function to create an immediate mode Binding from a Property.
*
* @tparam T The type of the value that the Binding expression evaluates to.
* @param property The Property to create a Binding from.
* @return std::unique_ptr<Binding<T, ImmediateBindingEvaluator>>
* An new Binding bound to an existing Property with immediate evaluation.
*
* *Note: For the difference between makeBinding and makeBoundProperty, see the
* ["Reassigning a Binding"](../../getting-started/data-binding/#reassigning-a-binding) section in the Getting Started guide.*
*/
template<typename T>
inline std::unique_ptr<Binding<T, ImmediateBindingEvaluator>> makeBinding(Property<T> &property)
{
return std::make_unique<Binding<T, ImmediateBindingEvaluator>>(Private::makeNode(property));
}
/**
* @brief Helper function to create an immediate mode Binding from a root Node.
*
* @tparam T The type of the value that the Binding expression evaluates to.
* @param rootNode Represents the expression that will be evaluated by the Binding.
* Typically constructed from a unary/binary operator on a Property.
* @return std::unique_ptr<Binding<<T, ImmediateBindingEvaluator>> An new Binding bound to a root Node with immediate evaluation.
*
* *Note: For the difference between makeBinding and makeBoundProperty, see the
* ["Reassigning a Binding"](../../getting-started/data-binding/#reassigning-a-binding) section in the Getting Started guide.*
*/
template<typename T>
inline std::unique_ptr<Binding<T, ImmediateBindingEvaluator>> makeBinding(Private::Node<T> &&rootNode)
{
return std::make_unique<Binding<T, ImmediateBindingEvaluator>>(std::move(rootNode));
}
/**
* @brief Helper function to create an immediate mode Binding from a function and its arguments.
*
* @tparam Func The type of the function - may be any type that implements operator().
* @param func The function object.
* @tparam Args The function argument types
* @param args The function arguments - Possible values include: Properties, Constants and Nodes
* They will be automatically unwrapped, i.e. a Property<T> will pass a value of type T to func.
* @return std::unique_ptr<Binding<ReturnType, ImmediateBindingEvaluator>> where ReturnType is the type that results from evaluationg func with the given arguments.
* The Binding will feature immediate evaluation.
*
* *Note: For the difference between makeBinding and makeBoundProperty, see the
* ["Reassigning a Binding"](../../getting-started/data-binding/#reassigning-a-binding) section in the Getting Started guide.*
*/
template<typename Func, typename... Args, typename = std::enable_if_t<sizeof...(Args) != 0>, typename ResultType = Private::operator_node_result_t<Func, Args...>>
inline std::unique_ptr<Binding<ResultType, ImmediateBindingEvaluator>> makeBinding(Func &&func, Args &&...args)
{
return std::make_unique<Binding<ResultType, ImmediateBindingEvaluator>>(Private::makeNode(std::forward<Func>(func), std::forward<Args>(args)...));
}
/**
* @brief Helper function to create a Property with a Binding.
*
* This function can take:
* - Another Property.
* - A Node, typically created by combining Property instances using operators.
* - A function with arguments (Nodes, Constants or Properties)
* By default this will construct a Property with an immediate binding evaluation.
*
* Alternatively a BindingEvaluator can be passed as the first argument to this function to control
* when evaluation takes place.
*
* See the documentation for the various overloads of the free @ref makeBinding function for a
* detailed description of which arguments can be used in which order.
*
* Examples:
* - @ref 05-property-bindings/main.cpp
* - @ref 06-lazy-property-bindings/main.cpp
*
* @return Property A new Property that is bound to the inputs
*
* *Note: For the difference between makeBinding and makeBoundProperty, see the
* ["Reassigning a Binding"](../../getting-started/data-binding/#reassigning-a-binding) section in the Getting Started guide.*
*/
template<typename... T>
inline auto makeBoundProperty(T &&...args)
{
auto binding = makeBinding(std::forward<T>(args)...);
return Property<decltype(binding->get())>(std::move(binding));
}
} // namespace KDBindings

View File

@@ -0,0 +1,162 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <functional>
#include <map>
#include <memory>
namespace KDBindings {
/**
* @brief A BindingEvaluator provides a mechanism to control the exact time
* when a KDBindings::Binding is reevaluated.
*
* A BindingEvaluator represents a collection of Binding instances that can be
* selectively reevaluated.
*
* If a Binding is created using KDBindings::makeBoundProperty with a BindingEvaluator,
* the Binding will only be evaluated if BindingEvaluator::evaluateAll is called
* on the given evaluator.
*
* Note that instances of BindingEvaluator internally wrap their collection of
* Bindings in such a way that copying a BindingEvaluator does not actually
* copy the collection of Bindings. Therefore adding a Binding to a copy of a
* BindingEvaluator will also add it to the original.
* This is done for ease of use, so evaluators can be passed around easily throughout
* the codebase.
*
* Examples:
* - @ref 06-lazy-property-bindings/main.cpp
*/
class BindingEvaluator
{
// We use pimpl here so that we can pass evaluators around by value (copies)
// yet each copy refers to the same set of data
struct Private {
// TODO: Use std::vector here?
std::map<int, std::function<void()>> m_bindingEvalFunctions;
int m_currentId;
};
public:
/** A BindingEvaluator can be default constructed */
BindingEvaluator() = default;
/**
* A BindingEvaluator can be copy constructed.
*
* Note that copying the evaluator will NOT create a new collection of
* Binding instances, but the new evaluator will refer to the same collection,
* so creating a new Binding with this evaluator will also modify the previous one.
*/
BindingEvaluator(const BindingEvaluator &) noexcept = default;
/**
* A BindingEvaluator can be copy assigned.
*
* Note that copying the evaluator will NOT create a new collection of
* Binding instances, but the new evaluator will refer to the same collection,
* so creating a new Binding with this evaluator will also modify the previous one.
*/
BindingEvaluator &operator=(const BindingEvaluator &) noexcept = default;
/**
* A BindingEvaluator can not be move constructed.
*/
BindingEvaluator(BindingEvaluator &&other) noexcept = delete;
/**
* A BindingEvaluator can not be move assigned.
*/
BindingEvaluator &operator=(BindingEvaluator &&other) noexcept = delete;
/**
* This function evaluates all Binding instances that were constructed with this
* evaluator, in the order they were inserted.
*
* It will therefore update the associated Property instances as well.
*/
void evaluateAll() const
{
// a std::map's ordering is deterministic, so the bindings are evaluated
// in the order they were inserted, ensuring correct transitive dependency
// evaluation.
for (auto &[id, func] : m_d->m_bindingEvalFunctions)
func();
}
private:
template<typename BindingType>
int insert(BindingType *binding)
{
m_d->m_bindingEvalFunctions.insert({ ++(m_d->m_currentId),
[=]() { binding->evaluate(); } });
return m_d->m_currentId;
}
void remove(int id)
{
m_d->m_bindingEvalFunctions.erase(id);
}
std::shared_ptr<Private> m_d{ std::make_shared<Private>() };
template<typename T, typename UpdaterT>
friend class Binding;
};
/**
* This subclass of BindingEvaluator doesn't do anything special on its own.
* It is used together with a template specialization of Binding to provide
* old-school, immediate mode Bindings.
*
* Any Binding that is constructed with an ImmediateBindingEvaluator will not wait
* for the evaluator to call evaluateAll, but rather evaluate the Binding immediately
* when any of its bindables (i.e. Property instances) change.
* This can lead to a Property Binding being evaluated many
* times before the result is ever used in a typical GUI application.
*/
class ImmediateBindingEvaluator final : public BindingEvaluator
{
public:
static inline ImmediateBindingEvaluator instance()
{
static ImmediateBindingEvaluator evaluator;
return evaluator;
}
};
} // namespace KDBindings
/**
* @example 06-lazy-property-bindings/main.cpp
*
* An example of how to use KDBindings::BindingEvaluator together
* with a KDBindings::Property to create a Property binding that is
* only reevaluated on demand.
*
* The output of this example is:
* ```
* The initial size of the image = 1920000 bytes
* The new size of the image = 8294400 bytes
* ```
*
* Note the difference to @ref 05-property-bindings/main.cpp, where the
* new size of the image is calculated twice.
*
* This feature is especially useful to reduce the performance impact of
* bindings and to create bindings that only update in specific intervals.
* <br/><!-- This <br/> is a workaround for a bug in doxybook2 that causes
* the rendering of the example code to break because it is missing a
* newline-->
*/

207
src/3rdparty/kdbindings/genindex_array.h vendored Normal file
View File

@@ -0,0 +1,207 @@
/*
This code has been adapted from MIT licensed code, originally by Jeremy burns and available at
https://gist.github.com/jaburns/ca72487198832f6203e831133ffdfff4.
The original license is provided below:
Copyright 2021 Jeremy Burns
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files
(the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge,
publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR
IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
#pragma once
#include <functional>
#include <vector>
#include <cstdint>
#include <optional>
#include <cassert>
#include <limits>
#include <stdexcept>
#include <string>
namespace KDBindings {
namespace Private {
struct GenerationalIndex {
uint32_t index = 0;
uint32_t generation = 0;
};
class GenerationalIndexAllocator
{
struct AllocatorEntry {
bool isLive = false;
uint32_t generation = 0;
};
std::vector<AllocatorEntry> m_entries;
std::vector<uint32_t> m_freeIndices;
public:
GenerationalIndex allocate()
{
if (m_freeIndices.size() > 0) {
uint32_t index = m_freeIndices.back();
m_freeIndices.pop_back();
m_entries[index].generation += 1;
m_entries[index].isLive = true;
return { index, m_entries[index].generation };
} else {
// check that we are still within the bounds of uint32_t
if (m_entries.size() + 1 >= std::numeric_limits<uint32_t>::max()) {
throw std::length_error(std::string("Maximum number of values inside GenerationalIndexArray reached: ") + std::to_string(m_entries.size()));
}
m_entries.push_back({ true, 0 });
return { static_cast<uint32_t>(m_entries.size()) - 1, 0 };
}
}
bool deallocate(GenerationalIndex index)
{
if (isLive(index)) {
m_entries[index.index].isLive = false;
m_freeIndices.emplace_back(index.index);
return true;
}
return false;
}
bool isLive(GenerationalIndex index) const noexcept
{
return index.index < m_entries.size() &&
m_entries[index.index].generation == index.generation &&
m_entries[index.index].isLive;
}
};
// A GenerationalIndexArray stores elements in contiguous memory just like an std::vector
// and also allows items to be retrieved in constant time through indexed access, but it keeps
// track of the "version"/generation of values at indices so that it can inform an accessor
// when the item at the index it is trying to access is no longer the item that it wants.
template<typename T>
class GenerationalIndexArray
{
struct Entry {
uint32_t generation;
T value;
};
// TODO: m_entries never shrinks after an entry has been deleted, it might be
// a good idea to add a "trim" function at some point if this becomes an issue
std::vector<std::optional<Entry>> m_entries;
GenerationalIndexAllocator m_allocator;
public:
// Sets the value at a specific index inside the array
void set(const GenerationalIndex index, T &&value)
{
while (m_entries.size() <= index.index)
m_entries.emplace_back(std::nullopt);
#ifndef NDEBUG
uint32_t previousGeneration = 0;
const auto &previousEntry = m_entries[index.index];
if (previousEntry)
previousGeneration = previousEntry->generation;
assert(index.generation >= previousGeneration);
#endif
m_entries[index.index] = std::optional<Entry>{ { index.generation, std::move(value) } };
}
// Insert a value at the first free index and get the index back
GenerationalIndex insert(T &&value)
{
const auto index = m_allocator.allocate();
set(index, std::move(value));
return index;
}
// Erase the value at the specified index and free up the index again
void erase(GenerationalIndex index)
{
if (m_allocator.deallocate(index))
m_entries[index.index] = std::nullopt;
}
// Get a pointer to the value at the specified index
T *get(GenerationalIndex index)
{
if (index.index >= m_entries.size())
return nullptr;
auto &entry = m_entries[index.index];
if (entry && entry->generation == index.generation) {
return &entry->value;
}
return nullptr;
}
// Get a const pointer to the value at the specified index
const T *get(GenerationalIndex index) const noexcept
{
return const_cast<const T *>(const_cast<GenerationalIndexArray *>(this)->get(index));
}
// Erase all the values in the array and thus free up all indices too
void clear()
{
const auto numEntries = entriesSize();
for (auto i = decltype(numEntries){ 0 }; i < numEntries; ++i) {
const auto index = indexAtEntry(i);
if (index != std::nullopt)
erase(*index);
}
}
// The number entries currently in the array, not all necessarily correspond to valid indices,
// use "indexAtEntry" to translate from an entry index to a optional GenerationalIndex
uint32_t entriesSize() const noexcept
{
// this cast is safe because the allocator checks that we never exceed the capacity of uint32_t
return static_cast<uint32_t>(m_entries.size());
}
// Convert an entry index into a GenerationalIndex, if possible otherwise returns nullopt
std::optional<GenerationalIndex> indexAtEntry(uint32_t entryIndex) const
{
if (entryIndex >= entriesSize())
return std::nullopt;
const auto &entry = m_entries[entryIndex];
if (!entry)
return std::nullopt;
GenerationalIndex index = { entryIndex, entry->generation };
if (m_allocator.isLive(index))
return index;
return std::nullopt;
}
};
} //namespace Private
} // namespace KDBindings

95
src/3rdparty/kdbindings/make_node.h vendored Normal file
View File

@@ -0,0 +1,95 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kdbindings/node.h>
#include <type_traits>
namespace KDBindings {
namespace Private {
template<typename T>
struct bindable_value_type_ {
using type = T;
};
template<typename T>
struct bindable_value_type_<Property<T>> {
using type = T;
};
template<typename T>
struct bindable_value_type_<NodeInterface<T>> {
using type = T;
};
template<typename T>
struct bindable_value_type_<Node<T>> {
using type = T;
};
template<typename T>
struct bindable_value_type : bindable_value_type_<std::decay_t<T>> {
};
template<typename T>
using bindable_value_type_t = typename bindable_value_type<T>::type;
// Find the type of a Node wrapping an operator and arguments
template<typename Operator, typename... Ts>
using operator_node_result =
std::decay<
std::invoke_result_t<
std::decay_t<Operator>,
bindable_value_type_t<Ts>...>>;
template<typename Operator, typename... Ts>
using operator_node_result_t = typename operator_node_result<Operator, Ts...>::type;
// Node creation helpers
template<typename T>
inline Node<std::decay_t<T>> makeNode(T &&value)
{
return Node<std::decay_t<T>>(std::make_unique<ConstantNode<std::decay_t<T>>>(std::move(value)));
}
template<typename T>
inline Node<T> makeNode(Property<T> &property)
{
return Node<T>(std::make_unique<PropertyNode<T>>(property));
}
template<typename T>
inline Node<T> makeNode(Node<T> &&node)
{
return std::move(node);
}
template<typename Operator, typename... Ts, typename = std::enable_if_t<sizeof...(Ts) >= 1>, typename ResultType = operator_node_result_t<Operator, Ts...>>
inline Node<ResultType> makeNode(Operator &&op, Ts &&...args)
{
return Node<ResultType>(std::make_unique<OperatorNode<ResultType, std::decay_t<Operator>, bindable_value_type_t<Ts>...>>(
std::forward<Operator>(op),
makeNode(std::forward<Ts>(args))...));
}
// Needed by function and operator helpers
template<typename T>
struct is_bindable : std::integral_constant<
bool,
is_property<T>::value || is_node<T>::value> {
};
} // namespace Private
} // namespace KDBindings

313
src/3rdparty/kdbindings/node.h vendored Normal file
View File

@@ -0,0 +1,313 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kdbindings/property.h>
#include <kdbindings/signal.h>
#include <functional>
#include <memory>
#include <stdexcept>
#include <type_traits>
#include <utility>
namespace KDBindings {
/**
* @brief A PropertyDestroyedError is thrown whenever a binding is evaluated
* that references a property that no longer exists.
*/
class PropertyDestroyedError : public std::runtime_error
{
public:
PropertyDestroyedError() = delete;
using std::runtime_error::runtime_error;
};
namespace Private {
class Dirtyable
{
public:
virtual ~Dirtyable() = default;
Dirtyable() = default;
void setParent(Dirtyable *newParent)
{
auto **parentVar = parentVariable();
if (parentVar) {
*parentVar = newParent;
}
}
// overridden by Binding
virtual void markDirty()
{
auto *dirtyVar = dirtyVariable();
if (dirtyVar) {
if (*dirtyVar) {
return;
// We are already dirty, don't bother marking the whole tree again.
}
// we only want to have one override for dirtyVariable,
// which is const, so we have to const cast here.
*const_cast<bool *>(dirtyVar) = true;
}
auto **parentVar = parentVariable();
if (parentVar && *parentVar) {
(*parentVar)->markDirty();
}
}
bool isDirty() const
{
auto *dirtyVar = dirtyVariable();
return dirtyVar && *dirtyVar;
}
protected:
virtual Dirtyable **parentVariable() = 0;
virtual const bool *dirtyVariable() const = 0;
};
template<typename ResultType>
class NodeInterface : public Dirtyable
{
public:
// Returns a reference, because we cache each evaluated value.
// const, because it shouldn't modify the return value of the AST.
// Requires mutable caches
virtual const ResultType &evaluate() const = 0;
protected:
NodeInterface() = default;
};
template<typename ResultType>
class Node
{
public:
Node(std::unique_ptr<NodeInterface<ResultType>> &&interface)
: m_interface(std::move(interface))
{
}
const ResultType &evaluate() const
{
return m_interface->evaluate();
}
void setParent(Dirtyable *newParent)
{
m_interface->setParent(newParent);
}
bool isDirty() const
{
return m_interface->isDirty();
}
private:
std::unique_ptr<NodeInterface<ResultType>> m_interface;
};
template<typename T>
class ConstantNode : public NodeInterface<T>
{
public:
explicit ConstantNode(const T &value)
: m_value{ value }
{
}
const T &evaluate() const override
{
return m_value;
}
protected:
// A constant can never be dirty, so it doesn't need to
// know its parent, as it doesn't have to notify it.
Dirtyable **parentVariable() override { return nullptr; }
const bool *dirtyVariable() const override { return nullptr; }
private:
T m_value;
};
template<typename PropertyType>
class PropertyNode : public NodeInterface<PropertyType>
{
public:
explicit PropertyNode(Property<PropertyType> &property)
: m_parent(nullptr), m_dirty(false)
{
setProperty(property);
}
// PropertyNodes cannot be moved
PropertyNode(PropertyNode<PropertyType> &&) = delete;
PropertyNode(const PropertyNode<PropertyType> &other)
: Dirtyable(other.isDirty())
{
setProperty(*other.m_property);
}
virtual ~PropertyNode()
{
m_valueChangedHandle.disconnect();
m_movedHandle.disconnect();
m_destroyedHandle.disconnect();
}
const PropertyType &evaluate() const override
{
if (!m_property) {
throw PropertyDestroyedError("The Property this node refers to no longer exists!");
}
m_dirty = false;
return m_property->get();
}
// This must currently take a const reference, as the "moved" signal emits a const&
void propertyMoved(Property<PropertyType> &property)
{
if (&property != m_property) {
m_property = &property;
} else {
// Another property was moved into the property this node refers to.
// Therefore it will no longer update this Node.
m_property = nullptr;
}
}
void propertyDestroyed()
{
m_property = nullptr;
}
protected:
Dirtyable **parentVariable() override { return &m_parent; }
const bool *dirtyVariable() const override { return &m_dirty; }
private:
void setProperty(Property<PropertyType> &property)
{
m_property = &property;
m_valueChangedHandle = m_property->valueChanged().connect(&PropertyNode<PropertyType>::markDirty, this);
m_movedHandle = m_property->moved().connect(&PropertyNode<PropertyType>::propertyMoved, this);
m_destroyedHandle = m_property->destroyed().connect(&PropertyNode<PropertyType>::propertyDestroyed, this);
}
Property<PropertyType> *m_property;
ConnectionHandle m_movedHandle;
ConnectionHandle m_valueChangedHandle;
ConnectionHandle m_destroyedHandle;
Dirtyable *m_parent;
mutable bool m_dirty;
};
template<typename ResultType, typename Operator, typename... Ts>
class OperatorNode : public NodeInterface<ResultType>
{
public:
// add another typename template for the Operator type, so
// it can be a universal reference.
template<typename Op>
explicit OperatorNode(Op &&op, Node<Ts> &&...arguments)
: m_parent{ nullptr }, m_dirty{ true /*dirty until reevaluated*/ }, m_op{ std::move(op) }, m_values{ std::move(arguments)... }, m_result(reevaluate())
{
static_assert(
std::is_convertible_v<decltype(m_op(std::declval<Ts>()...)), ResultType>,
"The result of the Operator must be convertible to the ReturnType of the Node");
setParents<0>();
}
template<std::size_t I>
auto setParents() -> std::enable_if_t<I == sizeof...(Ts)>
{
}
// The enable_if_t confuses clang-format into thinking the
// first "<" is a comparison, and not the second.
// clang-format off
template<std::size_t I>
auto setParents() -> std::enable_if_t<I < sizeof...(Ts)>
// clang-format on
{
std::get<I>(m_values).setParent(this);
setParents<I + 1>();
}
virtual ~OperatorNode() = default;
const ResultType &evaluate() const override
{
if (Dirtyable::isDirty()) {
m_result = reevaluate();
}
return m_result;
}
protected:
Dirtyable **parentVariable() override { return &m_parent; }
const bool *dirtyVariable() const override { return &m_dirty; }
private:
template<std::size_t... Is>
ResultType reevaluate_helper(std::index_sequence<Is...>) const
{
return m_op(std::get<Is>(m_values).evaluate()...);
}
ResultType reevaluate() const
{
m_dirty = false;
return reevaluate_helper(std::make_index_sequence<sizeof...(Ts)>());
}
Dirtyable *m_parent;
mutable bool m_dirty;
Operator m_op;
std::tuple<Node<Ts>...> m_values;
// Note: it is important that m_result is evaluated last!
// Otherwise the call to reevaluate in the constructor will fail.
mutable ResultType m_result;
};
template<typename T>
struct is_node_helper : std::false_type {
};
template<typename T>
struct is_node_helper<Node<T>> : std::true_type {
};
template<typename T>
struct is_node : is_node_helper<T> {
};
} // namespace Private
} // namespace KDBindings

149
src/3rdparty/kdbindings/node_functions.h vendored Normal file
View File

@@ -0,0 +1,149 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kdbindings/make_node.h>
#include <cmath>
namespace KDBindings {
namespace Private {
template<typename... Ts>
struct any_bindables;
// Check to see if a single type is a bindable (node or property)
template<typename T>
struct any_bindables<T> : is_bindable<T> {
};
// Check the head of the typelist and recurse
template<typename HEAD, typename... Ts>
struct any_bindables<HEAD, Ts...> : std::integral_constant<
bool,
any_bindables<HEAD>::value || any_bindables<Ts...>::value> {
};
} // namespace Private
/**
* @brief KDBINDINGS_DECLARE_FUNCTION is a helper macro to declare and define functions for use in data binding.
*
* This macro can take any callable object or function reference and create a new function that may be used
* in data binding expressions.
* The result function that can be called with a Property or the result of a data binding expression
* to create another data binding expression.
*
* Note that if a function is overloaded, it is impossible to reference all of its overloads at once.
* Therefore we recommend declaring a struct with a templated operator() to use as the function object.
* See the KDBindings::node_abs struct for an example of how to do this.
*
* @param NAME The name of the function to generate.
* @param FUNC The function to wrap.
*/
#define KDBINDINGS_DECLARE_FUNCTION(NAME, FUNC) \
template<typename... Ts> \
inline auto NAME(Ts &&...args)->std::enable_if_t<KDBindings::Private::any_bindables<Ts...>::value, KDBindings::Private::Node<KDBindings::Private::operator_node_result_t<decltype(FUNC), Ts...>>> \
{ \
return Private::makeNode(FUNC, std::forward<Ts>(args)...); \
}
/**
* @brief An example struct that is used with a call to KDBINDINGS_DECLARE_FUNCTION to declare all overloads
* of std::abs as usable in data binding.
*
* Because of the way node_abs overloads its operator(), it can be used in a call to KDBINDINGS_DECLARE_FUNCTION like this:
* @code
* KDBINDINGS_DECLARE_FUNCTION(abs, node_abs{})
* @endcode
*
* To generate such a struct for another function, use the KDBINDINGS_DECLARE_FUNCTION_OBJECT macro.
*/
struct node_abs {
/**
* @brief The operator() is overloaded so the struct can be used as a function object.
*
* Because this operator is templated, a single instance of node_abs
* can refer to all overloads of std::abs.
*/
template<typename... Ts>
auto operator()(Ts &&...x) const
{
return std::abs(std::forward<Ts>(x)...);
}
};
KDBINDINGS_DECLARE_FUNCTION(abs, node_abs{})
/**
* @brief This macro declares a callable struct that wraps a function with all
* its overloads.
*
* The declared struct can be used as the FUNCTION argument to
* KDBINDINGS_DECLARE_FUNCTION(NAME, FUNCTION) to pass a function with
* all its overloads to the macro.
*
* See the KDBindings::node_abs struct for an example of what this macro would generate.
*
* @param NAME The name of the resulting struct.
* @param FUNCTION The function to wrap.
*/
#define KDBINDINGS_DECLARE_FUNCTION_OBJECT(NAME, FUNCTION) \
struct NAME { \
template<typename... Ts> \
auto operator()(Ts &&...x) const \
{ \
return FUNCTION(std::forward<Ts>(x)...); \
} \
};
/**
* @brief This macro allows you to declare any function in a non-nested namespace
* as available in the context of data binding.
*
* @param NAMESPACE the name of the namespace the function is in.
* @param NAME the name of the function to wrap.
*
* In comparison to KDBINDINGS_DECLARE_FUNCTION(NAME, FUNC), this macro will generate a
* helper struct using #KDBINDINGS_DECLARE_FUNCTION_OBJECT, so all overloads of the function are
* made available at once.
*
* #KDBINDINGS_DECLARE_STD_FUNCTION is basically just a call to this macro with
* the NAMESPACE parameter set to `std`.
*/
#define KDBINDINGS_DECLARE_NAMESPACED_FUNCTION(NAMESPACE, NAME) \
KDBINDINGS_DECLARE_FUNCTION_OBJECT(node_##NAMESPACE_##NAME, NAMESPACE::NAME) \
KDBINDINGS_DECLARE_FUNCTION(NAME, node_##NAMESPACE_##NAME{})
/**
* @brief This macro is based on KDBINDINGS_DECLARE_NAMESPACED_FUNCTION(NAMESPACE, FUNC)
* to make it easier to declare any standard library function as available for data binding.
*
* It uses #KDBINDINGS_DECLARE_NAMESPACED_FUNCTION and can therefore make all overloads
* of the `std::` function available at once.
*
* @param NAME The name of the function in the `std::` namespace.
*/
#define KDBINDINGS_DECLARE_STD_FUNCTION(NAME) \
KDBINDINGS_DECLARE_NAMESPACED_FUNCTION(std, NAME)
// Define some common and useful functions
KDBINDINGS_DECLARE_STD_FUNCTION(floor)
KDBINDINGS_DECLARE_STD_FUNCTION(ceil)
KDBINDINGS_DECLARE_STD_FUNCTION(sin)
KDBINDINGS_DECLARE_STD_FUNCTION(cos)
KDBINDINGS_DECLARE_STD_FUNCTION(tan)
KDBINDINGS_DECLARE_STD_FUNCTION(asin)
KDBINDINGS_DECLARE_STD_FUNCTION(acos)
KDBINDINGS_DECLARE_STD_FUNCTION(atan)
} // namespace KDBindings

135
src/3rdparty/kdbindings/node_operators.h vendored Normal file
View File

@@ -0,0 +1,135 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kdbindings/node.h>
#include <kdbindings/make_node.h>
namespace KDBindings {
// Helper macro to declare free standing unary operators for Property and Node
#define KDBINDINGS_DEFINE_UNARY_OP(OP) \
template<typename... T> \
inline auto operator OP(Property<T...> &arg) noexcept(noexcept(OP arg.get())) \
->Private::Node<std::decay_t<decltype(OP arg.get())>> \
{ \
return Private::makeNode([](auto &&v) { return (OP v); }, arg); \
} \
\
template<typename T> \
inline auto operator OP(Private::Node<T> &&arg) noexcept(noexcept(OP arg.evaluate())) \
->Private::Node<std::decay_t<decltype(OP arg.evaluate())>> \
{ \
return Private::makeNode([](auto &&v) { return (OP v); }, std::move(arg)); \
}
KDBINDINGS_DEFINE_UNARY_OP(!)
KDBINDINGS_DEFINE_UNARY_OP(~) // Bitwise not
KDBINDINGS_DEFINE_UNARY_OP(+)
KDBINDINGS_DEFINE_UNARY_OP(-)
// Helper macro to declare free standing binary operators for Property and Node.
// The combinations we need are:
//
// operator op (Property<A> &a, B&& b) [Property, value]
// operator op (A&& a, Property<B> &b) [value, Property]
// operator op (Property<A> &a, Property<B> &b) [Property, Property]
//
// operator op (Node<A>&& a, B&& b) [Node value]
// operator op (A&& a, Node<B>&& b) [value, Node]
// operator op (Node<A>&& a, Node<B>&& b) [Node, Node]
//
// operator op (Property<A> &a, Node<B>&& b) [Property, Node]
// operaotr op (Node<A>&& a, Property<B> &b) [Node, Property]
#define KDBINDINGS_DEFINE_BINARY_OP(OP) \
template<typename B, typename... A> \
inline auto operator OP(Property<A...> &a, B &&b) noexcept(noexcept(a.get() OP b)) \
->std::enable_if_t<!Private::is_bindable<B>::value, \
Private::Node<decltype(a.get() OP b)>> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, a, std::forward<B>(b)); \
} \
\
template<typename A, typename... B> \
inline auto operator OP(A &&a, Property<B...> &b) noexcept(noexcept(a OP b.get())) \
->std::enable_if_t<!Private::is_bindable<A>::value, \
Private::Node<decltype(a OP b.get())>> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, std::forward<A>(a), b); \
} \
\
template<typename A, typename B> \
inline auto operator OP(Property<A> &a, Property<B> &b) noexcept(noexcept(a.get() OP b.get())) \
->Private::Node<decltype(a.get() OP b.get())> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, a, b); \
} \
\
template<typename A, typename B> \
inline auto operator OP(Private::Node<A> &&a, B &&b) noexcept(noexcept(a.evaluate() OP b)) \
->std::enable_if_t<!Private::is_bindable<B>::value, \
Private::Node<decltype(a.evaluate() OP b)>> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, std::move(a), std::forward<B>(b)); \
} \
\
template<typename A, typename B> \
inline auto operator OP(A &&a, Private::Node<B> &&b) noexcept(noexcept(a OP b.evaluate())) \
->std::enable_if_t<!Private::is_bindable<A>::value, \
Private::Node<decltype(a OP b.evaluate())>> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, std::forward<A>(a), std::move(b)); \
} \
\
template<typename A, typename B> \
inline auto operator OP(Private::Node<A> &&a, Private::Node<B> &&b) noexcept(noexcept(a.evaluate() OP b.evaluate())) \
->Private::Node<decltype(a.evaluate() OP b.evaluate())> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, std::move(a), std::move(b)); \
} \
\
template<typename B, typename A> \
inline auto operator OP(Property<A> &a, Private::Node<B> &&b) noexcept(noexcept(a.get() OP b.evaluate())) \
->Private::Node<decltype(a.get() OP b.evaluate())> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, a, std::move(b)); \
} \
\
template<typename A, typename B> \
inline auto operator OP(Private::Node<A> &&a, Property<B> &b) noexcept(noexcept(a.evaluate() OP b.get())) \
->Private::Node<decltype(a.evaluate() OP b.get())> \
{ \
return Private::makeNode([](auto &&av, auto &&bv) { return (av OP bv); }, std::move(a), b); \
}
KDBINDINGS_DEFINE_BINARY_OP(*)
KDBINDINGS_DEFINE_BINARY_OP(/)
KDBINDINGS_DEFINE_BINARY_OP(%)
KDBINDINGS_DEFINE_BINARY_OP(+)
KDBINDINGS_DEFINE_BINARY_OP(-)
KDBINDINGS_DEFINE_BINARY_OP(<<)
KDBINDINGS_DEFINE_BINARY_OP(>>)
KDBINDINGS_DEFINE_BINARY_OP(<)
KDBINDINGS_DEFINE_BINARY_OP(<=)
KDBINDINGS_DEFINE_BINARY_OP(>)
KDBINDINGS_DEFINE_BINARY_OP(>=)
KDBINDINGS_DEFINE_BINARY_OP(==)
KDBINDINGS_DEFINE_BINARY_OP(!=)
KDBINDINGS_DEFINE_BINARY_OP(&)
KDBINDINGS_DEFINE_BINARY_OP(^)
KDBINDINGS_DEFINE_BINARY_OP(|)
KDBINDINGS_DEFINE_BINARY_OP(&&)
KDBINDINGS_DEFINE_BINARY_OP(||)
} // namespace KDBindings

446
src/3rdparty/kdbindings/property.h vendored Normal file
View File

@@ -0,0 +1,446 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <kdbindings/property_updater.h>
#include <kdbindings/signal.h>
#include <iostream>
#include <memory>
#include <type_traits>
namespace KDBindings {
/**
* @brief A namespace containing parts of KDBindings that are not part of the public API.
*
* The contents of this namespace may only be accessed by the implementation of KDBindings, they
* are not part of KDBindings public API and may be altered at any time and provide no guarantees
* of any kind when used directly.
**/
namespace Private {
template<typename X, typename Y, typename = void>
struct are_equality_comparable : std::false_type {
};
template<typename X, typename Y>
struct are_equality_comparable<X, Y,
std::enable_if_t<
std::is_same<
std::decay_t<
decltype(std::equal_to<>{}(std::declval<X>(), std::declval<Y>()))>,
bool>::value>> : std::true_type {
};
template<typename X, typename Y>
constexpr bool are_equality_comparable_v = are_equality_comparable<X, Y>::value;
} // namespace Private
/**
* A ReadOnlyProperty is thrown when trying to set the value of a Property
* that has a PropertyUpdater associated with it.
*
* Most commonly because the property holds the result of a binding expression.
*/
struct ReadOnlyProperty : std::runtime_error {
ReadOnlyProperty() = delete;
using std::runtime_error::runtime_error;
};
/**
* @brief An instance of the KDBindings::equal_to struct is used to decide whether
* two values of type T are equal in the context of data binding.
*
* If a new value is assigned to a Property and the existing value is equal_to
* the existing value, the Property will not emit the Property::valueChanged or
* Property::valueAboutToChange signals and not change the stored value.
*
* By default, all classes T that are equality comparable using std::equal_to
* delegate to std::equal_to for equality comparison. All other instances are
* assumed to never be equal.
* Therefore, to change the equality behavior of a Property<T>, either:
* - Implement operator== for T (std::equal_to uses operator== for equality comparison)
* - Provide a template spezialization of KDBindings::equal_to and implement operator()()
*/
template<typename T>
struct equal_to {
/**
* This implementation of operator()() is only enabled if std::equal_to can be
* used to compare values of type T.
* In this case, std::equal_to is used to decide whether values of type T are equal.
*
* @return bool - Whether the values are equal.
*/
auto operator()(const T &x, const T &y) const noexcept
-> std::enable_if_t<Private::are_equality_comparable_v<T, T>, bool>
{
return std::equal_to<>{}(x, y);
}
/**
* The fallback implementation of operator()() if the types are not equality comparable
* using std::equal_to (i.e. no operator== implementation exists for this type).
* In this case, two values of type T are assumed to never be equal.
*
* @return bool - Whether the values are equal - always false for this default implementation
*/
template<typename X, typename Y>
auto operator()(const X &, const Y &) const noexcept
-> std::enable_if_t<!Private::are_equality_comparable_v<X, Y>, bool>
{
return false;
}
};
/**
* @brief A property represents a value that can be part of or the result of data binding.
*
* Properties are at the basis of data binding.
* They can contain a value of any type T.
* The value can either represent the result of a data binding or a value that is used
* in the calculation of a binding expression.
*
* If the value of a property is changed, either manually or because it is the result of a
* binding expression, the Property will emit the valueAboutToChange(), and valueChanged() Signal.
* If it is used as part of a binding expression, the expression will be marked
* as dirty and (unless a custom BindingEvaluator is used) updated immediately.
*
* To create a property from a data binding expression, use the @ref makeBoundProperty or @ref makeBinding
* functions in the @ref KDBindings namespace.
*
* Examples:
* - @ref 04-simple-property/main.cpp
* - @ref 05-property-bindings/main.cpp
* - @ref 06-lazy-property-bindings/main.cpp
*/
template<typename T>
class Property
{
public:
typedef T valuetype;
/**
* Properties are default constructable.
*
* The value of a default constructed property is then also default constructed.
*/
Property() = default;
/**
* If a Property is destroyed, it emits the destroyed() Signal.
*/
~Property()
{
m_destroyed.emit();
}
/**
* Constructs a Property from the provided value.
*/
explicit Property(T value) noexcept(std::is_nothrow_move_constructible<T>::value)
: m_value{ std::move(value) }
{
}
/**
* Properties are not copyable.
*/
Property(Property<T> const &other) = delete;
Property &operator=(Property<T> const &other) = delete;
/**
* @brief Properties are movable.
*
* This will emit the moved() Signal of the property that is moving as well as
* the property being moved into.
* All data bindings that depend on this Property will update their references
* to the newly move-constructed Property using this Signal.
*/
Property(Property<T> &&other) noexcept(std::is_nothrow_move_constructible<T>::value)
: m_value(std::move(other.m_value))
, m_valueAboutToChange(std::move(other.m_valueAboutToChange))
, m_valueChanged(std::move(other.m_valueChanged))
, m_destroyed(std::move(other.m_destroyed))
, m_updater(std::move(other.m_updater))
{
// We do not move the m_moved signal so that objects interested in the moved-into
// property can recreate any connections they need.
// If we have an updater, let it know how to update our internal value
if (m_updater) {
using namespace std::placeholders;
m_updater->setUpdateFunction(
std::bind(&Property<T>::setHelper, this, _1));
}
// Emit the moved signals for the moved from and moved to properties
m_moved.emit(*this);
other.m_moved.emit(*this);
m_moved = std::move(other.m_moved);
}
/**
* See: Property(Property<T> &&other)
*/
Property &operator=(Property<T> &&other) noexcept(std::is_nothrow_move_assignable<T>::value)
{
// We do not move the m_moved signal so that objects interested in the moved-into
// property can recreate any connections they need.
m_value = std::move(other.m_value);
m_valueAboutToChange = std::move(other.m_valueAboutToChange);
m_valueChanged = std::move(other.m_valueChanged);
m_destroyed = std::move(other.m_destroyed);
m_updater = std::move(other.m_updater);
// If we have an updater, let it know how to update our internal value
if (m_updater) {
using namespace std::placeholders;
m_updater->setUpdateFunction(
std::bind(&Property<T>::setHelper, this, _1));
}
// Emit the moved signals for the moved from and moved to properties
m_moved.emit(*this);
other.m_moved.emit(*this);
m_moved = std::move(other.m_moved);
return *this;
}
/**
* Construct a property that will be updated by the specified PropertyUpdater.
*
* This constructor is usually called by the creation of a data binding
* and usually doesn't need to be called manually.
*/
template<typename UpdaterT>
explicit Property(std::unique_ptr<UpdaterT> &&updater)
{
*this = std::move(updater);
}
/**
* Assigns a Binding or other Updater to this Property.
*
* In comparison to the move assignment operator, this does NOT change any
* of the existing Signal connections. They are all kept as-is.
* Only the source of the update is changed.
*
* This will immediately set the value of this Property to the
* result of the updater and will call the valueAboutToChange or valueChanged
* Signals respectively if necessary.
*/
template<typename UpdaterT>
Property &operator=(std::unique_ptr<UpdaterT> &&updater)
{
m_updater = std::move(updater);
// Let the updater know how to update our internal value
using namespace std::placeholders;
m_updater->setUpdateFunction(
std::bind(&Property<T>::setHelper, this, _1));
// Now synchronise our value with whatever the updator has right now.
setHelper(m_updater->get());
return *this;
}
/**
* @brief Disconnects the binding from this Property
*
* If this Property has a binding, it will no longer update it.
* Otherwise, this function does nothing.
*
* The value of the property does not change when it is reset.
*/
void reset()
{
m_updater.reset();
}
/**
* Returns a Signal that will be emitted before the value is changed.
*
* The first emitted value is the current value of the Property.<br>
* The second emitted value is the new value of the Property.
*/
Signal<const T &, const T &> &valueAboutToChange() const { return m_valueAboutToChange; }
/**
* Returns a Signal that will be emitted after the value of the property changed.
*
* The emitted value is the current (new) value of the Property.
*/
Signal<const T &> &valueChanged() const { return m_valueChanged; }
/**
* Returns a Signal that will be emitted when the Property is moved.
*
* The emitted value is a reference to the newly constructed Property that
* this Property was moved into.
*
* The Signal will also be emitted if another Property is moved into
* this property.
*/
Signal<Property<T> &> &moved() { return m_moved; }
Signal<Property<T> &> const &moved() const { return m_moved; }
/**
* Returns a Signal that will be emitted when this Property is destructed.
*/
Signal<> &destroyed() const { return m_destroyed; }
/**
* Assign a new value to this Property.
*
* If the new value is equal_to the existing value, the value will not be
* changed and no Signal will be emitted.
*
* Otherwise, the valueAboutToChange() Signal will be emitted before the value
* of the Property is changed.
* Then, the provided value will be assigned, and the valueChanged() Signal
* will be emitted.
*
* @throw ReadOnlyProperty If the Property has a PropertyUpdater associated with it (i.e. it is
* the result of a binding expression).
*/
void set(T value)
{
if (m_updater) {
throw ReadOnlyProperty{
"Cannot set value on a read-only property. This property likely holds the result of a binding expression."
};
}
setHelper(std::move(value));
}
/**
* Returns the value represented by this Property.
*/
T const &get() const
{
return m_value;
}
/**
* Assigns a new value to this Property.
*
* See: set().
*/
Property<T> &operator=(T const &rhs)
{
set(std::move(rhs));
return *this;
}
/**
* Returns the value represented by this Property.
*
* See: get().
*/
T const &operator()() const
{
return Property<T>::get();
}
private:
void setHelper(T value)
{
if (equal_to<T>{}(value, m_value))
return;
m_valueAboutToChange.emit(m_value, value);
m_value = std::move(value);
m_valueChanged.emit(m_value);
}
T m_value;
// the signals in a property are mutable, as a property
// being "const" should mean that it's value or binding does
// not change, not that nobody can listen to it anymore.
mutable Signal<const T &, const T &> m_valueAboutToChange;
mutable Signal<const T &> m_valueChanged; // By const ref so we can emit the signal for move-only types of T e.g. std::unique_ptr<int>
Signal<Property<T> &> m_moved;
mutable Signal<> m_destroyed;
std::unique_ptr<PropertyUpdater<T>> m_updater;
};
/**
* Outputs the value of the Property onto an output stream.
*/
template<typename T>
std::ostream &operator<<(std::ostream &stream, Property<T> const &property)
{
stream << property.get();
return stream;
}
/**
* Reads a value of type T from the input stream and assigns it to
* the Property using set().
*/
template<typename T>
std::istream &operator>>(std::istream &stream, Property<T> &prop)
{
T temp;
stream >> temp;
prop.set(std::move(temp));
return stream;
}
namespace Private {
template<typename T>
struct is_property_helper : std::false_type {
};
template<typename T>
struct is_property_helper<Property<T>> : std::true_type {
};
template<typename T>
struct is_property : is_property_helper<std::decay_t<T>> {
};
} // namespace Private
/**
* @example 04-simple-property/main.cpp
*
* An example of how to create a KDBindings::Property and use its valueChanged() KDBindings::Signal to receive notifications whenever the value of the KDBindigns::Property changes.
*
* The output of this example is:
* ```
* The new value is 42
* The new value is 69
* Property value is 69
* ```
*/
/**
* @example 05-property-bindings/main.cpp
*
* An example of how to use makeBoundProperty() to create a KDBindings::Property that is automatically updated once any of its inputs change.
*
* The output of this example is:
* ```
* The initial size of the image = 1920000 bytes
* The new size of the image = 4608000 bytes
* The new size of the image = 8294400 bytes
* ```
*/
} // namespace KDBindings

View File

@@ -0,0 +1,66 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <functional>
namespace KDBindings {
/**
* @brief A PropertyUpdater defines the interface used to update a Property, e.g. from a binding expression.
*
* An instance of this class (wrapped in a std::unique_ptr) can be passed to the Property constructor.
* The Property will then become read-only, meaning an instance of ReadOnlyProperty will be thrown if the
* Property's value is updated through any other means than through the PropertyUpdater.
*
* The Property constructor will pass a function to setUpdateFunction() for this purpose.
* This function is then the only way to update the Property without encountering a ReadOnlyProperty error.
*
* The most typical use of PropertyUpdater is in instances of Binding, which are created by makeBoundProperty().
*/
template<typename T>
class PropertyUpdater
{
public:
/** A PropertyUpdater can be default constructed. */
PropertyUpdater() = default;
/** A PropertyUpdater has a virtual destructor. */
virtual ~PropertyUpdater() = default;
/** A PropertyUpdater can be copy constructed. */
PropertyUpdater(PropertyUpdater const &other) = default;
/** A PropertyUpdater can be copy assigned. */
PropertyUpdater &operator=(PropertyUpdater const &other) = default;
/** A PropertyUpdater can be move constructed. */
PropertyUpdater(PropertyUpdater &&other) = default;
/** A PropertyUpdater can be move assigned. */
PropertyUpdater &operator=(PropertyUpdater &&other) = default;
/**
* The Property will call this function when it constructed and pass a std::function as argument that allows
* the PropertyUpdater to update the Property value.
*
* A PropertyUpdater typically saves this function and calls it once the value it computes changes.
*/
virtual void setUpdateFunction(std::function<void(T &&)> const &updateFunction) = 0;
/**
* The get() function must return the current value the PropertyUpdater wants to assign to the Property.
*
* It is called from the Property constructor.
*/
virtual T get() const = 0;
};
} // namespace KDBindings

716
src/3rdparty/kdbindings/signal.h vendored Normal file
View File

@@ -0,0 +1,716 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sean Harmer <sean.harmer@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <assert.h>
#include <functional>
#include <memory>
#include <optional>
#include <stdexcept>
#include <type_traits>
#include <utility>
#include <kdbindings/genindex_array.h>
#include <kdbindings/utils.h>
/**
* @brief The main namespace of the KDBindings library.
*
* All public parts of KDBindings are members of this namespace.
*/
namespace KDBindings {
template<typename... Args>
class Signal;
namespace Private {
//
// This class defines a virtual interface, that the Signal this ConnectionHandle refers
// to must implement.
// It allows ConnectionHandle to refer to this non-template class, which then dispatches
// to the template implementation using virtual function calls.
// It allows ConnectionHandle to be a non-template class.
class SignalImplBase
{
public:
SignalImplBase() = default;
virtual ~SignalImplBase() = default;
virtual void disconnect(const GenerationalIndex &id) = 0;
virtual bool blockConnection(const GenerationalIndex &id, bool blocked) = 0;
virtual bool isConnectionActive(const GenerationalIndex &id) const = 0;
virtual bool isConnectionBlocked(const GenerationalIndex &id) const = 0;
};
} // namespace Private
/**
* @brief A ConnectionHandle represents the connection of a Signal
* to a slot (i.e. a function that is called when the Signal is emitted).
*
* It is returned from a Signal when a connection is created and used to
* manage the connection by disconnecting, (un)blocking it and checking its state.
*
* To make sure a Connection to an object is disconnected correctly, consider
* storing a ScopedConnection to its ConnectionHandle inside the object.
**/
class ConnectionHandle
{
public:
/**
* A ConnectionHandle can be default constructed.
* In this case the ConnectionHandle will not reference any active connection (i.e. isActive() will return false),
* and not belong to any Signal.
**/
ConnectionHandle() = default;
/**
* A ConnectionHandle can be copied.
**/
ConnectionHandle(const ConnectionHandle &) = default;
ConnectionHandle &operator=(const ConnectionHandle &) = default;
/**
* A ConnectionHandle can be moved.
**/
ConnectionHandle(ConnectionHandle &&) = default;
ConnectionHandle &operator=(ConnectionHandle &&) = default;
/**
* Disconnect the slot.
*
* When this function is called, the function that was passed to Signal::connect
* to create this ConnectionHandle will no longer be called when the Signal is emitted.
*
* If the ConnectionHandle is not active or the connection has already been disconnected,
* nothing happens.
*
* After this call, the ConnectionHandle will be inactive (i.e. isActive() returns false)
* and will no longer belong to any Signal (i.e. belongsTo returns false).
**/
void disconnect()
{
if (auto shared_impl = checkedLock()) {
shared_impl->disconnect(m_id);
}
// ConnectionHandle is no longer active;
m_signalImpl.reset();
}
/**
* Check whether the connection of this ConnectionHandle is active.
*
* @return true if the ConnectionHandle refers to an active Signal
* and the connection was not disconnected previously, false otherwise.
**/
bool isActive() const
{
return static_cast<bool>(checkedLock());
}
/**
* Sets the block state of the connection.
* If a connection is blocked, emitting the Signal will no longer call this
* connections slot, until the connection is unblocked.
*
* Behaves the same as calling Signal::blockConnection with this
* ConnectionHandle as argument.
*
* To temporarily block a connection, consider using an instance of ConnectionBlocker,
* which offers a RAII-style implementation that makes sure the connection is always
* returned to its original state.
*
* @param blocked The new blocked state of the connection.
* @return whether the connection was previously blocked.
* @throw std::out_of_range Throws if the connection is not active (i.e. isActive() returns false).
**/
bool block(bool blocked)
{
if (auto shared_impl = checkedLock()) {
return shared_impl->blockConnection(m_id, blocked);
}
throw std::out_of_range("Cannot block a non-active connection!");
}
/**
* Checks whether the connection is currently blocked.
*
* To change the blocked state of a connection, call ConnectionHandle::block.
*
* @return whether the connection is currently blocked.
**/
bool isBlocked() const
{
if (auto shared_impl = checkedLock()) {
return shared_impl->isConnectionBlocked(m_id);
}
throw std::out_of_range("Cannot check whether a non-active connection is blocked!");
}
/**
* Check whether this ConnectionHandle belongs to the given Signal.
*
* @return true if this ConnectionHandle refers to a connection within the given Signal
**/
template<typename... Args>
bool belongsTo(const Signal<Args...> &signal) const
{
auto shared_impl = m_signalImpl.lock();
return shared_impl && shared_impl == std::static_pointer_cast<Private::SignalImplBase>(signal.m_impl);
}
private:
template<typename...>
friend class Signal;
std::weak_ptr<Private::SignalImplBase> m_signalImpl;
Private::GenerationalIndex m_id;
// private, so it is only available from Signal
ConnectionHandle(std::weak_ptr<Private::SignalImplBase> signalImpl, Private::GenerationalIndex id)
: m_signalImpl{ std::move(signalImpl) }, m_id{ std::move(id) }
{
}
// Checks that the weak_ptr can be locked and that the connection is
// still active
std::shared_ptr<Private::SignalImplBase> checkedLock() const
{
auto shared_impl = m_signalImpl.lock();
if (shared_impl && shared_impl->isConnectionActive(m_id)) {
return shared_impl;
}
return nullptr;
}
};
/**
* @brief A Signal provides a mechanism for communication between objects.
*
* KDBindings::Signal recreates the <a href="https://doc.qt.io/qt-5/signalsandslots.html">Qt's Signals & Slots mechanism</a> in pure C++17.
* A Signal can be used to notify any number of slots that a certain event has occurred.
*
* The slot can be almost any callable object, including member functions and lambdas.
*
* This connection happens in a type-safe manner, as a slot can only be connected to
* a Signal when the arguments of the slot match the values the Signal emits.
*
* The Args type parameter pack describe which value types the Signal will emit.
*
* Examples:
* - @ref 01-simple-connection/main.cpp
* - @ref 02-signal-member/main.cpp
* - @ref 03-member-arguments/main.cpp
* - @ref 07-advanced-connections/main.cpp
*/
template<typename... Args>
class Signal
{
static_assert(
std::conjunction<std::negation<std::is_rvalue_reference<Args>>...>::value,
"R-value references are not allowed as Signal parameters!");
// The Signal::Impl class exists, so Signals can be implemented in a PIMPL-like way.
// This allows us to easily move Signals without losing their ConnectionHandles, as well as
// making an unconnected Signal only sizeof(shared_ptr).
class Impl : public Private::SignalImplBase
{
public:
Impl() noexcept { }
~Impl() noexcept { }
// Signal::Impls are not copyable
Impl(Impl const &other) = delete;
Impl &operator=(Impl const &other) = delete;
// Signal::Impls are not moveable, this would break the ConnectionHandles
Impl(Impl &&other) = delete;
Impl &operator=(Impl &&other) = delete;
// Connects a std::function to the signal. The returned
// value can be used to disconnect the function again.
Private::GenerationalIndex connect(std::function<void(Args...)> const &slot)
{
return m_connections.insert({ slot });
}
// Disconnects a previously connected function
void disconnect(const Private::GenerationalIndex &id) override
{
m_connections.erase(id);
}
// Disconnects all previously connected functions
void disconnectAll()
{
m_connections.clear();
}
bool blockConnection(const Private::GenerationalIndex &id, bool blocked) override
{
Connection *connection = m_connections.get(id);
if (connection) {
const bool wasBlocked = connection->blocked;
connection->blocked = blocked;
return wasBlocked;
} else {
throw std::out_of_range("Provided ConnectionHandle does not match any connection\nLikely the connection was deleted before!");
}
}
bool isConnectionActive(const Private::GenerationalIndex &id) const override
{
return m_connections.get(id);
}
bool isConnectionBlocked(const Private::GenerationalIndex &id) const override
{
auto connection = m_connections.get(id);
if (connection) {
return connection->blocked;
} else {
throw std::out_of_range("Provided ConnectionHandle does not match any connection\nLikely the connection was deleted before!");
}
}
// Calls all connected functions
void emit(Args... p) const
{
const auto numEntries = m_connections.entriesSize();
// This loop can tolerate signal handles being disconnected inside a slot,
// but adding new connections to a signal inside a slot will still be undefined behaviour
for (auto i = decltype(numEntries){ 0 }; i < numEntries; ++i) {
const auto index = m_connections.indexAtEntry(i);
if (index) {
const auto con = m_connections.get(*index);
if (!con->blocked)
con->slot(p...);
}
}
}
private:
struct Connection {
std::function<void(Args...)> slot;
bool blocked{ false };
};
mutable Private::GenerationalIndexArray<Connection> m_connections;
};
public:
/** Signals are default constructible */
Signal() = default;
/**
* Signals cannot be copied.
**/
Signal(const Signal &) = delete;
Signal &operator=(Signal const &other) = delete;
/** Signals can be moved */
Signal(Signal &&other) noexcept = default;
Signal &operator=(Signal &&other) noexcept = default;
/**
* A signal disconnects all slots when it is destructed
*
* Therefore, all active ConnectionHandles that belonged to this Signal
* will no longer be active (i.e. ConnectionHandle::isActive will return false).
*/
~Signal()
{
disconnectAll();
}
/**
* Connects a std::function to the signal.
*
* When emit() is called on the Signal, the functions will be called with
* the arguments provided to emit().
*
* @return An instance of ConnectionHandle, that can be used to disconnect
* or temporarily block the connection.
*/
ConnectionHandle connect(std::function<void(Args...)> const &slot)
{
ensureImpl();
return ConnectionHandle{ m_impl, m_impl->connect(slot) };
}
/**
* A template overload of Signal::connect that makes it easier to connect arbitrary functions to this
* Signal.
* It connects a function to this Signal, binds any provided arguments to that function and discards
* any values emitted by this Signal that aren't needed by the resulting function.
*
* This is especially useful for connecting member functions to signals.
*
* Examples:
* @code
* Signal<int> signal;
* std::vector<int> numbers{ 1, 2, 3 };
* bool emitted = false;
*
* // disambiguation necessary, as push_back is overloaded.
* void (std::vector<int>::*push_back)(const int &) = &std::vector<int>::push_back;
* signal.connect(push_back, &numbers);
*
* // this slot doesn't require the int argument, so it will be discarded.
* signal.connect([&emitted]() { emitted = true; });
*
* signal.emit(4); // Will add 4 to the vector and set emitted to true
* @endcode
*
* For more examples see the @ref 07-advanced-connections/main.cpp example.
*
* @return An instance of a Signal::ConnectionHandle that refers to this connection.
* Warning: When connecting a member function you must use the returned ConnectionHandle
* to disconnect when the object containing the slot goes out of scope!
**/
// The enable_if_t makes sure that this connect function specialization is only
// available if we provide a function that cannot be otherwise converted to a
// std::function<void(Args...)>, as it otherwise tries to take precedence
// over the normal connect function.
template<typename Func, typename... FuncArgs, typename = std::enable_if_t<std::disjunction_v<std::negation<std::is_convertible<Func, std::function<void(Args...)>>>, std::integral_constant<bool, sizeof...(FuncArgs) /*Also enable this function if we want to bind at least one argument*/>>>>
ConnectionHandle connect(Func &&slot, FuncArgs &&...args)
{
std::function<void(Args...)> bound = Private::bind_first(std::forward<Func>(slot), std::forward<FuncArgs>(args)...);
return connect(bound);
}
/**
* Disconnect a previously connected slot.
*
* After the slot was successfully disconnected, the ConnectionHandle will no
* longer be active. (i.e. ConnectionHandle::isActive will return false).
*
* @throw std::out_of_range - If the ConnectionHandle does not belong to this
* Signal (i.e. ConnectionHandle::belongsTo returns false).
*/
void disconnect(const ConnectionHandle &handle)
{
if (m_impl && handle.belongsTo(*this)) {
m_impl->disconnect(handle.m_id);
// TODO check if Impl is now empty and reset
} else {
throw std::out_of_range("Provided ConnectionHandle does not match any connection\nLikely the connection was deleted before!");
}
}
/**
* Disconnect all previously connected functions.
*
* All currently active ConnectionHandles that belong to this Signal will no
* longer be active afterwards. (i.e. ConnectionHandle::isActive will return false).
*/
void disconnectAll()
{
if (m_impl) {
m_impl->disconnectAll();
// Once all connections are disconnected, we can release ownership of the Impl.
// This does not destroy the Signal itself, just the Impl object.
// If another slot is connected, another Impl object will be constructed.
m_impl.reset();
}
// If m_impl is nullptr, we don't have any connections to disconnect
}
/**
* Sets the block state of the connection.
* If a connection is blocked, emitting the Signal will no longer call this
* connections slot, until the connection is unblocked.
*
* ConnectionHandle::block can be used as an alternative.
*
* To temporarily block a connection, consider using an instance of ConnectionBlocker,
* which offers a RAII-style implementation that makes sure the connection is always
* returned to its original state.
*
* @param blocked Whether the connection should be blocked from now on.
* @param handle The ConnectionHandle to block.
* @return Whether the connection was previously blocked.
* @throw std::out_of_range - If the ConnectionHandle does not belong to this
* Signal (i.e. ConnectionHandle::belongsTo returns false).
*/
bool blockConnection(const ConnectionHandle &handle, bool blocked)
{
if (m_impl && handle.belongsTo(*this)) {
return m_impl->blockConnection(handle.m_id, blocked);
} else {
throw std::out_of_range("Provided ConnectionHandle does not match any connection\nLikely the connection was deleted before!");
}
}
/**
* Checks whether the connection is currently blocked.
*
* To change the blocked state of a connection, call blockConnection().
*
* @return Whether the connection is currently blocked
* @throw std::out_of_range - If the ConnectionHandle does not belong to this
* Signal (i.e. ConnectionHandle::belongsTo returns false).
*/
bool isConnectionBlocked(const ConnectionHandle &handle) const
{
assert(handle.belongsTo(*this));
if (!m_impl) {
throw std::out_of_range("Provided ConnectionHandle does not match any connection\nLikely the connection was deleted before!");
}
return m_impl->isConnectionBlocked(handle.m_id);
}
/**
* Emits the Signal, which causes all connected slots to be called,
* as long as they are not blocked.
*
* The arguments provided to emit will be passed to each slot by copy,
* therefore consider using (const) references as the Args to the Signal
* wherever possible.
*
* Note: Slots may disconnect themselves during an emit, however it is
* undefined whether a slot that is connected during the emit function
* of the Signal will also be called during this emit, or only at the next
* emit.
*/
void emit(Args... p) const
{
if (m_impl)
m_impl->emit(p...);
// if m_impl is nullptr, we don't have any slots connected, don't bother emitting
}
private:
friend class ConnectionHandle;
void ensureImpl()
{
if (!m_impl) {
m_impl = std::make_shared<Impl>();
}
}
// shared_ptr is used here instead of unique_ptr, so ConnectionHandle instances can
// use a weak_ptr to check if the Signal::Impl they reference is still alive.
//
// This makes Signals easily copyable in theory, but the semantics of this are unclear.
// Copying could either simply copy the shared_ptr, which means the copy would share
// the connections of the original, which is possibly unintuitive, or the Impl would
// have to be copied as well.
// This would however leave connections without handles to disconnect them.
// So copying is forbidden for now.
//
// Think of this shared_ptr more like a unique_ptr with additional weak_ptr's
// in ConnectionHandle that can check whether the Impl object is still alive.
mutable std::shared_ptr<Impl> m_impl;
};
/**
* @brief A ScopedConnection is a RAII-style way to make sure a Connection is disconnected.
*
* When the ScopedConnections scope ends, the connection this ScopedConnection guards will be disconnected.
*
* Example:
* - @ref 08-managing-connections/main.cpp
*/
class ScopedConnection
{
public:
/**
* @brief A ScopedConnection can be default constructed
*
* A default constructed ScopedConnection has no connection to guard.
* Therefore it does nothing when it is destructed, unless a ConnectionHandle is assigned to it.
*/
ScopedConnection() = default;
/** A ScopedConnection can be move constructed */
ScopedConnection(ScopedConnection &&) = default;
/** A ScopedConnection can be move assigned */
ScopedConnection &operator=(ScopedConnection &&) = default;
/** A ScopedConnection cannot be copied */
ScopedConnection(const ScopedConnection &) = delete;
/** A ScopedConnection cannot be copied */
ScopedConnection &operator=(const ScopedConnection &) = delete;
/**
* A ScopedConnection can be constructed from a ConnectionHandle
*/
ScopedConnection(ConnectionHandle &&h)
: m_connection(std::move(h))
{
}
/**
* A ScopedConnection can be assigned from a ConnectionHandle
*/
ScopedConnection &operator=(ConnectionHandle &&h)
{
m_connection.disconnect();
m_connection = std::move(h);
return *this;
}
/**
* @return the handle to the connection this instance is managing
*/
ConnectionHandle &handle()
{
return m_connection;
}
/**
* @overload
*/
const ConnectionHandle &handle() const
{
return m_connection;
}
/**
* Convenience access to the underlying ConnectionHandle using the `->` operator.
*/
ConnectionHandle *operator->()
{
return &m_connection;
}
/**
* @overload
*/
const ConnectionHandle *operator->() const
{
return &m_connection;
}
/**
* When a ConnectionHandle is destructed it disconnects the connection it guards.
*/
~ScopedConnection()
{
m_connection.disconnect();
}
private:
ConnectionHandle m_connection;
};
/**
* @brief A ConnectionBlocker is a convenient RAII-style mechanism for temporarily blocking a connection.
*
* When a ConnectionBlocker is constructed, it will block the connection.
*
* When it is destructed, it will return the connection to the blocked state it was in
* before the ConnectionBlocker was constructed.
*
* Example:
* - @ref 08-managing-connections/main.cpp
*/
class ConnectionBlocker
{
public:
/**
* Constructs a new ConnectionBlocker and blocks the connection this ConnectionHandle
* refers to.
*
* @throw std::out_of_range If the connection is not active (i.e. ConnectionHandle::isActive() returns false).
*/
explicit ConnectionBlocker(const ConnectionHandle &handle)
: m_handle{ handle }
{
m_wasBlocked = m_handle.block(true);
}
/**
* Destructs the ConnectionBlocker and returns the connection into the blocked state it was in
* before the ConnectionBlocker was constructed.
*/
~ConnectionBlocker()
{
m_handle.block(m_wasBlocked);
}
private:
ConnectionHandle m_handle;
bool m_wasBlocked{ false };
};
/**
* @example 01-simple-connection/main.cpp
*
* A simple example of how to create a KDBindings::Signal and connect a lambda to it.
*
* The output of this example is:
* ```
* The answer: 42
* ```
*/
/**
* @example 02-signal-member/main.cpp
*
* An example of how to connect a member function to a KDBindings::Signal.
*
* The output of this example is:
* ```
* Hello World!
* ```
*/
/**
* @example 03-member-arguments/main.cpp
*
* An example of how to connect a member function with arguments to a KDBindings::Signal.
*
* The output of this example is:
* ```
* Bob received: Have a nice day!
* Alice received: Thank you!
* ```
*/
/**
* @example 07-advanced-connections/main.cpp
*
* An example of how to use the KDBindings::Signal::connect() overloaded function for advanced slot connections.
*
* The output of this example is:
* ```
* Hello World!
* Emitted value: 5
* true
* ```
*/
/**
* @example 08-managing-connections/main.cpp
*
* An example of how to use a ScopedConnection and ConnectionBlocker to manage
* when a Connection is disconnected or blocked.
*
* Expected output:
* ```
* Guard is connected: 1
* Connection is not blocked: 3
* Connection is not blocked: 5
* ```
*/
} // namespace KDBindings

169
src/3rdparty/kdbindings/utils.h vendored Normal file
View File

@@ -0,0 +1,169 @@
/*
This file is part of KDBindings.
SPDX-FileCopyrightText: 2021-2022 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Leon Matthes <leon.matthes@kdab.com>
SPDX-License-Identifier: MIT
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#pragma once
#include <functional>
#include <type_traits>
#include <utility>
namespace KDBindings {
/**
* The contents of this namespace may only be accessed by the implementation of KDBindings, they
* are not part of KDBindings public API and may be altered at any time and provide no guarantees
* of any kind when used directly.
**/
namespace Private {
// ------------------------ get_arity --------------------------
// get_arity is a template function that returns the number of arguments
// of (almost) any callable object.
// The easiest way is to simply call get_arity<T>() for callable type T.
// It needs to be constexpr in order so it can be used in template arguments.
// To overload get_arity, it needs a marker type, as C++ doesn't allow partial
// function specialization.
template<typename T>
struct TypeMarker {
constexpr TypeMarker() = default;
};
// base implementation of get_arity refers to specialized implementations for each
// type of callable object by using the overload for its specialized TypeMarker.
template<typename T>
constexpr size_t get_arity()
{
return get_arity(TypeMarker<std::decay_t<T>>{});
}
// Syntactic sugar version of get_arity, allows to pass any callable object
// to get_arity, instead of having to pass its decltype as a template argument.
template<typename T>
constexpr size_t get_arity(const T &)
{
return get_arity<T>();
}
// The arity of a function pointer is simply its number of arguments.
template<typename Return, typename... Arguments>
constexpr size_t get_arity(TypeMarker<Return (*)(Arguments...)>)
{
return sizeof...(Arguments);
}
template<typename Return, typename... Arguments>
constexpr size_t get_arity(TypeMarker<Return (*)(Arguments...) noexcept>)
{
return sizeof...(Arguments);
}
// The arity of a generic callable object is the arity of its operator() - 1, as the this
// pointer is already known for such an object.
template<typename T>
constexpr size_t get_arity(TypeMarker<T>)
{
return get_arity(TypeMarker<decltype(&T::operator())>{}) - 1;
}
// Macro to help define most combinations of possible member function qualifiers.
// Add + 1 to sizeof...(Arguments) here as the "this" pointer is an implicit argument to any member function.
#define KDBINDINGS_DEFINE_MEMBER_GET_ARITY(MODIFIERS) \
template<typename Return, typename Class, typename... Arguments> \
constexpr size_t get_arity(::KDBindings::Private::TypeMarker<Return (Class::*)(Arguments...) MODIFIERS>) \
{ \
return sizeof...(Arguments) + 1; \
}
// Define the get_arity version without modifiers without using the macro.
// MSVC otherwise complains about a call to the macro with too few arguments
template<typename Return, typename Class, typename... Arguments>
constexpr size_t get_arity(::KDBindings::Private::TypeMarker<Return (Class::*)(Arguments...)>)
{
return sizeof...(Arguments) + 1;
}
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(const)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(&)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(const &)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(&&)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(const &&)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile const)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile &)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile const &)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile &&)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile const &&)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(const noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(&noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(const &noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(&&noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(const &&noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile const noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile &noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile const &noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile &&noexcept)
KDBINDINGS_DEFINE_MEMBER_GET_ARITY(volatile const &&noexcept)
// -------------------- placeholder and bind_first ---------------------
// Inspired by https://gist.github.com/engelmarkus/fc1678adbed1b630584c90219f77eb48
// A placeholder provides a way to construct something equivalent to a std::placeholders::_N
// with N as a template argument.
//
// Note: As placeholders start at 1, therefore placeholder<0> is NOT a valid placeholder.
template<int>
struct placeholder {
};
template<typename Func, typename... Args, std::size_t... Is>
auto bind_first_helper(std::index_sequence<Is...>, Func &&fun, Args... args)
{
return std::bind(std::forward<Func>(fun), std::forward<Args>(args)..., placeholder<Is + 1>{}...);
}
// bind_first binds the first arguments to the callable object (i.e. function) to the values provided by args.
// The return value is a new function taking get_arity<Func> - sizeof...(Args) many arguments, with the first
// sizeof...(Args) arguments bound to the values of args.
// This is different to a call with std::bind(fun, args...), as the callable object created by std::bind would
// in this case now take zero arguments, whilst bind_first still expects the remaining arguments to be provided
//
// For now, providing instances of std::placeholders in Args is not allowed, as the implications of this are
// unclear if sizeof...(Args) != get_arity<Func>. The enable_if_t makes sure none of the Args value is a placeholder.
//
// In the future, we could provide another overload of this function that allows placeholders, as long as all arguments
// are bound.
template<
typename Func,
typename... Args,
/*Disallow any placeholder arguments, they would mess with the number and ordering of required and bound arguments, and are, for now, unsupported*/
typename = std::enable_if_t<std::conjunction_v<std::negation<std::is_placeholder<Args>>...>>>
auto bind_first(Func &&fun, Args &&...args)
{
return bind_first_helper(std::make_index_sequence<get_arity<Func>() - sizeof...(Args)>{}, std::forward<Func>(fun), std::forward<Args>(args)...);
}
} // namespace Private
} // namespace KDBindings
namespace std {
// This allows a placeholder to be used as a replacement of a std::placeholders.
template<int N>
struct is_placeholder<KDBindings::Private::placeholder<N>>
: integral_constant<int, N> {
};
} // namespace std

View File

@@ -0,0 +1,21 @@
MIT License
Copyright (c) 2013-2022 Niels Lohmann
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

Some files were not shown because too many files have changed in this diff Show More