Remove DockWidget::hidden() and shown() signals

Visibility isn't useful as a concept, since non current tabs
are also hidden. Instead, use DockWidget::isOpen()
This commit is contained in:
Sergio Martins
2022-09-10 11:23:39 +01:00
parent 764385de9f
commit 29be2ae819
3 changed files with 0 additions and 9 deletions

View File

@@ -879,7 +879,6 @@ void DockWidget::Private::onParentChanged()
void DockWidget::onShown()
{
d->onDockWidgetShown();
Q_EMIT shown();
d->maybeRestoreToPreviousPosition();
@@ -890,7 +889,6 @@ void DockWidget::onShown()
void DockWidget::onHidden()
{
d->onDockWidgetHidden();
Q_EMIT hidden();
}
void DockWidget::onResize(QSize)

View File

@@ -433,11 +433,6 @@ public:
void onResize(QSize newSize);
Q_SIGNALS:
///@brief signal emitted when the DockWidget is shown. As in QEvent::Show.
void shown();
///@brief signal emitted when the DockWidget is hidden. As in QEvent::Hide.
void hidden();
///@brief signal emitted when the icon changed
void iconChanged();

View File

@@ -194,8 +194,6 @@ void DockWidgetInstantiator::componentComplete()
&DockWidgetInstantiator::actualTitleBarChanged);
connect(m_dockWidget, &Controllers::DockWidget::optionsChanged, this,
&DockWidgetInstantiator::optionsChanged);
connect(m_dockWidget, &Controllers::DockWidget::shown, this, &DockWidgetInstantiator::shown);
connect(m_dockWidget, &Controllers::DockWidget::hidden, this, &DockWidgetInstantiator::hidden);
connect(m_dockWidget, &Controllers::DockWidget::iconChanged, this,
&DockWidgetInstantiator::iconChanged);
connect(m_dockWidget, &Controllers::DockWidget::guestViewChanged, this, [this] {