tests: Run tst_view on offscreen by default

Moved the QPA offscreen defaulting to Platform_qt

src/qtcommon/Platform_qt.cpp

@@ -196,8 +196,20 @@ bool Platform_qt::isGammaray()
 
 Platform_qt::Platform_qt(int argc, char *argv[])
 {
-    Q_UNUSED(argc)
-    Q_UNUSED(argv)
+    // This CTOR is called before we have a QApplication
+
+    bool qpaPassed = false;
+    for (int i = 1; i < argc; ++i) {
+        if (qstrcmp(argv[i], "-platform") == 0) {
+            qpaPassed = true;
+            break;
+        }
+    }
+
+    if (!qpaPassed) {
+        // Use offscreen by default as it's less annoying, doesn't create visible windows
+        qputenv("QT_QPA_PLATFORM", "offscreen");
+    }
 }
 
 void Platform_qt::tests_wait(int ms)

tests/fuzzer/main.cpp

@@ -28,11 +28,6 @@ using namespace KDDockWidgets::Testing;
 
 int main(int argc, char **argv)
 {
-    if (!qpaPassedAsArgument(argc, argv)) {
-        // Use offscreen by default as it's less annoying, doesn't create visible windows
-        qputenv("QT_QPA_PLATFORM", "offscreen");
-    }
-
     QApplication app(argc, argv);
 
     QCommandLineParser parser;
@@ -88,7 +83,7 @@ int main(int argc, char **argv)
         if (filesToLoad.isEmpty()) {
             do {
                 fuzzer.fuzz({ 1, 10, true });
-            } while(loops);
+            } while (loops);
         } else {
             fuzzer.fuzz(filesToLoad);
         }

tests/qtwidgets/tst_qtwidgets.cpp

@@ -1406,11 +1406,6 @@ void TestQtWidgets::tst_complex()
 
 int main(int argc, char *argv[])
 {
-    if (!qpaPassedAsArgument(argc, argv)) {
-        // Use offscreen by default as it's less annoying, doesn't create visible windows
-        qputenv("QT_QPA_PLATFORM", "offscreen");
-    }
-
     KDDockWidgets::Platform::tests_initPlatform(argc, argv, KDDockWidgets::FrontendType::QtWidgets);
 
     if (shouldSkipTests())

tests/tst_docks.cpp

@@ -6344,11 +6344,6 @@ void TestDocks::tst_persistentCentralWidget()
 
 int main(int argc, char *argv[])
 {
-    if (!qpaPassedAsArgument(argc, argv)) {
-        // Use offscreen by default as it's less annoying, doesn't create visible windows
-        qputenv("QT_QPA_PLATFORM", "offscreen");
-    }
-
     KDDockWidgets::Platform::tests_initPlatform(argc, argv, KDDockWidgets::FrontendType::QtWidgets);
     if (shouldSkipTests())
         return 0;

tests/tst_multisplitter.cpp

@@ -1808,19 +1808,6 @@ void TestMultiSplitter::tst_adjacentLayoutBorders()
 
 int main(int argc, char *argv[])
 {
-    bool qpaPassed = false;
-    for (int i = 1; i < argc; ++i) {
-        if (qstrcmp(argv[i], "-platform") == 0) {
-            qpaPassed = true;
-            break;
-        }
-    }
-
-    if (!qpaPassed) {
-        // Use offscreen by default as it's less annoying, doesn't create visible windows
-        qputenv("QT_QPA_PLATFORM", "offscreen");
-    }
-
     KDDockWidgets::Platform::tests_initPlatform(argc, argv, KDDockWidgets::FrontendType::QtWidgets);
     TestMultiSplitter test;
 

tests/utils.h

@@ -439,17 +439,6 @@ inline void dragFloatingWindowTo(Controllers::FloatingWindow *fw, Controllers::D
 
 }
 
-inline bool qpaPassedAsArgument(int argc, char *argv[])
-{
-    for (int i = 1; i < argc; ++i) {
-        if (qstrcmp(argv[i], "-platform") == 0) {
-            return true;
-        }
-    }
-
-    return false;
-}
-
 }
 
 Q_DECLARE_METATYPE(KDDockWidgets::Tests::DockDescriptor)