philipp/KDDockWidgets
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the *_impl indirection methods from Group

Browse Source 
They are no longer virtual, so the indirection doesn't make
sense anymore
This commit is contained in:
Sergio Martins
2022-07-20 14:26:49 +01:00
parent b5a76a4373
commit 4706d2527c
2 changed files with 8 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
src/controllers/Group.cpp
View File

@@ -172,41 +172,6 @@ void Group::changeTabIcon(int index, const QIcon &icon)
dynamic_cast<Views::GroupViewInterface *>(view())->changeTabIcon(index, icon);
}
void Group::removeWidget_impl(DockWidget *dw)
{
dynamic_cast<Views::GroupViewInterface *>(view())->removeWidget_impl(dw);
}
int Group::indexOfDockWidget_impl(const DockWidget *dw)
{
return dynamic_cast<Views::GroupViewInterface *>(view())->indexOfDockWidget_impl(dw);
}
void Group::setCurrentTabIndex_impl(int index)
{
dynamic_cast<Views::GroupViewInterface *>(view())->setCurrentTabIndex_impl(index);
}
void Group::setCurrentDockWidget_impl(DockWidget *dw)
{
dynamic_cast<Views::GroupViewInterface *>(view())->setCurrentDockWidget_impl(dw);
}
void Group::insertDockWidget_impl(DockWidget *dw, int index)
{
dynamic_cast<Views::GroupViewInterface *>(view())->insertDockWidget_impl(dw, index);
}
Controllers::DockWidget *Group::dockWidgetAt_impl(int index) const
{
return dynamic_cast<Views::GroupViewInterface *>(view())->dockWidgetAt_impl(index);
}
Controllers::DockWidget *Group::currentDockWidget_impl() const
{
return dynamic_cast<Views::GroupViewInterface *>(view())->currentDockWidget_impl();
}
int Group::nonContentsHeight() const
{
return dynamic_cast<Views::GroupViewInterface *>(view())->nonContentsHeight();
@@ -318,7 +283,8 @@ void Group::removeWidget(DockWidget *dw)
{
disconnect(dw, &DockWidget::titleChanged, this, &Group::onDockWidgetTitleChanged);
disconnect(dw, &DockWidget::iconChanged, this, &Group::onDockWidgetTitleChanged);
removeWidget_impl(dw);
dynamic_cast<Views::GroupViewInterface *>(view())->removeWidget_impl(dw);
}
FloatingWindow *Group::detachTab(DockWidget *dockWidget)
@@ -350,7 +316,7 @@ int Group::indexOfDockWidget(const DockWidget *dw)
if (m_inCtor || m_inDtor)
return -1;
return indexOfDockWidget_impl(dw);
return dynamic_cast<Views::GroupViewInterface *>(view())->indexOfDockWidget_impl(dw);
}
int Group::currentIndex() const
@@ -366,7 +332,7 @@ void Group::setCurrentTabIndex(int index)
if (m_inCtor || m_inDtor)
return;
setCurrentTabIndex_impl(index);
dynamic_cast<Views::GroupViewInterface *>(view())->setCurrentTabIndex_impl(index);
}
void Group::setCurrentDockWidget(DockWidget *dw)
@@ -374,7 +340,7 @@ void Group::setCurrentDockWidget(DockWidget *dw)
if (m_inCtor || m_inDtor)
return;
setCurrentDockWidget_impl(dw);
dynamic_cast<Views::GroupViewInterface *>(view())->setCurrentDockWidget_impl(dw);
}
void Group::insertDockWidget(DockWidget *dw, int index)
@@ -382,7 +348,7 @@ void Group::insertDockWidget(DockWidget *dw, int index)
if (m_inCtor || m_inDtor)
return;
insertDockWidget_impl(dw, index);
dynamic_cast<Views::GroupViewInterface *>(view())->insertDockWidget_impl(dw, index);
}
Controllers::DockWidget *Group::dockWidgetAt(int index) const
@@ -390,7 +356,7 @@ Controllers::DockWidget *Group::dockWidgetAt(int index) const
if (m_inCtor || m_inDtor)
return nullptr;
return dockWidgetAt_impl(index);
return dynamic_cast<Views::GroupViewInterface *>(view())->dockWidgetAt_impl(index);
}
Controllers::DockWidget *Group::currentDockWidget() const
@@ -398,7 +364,7 @@ Controllers::DockWidget *Group::currentDockWidget() const
if (m_inCtor || m_inDtor)
return nullptr;
return currentDockWidget_impl();
return dynamic_cast<Views::GroupViewInterface *>(view())->currentDockWidget_impl();
}
int Group::dockWidgetCount() const

8
src/controllers/Group.h
View File

@@ -336,14 +336,6 @@ public:
* Any widget having 16777215x16777215 is ignored (represents not having a max-size, QWIDGETSIZE_MAX)
*/
QSize biggestDockWidgetMaxSize() const;
void removeWidget_impl(DockWidget *);
int indexOfDockWidget_impl(const DockWidget *);
void setCurrentTabIndex_impl(int index);
void setCurrentDockWidget_impl(DockWidget *);
void insertDockWidget_impl(DockWidget *, int index);
DockWidget *dockWidgetAt_impl(int index) const;
DockWidget *currentDockWidget_impl() const;
int nonContentsHeight() const;
private: