Commit Graph

6681 Commits

Author SHA1 Message Date
Dana Robinson
02879bc4b2 Updated the H5FS cache code to grab the correct tag and modified
the freespace test to use dxpls that have been tagged with
the H5AC__FREESPACE_TAG global tag instead of H5AC_ind_read_dxpl_id.
The library code now expects the owner of the free space manager
to tag it so the owner-less free space managers in the freespace
tag had to be tagged with *something* to avoid cache errors.
2016-12-07 21:16:12 -05:00
Dana Robinson
16a5c7c8f3 Merge branch 'develop' into eoc_h5fs_fix 2016-12-07 17:21:07 -05:00
Dana Robinson
0f2f51bb7b Updated the comment for the valgrind fix. 2016-12-06 19:44:18 -05:00
Dana Robinson
a366c0a492 Fixed a valgrind problem in file shutdown exposed by the swmr.c test. 2016-12-06 19:03:00 -05:00
Quincey Koziol
e1026bd354 Correct oversight in Java test and remove direct VFD from SWMR supported
drivers.
2016-12-02 11:36:27 -08:00
Quincey Koziol
15e04901a0 Merge branch 'develop' of https://bitbucket.hdfgroup.org/scm/~koziol/hdf5 into develop_swmr_merge 2016-12-02 08:08:49 -08:00
Quincey Koziol
64a339183f Bring SWMR support in to the main development branch. (Finally!) More tests
and the tool and API wrappers will be coming in over the weekend.
2016-12-02 08:07:04 -08:00
derobins
488f19a9cb Fixed a comment. 2016-12-02 01:00:45 -05:00
derobins
0c5f56a865 Added Windows-only versions of the round() functions, which do not
exist in VS2012 and earlier.

Tested on: 32-bit Windows 7 w/ VS2012 Pro
2016-12-02 00:51:07 -05:00
Quincey Koziol
5d7d029b97 Merge branch 'develop' of https://bitbucket.hdfgroup.org/scm/~koziol/hdf5 into develop_swmr_merge 2016-12-01 01:41:13 -08:00
Quincey Koziol
5922bbb45f Minor normalization cleanups. 2016-11-30 14:41:31 -08:00
Dana Robinson
f3dfc133cc Changed the name of H5MF_alloc_close() to H5MF__alloc_close()
to make the FUNC_ENTER macro happy.
2016-11-30 03:51:28 -05:00
Dana Robinson
1093e7a1f7 Added missing TAG macros to H5MF_get_freespace(). 2016-11-30 03:25:09 -05:00
Dana Robinson
f4a74462f2 Added TAG macros to the H5MF package code so H5AC__FREESPACE_TAG
gets set on the dxpl correctly. Also restored the TAG macro
to H5FS__cache_hdr_pre_serialize() since otherwise the tag
won't be initialized.
2016-11-30 01:37:52 -05:00
Dana Robinson
a046ac31d2 First cut at fixing the tagging issue with the free space managers.
* Converted the tag macros to regular ones so the parent's tag
  is used via the dxpl.

* Updated the tag sanity check logic so for free space managers.

* Turned new-style group checks back on in test/evict_on_close.c
2016-11-29 23:53:52 -05:00
Dana Robinson
d3dbe9d90e Merge branch 'develop' into eoc_valgrind_bugfix 2016-11-29 15:06:37 -05:00
Quincey Koziol
b092dbcdfd Bring over another batch (hopefully the last) of non-SWMR "normalization"
changes from the revise_chunks branch.
2016-11-28 16:34:36 -08:00
Dana Robinson
8fd8115715 Merge branch 'develop' into eoc_valgrind_bugfix 2016-11-28 13:33:08 -05:00
Dana Robinson
a6ab26c74b Merge pull request #175 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:new_H5AC_dump_cache to develop
Updated H5AC_dump_cache() to emit more information.

* commit '7a8c7c6063e328fdac28aa3f77ead4bdc91860e5':
  Updated the cache dump to use the stored type name instead of the (redundant) array of names I previously created.
  Updated the format of H5AC/C_dump_cache() to include more information and be easier to read.
2016-11-28 12:19:23 -06:00
Dana Robinson
978e83fb5b Merge branch 'develop' into eoc_valgrind_bugfix 2016-11-28 13:01:10 -05:00
Dana Robinson
7a8c7c6063 Updated the cache dump to use the stored type name instead
of the (redundant) array of names I previously created.
2016-11-28 12:47:59 -05:00
Quincey Koziol
2cb2d5a533 Remove "collective write list" parameter from H5C__flush_single_entry() as it
is only used in a couple of places.  The collective write list has been moved
to be internal to the cache data structure instead.
2016-11-28 01:26:33 -06:00
Dana Robinson
1a0de8ebd8 Updated the format of H5AC/C_dump_cache() to include
more information and be easier to read.
2016-11-27 20:50:13 -05:00
Quincey Koziol
460b573a73 Eliminate unnecessary data structure for parallel collective metadata cache I/O 2016-11-27 19:00:12 -06:00
Dana Robinson
2c3d02e6e5 Merge branch 'develop' into eoc_valgrind_bugfix 2016-11-26 13:11:08 -05:00
Dana Robinson
a8d1aff235 Tentative fix for valgrind issues related to EoC.
Adds /*out*/ parameters to H5O_close() and H5F_try_close() so
that H5D/G_close() will know when H5O_close() has triggered a
file close and thus the file struct is not reliable.

Also removes the H5F_CLOSING() macro and related which were
formerly used to check if the file was closing.
2016-11-26 10:47:32 -05:00
Quincey Koziol
1071d8bf73 Add a flag for H5C__flush_single_entry() to allow the parallel code to request
that images for entries be generated, even when not writing the entry from an
MPI rank.
2016-11-25 16:07:23 -06:00
Dana Robinson
fff898558e Merge pull request #167 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:eoc_valgrind_bugfix to develop
Applied the evict-on-close "check for file closing" change that was successful for groups to datasets.

* commit '88b6f2e24cafcfaffe7d99ab6c5afc2290ce93b4':
  Added the H5F_CLOSING() check that makes valgrind happy in the evict-on-close code in H5G_close() to H5D_close().
2016-11-22 08:54:47 -06:00
Dana Robinson
72ecaf0940 Merge branch 'develop' into eoc_valgrind_bugfix 2016-11-21 17:48:03 -05:00
Dana Robinson
88b6f2e24c Added the H5F_CLOSING() check that makes valgrind happy in
the evict-on-close code in H5G_close() to H5D_close().
2016-11-21 17:45:46 -05:00
Dana Robinson
a44d7b8754 Merge pull request #166 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:eoc_valgrind_bugfix to develop
Two minor evict-on-close changes:

* Fix for a valgrind-reported issue where invoking EoC behavior when the file is closing leads to garbage file data being passed to downstream calls. The solution is to ignore EoC when the file is closing anyway.

* Added brackets so an infinite loop that arises when evicting tagged entries (due to pinned entries preventing progress) raises an error instead.

* commit '4e7b19f8260a7adb0e3b3df30e2d8289fccdcca6':
  Two minor cache changes:
2016-11-21 12:28:48 -06:00
Dana Robinson
4e7b19f826 Two minor cache changes:
* Evict-on-close behavior is now skipped when the file is closing.
  This fixes a potential issue discovered by Valgind on Windows
  where potentially garbage data would be availble for manipulation.

* Added brackets to some code in the tagged entry evict iterators
  so that the flag that determines if progress was made only gets
  set if things are actually evicted. This prevents an infinite
  loop (and emits an error) when pinned entries prevent eviction
  and thus progress.
2016-11-20 11:57:46 -05:00
Quincey Koziol
3b0c2b24da Bring over support for retrying metadata cache entry loads, along with all the
supporting metadata cache callback changes, etc.
2016-11-20 04:24:57 -08:00
Quincey Koziol
eba0ff43c9 Remove 'clear' callback from metadata cache client interface, using the
new 'entry cleaned' notify action innstead.
2016-11-17 17:48:21 -08:00
Quincey Koziol
be27e1ad79 Remove explicit support within the metadata cache for tracked compressed
entries, they are now completely handled in the clients.
2016-11-17 12:58:04 -08:00
Quincey Koziol
d4591ff54d Bring over new 'notify' metadata cache client callback actions for when an
entry is cleaned / dirtied or its [flush dependency] child entry is cleaned /
dirtied.
2016-11-12 14:01:30 -08:00
Quincey Koziol
d183e9a1a2 Merge pull request #155 in HDFFV/hdf5 from ~KOZIOL/hdf5:develop_merge_revise_chunks_05 to develop
* commit '1c6924f18bd8fdad63c4f191c00605092c17fa6e':
  Refactor H5O code to clean up message allocation, align cache deserialize code with revise_chunks changes, and remove unused "message locking" code.
2016-11-12 13:01:58 -06:00
Quincey Koziol
1c6924f18b Refactor H5O code to clean up message allocation, align cache deserialize code
with revise_chunks changes, and remove unused "message locking" code.
2016-11-12 01:05:47 -08:00
Quincey Koziol
80ac4343cd Align w/minor cleanups in revise_chunks branch. 2016-11-11 23:14:58 -08:00
Quincey Koziol
70938cbf28 Merge pull request #151 in HDFFV/hdf5 from ~KOZIOL/hdf5:develop to develop
* commit '31ffc1e72687b4d27602a044565bde6b1e9d803f':
  Clean up cache code to eliminate dead-ends and unify code.
2016-11-11 17:13:03 -06:00
derobins
be0dfa3e22 Moved Win32 variables to top of function in H5FDlog.c. 2016-11-11 14:16:24 -05:00
Quincey Koziol
492eae3995 Clean up cache code to eliminate dead-ends and unify code. 2016-11-10 12:49:22 -08:00
Dana Robinson
c5ca422496 Merge pull request #138 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:H5Pget_driver_info_retval to develop
Changed the return type of H5Pget_driver_info() from void * to const void *

* commit '8eaa0af30585adbbab29686541cd33e058abd6e8':
  Changed the return type of H5Pget_driver_info() from void * to const void *. Fixes HDFFV-10017.
2016-11-07 11:11:58 -06:00
Quincey Koziol
9504d3f337 Switch to new, more scalable, metadata cache entry tagging. 2016-11-06 23:14:10 -08:00
Quincey Koziol
323ae13590 Remove routines not yet used in develop 2016-11-06 22:04:36 -08:00
Quincey Koziol
bb6cb6adb0 Code style and warning cleanups, from revise_chunks branch. 2016-11-06 12:08:19 -08:00
Dana Robinson
8eaa0af305 Changed the return type of H5Pget_driver_info() from void * to
const void *. Fixes HDFFV-10017.
2016-11-05 00:31:26 -04:00
Quincey Koziol
9187e8c5d0 Add missing retrieval of cache logging name, from revise_chunks. 2016-11-04 09:56:55 -07:00
Quincey Koziol
872d1666b4 Add public H5F* routines for cache logging. 2016-11-04 08:14:12 -07:00
Quincey Koziol
ed452ce690 Add cache logging property and file pieces. 2016-11-03 23:06:17 -07:00