Commit Graph

6681 Commits

Author SHA1 Message Date
Quincey Koziol
1077a767ff Minor fixes to align w/state of 1.12 code 2020-08-22 14:43:46 -05:00
Quincey Koziol
41ccf61526 Correct typos w/HGOTO_DONE & HGOTO_ERROR 2020-08-22 14:01:59 -05:00
Quincey Koziol
1b0c423ba0 Move H5T_vlen_reclaim to package scope 2020-08-22 14:01:48 -05:00
Quincey Koziol
a90258b04b Switch H5VM inline routines back to single underscope and put a comment in their header about this naming 2020-08-22 14:01:17 -05:00
Quincey Koziol
ba087ce2b5 Clean up private / package / static namespace issues (function naming, which
header file, FUNC_ENTER / LEAVE, etc).  Removed remaining personal email
addresses from library source code (still needs cleaned from other directories).
Misc. warning, style, and whitespace cleanup.
2020-08-22 14:00:44 -05:00
Quincey Koziol
3c5512eac4 Simplify default use of MPI_BYTE 2020-08-21 16:18:51 -05:00
Quincey Koziol
5a23ba8b59 Don't free builtin MPI_BYTE MPI type 2020-08-21 16:18:40 -05:00
Quincey Koziol
be11bcf2ae Simplify code to avoid using a boolean to free MPI types 2020-08-21 16:18:30 -05:00
Quincey Koziol
e3fb9cdfb6 Avoid creating MPI datatypes on ranks with 0 chunks to write' 2020-08-21 16:18:17 -05:00
Larry Knox
3cea63d8e5 Revert "Merge pull request #2815 in HDFFV/hdf5 from hdf5_1_12_small_chunk_io_opt to hdf5_1_12"
This reverts commit 331cf8c38a, reversing
changes made to ed0985ff7f.
2020-08-20 11:03:40 -05:00
Quincey Koziol
c32d274e83 Only initialize the contiguous or compact I/O info struct when needed. 2020-08-19 16:57:16 -05:00
Allen Byrne
f57011b7af HDFFV-11127 - force RTLD_LOCAL in dlopen 2020-08-12 16:18:16 -05:00
Dana Robinson
84b01a39a1 Fixes minor typos in H5S comments 2020-08-05 12:42:54 -07:00
Dana Robinson
1ae6daaa80 Sync with develop 2020-08-01 09:18:18 -07:00
Vailin Choi
02d8c7256e Merge pull request #2693 in HDFFV/hdf5 from ~VCHOI/my_third_fork:bugfix/HDFFV-11080-heap-use-after-free-by-the-call to develop
* commit '3023b34272cc6ada84aebfa7441a6a55afa3621c':
  Update MANIFEST. Add new test to Cmake.
  Fix for jira issue HDFFV-11080: (1) Patch up the file pointer when reading attribute of variable length datatype (2) Test to verify the fix when doing multiple threads
2020-07-21 12:40:44 -05:00
hdftest
e5b1042450 Snapshot version 1.12.1-1
Update version to 1.12.1-2
2020-07-18 23:19:33 -05:00
Allen Byrne
271208dceb CMake updates:
Add build folder as Include for generated files
Add install option for copying Fortran mod files to include folder
Add PRI defines to win32defs file
Exclude mingw from extra flags
2020-07-15 10:27:06 -05:00
Larry Knox
538b131764 Squashed commit of the following:
commit 45b0cbc71929930a874e1c09e0770aa64d0ae697
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Thu Apr 23 13:14:56 2020 -0500

    Add C++ warnings treated as error for autotools builds.

commit 6debcddcc766601799d5bd661bd60946f951a07e
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Fri Jun 19 16:50:03 2020 -0500

    Remove tests for develop branch from testh5cc.sh.in.
    Add @H5_ECXXFLAGS@ to AM_CXXFLAGS.

commit fed497e7f207313b2a133d3b68c942b7d7104b90
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Fri Jun 12 15:06:39 2020 -0500

    Merge pull request #2646 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop

    * commit '998c6470d78e14228695419c3b514c35ecf3d69e':
      Remove unnecessary version conditions for Clang compilers.

commit 92e52ce5c211bd1d3991a3b8bb67287ac7b652aa
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Wed Jun 10 18:53:45 2020 -0500

    Merge pull request #2639 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop

    * commit 'a33667faf226f5d8c9633bf537893e8fce1bf1f6':
      Add c++ to --enable-sanitize-checks option.

commit 2e802534fb997b81fa98fdd1c7d97d4310898e0d
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Wed Jun 10 15:18:36 2020 -0500

    Merge pull request #2633 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop

    * commit '20eab963899841c9a003baebead8e3bc07d9e127':
      Remove duplicate entries in MANIFEST.
      Make changes to CMake CompilerFlags.cmake files so extra flags are loaded for non-GNU compilers.
      Update new clang files to not pick up clang as vendor for pgCC. Add new files to MANIFEST Temporary demotion of 2 -Werror warning flags that fail on macos 10.12 Remove Production flag unknown to Apple clang.

commit 96ef60a58a23847a7da89a891f2415055ec2ab60
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Mon Jun 8 16:24:49 2020 -0500

    Merge pull request #2631 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop

    * commit 'b942a4d8a3e27317cac50ce37ff5302d477664d8':
      Clean up code to get clang version in config/linux-gnulibc1

commit 8a7c687da568e8b50b38fa53da1ca63759be6ec4
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Mon Jun 8 11:42:37 2020 -0500

    Merge pull request #2623 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop

    * commit 'c7626f79fdee4eee13925e240ef41e61f3367eab':
      Add flags from config/clang-warnings/*general files to H5 C and CXX flags for all versions of Clang and Clang++ compilers. Switched from cut to awk in testcheck_version.sh.in to avoid dependence on tab vs. " " in version definitions in H5public.h.
      Add files for adding warning flags for clang compilers in autotools configure.

commit db3ef7ff3c1ed79167cecef831501411cff8291f
Merge: 5a0f8d7 f9f1310
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Fri Jun 19 14:46:22 2020 -0500

    Merge branch 'hdf5_1_12' of https://bitbucket.hdfgroup.org/scm/~lrknox/hdf5_lrk into hdf5_1_12

commit 5a0f8d7940ae57b445f545a0abd7e303ce6924ee
Author: Larry Knox <lrknox@hdfgroup.org>
Date:   Wed Jun 10 20:15:41 2020 -0500

    Merge pull request #2636 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:HDFFV-11000-update-testh5cc.sh.in-for-version to develop

    * commit '5c0bd670d6e9919c463fbc05de99e2ba55b0761e':
      Add tests for all version to H5_NO_DEPRECATED_SYMBOLS section and to section for current version, with and without default API version flags.
      HDFFV-11000:  update-testh5cc.sh.in to test sample versioned functions in HDF5 1.10, 1.12 and develop.
2020-06-20 22:10:49 -05:00
Quincey Koziol
ab9f73e4db Reduce overhead for H5open, which is involved in the public symbols like H5T_NATIVE_INT, etc. 2020-06-18 15:20:57 -05:00
Quincey Koziol
2cb6c23608 Merge remote-tracking branch 'origin/hdf5_1_12' into hdf5_1_12_cache_last_id_info 2020-06-11 10:03:43 -05:00
Quincey Koziol
cc50a1a3e0 Remember the info for the last ID looked up for a given ID type. 2020-06-11 08:21:25 -05:00
Quincey Koziol
6ca633026c Merge remote-tracking branch 'origin/hdf5_1_12' into hdf5_1_12_opt_single_selection_io 2020-06-11 08:14:48 -05:00
Quincey Koziol
a9e9de8c6c Eliminate allocating file & memory offset & length arrays when performing I/O on a single element. 2020-06-10 16:04:15 -05:00
Quincey Koziol
d97fd2c7b5 Remove redundant metadata cache tagging from some low-level internal chunk functions. The metadata cache tagging has already been done by routines further up the call stack. 2020-06-10 13:35:07 -05:00
Quincey Koziol
95916c8936 Detect when there's the same-shaped selection of a single block of elements on
both selections, but with different selection types (i.e. one selection defined
as an 'all' type and the other as a hyperslab or point type), without falling
into the generic selection iteration case.
2020-06-07 16:22:40 -05:00
Allen Byrne
5ba81f88a3 Whitespace cleanup 2020-05-13 08:18:11 -05:00
Allen Byrne
c1db3c97c6 Whitespace cleanup 2020-05-13 07:15:38 -05:00
David Young
c0fa07fd9f src/H5Eint.c: #include H5TSprivate.h for H5TS_thread_id() definitions.
test/thread_id.c: move threads_failure() inside #ifdefs.
2020-05-11 15:32:40 -05:00
David Young
c97981da36 Remove tongue-in-cheek credit for Rusty Shackleford and Dale Alvin Gribble.
Delete the comment questioning whether pthread_mutex_lock is allowed
in a key destructor, since pthread_key_create(3) provides the answer:

   There  is  no  notion  of a destructor-safe function. If an application
   does not call pthread_exit() from a signal handler, or if it blocks any
   signal whose handler may call pthread_exit() while calling async-unsafe
   functions, all functions may be safely called from destructors.

Delete redundant comment.
2020-05-11 10:22:24 -05:00
David Young
d64afcd9d0 Follow HDF5 conventions. 2020-05-11 10:22:17 -05:00
David Young
2ba97e40cd Make sure that H5TS_thread_id() is available as either a function or a macro in
all configurations.

Previously it was neither declared nor defined in --disable-threadsafety
builds.  The compiler's warning got lost in the noise---I first saw the issue
because my -Werror branch stopped compiling cold---and the tests still linked
and ran.
2020-05-11 10:22:07 -05:00
David Young
8aa74137dd Use a naked pthread_self() call in the HDF5 thread wrappers. 2020-05-11 10:21:59 -05:00
David Young
a7dd25be55 If H5_HAVE_THREADSAFE is not #defined, define nothing but a stub implementation
of H5TS_thread_id().
2020-05-11 10:21:50 -05:00
David Young
524af38af8 Change thread IDs to uint64_t from unsigned long, per Quincey's suggestion.
Fix a typo in the H5TS_thread_init() comment and reword some ID
properties.
2020-05-06 15:37:42 -05:00
David Young
763d7a778e Replace pthread_self_ulong() with H5TS_thread_id(). The POSIX Threads
implementation ought to be portable to any system that has POSIX
Threads.  On Windows, I use the same API call as before.
2020-05-06 15:37:14 -05:00
Quincey Koziol
2edc8daa16 Avoid allocating a chunk index for datasets with 0-sized dimensions, until
the dataset is extended.
2020-05-04 13:17:04 -05:00
hdftest
bf5029051c Merge pull request #2528 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_12 to hdf5_1_12
* commit '8a4905b9d329b582b04d1cc2705d9e367f4dd20b':
  Restrict errors to gcc 4.8 and above.
  Merge pull request #2537 in HDFFV/hdf5 from ~DYOUNG/werror:fix-werrors to develop
  Fix NoFilter build
  TRILAB-244 separate CXX warnings and errors from C
  Don't add general warnings flags for unsupported old versions of gcc and g++ (older than gcc/g++ 4.2). Correct gnu-cxxflags to determine warnings flags to be added based on C++ compiler version instead of C compiler version.
2020-04-27 08:09:20 -05:00
hdftest
ee86b05d98 Snapshot version 1.12 release 1 (snap0)
Update version to 1.12.1-1
2020-04-26 23:19:09 -05:00
David Young
743a2adb2a Merge pull request #2537 in HDFFV/hdf5 from ~DYOUNG/werror:fix-werrors to develop
* commit 'd16eb45d536bd13ca3cf1b0bdc76c58d95d13f17':
  For compatibility with non-C99 Visual Studio versions, use "%" PRIuMAX instead of "%ju".
  Fix `test/swmr_sparse_reader.c:118:77: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]` and `test/snapshots-hdf5/current/test/swmr_sparse_reader.c:129:100: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]`.
  Fix `src/H5FDdirect.c:1346:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]`.
2020-04-25 22:30:08 -05:00
Vailin Choi
8b475a8a95 Merge pull request #2497 in HDFFV/hdf5 from ~VCHOI/my_third_fork:bugfix/112_dtype_close_on_error to hdf5_1_12
* commit '365f08e555e7e92f04b095ccfb3dae09b27fd0ad':
  Fix according to PR feedback.
  Fix error in previous merge: should use NULL instead of FAIL.
2020-04-14 12:34:17 -05:00
vchoi
365f08e555 Fix according to PR feedback. 2020-04-07 14:52:11 -05:00
Allen Byrne
6108186feb TRILAB-192 - merge changes from develop
Single source, config files, for warnings for both autotools and CMake.
Update CMake libraries, tools, tests to use correct flags.
2020-04-07 09:47:29 -05:00
vchoi
c566935876 Fix error in previous merge: should use NULL instead of FAIL. 2020-04-06 21:32:28 -05:00
Allen Byrne
d2b7bacea1 Merging in latest from upstream (HDFFV/hdf5:refs/heads/hdf5_1_12)
* commit 'db3f89ce9dc7eae17cb15d39e402112c3fbd2955':
  Merge pull request #2461 in HDFFV/hdf5 from ~VCHOI/my_third_fork:bugfix/dtype_close_on_error to develop
2020-04-05 11:06:28 -05:00
Vailin Choi
b4d06a7e80 Merge pull request #2461 in HDFFV/hdf5 from ~VCHOI/my_third_fork:bugfix/dtype_close_on_error to develop
* commit 'afdcac28b85d690eebc80ab568fa5266081baaaa':
  A fix in the cleaning up code for datatype when datatype initialization via H5D__init_type() fails. This is triggered by the tests for revised references when the libver bounds setting does not allow version 4 datatype message to be created.  The test failure is abort core dumped. This is due to the datatype initialization fails before the datatype ID is registered. The datatype cleanup code should provide for the above situation. The code to fix the problem is the same as what is done in H5D__open_oid().
2020-04-02 18:30:11 -05:00
Allen Byrne
ac32ce96a3 TRILAB-192 merging warnings changes from develop 2020-03-30 09:28:05 -05:00
Quincey Koziol
8f0c6f0e83 Remove VCS merge conflict 2020-03-24 12:13:13 -05:00
Quincey Koziol
5144eedd2e Revise API for H5get_alloc_stats() to take a struct instead of separate values. 2020-03-23 18:05:37 -05:00
Quincey Koziol
4065a506bc Add routines to query the library's free list sizes and allocation stats. 2020-03-23 18:04:33 -05:00
Vailin Choi
3b2db5eb19 Merge pull request #2451 in HDFFV/hdf5 from ~VCHOI/my_third_fork:bugfix/develop_seg_fault_sel_compat to develop
* commit '81b1ed4e1724b8a6a731ab2b8fb03234a8b49d15':
  Fix issues when deserializing point/all/none selection with version beyond the library's supported version: (1) Verify the decoded version before proceeding further with deserialization (2) Close the dataspace if errors occurred after opening the dataspace
2020-03-16 14:33:52 -05:00