bug fix
Description:
H5FD_mpio_flush() would try to file seek negative if the
file->eoa is 0 (e.g., doing mpio on the raw-file of the
split file driver). Put in a code to catch this case
by returning succeed immediately.
Platforms tested:
modi4(pp)
Bug Fix
Description:
Byte swapping routine was core dumping when attempting to convert 0
elements.
Solution:
Don't try to byte swap when there is nothing to do... :-)
Apologies to Kent for my comments on Friday about testing his checkins,
especially when it was I who needed to do moer testing. :-/
Platforms tested:
Solaris 2.7 (arabica)
Code improvement
Description:
The byte swapping routine for data conversion was inefficient.
Solution:
Applied a number of optimizations which should yield around a 2-3 times
faster algorithm.
Platforms tested:
Solaris 2.6 (baldric)
Code cleanup (sorta)
Description:
When the first versions of the HDF5 library were designed, I remembered
vividly the difficulties of porting code from a 32-bit platform to a 16-bit
platform and asked that people use intn & uintn instead of int & unsigned
int, respectively. However, in hindsight, this was overkill and
unnecessary since we weren't going to be porting the HDF5 library to
16-bit architectures.
Currently, the extra uintn & intn typedefs are causing problems for users
who'd like to include both the HDF5 and HDF4 header files in one source
module (like Kent's h4toh5 library).
Solution:
Changed the uintn & intn's to unsigned and int's respectively.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Bug Fix
Description:
The datatype conversion buffer size was only halfway converted from hsize_t
to size_t and was causing problems. Also, the H5P_peek_<foo> routines have
a bunch of identical code.
Solution:
Finished converting the datatype conversion buffer size to size_t and
cleaned up the implementation of the H5P_peek_<foo> routines to call a
common routine instead of reimplementing a bunch of code.
Platforms tested:
Solaris 2.7 (arabica)
More code cleanups
Description:
Wrap up the code cleanups for changing the dataset transfer property lists
over to using the generic property list code.
Platforms tested:
IRIX64 6.5 (modi4)
Code cleanups, mostly..
Description:
Work on pacifying the SGI compiler to get the generic properties working
correctly with --enable-parallel and --enable-fortran. It's not quite
fixed yet, but I need to head home and these patches help... :-/
Platforms tested:
IRIX64 6.5 (modi4)
New Features!
Description:
Start migrating the internal use of property lists in the library from the
older implementation to the new generic property lists.
Currently, only the dataset transfer property lists are migrated to the
new architecture, all the rest of the property list types are still using
the older architecture.
Also, the backward compatibility features are not implemented yet, so
applications which use dataset transfer properties may need to make the
following changes:
H5Pcreate(H5P_DATASET_XFER) -> H5Pcreate_list(H5P_DATASET_XFER_NEW)
and
H5Pclose(<a dataset transfer property list>) -> H5Pclose_list(id)
This still may have some bugs in it, especially with Fortran, but I should
be wrapping up those later today.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Feature shift
Description:
Take out the v1.2.x compatibility stubs and put in the hooks for v1.4.x
compatibility when needed.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Bug Fix
Description:
H5FD_fapl_copy is being called in H5Pset_driver when copying a dataset
transfer property list instead of H5FD_dxpl_copy and could potentially
cause problems if the file driver information was different.
Solution:
Changed call to H5FD_dxpl_copy() until the generic property code gets
merged in.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Purpose:
Bug Fix
Description:
The way we were generating Dependencies and .depend files was broken.
If the $srcdir or other macros began with a ".", then it would match
anything and cause problems since it would then overwrite the
beginning of the header file's path.
Solution:
Wrote a Perl script which can handle this type of weirdness better.
It's only used when the environment is a GNU one with a GCC
compiler...
Platforms tested:
Linux
Bug Fix
Description:
H5Pset_driver had a resource leak which was dropping dataset transfer IDs
when switching drivers.
Solution:
Decrement dataset transfer ID reference count properly
Platforms tested:
IRIX64 6.5 (modi4)
Bug Fix
Description:
Header file is using incorrect macro for detecting parallel I/O when
backward compability is turned on.
Solution:
Fix header files to define prototypes for parallel I/O property list
functions when compiled with v1.2 backward compatibility turned on.
Platforms tested:
Eyeballed... (Elena will be testing shortly)
Bug Fix
Description:
In certain circumstances, raw data was inadvertantly attempted to be read
from the metadata cache. This was caught with an assertion failure (i.e.
core dump) in the development branch or an eventual sequence of errors in
the release branch.
Solution:
Corrected off-by-one error in metadata caching code.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Purpose:
Bug Fix
Description:
Forward port of the bug fix to the 1.4 branch reguarding the C++
compile error.
Solution:
Need to put
#ifdef __cplusplus
extern "C" {
#endif
/* ... */
#ifdef __cplusplus
}
#endif
around function declarations.
Code Cleanup/Bug Fixes
Description:
Raymond's last fix corrected the problem with eirene, but there were still
a number of warnings, etc. during compiles.
Solution:
Clean up the warnings, neaten up the code a little and change a few hsize_t's
into size_t's that were missed in my previous sweep through the code.
Platforms tested:
Linux 2.2 (eirene)
Purpose:
Bug fix.
Description:
Daily test fails in parallel collective write testing on eirene.
Solution:
In function H5S_mpio_spaces_xfer in H5Smpio.c, changed mpi_count
from hsize_t to size_t.
Platforms tested:
MPICH(Linux, SunOS, IRIX64), SGI MPI.
Bug fix.
Description:
On some systems (linux when not using gcc) 'dev_t' is not actually
a scalar variable. This causes the code which compares dev_t's in
the file drivers to not compile. Also the H5_inline flag was not being
set correctly in the H5private.h file.
Solution:
Set the H5_inline flag to '' (i.e. define it, but don't assign it a value)
if it is not currently defined.
Use DEV_T_IS_SCALAR flag from configure to correctly compare dev_t's using
memcmp instead of a scalar flag.
Platforms tested:
FreeBSD 4.3 (hawkwind), Linux 2.4.2 (chiba city cluster at Argonne)
Bug fix... (sorta)
Description:
Added --enable-linux-lfs configure flag to have better control over whether
the enable large file support on Linux machines. Also removed the
-malign-double flag for gcc since it can potentially cause errors which
are difficult to detect.
Platforms tested:
Linix 2.2 & 2.4 (eirene and dangermouse)
Bug Fix
Description:
Using a 'long long' type (i.e. hsize_t) in a switch statement is apparently
not allowed by the HP/UX 10.20 system compiler and causes the compile to
fail.
Solution:
Cast the variable to a size_t for the switch.
Platforms tested:
HP/UX 10.20 (sangamon)
Bug Fix, Code Cleanup, Code Optimization, etc.
Description:
Fold in the hyperslab speedups, clean up compile warnings and change a
few things from using 'unsigned' or 'hsize_t' to use 'size_t' instead.
Platforms tested:
FreeBSD 4.3 (hawkwind), Solaris 2.7 (arabica), Irix64 6.5 (modi4)
Documentation
Description:
H5Tget_member_type in v1.2.x returns the base type of array fields in
compound datatypes, not an array type itself.
Solution:
Changed to emulate this behavior in v1.4.x when the --enable-hdf5v1_2
flag is given during configuration.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code cleanup
Description:
File driver macros were defined in this file, instead of the file driver
source file.
Solution:
Removed redundant file driver information, which is already in each file
driver source file.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Purpose:
Code Cleanup
Description:
Updating CodeWarrior Port
Solution:
Move around some Windows and Metroworks ifdefs, etc.
Platforms tested:
Solaris 2.7 (arabica) Linux 2.2 (eirene)
Purpose:
Implemented port hunting
Really catch SIGPIPE signals
Description:
Port hunting allows to try and bind to a successive port number
if the port number given in the filename is already used.
Because of a stupid typo in the code, SIGPIPE wasn't catched
which might have caused the sending side to hang.
Solution:
The Stream VFD's file access property list was extended by two
elements:
- maxhunt: how many successive ports to try if the one
given in the filename is already in use
Default is not to hunt for additional ports.
- port: port number which is finally used to bind a socket
This might be different to the port number
as given in the filename if port hunting is enabled.
The H5Pget_fapl_stream() can be used to obtain
this port number.
Platforms tested:
x86 Linux, Irix 32/64 bit, Dec Alpha, Unicos on T3E, AIX on SP2
Hitachi SR8000
Code cleanup
Description:
Recent CodeWarrior patches have broken the Unix builds and moved code
around in non-portable ways.
Solution:
Patched things back up to try to accomodate CodeWarrior and still let the
Unix builds work correctly.
Platforms tested:
FreeBSD 4.3 (hawkwind)
code warrior support
and some clean up
the macros file_seek and file_offset_t that were repeated over sevral files were put only in
H5private.h
H5private .h was updated for win32
vthe
Description:
Solution:
Platforms tested:
Purpose:
bug fix for windows MVS
Description:
adding various windows macros to make it work on windows platform
Solution:
see above
Platforms tested:
test on windows 2000, confirmed on linux.
Code clean/bug fix
Description:
H5FL (free-list manager) code currently is taking an hsize_t as the size
of a memory block to allocate. On many machines, the size of an hsize_t
is greater than the size of a size_t, potentially leading to incorrect
memory allocations in rare circumstances.
Solution:
Changed hsize_t parameters and variables to size_t.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code Cleanup
Description:
Changed POSIX function calls to the HD* way of doing things. Checked
with checkposix and tested on Linux.
Platforms tested:
Linux
Bug Fix
Description:
On some platforms, long long is printed with the "ll" modifier.
HDfprintf didn't handle this case.
Solution:
Added code which checks if there's an "ll" modifier on the template.
If so, then it uses that as the modifier.
Platforms tested:
Kelgia and Dangermouse
Bug fix
Description:
'll' type description wasn't being handled correctly in HDfprintf, causing
testing failures.
Solution:
Added tests for 'll' to HDfprintf's type description parsing.
Platforms tested:
Solaris 2.7 (arabica)
Code cleanup
Description:
Several system header files needed to be included on Linux machines to
get the prototypes for some of the system calls we are using.
Solution:
Added a new feature test macro for including the <features.h>
header on Linux machines, to set up compile macros for system header
files.
Platforms tested:
Linux (eirene), FreeBSD 4.3 (hawkwind)
Bug Fix
Description:
HDfprintf wasn't aware of 'L' type modifier and was passing along the
'%Ld' verbatim instead of printing a long long integer value.
Solution:
Added 'L' to the type modifiers checked in HDfprintf
Platforms tested:
Linux (eirene)
POSIX Removal
Description:
Removed calls to POSIX functions and replaced them with the HD*
equivalents.
Solution:
Did just that. Also had to create two new HD* macros, the
gettimeofday() and getrusage()
Platforms tested:
Linux
Code fix
Description:
Unresolved references to the image code were left behind when it was removed
from the library..
Solution:
Finished taking out the image stuff...
Platforms tested:
FreeBSD 4.3 (hawkwind)
