Commit Graph

1069 Commits

Author SHA1 Message Date
Sergio Martins
da8539820e qtquick: Find the correct controller when using ViewWrapper 2022-05-27 14:00:19 +01:00
Sergio Martins
267bc4ec79 tests: Test that a floating window is created 2022-05-27 13:35:52 +01:00
Sergio Martins
5fdbc12524 Add some asserts 2022-05-27 12:53:22 +01:00
Sergio Martins
ad7f5f5970 tests: Remove some manual creation of QQuickView
It's abstracted by the platform now
2022-05-27 12:11:43 +01:00
Sergio Martins
03f1a6930c Added Platform::createMainWindow()
Called by tests and layout linter to create a main window.

Simplifies creation of the main window, we can now remove one of the ctors.
Before we supported both the controller creating the view and vice-versa,
while this is convenient it's complex to support, due to order or initializations.

Now, you a create a view, and it creates the controller behind the scenes.
MainWindow is special in this sense, as it's created by the end user, it's
not something internal we want in the ViewFactory.
2022-05-27 10:36:54 +01:00
Sergio Martins
c554bdc68c Fix DropArea only looking for QtWidget children
Instead of using findChildren(), just ask the layout for the
items.

tst_floatingWindow now doesn't crash anymore when looking for
the layout items.
2022-05-26 09:58:23 +01:00
Sergio Martins
a85c56a25a Implement ViewWrapper::is() 2022-05-23 23:37:25 +01:00
Sergio Martins
ac51ffc7d4 tests: Add tests for DockWidget and FloatingWindow ctor
To catch potential QML errors in the .qml files.
2022-05-23 23:06:32 +01:00
Sergio Martins
c648e5fbba qtquick: View::rootView() now returns itself if no parent
This matches QWidget::window() behaviour
2022-05-23 22:51:57 +01:00
Sergio Martins
bab0c99d13 tests: Added tst_separator
Helps finding problems in the respective qml file
2022-05-23 19:12:32 +01:00
Sergio Martins
79ef648a27 tests: Added tst_stack and tst_tabbar
Finds errors in the respective qml files
2022-05-23 19:00:21 +01:00
Sergio Martins
0f55a2f87a tests: Add tst_titlebar
At least for the ctor, which already helps to find bugs in
the .qml file
2022-05-23 18:07:56 +01:00
Sergio Martins
87e9cbc388 tests: Add tst_frame 2022-05-23 17:15:43 +01:00
Sergio Martins
bafa21d11c tests: Abort tests if there were warnings 2022-05-21 00:00:14 +01:00
Sergio Martins
07fc7d0437 tests: Move waitForDeleted() into Platform
So each platform can implement their own.
Meaning old Testing.cpp can be deleted too.
2022-05-20 16:41:59 +01:00
Sergio Martins
cc1f75b1b3 tests: Move our message filter into Platform_qt
So it can be reused by other tests
2022-05-20 16:29:14 +01:00
Sergio Martins
bb4f5a5037 Mass renaming of last usages of FrameworkWidgetFactory 2022-05-19 08:12:29 +01:00
Sergio Martins
09eb303bab Rename some methods from FrameworkWidget to View 2022-05-19 08:00:20 +01:00
Sergio Martins
65c1b53ea0 tests: Some include cleanup 2022-05-18 04:48:31 +01:00
Sergio Martins
522b2623be Moved DropIndicatorOverlay into controllers/ folder 2022-05-18 04:47:01 +01:00
Sergio Martins
d2bf83e4ac Rename DropIndicatorOverlayInterface to DropIndicatorOverlay
We don't suffix our base classes with "Interface"
2022-05-18 04:39:21 +01:00
Sergio Martins
2b6c18dbcd Move the drop indicators into Controllers namespace 2022-05-18 04:24:16 +01:00
Sergio Martins
a039f102a3 Remove some unneeded QWidget includes 2022-05-17 22:16:00 +01:00
Sergio Martins
cc8ee097a3 Remove last usage of QWidgetOrQuick type 2022-05-16 23:04:29 +01:00
Sergio Martins
1bacb31949 tests: Use generic view instead of QWidget NonClosableWidget 2022-05-16 22:55:46 +01:00
Sergio Martins
be75247dba tests: Remove some unused includes 2022-05-16 22:37:22 +01:00
Sergio Martins
6bc68fece8 tests: Remove instances of QTextEdit in tests
It's generic now
2022-05-16 22:30:57 +01:00
Sergio Martins
be8250acb7 tests: Remove instances of QLineEdit from the tests
It's now generic
2022-05-16 21:59:43 +01:00
Sergio Martins
8372ffc0d7 tests: Remove all instances of QPushButton from tst_docks
Now uses generic alternatives that will work with other frontends too
2022-05-16 21:29:46 +01:00
Sergio Martins
a10187ed5d tests: Port away further from "QWidgetOrQuick" 2022-05-16 20:01:08 +01:00
Sergio Martins
97baed0ef9 Rename layoutWidget variable/method name to layout
It's a controller, so don't suffix it with Widget/View
2022-05-15 21:12:01 +01:00
Sergio Martins
fa16020d61 Rename MDILayoutWidget to MDILayout and move it to controllers/
Since it's not a view, remove the "Widget" suffix
2022-05-15 16:24:57 +01:00
Sergio Martins
65f74077d3 tests: Replace a usage of QWidgetOrQuick with View 2022-05-15 13:00:08 +01:00
Sergio Martins
383e4f8abd tests: Use tests_createView() instead of MyWidget2
Decouples tests from Qt a bit more
2022-05-15 12:20:30 +01:00
Sergio Martins
9698baefd0 tests: Remove unused HostedWidget 2022-05-15 12:20:30 +01:00
Sergio Martins
f719697852 Remove DockWidget::setWidget(QWidget) 2022-05-14 09:38:55 +01:00
Sergio Martins
df61c35314 Implemented ViewWrapper::sizePolicy() 2022-05-14 09:26:07 +01:00
Sergio Martins
f5fe7e6cc8 tests: Port away from QWidget further
DockWidget::widget() is getting removed in favor of guestView()
2022-05-11 23:51:57 +01:00
Sergio Martins
313be585ae tests: More focus tests 2022-05-11 17:23:31 +01:00
Sergio Martins
8a725298de Added View::hasFocus() 2022-05-11 00:02:18 +01:00
Sergio Martins
721402b710 Remove a few usages of DockWidget::widget()
Use View instead of QWidget
2022-05-10 23:43:07 +01:00
Sergio Martins
73e6822a1d Added View::focusPolicy() 2022-05-10 23:23:27 +01:00
Sergio Martins
9f7c4cb217 Removed the DockWidgetBase typedef
That existed only to ease porting
2022-05-10 22:53:16 +01:00
Sergio Martins
93e388e04f tests: tst_multisplitter is now run against all platforms 2022-05-09 17:38:22 +01:00
Sergio Martins
146b929b5d qtquick: Implement View::maximumSize() and test 2022-05-09 17:28:48 +01:00
Sergio Martins
9173226be7 tests: Normalise signature of argc/argv to match QApplication's
Fixes crash when passing "platform -xcb", because argc was being
passed by value, decremented in QApplication, then going out
of bounds in QTest
2022-05-09 15:16:36 +01:00
Sergio Martins
3c340aee40 tests: Remove last traces of QWidget from tst_multisplitter 2022-05-08 19:56:25 +01:00
Sergio Martins
2b2c5efd1a tests: Don't instance Separator_qtwidgets directly
So it can support qtquick
2022-05-08 19:50:15 +01:00
Sergio Martins
985224f24b tests: Run tst_view on offscreen by default
Moved the QPA offscreen defaulting to Platform_qt
2022-05-08 19:38:52 +01:00
Sergio Martins
97f26743e5 tests: Decouple tst_multisplitter from QWidget more
It now asks the platform to create a test view instead of
using one that inherits from QWidget.
2022-05-08 19:33:04 +01:00