Commit Graph

1069 Commits

Author SHA1 Message Date
Sergio Martins
a4d337e891 Fully qualify header paths when including controllers
so this still works when private headers are installed
2022-06-13 23:24:43 +01:00
Sergio Martins
3ab3076263 Fix some low hanging TODOs 2022-06-13 02:37:03 +01:00
Sergio Martins
55620a5d10 TODO cleanup
Removed stale TODOs and promoted some to TODOm2 , as they should
be tackled next
2022-06-12 16:07:29 +01:00
Sergio Martins
c12da6b6d5 cmake: Don't link against QTTest in release builds 2022-06-12 14:51:57 +01:00
Sergio Martins
ab2b481a80 cmake: QtQuick frontend no longer needs to link against QtWidgets 2022-06-12 14:43:17 +01:00
Sergio Martins
fb844bc989 Don't use QAction directly
In prepartion for qtquick frontend not needing QtWidgets
2022-06-11 18:48:37 +01:00
Sergio Martins
1acbf48786 Don't depend directly on QSizePolicy, as that's QtWidgets
Introduce our own enum. Soon our qtquick frontend won't link
against QtWidgets
2022-06-11 18:22:38 +01:00
Sergio Martins
e120f6f318 tests: Fix windows tests regarding frame pos vs client pos confusion
It's also more readable now.
Might break on linux though, will need to investigate further if that's
the case. In many cases it's just a timing issue, as some platforms are
"more async" than others to add frame
2022-06-11 16:17:10 +01:00
Sergio Martins
29fd6f4a40 qtquick: Fix binding loops
This also restores behaviour with v1.x regarding setParent
2022-06-11 14:03:41 +01:00
Sergio Martins
6aed1508af tests: Don't run tst_qtwidgets if only qtquick tests were specified 2022-06-11 12:38:57 +01:00
Sergio Martins
1070cbce87 tests: Remove unneeded test skipping on Qt < 5.15
Minimum is 5.15 nowadays
2022-06-10 23:12:10 +01:00
Sergio Martins
cfd90b6779 tests: Enable tests for QtQuick as they pass now 2022-06-10 19:25:37 +01:00
Sergio Martins
8e85e46ee9 tests: Make the view min size be the same as it was in 1.x 2022-06-08 19:02:01 +01:00
Sergio Martins
118fe3d32e qtquick: Fix guest view not getting parented when getting added
To be improved on milestone 3
2022-06-08 12:22:57 +01:00
Sergio Martins
3c13f51017 tests: Also resize the view, not only the window when creating main window
Both are needed. This is how it worked in v1
2022-06-07 00:24:38 +01:00
Sergio Martins
31992dcb83 tests: Fix tst_honourGeometryOfHiddenWindow on XCB
The suggested height should be smaller than the floating window
min-size.
2022-06-06 23:35:31 +01:00
Sergio Martins
a5ecfbdd91 tests: Fix createMainWindow having different behavior between frontends 2022-06-06 23:03:53 +01:00
Sergio Martins
0929fb1c75 qtquick: Fix showing qtquick window not setting the root item visible 2022-06-06 15:43:53 +01:00
Sergio Martins
5faf36700b Use qGuiApp instead of qApp
As QtQuick applications might not have QApplication.
2022-06-06 13:24:38 +01:00
Sergio Martins
eb198736b8 qtquick: Fixed drag indicators not working on main window
ViewWrapper::asDropArea() was dummy. Will remove it.
2022-06-06 10:23:48 +01:00
Sergio Martins
e8f390f2ad tests|qtquick: Don't create lots of spurious QQuickView
Most of the times we just want to create a dock widget which
will be parented immediately, we don't need the window.
2022-06-06 10:13:19 +01:00
Sergio Martins
7e3a82ed3e qtquick: Fix setting of transient parent window
We need to go through Window, not through View.
This even makes things cleaner, as parentView() shouldn't go across
window boundaries. That's the case for QtWidgets but it's not consistent
with QtQuick. Our View abstraction has saner rules
2022-06-05 14:12:22 +01:00
Sergio Martins
ce88a00b4b tests: Don't enable these qtquick tests yet
Was commited by mistake
2022-06-05 01:14:32 +01:00
Sergio Martins
ec4e22b5ae qtquick: Move the ClassicIndicator Q_PROPERTIES to the view
as that's what will be exposed to QtQuick
2022-06-05 00:54:30 +01:00
Sergio Martins
0f8823664c qtquick: Remove old references to FrameQuick 2022-06-04 20:24:12 +01:00
Sergio Martins
84561a9d67 tests: Remove unused color argument from createDockWidget() 2022-06-04 20:03:43 +01:00
Sergio Martins
f1f722f1ce Replace TODOv2 tags with TODOm2 and TODOm3 tags
Not all todos are required for milestone m2
2022-06-04 19:53:25 +01:00
Sergio Martins
9f96eff663 Make numSideBySide_recursive() ignore invisible items
We have invisible items that just remember the position of
other items.
2022-06-02 16:30:02 +01:00
Sergio Martins
f5622732ce Added ItemBoxContainer::tst_numSideBySide_recursive() 2022-06-02 13:59:20 +01:00
Sergio Martins
1acafd8a6c Remove unneeded MultiSplitterConfig
Config.cpp is enough
2022-05-31 23:31:29 +01:00
Sergio Martins
affd1d12ae tests: Move the last qtwidgets only test to tst_qtwidgets.cpp
tst_docks.cpp is now completely rid of the widget ifdefs
2022-05-31 15:14:16 +01:00
Sergio Martins
300bd89728 tests: Port a bunch of KDDOCKWIDGETS_QTWIDGETS defines
These already existed in version 1.0, so just use the proper
guard. They won't be made generic at this point
2022-05-31 15:09:36 +01:00
Sergio Martins
61fb31b62a tests: Move a qtquick only test to tst_qtquick 2022-05-31 15:05:27 +01:00
Sergio Martins
07853bdc4d Remove the last two remaining KDDOCKWIDGETS_QTQUICK ifdefs 2022-05-31 14:14:31 +01:00
Sergio Martins
6289e92e54 qtquick: Fix resizing root view
And uncommented the qtquick test for this, which now passes.
Moved the test to its own qtquick tests file.
2022-05-31 14:06:36 +01:00
Sergio Martins
c93911016f tests: remove unused already ported class 2022-05-31 10:37:51 +01:00
Sergio Martins
8223f462c6 Remove Q_OBJECT from inside comments, so cmake doesn't trigger moc
Fixes a warning where moc says "No relevant classes found"
2022-05-31 10:08:55 +01:00
Sergio Martins
94afae2729 windows: Reviewed and ported a bunch of Q_OS_WIN_OLD usages
Those are fine. Will tackle the difficult ones next.
2022-05-30 22:04:35 +01:00
Sergio Martins
d8e703275f windows: Replace Q_OS_WIN with Q_OS_WIN_TODO so we can start porting
Now it builds. This way I can port each Q_OS_WIN one by one and make
sure everything still builds, without risking breaking Linux/macOS.
2022-05-30 21:55:49 +01:00
Sergio Martins
c619c72094 tests: Introduce an env var to allow to run a subset of tests
by frontend
2022-05-30 18:57:59 +01:00
Sergio Martins
230317551b Move installMessageHandler() to Platform.h
It's not Qt specific, as other frontends might want to install
their own handler
2022-05-30 18:31:14 +01:00
Waqar Ahmed
39c058cd29 Fix messageHandler installation for Qt backends 2022-05-30 20:28:44 +05:00
Sergio Martins
2421e607a9 Users now instantiate DockWidget view instead of controller
The controllers are private and not intentend for the public.
2022-05-30 11:45:43 +01:00
Sergio Martins
04b9590d59 cmake: Compile tst_qtwidgets only if QtWidgets frontend is built
The QtQuick frontend is now buildable withotu the QtWidgets one.
2022-05-29 22:14:45 +01:00
Sergio Martins
c36832d71c Port tst_viewguard away from QtWidgets 2022-05-29 22:07:38 +01:00
Sergio Martins
eff711b9ca Port MainWindowMDI to the new architecture
Has a qtquick implementation now.
2022-05-29 21:57:08 +01:00
Sergio Martins
20c41fa3b1 qtquick: Implement Platform_qtquick::tests_createNonClosableView() 2022-05-29 19:54:37 +01:00
Sergio Martins
1c0c594abe cmake: Add qtwidgets/qtquick ifdefs
Code now builds without QtQuick if needed
2022-05-28 16:02:14 +01:00
Sergio Martins
c77b9628b4 cmake: Only link to QtWidgets when building qtwidgets frontend
And the same for QtQuick
2022-05-28 15:34:59 +01:00
Sergio Martins
56a871b86b tests: Remove unneeded setContentsMargin() call 2022-05-27 15:50:16 +01:00