Commit Graph

22090 Commits

Author SHA1 Message Date
Dana Robinson
1227bc0411 Sync with develop (#1863) 2022-07-09 03:05:53 -07:00
raylu-hdf
57cc499009 Enable the Onion VFD to support H5Pset_driver_by_name (#1813)
* Enable the Onion VFD to support H5Pset_driver_by_name and added a test case for it.

* Committing clang-format changes

* Revised a private function to return an error if it fails.

* Committing clang-format changes

* Refactored some code in the previous commit.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-29 15:26:31 -07:00
raylu-hdf
07ea411e8a Enabling h5repack to support onion VFD (#1788)
* Enable h5repack to support onion VFD.  The input file can take options for onion VFD.  But output file doesn't.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-29 15:25:27 -07:00
Dana Robinson
29eb6f4df5 Onion VFD: Refactoring (#1765)
* Struct cleanup

* More renaming

* Minor cleanup

* Removed aspirational code from the feature

* Revert "Removed aspirational code from the feature"

This reverts commit 0b162d16a1.

* Split header code into new files, history_header --> header

* In-memory things are size_t now

* Minor renaming

* More encode/decode functions use size_t instead of uint64_t
2022-05-11 21:05:04 -07:00
Dana Robinson
6e6dbf2e81 Onion VFD: Refactoring (#1756) 2022-05-08 03:43:32 -07:00
Dana Robinson
3dd97b88e9 Onion VFD: Sync with develop (#1753) 2022-05-07 19:45:30 -07:00
raylu-hdf
8287d93f4e Added a test case for object and region references (#1752)
* Added a test case for object and region references.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-05-07 19:05:37 -07:00
Dana Robinson
a02cbdac31 Onion VFD: sync with develop (#1747)
Sync with develop
2022-05-06 15:37:40 -07:00
Dana Robinson
4f376eb29f Onion VFD: Removes the user info from the revision entries (#1737)
* Removes the user info from the onion VFD revision entries

* Formatted source

* Fixed codespell issue
2022-05-05 23:27:39 -07:00
Dana Robinson
c78bb5a460 Cleaned up new public call to get the number of onion revisions (#1735) 2022-05-05 20:34:19 -07:00
raylu-hdf
4493080163 Added the standard output file (tools/testfiles/tst_onion_revision_count.ddl) which was left out in the previous checkin. (#1736) 2022-05-05 20:34:02 -07:00
Dana Robinson
7450731a44 Adds the onion VFD to Github workflows (#1734) 2022-05-05 18:53:21 -07:00
Dana Robinson
4d335fc267 Onion VFD: Cleans up warnings related to onion VFD stuff in tools code (#1733)
* Cleans up warnings related to onion VFD stuff in tools code

Also disables an h5dump test that has a missing file

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-05-05 18:47:40 -07:00
Dana Robinson
89f8f84353 Onion VFD: Sync with develop. (#1732)
* Sync with develop. h5dump is broken, so I can't test the tools.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-05-05 17:02:46 -07:00
raylu-hdf
0566defd2c Added the support to get the revision count for the onion file into the h5dump. (#1726)
* Removes unused definitions from module headers (#1624)

* Fix these Doxygen warnings #1581 (#1589)

* Fixes a typo in H5.c (#1639)

* free MPI_Group/MPI_Comm/MPI_Datatype objects (#1638)

* free MPI_Group/MPI_Comm/MPI_Datatype objects

* fix clang-format style

* Adds build and license shields to README.md (#1641)

* First stab at a Github status bar

* Adds a .tokeignore file for counting lines of code accurately

* Yanks lines of code calculation since it wildly overcounts

* not depend on doIO to free an MPI_Comm object (#1642)

* free MPI datatypes previously created (#1637)

* Retrieve MPI-IO hints used by MPI library after file open (#1636)

H5Pget_fapl_mpio() should return an MPI info object containing all the
MPI-IO hints used by the MPI library underneath, after the file is
opened. Some hints, such as cb_nodes (number of I/O aggregators), are
useful for HDF5 applications and I/O libraries built on top of HDF5.

* OESS-168: Remove clang warnings. (#1309)

* OESS-168: Remove clang warnings.

* OESS-168: Address @lrknox review.

* OESS-168: Remove clang warnings. (#1376)

* Added the support to get the revision count for the onion file into the h5dump.

* Committing clang-format changes

* Changed the function from H5FDget_onion_revision_count to H5FDonion_get_revision_count for better name.

* Fixed compiler warnings.

Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: Allen Byrne <50328838+byrnHDF@users.noreply.github.com>
Co-authored-by: Wei-keng Liao <wkliao@users.noreply.github.com>
Co-authored-by: H. Joe Lee <hyoklee@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-05-05 13:33:47 -07:00
raylu-hdf
93f65cc613 Adding a new API function to get the number of revisions for an onion file (#1692)
* Removes unused definitions from module headers (#1624)

* Fix these Doxygen warnings #1581 (#1589)

* Fixes a typo in H5.c (#1639)

* free MPI_Group/MPI_Comm/MPI_Datatype objects (#1638)

* free MPI_Group/MPI_Comm/MPI_Datatype objects

* fix clang-format style

* Adds build and license shields to README.md (#1641)

* First stab at a Github status bar

* Adds a .tokeignore file for counting lines of code accurately

* Yanks lines of code calculation since it wildly overcounts

* not depend on doIO to free an MPI_Comm object (#1642)

* free MPI datatypes previously created (#1637)

* Retrieve MPI-IO hints used by MPI library after file open (#1636)

H5Pget_fapl_mpio() should return an MPI info object containing all the
MPI-IO hints used by the MPI library underneath, after the file is
opened. Some hints, such as cb_nodes (number of I/O aggregators), are
useful for HDF5 applications and I/O libraries built on top of HDF5.

* OESS-168: Remove clang warnings. (#1309)

* OESS-168: Remove clang warnings.

* OESS-168: Address @lrknox review.

* OESS-168: Remove clang warnings. (#1376)

* Adding a new API function to get the number of revisions for an onion file. This function uses H5FD_ctl().

* Committing clang-format changes

* Removed a few unused variables.

* Modified the way that the API function H5FDget_onion_revision_count is organized and added Doxygen comments for the three API functions.

* Committing clang-format changes

* Minor changes: modified some Doxygen comments.

Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: Allen Byrne <50328838+byrnHDF@users.noreply.github.com>
Co-authored-by: Wei-keng Liao <wkliao@users.noreply.github.com>
Co-authored-by: H. Joe Lee <hyoklee@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-05-03 11:05:09 -07:00
Dana Robinson
a53f47b72f Onion VFD: Misc cleanup (#1693)
* Removes unused definitions from module headers (#1624)

* Fix these Doxygen warnings #1581 (#1589)

* Fixes a typo in H5.c (#1639)

* free MPI_Group/MPI_Comm/MPI_Datatype objects (#1638)

* free MPI_Group/MPI_Comm/MPI_Datatype objects

* fix clang-format style

* Adds build and license shields to README.md (#1641)

* First stab at a Github status bar

* Adds a .tokeignore file for counting lines of code accurately

* Yanks lines of code calculation since it wildly overcounts

* not depend on doIO to free an MPI_Comm object (#1642)

* free MPI datatypes previously created (#1637)

* Retrieve MPI-IO hints used by MPI library after file open (#1636)

H5Pget_fapl_mpio() should return an MPI info object containing all the
MPI-IO hints used by the MPI library underneath, after the file is
opened. Some hints, such as cb_nodes (number of I/O aggregators), are
useful for HDF5 applications and I/O libraries built on top of HDF5.

* OESS-168: Remove clang warnings. (#1309)

* OESS-168: Remove clang warnings.

* OESS-168: Address @lrknox review.

* OESS-168: Remove clang warnings. (#1376)

* Remove H5_NO_ALIGNMENT_RESTRICTIONS (#1426)

* Do not conditionally compile code that uses a pointer dereference
and assignment to copy a potentially unaligned variable to aligned
automatic storage, or vice versa.  Instead, always use naked `memcpy(3)`s.
Disassembling the generated code reveals that the `memcpy(3)`s optimize
(`-O3`) to a single `mov` instruction for x86_64, which is not strict
about alignment.

This change reduces the size of code and scripts by 143 lines, eases
our way to cross-compilation, and avoids invoking undefined behavior.

* Committing clang-format changes

* Per discussion, use HD and add comments.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Cleans up some HL library code that inappropriately returns htri_t values cast to herr_t (#1651)

* Cleans up some HL library code that inappropriately returns
htri_t values cast to herr_t

* Committing clang-format changes

* Formatted source

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Mirror vfd test fixes (#1629)

* Use the FAPL that was created earlier in the test (and delete an unused
variable).   This allows 'make check-vfd' to pass with --enable-mirror-vfd.

* Check for testing directory before creating, to avoid warning from bash.
Clean out .libs directory before re-using it (after a failed test), to
remove any files generated by libtool.

* Committing clang-format changes

* Increment error count on failed file open and skip tests for VFDs that need
modified filenames.

* Skip the mirror VFD for 'make check-vfd' - the mirror VFD requires networking
configuration parameters and can't be provided for an automated test that
is configured with an environment variable.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Removes HDF Group paths, adds shellcheck fixes (#1656)

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2230 -- which is non-standard. Use builti...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

* HDFFV-11306 Fixed (#1657)

* HDFFV-11306,
 * Fixed it so both h5open_f and h5close_f can be called multiple times.
 * Fixed an issue with open objects remaining after h5close_f was called.
 * Added additional tests.

* comments clean-up

* Develop clang format java (#1653)

* added HDFFV-11306 entry (#1662)

* Adds the -q flag to all swmr test programs, quieting noisy output (#1665)

* Adds paths-ignore to the Github pull request workflow (#1663)

* Changes Github action `hdf5 dev CI` to `PR hdf5 dev CI` (#1666)

So the PR action name is not the same as the one in main.yml

* Replace H5detect's build-time detection of C99 integer properties with a (#1400)

* Replace H5detect's build-time detection of C99 integer properties with a
table-driven routine, `H5T__init_native_int()`, that is run at library
initialization time.

* Improve handling of copying of dynamic libraries and clean them up after (#1681)

test finishes.

* Warnings fixes (#1680)

* Clean stack size warnings in sio_engine (#1687)

* Fixes stack size warnings in tcoords.c (#1688)

* Minor things noticed while bringing VFD SWMR in line with develop (#1691)

* Removed dead code, weird formatting, and other badness

* Fixed remaining stack size warnings in onion VFD

* Committing clang-format changes

Co-authored-by: Allen Byrne <50328838+byrnHDF@users.noreply.github.com>
Co-authored-by: Wei-keng Liao <wkliao@users.noreply.github.com>
Co-authored-by: H. Joe Lee <hyoklee@hdfgroup.org>
Co-authored-by: David Young <dyoung@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Quincey Koziol <koziol@lbl.gov>
Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
Co-authored-by: jhendersonHDF <jhenderson@hdfgroup.org>
2022-04-25 23:24:11 -07:00
Dana Robinson
b36cceee0e Onion VFD: Cleaned up code and warnings in onion VFD tools code (#1686)
* Cleaned up code and warnings in onion VFD tools code

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-25 00:22:19 -07:00
Dana Robinson
63197e99f8 Onion VFD: Sync with develop (#1685)
* Removes unused definitions from module headers (#1624)

* Fix these Doxygen warnings #1581 (#1589)

* Fixes a typo in H5.c (#1639)

* free MPI_Group/MPI_Comm/MPI_Datatype objects (#1638)

* free MPI_Group/MPI_Comm/MPI_Datatype objects

* fix clang-format style

* Adds build and license shields to README.md (#1641)

* First stab at a Github status bar

* Adds a .tokeignore file for counting lines of code accurately

* Yanks lines of code calculation since it wildly overcounts

* not depend on doIO to free an MPI_Comm object (#1642)

* free MPI datatypes previously created (#1637)

* Retrieve MPI-IO hints used by MPI library after file open (#1636)

H5Pget_fapl_mpio() should return an MPI info object containing all the
MPI-IO hints used by the MPI library underneath, after the file is
opened. Some hints, such as cb_nodes (number of I/O aggregators), are
useful for HDF5 applications and I/O libraries built on top of HDF5.

* OESS-168: Remove clang warnings. (#1309)

* OESS-168: Remove clang warnings.

* OESS-168: Address @lrknox review.

* OESS-168: Remove clang warnings. (#1376)

* Remove H5_NO_ALIGNMENT_RESTRICTIONS (#1426)

* Do not conditionally compile code that uses a pointer dereference
and assignment to copy a potentially unaligned variable to aligned
automatic storage, or vice versa.  Instead, always use naked `memcpy(3)`s.
Disassembling the generated code reveals that the `memcpy(3)`s optimize
(`-O3`) to a single `mov` instruction for x86_64, which is not strict
about alignment.

This change reduces the size of code and scripts by 143 lines, eases
our way to cross-compilation, and avoids invoking undefined behavior.

* Committing clang-format changes

* Per discussion, use HD and add comments.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Cleans up some HL library code that inappropriately returns htri_t values cast to herr_t (#1651)

* Cleans up some HL library code that inappropriately returns
htri_t values cast to herr_t

* Committing clang-format changes

* Formatted source

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Mirror vfd test fixes (#1629)

* Use the FAPL that was created earlier in the test (and delete an unused
variable).   This allows 'make check-vfd' to pass with --enable-mirror-vfd.

* Check for testing directory before creating, to avoid warning from bash.
Clean out .libs directory before re-using it (after a failed test), to
remove any files generated by libtool.

* Committing clang-format changes

* Increment error count on failed file open and skip tests for VFDs that need
modified filenames.

* Skip the mirror VFD for 'make check-vfd' - the mirror VFD requires networking
configuration parameters and can't be provided for an automated test that
is configured with an environment variable.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Removes HDF Group paths, adds shellcheck fixes (#1656)

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2230 -- which is non-standard. Use builti...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

* HDFFV-11306 Fixed (#1657)

* HDFFV-11306,
 * Fixed it so both h5open_f and h5close_f can be called multiple times.
 * Fixed an issue with open objects remaining after h5close_f was called.
 * Added additional tests.

* comments clean-up

* Develop clang format java (#1653)

* added HDFFV-11306 entry (#1662)

* Adds the -q flag to all swmr test programs, quieting noisy output (#1665)

* Adds paths-ignore to the Github pull request workflow (#1663)

* Changes Github action `hdf5 dev CI` to `PR hdf5 dev CI` (#1666)

So the PR action name is not the same as the one in main.yml

* Replace H5detect's build-time detection of C99 integer properties with a (#1400)

* Replace H5detect's build-time detection of C99 integer properties with a
table-driven routine, `H5T__init_native_int()`, that is run at library
initialization time.

* Improve handling of copying of dynamic libraries and clean them up after (#1681)

test finishes.

Co-authored-by: Allen Byrne <50328838+byrnHDF@users.noreply.github.com>
Co-authored-by: Wei-keng Liao <wkliao@users.noreply.github.com>
Co-authored-by: H. Joe Lee <hyoklee@hdfgroup.org>
Co-authored-by: David Young <dyoung@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Quincey Koziol <koziol@lbl.gov>
Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
2022-04-24 23:20:52 -07:00
Dana Robinson
e8bda8f3a4 Onion VFD: Cleanup and refactoring in the onion VFD (#1679)
* Trivial comment change

* Misc refactoring in the onion test

* Committing clang-format changes

* Fix unused parameter warning

* Removed printf debugging statements

* checkposix fixes

* Cleaned up some function headers

* Remove useless casts

* Fixes most warnings in the onion VFD test code

(exception: stack size warnings)

* Make TEST_ERROR semicolons consistent

* Much tidying in the onion VFD tests

* Formatted source

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-23 17:41:28 -07:00
raylu-hdf
7bf24dabc4 Adding the support of H5FDctl for the Onion VFD and the test case. (#1677) 2022-04-22 12:46:22 -07:00
Dana Robinson
d5aa86df4b Onion VFD: Misc refactoring in the tests (#1654)
* Trivial comment change

* Misc refactoring in the onion test

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-18 13:43:09 -07:00
raylu-hdf
a7fd6b3bf2 Changed the field name 'revision_id' of H5FD_onion_fapl_info_t to 'revision_num' for better description (#1650)
* Changed the field name 'revision_id' of H5FD_onion_fapl_info_t to 'revision_num' for better description.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-15 18:09:27 -07:00
Dana Robinson
033c060a9e Trivial comment change (#1646) 2022-04-15 09:51:10 -07:00
raylu-hdf
374f49946f Changed the options for the Onion VFD to use the generic VFD options in h5diff and h5dump (#1643)
* Changed the options for the Onion VFD to use the generic VFD options in h5diff and h5dump.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-15 08:47:31 -07:00
raylu-hdf
30dfa364ea Merge pull request #1626 from HDFGroup/raylu_onion_vfd_7
Syncing with the Develop Branch
2022-04-08 16:38:55 -05:00
Ray Lu
34ee752efb Changed FUNC_ENTER_STATIC_NOERR to FUNC_ENTER_PACKAGE_NOERR and FUNC_ENTER_STATIC to FUNC_ENTER_PACKAGE to follow the changes in the develop branch. 2022-04-08 16:36:10 -05:00
Ray Lu
028791c6ca Merge branch 'develop' of https://github.com/HDFGroup/hdf5 into raylu_onion_vfd_7 2022-04-08 15:59:45 -05:00
Dana Robinson
d433f0f7a6 Removes the STATIC flavor of FUNC_ENTER macros (#1622)
* Removes the STATIC flavor of FUNC_ENTER macros
2022-04-08 14:32:40 -05:00
Dana Robinson
95909be9c3 Minor things discovered while preparing 1.12.2 (#1620) 2022-04-08 09:50:20 -05:00
raylu-hdf
43ab4e6db1 Merge pull request #1601 from HDFGroup/raylu_onion_vfd_4
Sync with the develop branch
2022-04-07 16:03:05 -05:00
Ray Lu
33cfd642b5 Corrected some spelling errors. 2022-04-07 16:00:14 -05:00
Dana Robinson
41936183d7 Updates bin/restore.sh to clean up src/H5config.h.in (#1605) 2022-04-07 09:14:47 -05:00
Dana Robinson
fe6b2b8e55 Minor C++ changes noticed while normalizing with 1.12 (#1606) 2022-04-07 06:03:15 -07:00
Dana Robinson
ead0f95877 Removes bin/README (#1602)
This README file refers to scripts that were removed when the MANIFEST
went away.
2022-04-07 05:36:43 -07:00
github-actions
ce315144f1 Committing clang-format changes 2022-04-06 00:53:31 +00:00
Dana Robinson
7e2d23d2a1 Merge remote-tracking branch 'canonical/develop' into feature/onion_vfd 2022-04-05 17:50:57 -07:00
Dana Robinson
a0aeb114e9 Adds additional files/paths to ignore for github actions (#1585) 2022-04-05 17:26:35 -05:00
Dana Robinson
a2b2148e73 Adds release timeline to README.md (#1584) 2022-04-05 17:26:00 -05:00
Allen Byrne
da562164ce Add missing release note for h5repack timing (#1572) 2022-04-04 22:51:17 -05:00
raylu-hdf
715cf1a29b Merge pull request #1579 from HDFGroup/raylu_onion_vfd_2
Minor updates for h5diff.  No review needed.
2022-04-04 21:50:31 -05:00
Ray Lu
8271e5bae9 Minor changes: changed the options --vfd-value-1 and --vfd-value-2 to --vfd-info-1 and --vfd-info-2; added the options for VFD in the help page. 2022-04-04 21:40:32 -05:00
Allen Byrne
b6398dd60e Move error-stack text to top of usage display (#1564)
* Move error-stack text to top of usage display

* Add optional tag ti list

* format changes

* Revert incorrect change
2022-04-01 15:55:22 -05:00
Dana Robinson
f15afef6b3 Fix for unexported global variable on Windows (#1568) 2022-04-01 15:42:22 -05:00
Scot Breitenfeld
e8ea850004 spelling fixes (#1561) 2022-03-31 10:42:30 -05:00
Allen Byrne
870ee8feee Update command format, avoid policy warning (#1550) 2022-03-30 18:01:22 -05:00
jhendersonHDF
ab48ed6df0 Add H5_CHECK_MPI_VERSION macro to check for at least MPI version of (version, subversion) (#1556)
* Fix MPI version check for MPI_Aint_diff usage

* Add H5_CHECK_MPI_VERSION macro

Adds new H5_CHECK_MPI_VERSION macro to check for MPI library version/subversion pair of at least the specified pair
2022-03-30 17:58:55 -05:00
Quincey Koziol
82bf2e97f7 Update MacOS configure, bringing it closer to Linux configure (#1554) 2022-03-30 17:02:18 -05:00
jhendersonHDF
9ed2613789 Add missing H5FL_TRACK debug parameters to free list array routines (#1555) 2022-03-30 16:42:11 -05:00
Allen Byrne
3a906eb3e5 Minor comment corrections (#1544) 2022-03-29 20:57:32 -05:00