Commit Graph

937 Commits

Author SHA1 Message Date
Jean-Michaël Celerier
f8a77d3b4f Optimize screen capture 2019-10-29 11:30:26 +01:00
Sergio Martins
10330a2edf Revert "README: Use a screenshot of the new demo instead of the old"
This reverts commit f5442ddc52.

The new screenshot has too much resolution and shows very small
on github. Restoring the old one.
2019-10-23 10:44:57 +01:00
Sergio Martins
f5442ddc52 README: Use a screenshot of the new demo instead of the old 2019-10-23 10:42:07 +01:00
Sergio Martins
c534efdb95 Minor readme fixes 2019-10-22 16:52:23 +01:00
Sergio Martins
a3556e3f78 Explain in README how to test the example 2019-10-22 16:51:09 +01:00
Sergio Martins
8e437f598b Remove old readme from the example, it's no longer relevant 2019-10-22 16:44:18 +01:00
Sergio Martins
afbe092f7c readme improvements 2019-10-22 16:03:39 +01:00
Sergio Martins
9f01261f9a Update README 2019-10-22 16:02:06 +01:00
Sergio Martins
83f6bb8daf Remove some sanity checks, no longer needed
Silenced a false-positive warning about anchor visibility.
It was invisible because we're within a main window show()

It will be checked by the unit-tests and fuzzer anyway. No need to
do it in production.
2019-10-22 15:28:50 +01:00
Sergio Martins
e4eac7a688 demo: Fix startup delay 2019-10-22 14:17:57 +01:00
Sergio Martins
44bcfdf53c Simplify the demo, make it more verbose
So people see how the API is used.
using vectors of structs with parameters is very compact but
is harder on the reader of a new API
2019-10-22 13:39:41 +01:00
Sergio Martins
a9f5917a54 demo: Make it look nice
Logo now scales better
2019-10-22 13:10:01 +01:00
Sergio Martins
fa8aaeff50 Use KDAB artwork for the dockwidgets example
Work in progress but already looks good.
2019-10-21 23:08:59 +01:00
Sergio Martins
38949fac2a Fix build without find_package()
Some of our projects have kddockwidgets directly in their build
2019-10-21 14:30:04 +01:00
Sergio Martins
de42a4a33c Remove some asserts that aren't needed anymore
They were useful during development.
They have a warning anyway, so the tests and fuzzer will still fail
if something bad happens
2019-10-20 20:32:35 +01:00
Sergio Martins
787f7802be Move the private code into a private/ folder
It's nice to have a similar include hierarchy at build time and install
time.

It also makes things more explicit
2019-10-20 19:24:54 +01:00
Sergio Martins
a3bb7e6b4b Remove examples/CMakeLists.txt
Examples are standalone now
2019-10-20 17:55:27 +01:00
Sergio Martins
6a9b02ea63 Fix ensureMinSize_recursive
It doesn't make sense to only grow one side, as sometimes the item
must grow in both sizes, as the right side might now have enough
to acomodate its needs.

This also allows us to not use Anchor::ensureBounded(), as separators
being within their bounds doesn't imply min sizes being respected, while
the inverse is true

fuzzer testcase 10.json now passes
2019-10-20 16:57:52 +01:00
Sergio Martins
9ce22848f4 Factor out some code into a Item::ensureMinSize_recursive() function
So we can reuse this function in other places.
2019-10-19 19:43:33 +01:00
Sergio Martins
d189506a8c Fix separators sometimes not being visible
When a separator is following other it becomes invisible. But if the
followee is deleted we weren't detecting that.

Connect to the followee's QObject::destroyed() signal so we stop following
and show this separator
2019-10-18 18:31:09 +01:00
Sergio Martins
195390aa9e Fix build with msvc2015, it doesn't have <optional> 2019-10-18 17:37:25 +01:00
Sergio Martins
38dc89818f fuzzer: Move 10.json to failing/
So we can test the good ones easier, just fuzzer *json
2019-10-18 17:24:48 +01:00
Sergio Martins
a4b064945b fuzzer: Add a failing test 2019-10-18 00:01:33 +01:00
Sergio Martins
71287fb916 Improve debug 2019-10-17 23:58:36 +01:00
Sergio Martins
f9c2283ff5 Dont shift separator if there's other visible items still
When hidding a dockwidget we shift the left separator 50% and the right one
50%, instead of left 100%, so it's fair. But if the separator has other
visible dock widgets then no shifting should happen.
2019-10-17 23:57:13 +01:00
Sergio Martins
00ae23d80b Add Anchors::followers() 2019-10-17 23:53:27 +01:00
Sergio Martins
bc1b511d86 fuzzer: Add a failing test 2019-10-17 18:45:03 +01:00
Sergio Martins
ffa61abeb8 Debug++ 2019-10-17 18:29:41 +01:00
Sergio Martins
9d0a69c1a6 Relax warning about AnchorGroup being small
When adjusting the vertical separators we should only check if
the group has enough width. It's height is adjusted in ensureAnchorsBounded().
(And vice-versa)

Found via fuzzer's test-case 9.json. Passes now.
2019-10-17 18:12:51 +01:00
Sergio Martins
bb7f5e51c6 Relax warning in Anchor::setPosition()
Can happen with normal separators too.
They'll be fixed ensureAnchorsBounded() anyway.
2019-10-17 17:50:59 +01:00
Sergio Martins
545b61988f Fix propagating item geometry
If the anchorThatMoved actually increased size then we were
calculating the signess wrong and the item would shrink.

Just check if the anchor is a side1 anchor in the group, if yes
then position must decrease so group grows
2019-10-17 17:40:28 +01:00
Sergio Martins
8f886b8eff Remove sanity checks from Anchor.cpp
As they might be running on an incomplete state, during some
operation.

Instead move it to MultiSplitterLayout::checkSanity() which is
run at the end of operations
2019-10-17 16:42:02 +01:00
Sergio Martins
27cae066a6 Fix Anchor::cumulativeMinLength
We don't want to count the size of separators that are following
others, but we might be in the middle of an operation that will
change which separators are following, like when restoring a placeholder.

So query the actual separators that will follow.

Fixes fuzzer 8.json and 2.json
2019-10-17 13:30:31 +01:00
Sergio Martins
fd7e849e99 Don't checkSanity() in the middle of restoring a placeholder
state isn't stable yet
2019-10-17 12:57:41 +01:00
Sergio Martins
8491224b73 Debug++ 2019-10-17 09:22:03 +01:00
Sergio Martins
1bd5f20309 fuzzer: Bail out if json to load doesn't exist 2019-10-17 09:06:30 +01:00
Sergio Martins
1493f904ab Export Draggable 2019-10-16 19:52:55 +01:00
Sergio Martins
7b5dc02022 Fix anchors out of bounds when redistributing space
In the above case:

+--------+---+
| 1      | 6 |
|        |   |
+---+----|   |
| 2 | 8  |   |
|   |    |   |
+---+----+---+

Supposing 8 is hidden (it's a placeholder), then the separator between 2
and 8 is following the big vertical one between 1 and 6. Now, if the size constraints
of the widget hosted by 2 increases, which might lead to the main window having to increase,
then we have to move that big separator. Problem was it was only honouring the min size of widget 1
because 8 was hidden.
2019-10-16 17:35:39 +01:00
Sergio Martins
be7e9caf15 Debug++ 2019-10-16 17:34:43 +01:00
Sergio Martins
ea2a1ed0fd fuzzer: simplify 8.json 2019-10-16 14:09:33 +01:00
Sergio Martins
8bdbe029ff fuzzer: Add failing unit-tests 2019-10-16 14:04:16 +01:00
Sergio Martins
618a62d0c5 Fix anchors out of bounds warning while restoring placeholder
ensureAnchorsBounded() shouldn't be run while in an inconsistent
state. And it's already run at the end of restoring placeholders.

Fixes fuzzer test case 2.json
2019-10-16 12:44:52 +01:00
Sergio Martins
c57815a828 fuzzer: trim 2.json 2019-10-15 19:34:14 +01:00
Sergio Martins
dd7b0b27d1 Don't move the static separators when restoring a placeholder
Fixes fuzzer testcase 6.json
2019-10-15 19:15:11 +01:00
Sergio Martins
855e9ab884 Minor rename 2019-10-15 18:20:02 +01:00
Sergio Martins
f44d63f4c3 DebugDialog: Add button to updateAnchorFollowing() 2019-10-15 18:17:22 +01:00
Sergio Martins
8fec6a871e fuzzer: minor simplification for 6.json 2019-10-15 17:13:34 +01:00
Sergio Martins
982e9828e8 fuzzer: regeneratete 6.json, fixes comments 2019-10-15 17:05:41 +01:00
Sergio Martins
68dba4c993 fuzzer: Add failing test-case
Another "Constraints not honoured"
2019-10-15 17:04:28 +01:00
Sergio Martins
af796f6e69 fuzzer: Only print tasks we're running 2019-10-15 16:40:38 +01:00