Commit Graph

3996 Commits

Author SHA1 Message Date
Sergio Martins
cfd4e61a3b Remove View::setLayoutItem()
Because it's specific to Frame
2022-06-13 01:49:06 +01:00
Sergio Martins
b56cf151fe TitleBar_qtwidgets: Header cleanup 2022-06-12 16:34:35 +01:00
Sergio Martins
87414585ea SideBar_qtwidgets: Cleanups
Include cleanups and making things protected/private.
2022-06-12 16:27:04 +01:00
Sergio Martins
3b814866e2 Remove unneeded isVertical() from Sidebar view 2022-06-12 16:21:11 +01:00
Sergio Martins
55620a5d10 TODO cleanup
Removed stale TODOs and promoted some to TODOm2 , as they should
be tackled next
2022-06-12 16:07:29 +01:00
Sergio Martins
5a99c8390a qtquick: Allow the user to pass a different QQmlEngine to DockWidget
Like was the case in v1.x
2022-06-12 15:51:00 +01:00
Sergio Martins
1f7ac6897c qtquick: Rename setWidget to setGuestView 2022-06-12 15:33:56 +01:00
Sergio Martins
24f1f6be33 qtquick: Remove unnneeded connect from frame view
It's already done in the controller
2022-06-12 15:29:21 +01:00
Sergio Martins
6c589f0500 Postpone some m2 TODOs to m3
m2 will focus on QtQuick being usable
2022-06-12 15:25:35 +01:00
Sergio Martins
767bbcb251 Make layout linter work against any frontend 2022-06-12 15:16:30 +01:00
Sergio Martins
c12da6b6d5 cmake: Don't link against QTTest in release builds 2022-06-12 14:51:57 +01:00
Sergio Martins
ab2b481a80 cmake: QtQuick frontend no longer needs to link against QtWidgets 2022-06-12 14:43:17 +01:00
Sergio Martins
fb844bc989 Don't use QAction directly
In prepartion for qtquick frontend not needing QtWidgets
2022-06-11 18:48:37 +01:00
Sergio Martins
098a368c79 qtquick: Use QGuiApplication for tests, not QApplication 2022-06-11 18:29:12 +01:00
Sergio Martins
1acbf48786 Don't depend directly on QSizePolicy, as that's QtWidgets
Introduce our own enum. Soon our qtquick frontend won't link
against QtWidgets
2022-06-11 18:22:38 +01:00
Sergio Martins
e120f6f318 tests: Fix windows tests regarding frame pos vs client pos confusion
It's also more readable now.
Might break on linux though, will need to investigate further if that's
the case. In many cases it's just a timing issue, as some platforms are
"more async" than others to add frame
2022-06-11 16:17:10 +01:00
Sergio Martins
a7b6dd5f24 Port the rest of win32 specific code 2022-06-11 15:50:03 +01:00
Sergio Martins
5cd46d572e Remove a Q_OS_WIN_TODO, nothing to port there 2022-06-11 15:24:32 +01:00
Sergio Martins
0031f1bcfd Release build now builds 2022-06-11 15:24:19 +01:00
Sergio Martins
42998971cc Make DockWidget's d ptr public
This gives more power to users, at their own risk ofc.
2022-06-11 15:22:34 +01:00
Sergio Martins
35f8e3c3f6 cmake: Disable unity build from release builds
It makes it hard to catch missing includes
2022-06-11 15:14:00 +01:00
Sergio Martins
98a8e67f9b Build fixes for release builds 2022-06-11 15:08:25 +01:00
Sergio Martins
6c53777f1b Fix build on Windows 2022-06-11 14:31:20 +01:00
Sergio Martins
02a8da4fb8 tests: Remove whitelisted warning
It doesn't happen anymore
2022-06-11 14:10:00 +01:00
Sergio Martins
29fd6f4a40 qtquick: Fix binding loops
This also restores behaviour with v1.x regarding setParent
2022-06-11 14:03:41 +01:00
Sergio Martins
0f6be75620 vscode: Add a qtquick launcher to the workspace too 2022-06-11 13:25:52 +01:00
Sergio Martins
78025d1e34 Fix name of examples in README and such, since they got renamed 2022-06-11 13:20:26 +01:00
Sergio Martins
b75a10b9eb examples: Normalize names of examples 2022-06-11 13:06:41 +01:00
Sergio Martins
6aed1508af tests: Don't run tst_qtwidgets if only qtquick tests were specified 2022-06-11 12:38:57 +01:00
Sergio Martins
e9c050b659 tests: Delete all QWidgets when test stops
So we don't go with garbage to the QtQuick tests
2022-06-11 12:38:11 +01:00
Sergio Martins
3c9598a560 tests: Fix Qt6/qtquick tests by supressing benign warnings
The main window can be smaller than our layout, we have no way
of imposing a min size to the QWindow, as we don't know what
the user has in main.qml, so don't qWarn when that happens.

This can be handled in the user side of things though, as our
layout exposes its min size, which the user should honour
2022-06-11 12:07:19 +01:00
Sergio Martins
6bded5e832 remove code line that was a no-op 2022-06-11 10:52:46 +01:00
Sergio Martins
e34b4c4d09 tests: Fix Qt6 qtquick tests regarding mouse grabbing not working
QtQuick tests don't work well if run after the QtWidget ones,
so change order.
2022-06-11 00:24:42 +01:00
Sergio Martins
3662f30ea4 vscode: Update the workspace file for Qt6 2022-06-10 23:42:44 +01:00
Sergio Martins
63ff503568 vscode: Remove qtquick workspace files
The same build builds both qtwidgets and qtquick
2022-06-10 23:25:34 +01:00
Sergio Martins
1070cbce87 tests: Remove unneeded test skipping on Qt < 5.15
Minimum is 5.15 nowadays
2022-06-10 23:12:10 +01:00
Sergio Martins
a1d62522f3 Fix Qt6 build 2022-06-10 19:28:25 +01:00
Sergio Martins
cfd90b6779 tests: Enable tests for QtQuick as they pass now 2022-06-10 19:25:37 +01:00
Sergio Martins
b184c6f830 qtquick: Reduce number of sanity checks during incomplete resizes
Fixes the last broken QtQuick test.
2022-06-10 19:24:11 +01:00
Sergio Martins
2aefa9efa0 qtquick: Fix windows being resized bellow their min size 2022-06-10 18:59:53 +01:00
Sergio Martins
5791198c51 qtquick: Fix some benign sizing warnings
During resize QtQuick will trigger lots of calls to setSize()
since it updates the width and the height separately.

Run our sanity checks only after with width and height are done
being updated, and not twice
2022-06-10 15:33:16 +01:00
Sergio Martins
a94daba3fc Bound the suggested floating window geometry
Because why not, seems correct. No bug would happen with QtWidgets
since QtWidgets respect the min sizes of their children, but for
QtQuick it's more flaky as there's no intrinsic mechanism for
min sizes, so give it some help
2022-06-10 14:16:57 +01:00
Sergio Martins
8e85e46ee9 tests: Make the view min size be the same as it was in 1.x 2022-06-08 19:02:01 +01:00
Sergio Martins
118fe3d32e qtquick: Fix guest view not getting parented when getting added
To be improved on milestone 3
2022-06-08 12:22:57 +01:00
Sergio Martins
fb31f893ae Remove unneeded QJsonDocument include 2022-06-08 00:59:16 +01:00
Sergio Martins
d275226df9 qtquick: Fix Stack creating two TabBar's
It's created by the controller, we shouldn't create another one
in the view
2022-06-08 00:32:14 +01:00
Sergio Martins
a5279b5efd qtquick: Minor refactoring, add TabBar_qtquick::qmlTabs() 2022-06-08 00:00:41 +01:00
Sergio Martins
81007f629f qtquick: Fix flaky handling of tabs
The flickable of TabBar from QtQuickControls has a bogus contentX
when removing and readding tabs. Instead implement tabAt() via
iteration and checking which tab contains the point
2022-06-07 23:34:54 +01:00
Sergio Martins
060fe44e71 Remove some unneeded QApplication includes 2022-06-07 17:14:05 +01:00
Sergio Martins
3c13f51017 tests: Also resize the view, not only the window when creating main window
Both are needed. This is how it worked in v1
2022-06-07 00:24:38 +01:00