Sergio Martins
5cd46d572e
Remove a Q_OS_WIN_TODO, nothing to port there
2022-06-11 15:24:32 +01:00
Sergio Martins
0031f1bcfd
Release build now builds
2022-06-11 15:24:19 +01:00
Sergio Martins
42998971cc
Make DockWidget's d ptr public
...
This gives more power to users, at their own risk ofc.
2022-06-11 15:22:34 +01:00
Sergio Martins
35f8e3c3f6
cmake: Disable unity build from release builds
...
It makes it hard to catch missing includes
2022-06-11 15:14:00 +01:00
Sergio Martins
98a8e67f9b
Build fixes for release builds
2022-06-11 15:08:25 +01:00
Sergio Martins
6c53777f1b
Fix build on Windows
2022-06-11 14:31:20 +01:00
Sergio Martins
02a8da4fb8
tests: Remove whitelisted warning
...
It doesn't happen anymore
2022-06-11 14:10:00 +01:00
Sergio Martins
29fd6f4a40
qtquick: Fix binding loops
...
This also restores behaviour with v1.x regarding setParent
2022-06-11 14:03:41 +01:00
Sergio Martins
0f6be75620
vscode: Add a qtquick launcher to the workspace too
2022-06-11 13:25:52 +01:00
Sergio Martins
78025d1e34
Fix name of examples in README and such, since they got renamed
2022-06-11 13:20:26 +01:00
Sergio Martins
b75a10b9eb
examples: Normalize names of examples
2022-06-11 13:06:41 +01:00
Sergio Martins
6aed1508af
tests: Don't run tst_qtwidgets if only qtquick tests were specified
2022-06-11 12:38:57 +01:00
Sergio Martins
e9c050b659
tests: Delete all QWidgets when test stops
...
So we don't go with garbage to the QtQuick tests
2022-06-11 12:38:11 +01:00
Sergio Martins
3c9598a560
tests: Fix Qt6/qtquick tests by supressing benign warnings
...
The main window can be smaller than our layout, we have no way
of imposing a min size to the QWindow, as we don't know what
the user has in main.qml, so don't qWarn when that happens.
This can be handled in the user side of things though, as our
layout exposes its min size, which the user should honour
2022-06-11 12:07:19 +01:00
Sergio Martins
6bded5e832
remove code line that was a no-op
2022-06-11 10:52:46 +01:00
Sergio Martins
e34b4c4d09
tests: Fix Qt6 qtquick tests regarding mouse grabbing not working
...
QtQuick tests don't work well if run after the QtWidget ones,
so change order.
2022-06-11 00:24:42 +01:00
Sergio Martins
3662f30ea4
vscode: Update the workspace file for Qt6
2022-06-10 23:42:44 +01:00
Sergio Martins
63ff503568
vscode: Remove qtquick workspace files
...
The same build builds both qtwidgets and qtquick
2022-06-10 23:25:34 +01:00
Sergio Martins
1070cbce87
tests: Remove unneeded test skipping on Qt < 5.15
...
Minimum is 5.15 nowadays
2022-06-10 23:12:10 +01:00
Sergio Martins
a1d62522f3
Fix Qt6 build
2022-06-10 19:28:25 +01:00
Sergio Martins
cfd90b6779
tests: Enable tests for QtQuick as they pass now
2022-06-10 19:25:37 +01:00
Sergio Martins
b184c6f830
qtquick: Reduce number of sanity checks during incomplete resizes
...
Fixes the last broken QtQuick test.
2022-06-10 19:24:11 +01:00
Sergio Martins
2aefa9efa0
qtquick: Fix windows being resized bellow their min size
2022-06-10 18:59:53 +01:00
Sergio Martins
5791198c51
qtquick: Fix some benign sizing warnings
...
During resize QtQuick will trigger lots of calls to setSize()
since it updates the width and the height separately.
Run our sanity checks only after with width and height are done
being updated, and not twice
2022-06-10 15:33:16 +01:00
Sergio Martins
a94daba3fc
Bound the suggested floating window geometry
...
Because why not, seems correct. No bug would happen with QtWidgets
since QtWidgets respect the min sizes of their children, but for
QtQuick it's more flaky as there's no intrinsic mechanism for
min sizes, so give it some help
2022-06-10 14:16:57 +01:00
Sergio Martins
8e85e46ee9
tests: Make the view min size be the same as it was in 1.x
2022-06-08 19:02:01 +01:00
Sergio Martins
118fe3d32e
qtquick: Fix guest view not getting parented when getting added
...
To be improved on milestone 3
2022-06-08 12:22:57 +01:00
Sergio Martins
fb31f893ae
Remove unneeded QJsonDocument include
2022-06-08 00:59:16 +01:00
Sergio Martins
d275226df9
qtquick: Fix Stack creating two TabBar's
...
It's created by the controller, we shouldn't create another one
in the view
2022-06-08 00:32:14 +01:00
Sergio Martins
a5279b5efd
qtquick: Minor refactoring, add TabBar_qtquick::qmlTabs()
2022-06-08 00:00:41 +01:00
Sergio Martins
81007f629f
qtquick: Fix flaky handling of tabs
...
The flickable of TabBar from QtQuickControls has a bogus contentX
when removing and readding tabs. Instead implement tabAt() via
iteration and checking which tab contains the point
2022-06-07 23:34:54 +01:00
Sergio Martins
060fe44e71
Remove some unneeded QApplication includes
2022-06-07 17:14:05 +01:00
Sergio Martins
3c13f51017
tests: Also resize the view, not only the window when creating main window
...
Both are needed. This is how it worked in v1
2022-06-07 00:24:38 +01:00
Sergio Martins
ad9cdad927
qtquick: Don't do geometry changes at destruction
...
It's unneeded and makes tests fail. Setting visibility would trigger
a bunch of code that we don't want at destruction time
2022-06-06 23:53:22 +01:00
Sergio Martins
31992dcb83
tests: Fix tst_honourGeometryOfHiddenWindow on XCB
...
The suggested height should be smaller than the floating window
min-size.
2022-06-06 23:35:31 +01:00
Sergio Martins
a5ecfbdd91
tests: Fix createMainWindow having different behavior between frontends
2022-06-06 23:03:53 +01:00
Sergio Martins
0929fb1c75
qtquick: Fix showing qtquick window not setting the root item visible
2022-06-06 15:43:53 +01:00
Sergio Martins
4515c85f91
Don't call "Frame::isMDI" when layout is being destroyed
...
Just emit the signal always, QtQuick will reread the property.
It's better than doing a complex solution
2022-06-06 15:30:34 +01:00
Sergio Martins
230f562cb4
qtquick: Fix floating window being deleted at construction
...
When the window is hidden we destroy it, but not while it's
still being constructed.
2022-06-06 14:58:09 +01:00
Sergio Martins
3758dc7dda
Fix weird logic in FloatingWindow::isBeingDeleted()
2022-06-06 14:48:58 +01:00
Sergio Martins
464624f2a5
qtquick: Don't dereference FloatingWindow while it's being destructed
...
Caught by UBSAN
2022-06-06 13:53:31 +01:00
Sergio Martins
0be61b0a1b
qtquick: Don't delete dock widgets in frame view dtor
...
views shouldn't delete controllers
2022-06-06 13:44:53 +01:00
Sergio Martins
5faf36700b
Use qGuiApp instead of qApp
...
As QtQuick applications might not have QApplication.
2022-06-06 13:24:38 +01:00
Sergio Martins
995df8e3e8
qtquick: Remove qFatal in TabBar_qtquick::tabsAreMovable
...
It wasn't implemented in v 1.x either.
2022-06-06 11:29:14 +01:00
Sergio Martins
14189dc601
Make LayoutSaver deserializeWindowGeometry deal in Window instead of View
2022-06-06 11:23:07 +01:00
Sergio Martins
9c881ec53e
Normalize how we set top level window geometry
...
Prefer Window API, since for QtQuick the root view isn't so tighly
coupled with the QWindow as in QWidgets world. Hide the difference in
Window_qtwidgets.cpp, which now prefers the QWidget API whenever possible,
as that's better tested than using QWindow direclty.
2022-06-06 11:17:42 +01:00
Sergio Martins
581451c342
Remove old ViewWrapper::asDropArea()
...
It's unneeded, and it wasn't implemented for QtQuick
2022-06-06 10:28:44 +01:00
Sergio Martins
eb198736b8
qtquick: Fixed drag indicators not working on main window
...
ViewWrapper::asDropArea() was dummy. Will remove it.
2022-06-06 10:23:48 +01:00
Sergio Martins
e8f390f2ad
tests|qtquick: Don't create lots of spurious QQuickView
...
Most of the times we just want to create a dock widget which
will be parented immediately, we don't need the window.
2022-06-06 10:13:19 +01:00
Sergio Martins
2beb4982b0
qtquick: Make Window_qtquick::rootView() behave like in v 1.x
...
The MainWindow might not be the QQuickView's root item, but
version 1.x would still return that. So preserve that, since it's
what tests expect.
We can improve after having tests passing.
2022-06-06 09:42:06 +01:00