minor: Make indexOfDockWidget() take a const dock widget

So it can be called from const places
This commit is contained in:
Sergio Martins
2021-01-29 18:17:16 +00:00
parent 1eaac74fb0
commit 78c2cdddc4
11 changed files with 16 additions and 16 deletions

View File

@@ -199,7 +199,7 @@ FloatingWindow* Frame::detachTab(DockWidgetBase *dockWidget)
return floatingWindow;
}
int Frame::indexOfDockWidget(DockWidgetBase *dw)
int Frame::indexOfDockWidget(const DockWidgetBase *dw)
{
if (m_inCtor || m_inDtor) return -1;

View File

@@ -84,7 +84,7 @@ public:
FloatingWindow *detachTab(DockWidgetBase *);
///@brief returns the index of the specified dock widget
int indexOfDockWidget(DockWidgetBase *);
int indexOfDockWidget(const DockWidgetBase *);
///@brief returns the index of the current tab
int currentIndex() const;
@@ -293,7 +293,7 @@ protected:
QSize biggestDockWidgetMaxSize() const;
virtual void removeWidget_impl(DockWidgetBase *) = 0;
virtual int indexOfDockWidget_impl(DockWidgetBase *) = 0;
virtual int indexOfDockWidget_impl(const DockWidgetBase *) = 0;
virtual int currentIndex_impl() const = 0;
virtual void setCurrentTabIndex_impl(int index) = 0;
virtual void setCurrentDockWidget_impl(DockWidgetBase *) = 0;

View File

@@ -109,7 +109,7 @@ public:
/**
* @brief Returns the index of the dock widget, or -1 if it doesn't exist
*/
virtual int indexOfDockWidget(DockWidgetBase *) const = 0;
virtual int indexOfDockWidget(const DockWidgetBase *) const = 0;
/**
* @brief Sets the current dock widget index

View File

@@ -84,7 +84,7 @@ void FrameQuick::removeWidget_impl(DockWidgetBase *dw)
disconnect(m_connections.take(dw));
}
int FrameQuick::indexOfDockWidget_impl(DockWidgetBase *dw)
int FrameQuick::indexOfDockWidget_impl(const DockWidgetBase *dw)
{
return m_tabWidget->indexOfDockWidget(dw);
}

View File

@@ -49,7 +49,7 @@ public:
protected:
void removeWidget_impl(DockWidgetBase *) override;
int indexOfDockWidget_impl(DockWidgetBase *) override;
int indexOfDockWidget_impl(const DockWidgetBase *) override;
int currentIndex_impl() const override;
void setCurrentTabIndex_impl(int index) override;
void setCurrentDockWidget_impl(DockWidgetBase *) override;

View File

@@ -43,7 +43,7 @@ void TabWidgetQuick::removeDockWidget(DockWidgetBase *dw)
m_dockWidgetModel->remove(dw);
}
int TabWidgetQuick::indexOfDockWidget(DockWidgetBase *dw) const
int TabWidgetQuick::indexOfDockWidget(const DockWidgetBase *dw) const
{
return m_dockWidgetModel->indexOf(dw);
}
@@ -186,9 +186,9 @@ void DockWidgetModel::remove(DockWidgetBase *dw)
}
}
int DockWidgetModel::indexOf(DockWidgetBase *dw)
int DockWidgetModel::indexOf(const DockWidgetBase *dw)
{
return m_dockWidgets.indexOf(dw);
return m_dockWidgets.indexOf(const_cast<DockWidgetBase*>(dw));
}
bool DockWidgetModel::insert(DockWidgetBase *dw, int index)

View File

@@ -46,7 +46,7 @@ public:
int numDockWidgets() const override;
void removeDockWidget(DockWidgetBase *) override;
int indexOfDockWidget(DockWidgetBase *) const override;
int indexOfDockWidget(const DockWidgetBase *) const override;
DockWidgetModel *dockWidgetModel() const;
DockWidgetBase *dockwidgetAt(int index) const override;
int currentIndex() const override;
@@ -88,7 +88,7 @@ public:
QVariant data(const QModelIndex &index, int role) const override;
DockWidgetBase *dockWidgetAt(int index) const;
void remove(DockWidgetBase *);
int indexOf(DockWidgetBase *);
int indexOf(const DockWidgetBase *);
bool insert(DockWidgetBase *dw, int index);
bool contains(DockWidgetBase *dw) const;
protected:

View File

@@ -101,7 +101,7 @@ QSize FrameWidget::maxSizeHint() const
return waste + biggestDockWidgetMaxSize();
}
int FrameWidget::indexOfDockWidget_impl(DockWidgetBase *dw)
int FrameWidget::indexOfDockWidget_impl(const DockWidgetBase *dw)
{
return m_tabWidget->indexOfDockWidget(dw);
}

View File

@@ -39,7 +39,7 @@ public:
protected:
void paintEvent(QPaintEvent *) override;
QSize maxSizeHint() const override;
int indexOfDockWidget_impl(DockWidgetBase *) override;
int indexOfDockWidget_impl(const DockWidgetBase *) override;
void setCurrentDockWidget_impl(DockWidgetBase *) override;
int currentIndex_impl() const override;
void insertDockWidget_impl(DockWidgetBase *, int index) override;

View File

@@ -69,9 +69,9 @@ void TabWidgetWidget::removeDockWidget(DockWidgetBase *dw)
removeTab(indexOf(dw));
}
int TabWidgetWidget::indexOfDockWidget(DockWidgetBase *dw) const
int TabWidgetWidget::indexOfDockWidget(const DockWidgetBase *dw) const
{
return indexOf(dw);
return indexOf(const_cast<DockWidgetBase*>(dw));
}
void TabWidgetWidget::mouseDoubleClickEvent(QMouseEvent *ev)

View File

@@ -40,7 +40,7 @@ public:
int numDockWidgets() const override;
void removeDockWidget(DockWidgetBase *) override;
int indexOfDockWidget(DockWidgetBase *) const override;
int indexOfDockWidget(const DockWidgetBase *) const override;
Q_SIGNALS:
void currentTabChanged(int index) override;