philipp/qhttpengine
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed bool return value from QHttpHandler::process().

Browse Source
This commit is contained in:
Nathan Osman
2015-07-03 16:06:02 -07:00
parent f669517982
commit 6a77b01f27
11 changed files with 87 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/TestQFilesystemHandler.cpp
View File

@@ -63,26 +63,26 @@ void TestQFilesystemHandler::initTestCase()
void TestQFilesystemHandler::testRequests_data()
{
QTest::addColumn<bool>("success");
QTest::addColumn<QString>("path");
QTest::addColumn<int>("statusCode");
QTest::newRow("nonexistent resource")
<< false
<< "nonexistent";
<< "nonexistent"
<< 404;
QTest::newRow("outside document root")
<< false
<< "../outside";
<< "../outside"
<< 404;
QTest::newRow("inside document root")
<< true
<< "inside";
<< "inside"
<< 200;
}
void TestQFilesystemHandler::testRequests()
{
QFETCH(bool, success);
QFETCH(QString, path);
QFETCH(int, statusCode);
QFilesystemHandler handler(QDir(dir.path()).absoluteFilePath("root"));
@@ -92,15 +92,9 @@ void TestQFilesystemHandler::testRequests()
QSimpleHttpClient client(pair.client());
QHttpSocket *socket = new QHttpSocket(pair.server(), &pair);
QCOMPARE(handler.process(socket, path), success);
handler.process(socket, path);
if(success) {
QSignalSpy destroyedSpy(socket, SIGNAL(destroyed()));
QTRY_COMPARE(client.statusCode(), 200);
QTRY_COMPARE(client.data(), Data);
QTRY_COMPARE(destroyedSpy.count(), 1);
}
QTRY_COMPARE(client.statusCode(), statusCode);
}
bool TestQFilesystemHandler::createFile(const QString &path)