This implementation has the following issues:
1) pthreads implementation only -- we still need a windows version.
2) must investigate thread cancelation issues
3) Error reporting is very poor. I followed the error reporting on
the existing thread safe code, but this should be re-visited and
improved.
Code is currently setup to use the new recursive R/W lock instead of
the global mutex to control entry to the library in threadsafe builds.
To revert to the global mutex, set H5TS__USE_REC_RW_LOCK_FOR_GLOBAL_MUTEX
in H5TSprivate.h to FALSE.
Added a reasonably robust regression test for the reursive R/W lock
in test/ttsafe_rec_rw_lock.c
Note that the change to hl/src/H5LTanalyse.c is an artifact of clang-format.
Tested serial threadsafe debug and production on jelly, and also regular
serial / debug.
On Windows builds, the new recursive R/W lock should not be built and
we should use the existing global mutex -- however this is not tested
at this time.
159 lines
5.1 KiB
C
159 lines
5.1 KiB
C
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
|
|
* Copyright by The HDF Group. *
|
|
* Copyright by the Board of Trustees of the University of Illinois. *
|
|
* All rights reserved. *
|
|
* *
|
|
* This file is part of HDF5. The full HDF5 copyright notice, including *
|
|
* terms governing use, modification, and redistribution, is contained in *
|
|
* the COPYING file, which can be found at the root of the source code *
|
|
* distribution tree, or in https://support.hdfgroup.org/ftp/HDF5/releases. *
|
|
* If you do not have access to either file, you may request a copy from *
|
|
* help@hdfgroup.org. *
|
|
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
|
|
|
|
/*
|
|
* FILE
|
|
* ttsafe.c - HDF5 threadsafe testing framework main file.
|
|
*
|
|
* REMARKS
|
|
* General test wrapper for HDF5 library thread safety test programs
|
|
*
|
|
* DESIGN
|
|
* Each test function should be implemented as function having no
|
|
* parameters and returning void (i.e. no return value). They should be put
|
|
* into the list of InitTest() calls in main() below. Functions which depend
|
|
* on other functionality should be placed below the InitTest() call for the
|
|
* base functionality testing.
|
|
* Each test module should include ttsafe.h and define a unique set of
|
|
* names for test files they create.
|
|
*
|
|
*/
|
|
|
|
/* ANY new test needs to have a prototype in ttsafe.h */
|
|
#include "ttsafe.h"
|
|
|
|
#define MAX_NUM_NAME 1000
|
|
#define NAME_OFFSET 6 /* offset for "name<num>" */
|
|
|
|
/* pre-condition: num must be a non-negative number */
|
|
H5_ATTR_PURE static unsigned
|
|
num_digits(int num)
|
|
{
|
|
unsigned u;
|
|
|
|
if (num == 0)
|
|
return 1;
|
|
|
|
for (u = 0; num > 0; u++)
|
|
num = num / 10;
|
|
|
|
return u;
|
|
}
|
|
|
|
/* Test the H5is_library_threadsafe() function */
|
|
void
|
|
tts_is_threadsafe(void)
|
|
{
|
|
hbool_t is_ts;
|
|
hbool_t should_be;
|
|
|
|
#ifdef H5_HAVE_THREADSAFE
|
|
is_ts = FALSE;
|
|
should_be = TRUE;
|
|
#else /* H5_HAVE_THREADSAFE */
|
|
is_ts = TRUE;
|
|
should_be = FALSE;
|
|
#endif /* H5_HAVE_THREADSAFE */
|
|
|
|
if (H5is_library_threadsafe(&is_ts) != SUCCEED)
|
|
TestErrPrintf("H5_is_library_threadsafe() call failed - test failed\n");
|
|
|
|
if (is_ts != should_be)
|
|
TestErrPrintf("Thread-safety value incorrect - test failed\n");
|
|
|
|
return;
|
|
}
|
|
|
|
/* Routine to generate attribute names for numeric values */
|
|
char *
|
|
gen_name(int value)
|
|
{
|
|
char * temp;
|
|
unsigned length;
|
|
int i;
|
|
|
|
length = num_digits(MAX_NUM_NAME - 1);
|
|
temp = (char *)HDmalloc(NAME_OFFSET + length + 1);
|
|
temp = HDstrcpy(temp, "attrib");
|
|
temp[NAME_OFFSET + length] = '\0';
|
|
|
|
for (i = (int)(length - 1); i >= 0; i--) {
|
|
temp[NAME_OFFSET + i] = (char)((int)'0' + value % 10);
|
|
value = value / 10;
|
|
}
|
|
|
|
return temp;
|
|
}
|
|
|
|
int
|
|
main(int argc, char *argv[])
|
|
{
|
|
|
|
/* Initialize testing framework */
|
|
TestInit(argv[0], NULL, NULL);
|
|
|
|
/* Tests are generally arranged from least to most complexity... */
|
|
AddTest("is_threadsafe", tts_is_threadsafe, NULL, "library threadsafe status", NULL);
|
|
#ifdef H5_HAVE_THREADSAFE
|
|
|
|
AddTest("rec_rwlock_1", tts_rec_rw_lock_smoke_check_1, cleanup_rec_rw_lock_smoke_check_1,
|
|
"recursive R/W lock smoke check 1 -- basic", NULL);
|
|
|
|
AddTest("rec_rwlock_2", tts_rec_rw_lock_smoke_check_2, cleanup_rec_rw_lock_smoke_check_2,
|
|
"recursive R/W lock smoke check 2 -- mob of readers", NULL);
|
|
|
|
AddTest("rec_rwlock_3", tts_rec_rw_lock_smoke_check_3, cleanup_rec_rw_lock_smoke_check_3,
|
|
"recursive R/W lock smoke check 3 -- mob of writers", NULL);
|
|
|
|
AddTest("rec_rwlock_4", tts_rec_rw_lock_smoke_check_4, cleanup_rec_rw_lock_smoke_check_4,
|
|
"recursive R/W lock smoke check 4 -- mixed mob", NULL);
|
|
|
|
AddTest("dcreate", tts_dcreate, cleanup_dcreate, "multi-dataset creation", NULL);
|
|
AddTest("error", tts_error, cleanup_error, "per-thread error stacks", NULL);
|
|
#ifdef H5_HAVE_PTHREAD_H
|
|
/* Thread cancellability only supported with pthreads ... */
|
|
AddTest("cancel", tts_cancel, cleanup_cancel, "thread cancellation safety test", NULL);
|
|
#endif /* H5_HAVE_PTHREAD_H */
|
|
AddTest("acreate", tts_acreate, cleanup_acreate, "multi-attribute creation", NULL);
|
|
AddTest("attr_vlen", tts_attr_vlen, cleanup_attr_vlen, "multi-file-attribute-vlen read", NULL);
|
|
|
|
#else /* H5_HAVE_THREADSAFE */
|
|
|
|
HDprintf("Most thread-safety tests skipped because THREADSAFE not enabled\n");
|
|
|
|
#endif /* H5_HAVE_THREADSAFE */
|
|
|
|
/* Display testing information */
|
|
TestInfo(argv[0]);
|
|
|
|
/* Parse command line arguments */
|
|
TestParseCmdLine(argc, argv);
|
|
|
|
/* Perform requested testing */
|
|
PerformTests();
|
|
|
|
/* Display test summary, if requested */
|
|
if (GetTestSummary())
|
|
TestSummary();
|
|
|
|
/* Clean up test files, if allowed */
|
|
if (GetTestCleanup() && !getenv("HDF5_NOCLEANUP"))
|
|
TestCleanup();
|
|
|
|
/* Release test infrastructure */
|
|
TestShutdown();
|
|
|
|
return GetTestNumErrs();
|
|
|
|
} /* end main() */
|