0c21f00cf8
HDFFV-5919 - GMQS: h5diff - The number of object difference is not consistent between dataset and group/type when attribute(s) have differences
Description:
Object differences are not consistent between dataset and group/datatype when their attribute(s) have differences. This is because attribute(s) differences is not accumulated to group or datatype object’s difference, but accumulated to dataset difference.
To fix, do not accumulate attribute difference to dataset difference. This is referred to h5diff’s default behavior and also past report from users that users were confused by the accumulated behavior. (also can’t figure out only for dataset difference , also hard to spot dataset difference when it has lots of attributes or differences)
This also lead to fix inconsistent format indicating difference between dataset and group/datatype object.
Merged from HDF5 trunk r22751.
Tested:
jam (linux32-LE), koala (linux64-LE), ostrich (linuxppc64-BE), tejeda (mac32-LE), linew (solaris-BE), Windows (32-LE cmake), cmake (jam)
13 lines
555 B
Plaintext
13 lines
555 B
Plaintext
dataset: </g2/dset1> and </g2/dset1>
|
|
3 differences found
|
|
Not comparable: <attr1> is of class H5T_INTEGER and <attr1> is of class H5T_STRING
|
|
Not comparable: <attr2> has rank 1, dimensions [3], max dimensions [3]
|
|
and <attr2> has rank 1, dimensions [4], max dimensions [4]
|
|
Not comparable: <attr3> has rank 1, dimensions [3], max dimensions [3]
|
|
and <attr3> has rank 2, dimensions [3x1], max dimensions [3x1]
|
|
attribute: <attr4 of </g2/dset1>> and <attr4 of </g2/dset1>>
|
|
3 differences found
|
|
dataset: </g2/dset2> and </g2/dset2>
|
|
3 differences found
|
|
EXIT CODE: 1
|