Commit Graph

37 Commits

Author SHA1 Message Date
Sean McBride
f6c49fe891 More clang tidy (#908)
* Pacify clang-analyzer-unix.cstring.NullArg

* Apply some bugprone-suspicious-string-compare

* Apply some readability-simplify-boolean-expr

* Apply some readability-make-member-function-const

* Apple some bugprone-macro-parentheses

* Changed an f suffix to L for `long double`

* Applied some readability-uppercase-literal-suffix automatically

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2021-08-23 16:14:53 -05:00
Dana Robinson
50d0888f49 C++ warning and build fixes (#707)
* Committing clang-format changes

* C++ build and warning updates

* Fixes all warnings on C++ (with gcc 9.3)
* Updates CMake and Autotools C++ builds

* Undo warning clobber

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2021-06-01 08:49:39 -05:00
Quincey Koziol
c6e4e53546 Update clang config (#473)
* Update clang config to put H5E_BEGIN_TRY / H5E_END_TRY on separate lines, empty C++ methods on separate lines, understand that ALL_MEMBERS / UNIQUE_MEMBERS are foreach macros, and properly skip the 'config' directory in the find command without emiting a warning

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2021-03-17 10:25:39 -05:00
Sean McBride
d7b40604ef Fixed all clang-tidy bugprone-suspicious-string-compare warnings (#451)
* Fixed all clang-tidy bugprone-suspicious-string-compare warnings

This change was generated entirely by clang-tidy itself.

* Reformat code with clang v10.0.1.

Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
2021-03-10 12:42:35 -06:00
Sean McBride
580008d5bb More warning fixes (#400)
* Fixed -Wunused-local-typedef warning

* Fixed -Wformat warnings

In one case also removed a `z` character. There was a `z%d` that I think was supposed to be `%zd`

* Fixed -Wshorten-64-to-32 warnings

* Fixed -Wself-assign warnings

* Fixed -Wreserved-id-macro warnings

* Commit format changes from clang-format, clang version 10.0.1.

* Fixed -Wself-assign warnings

* Fixed -Wunused-local-typedef warning

* Fixed -Wformat warnings

In two cases also removed a `z` character. There was a `z%d` that was supposed to be `%zd`.

* Fixed -Wshorten-64-to-32 warnings

* Fixed -Wreserved-id-macro warnings

* Fixed -Wself-assign warnings

* Format source.

* Remove blank lines to pass format check.

Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
2021-03-04 15:06:30 -06:00
Larry Knox
2ea165efd0 Update license url part2 (#333)
* Modify temporary rpath for testing in java example scripts.

* Update URL in source file Copyright headers for web copy of COPYING
    file - files not in src or test.
2021-02-17 08:52:36 -06:00
Allen Byrne
b2d661b508 Clang-format of source files 2020-09-30 09:27:10 -05:00
Allen Byrne
7f44915b44 Fix NoFilter build 2020-04-24 07:49:39 -05:00
Allen Byrne
ef70c1695d Fix shadowed type 2020-04-13 10:25:44 -05:00
Allen Byrne
2bce24576e This test cannot use HD prefix macro with printf of fprintf 2019-08-17 13:33:41 -05:00
Allen Byrne
96bf97f534 Update HD prefix and reconcile hl/cpp test 2019-08-16 13:23:29 -05:00
Allen Byrne
64e6665b54 Add HD prefix to tests 2019-08-15 16:46:15 -05:00
Larry Knox
89fbe00dec Merge pull request #426 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10 to hdf5_1_10
* commit '54957d37f5aa73912763dbb6e308555e863c43f4':
  Commit copyright header change for src/H5PLpkg.c which was added after running script to make changes.
  Add new files in release_docs to MANIFEST. Cimmit changes to Makefile.in(s) and H5PL.c that resulted from running autogen.sh.
  Merge pull request #407 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10_1 to hdf5_1_10_1
  Change copyright headers to replace url referring to file to be removed and replace it with new url for COPYING file.
2017-04-25 16:05:36 -05:00
Binh-Minh Ribler
889d7fd733 Description:
- In the test for HDFFV-9758, a pragma pack(1) caused failure on Emu
      because Sparc cannot access misaligned data.  Changed it to pack() to
      do the default alignment.
    - Added DOXYGEN_SHOULD_SKIP_THIS blocks to private elements to prevent
      warnings from doxygen.
Platforms tested:
    SunOS 5.11 (emu)
    Linux/32 2.6 (jam)
2016-10-26 14:16:24 -05:00
Binh-Minh Ribler
061b758c29 Description:
User's sample code used "not" instead of "!" and Windows does
    not like that.  Fixed.
Platforms tested:
    Linux/32 2.6 (jam)
    Darwin (osx1010test)
2016-10-24 09:56:01 -05:00
Binh-Minh Ribler
b3b7ae087e Purpose: Fix Packet Table issues cont.
Description:
    Misc cleanups and comments in tests.
Platforms tested:
    Linux/32 2.6 (jam)
    Darwin (osx1010test)
    Linux/64 (jelly)
2016-10-23 21:03:47 -05:00
Binh-Minh Ribler
14e308b2e6 Description:
- Removed calls to H5Tget_native_type in the PT code. The application would
    need to do that if desired.
    - Added Abhi's program to tests to verify the fix.
    - This fix might have fixed HDFFV-9927, HDFFV-9042, and the issue reported
      by Barbara Jones from Ametek as well.
Platforms tested:
    Linux/32 2.6 (jam)
    Linux/64 (jelly)
    Darwin (osx1010test)
2016-10-20 14:07:45 -05:00
Binh-Minh Ribler
75b926c96a [svn-r29803] Purpose: Code improvement
Description:
    The constructor FL_PacketTable added in 1.10.0 did not have good
    prototype; it didn't allow the property list to be default.  Marked
    it deprecated and added this one:

        FL_PacketTable(hid_t fileID, const char* name, hid_t dtypeID,
                       hsize_t chunkSize = 0, hid_t plistID = H5P_DEFAULT)
Platforms tested:
    Linux/32 2.6 (jam)
    Linux/64 (platypus)
    Darwin (osx1010test)
2016-04-25 23:15:52 -05:00
Binh-Minh Ribler
bd4d0d62bd [svn-r29710] Purpose: Code improvements
Description:
    - Replaced "goto out" and "out:" with "goto error" and "error:" to indicate
      the failure situations.
    - Replaced old-style casts with static_cast to remove warnings.
Platforms tested:
    Linux/32 2.6 (jam)
    Linux/64 (platypus)
    Darwin (osx1010test)
2016-04-15 14:08:28 -05:00
Binh-Minh Ribler
8222b34406 [svn-r29364] Purpose: Improve C++ Packet Table library
Description:
    Performed similar improvement as the C Packet Table library.
      - Removed the VLPT_REMOVED ifdef around class VL_PacketTable
      - Moved VL_PacketTable::IsVariableLength to PacketTable
      - Moved VL_PacketTable::FreeReadBuff to PacketTable::FreeBuff
      - Added overloaded constructor to FL_PacketTable that takes a
        property list ID and call the new C API H5PTcreate.
      - Added accessor wrappers to class PacketTable, per HDFFV-8623/patch 003.
            /* Returns the ID of the dataset associated with the packet table */
            hid_t GetDataset();

            /* Returns the ID of the datatype the packet table uses */
            hid_t GetDatatype();
      - Replaced appropriate calls in tests
      - Various cleanup
Platforms tested:
    Linux/32 2.6 (jam)
    Linux/64 (platypus)
    Darwin (osx1010test)
2016-03-09 01:47:27 -05:00
Allen Byrne
97569890f8 [svn-r21175] Release datatypes created locally 2011-08-05 14:43:34 -05:00
Quincey Koziol
bdd7d59902 [svn-r15628] Description:
Remove trailing whitespace from C/C++ source files, with the following
script:

    foreach f (*.[ch] *.cpp)
        sed 's/[[:blank:]]*$//' $f > sed.out && mv sed.out $f
    end

Tested on:
    Mac OS X/32 10.5.5 (amazon)
    No need for h5committest, just whitespace changes...
2008-09-16 10:52:51 -05:00
Quincey Koziol
507a211257 [svn-r15462] Description:
Correct compiler warnings from Visual Studio.

Tested on:
    Mac OS X/32 10.5.4 (amazon) w/FORTRAN & C++
    (Too minor to require full h5committest)
2008-08-12 07:46:40 -05:00
Binh-Minh Ribler
05a9cc4c14 [svn-r15408] Purpose: Enable test
Description:
    The daily test failure caused by the C++ API was fixed, so put
    the packet table test back.

Platforms tested:
    SunOS 5.10 (linew)
    Linux 2.6 (kagiso)
    FreeBSD (duty)
2008-07-25 16:56:34 -05:00
Raymond Lu
8704820d1c [svn-r15395] When an attribute was opened twice and data was written with one of the handles,
the file didn't have the data.  It happened because each handle had its own
object structure, and the empty one overwrote the data with fill value.  This is
fixed by making some attribute information like the data be shared in the
attribute structure.

Tested on smirom, kagiso, and linew.
2008-07-22 15:36:31 -05:00
MuQun Yang
46226727d1 [svn-r13857] This test will fail without having zlib library and this is the case for windows 64-bit support. So we add a macro to skip this test if there is no zlib library.
Tested at windows and linux. Too minor to use h5committest.
2007-06-12 16:51:19 -05:00
Albert Cheng
ed7d456e51 [svn-r13253] Updated all C and C++ style source code files with the THG copyright notice.
Tested platform:
Kagiso only since it is only a comment block change.  If it works in one
machine, it should work in all, I hope.  Still need to check the parallel
build on copper.
2007-02-07 09:56:24 -05:00
James Laird
d4daafbc85 [svn-r12775] Fixed HL C++ errors from removing VL packet table. Silly me for
omitting the C++ test in the first place!

Tested on heping (with --enable-cxx!).
2006-10-18 12:56:33 -05:00
James Laird
ce30ee9b28 [svn-r12773] Removed Variable-length packet tables from the HL libraries.
This is a quick change to make sure nothing breaks; VL functions in
the header files have been #ifdef'd out.

Tested on mir.
2006-10-17 16:19:11 -05:00
James Laird
6aeb73dd44 [svn-r12686] Added compression to Packet Tables. Now both C and C++ packet tables
have an extra parameter that sets the deflate filter.

Added tests, made examples use the new APIs.

Cleaned up include files a little and removed some casts that I hope are
superfluous.  If anybody encounters strange errors in the packet table
tests where the chunk size is set to some extremely large value, please
let me know, but I was unable to reproduce this error on any system.

Tested on mir, heping, sol, juniper, VS 6.0.  Looked for the chunk size
error on several other systems a month or two ago.
2006-09-26 13:25:03 -05:00
James Laird
0f61afce1c [svn-r12576] Added funtions to query the "current position" for Packet Tables in C and C++. 2006-08-14 11:18:28 -05:00
Albert Cheng
5b4b3d574f [svn-r11537] Purpose:
Fixed the copyright notice.

Tested in heping.
2005-10-11 11:55:29 -05:00
Quincey Koziol
6b45f5172c [svn-r11245] Purpose:
Code cleanup

Description:
    Trim trailing whitespace, which is making 'diff'ing the two branches
difficult.

Solution:
    Ran this script in each directory:

foreach f (*.[ch] *.cpp)
    sed 's/[[:blank:]]*$//' $f > sed.out && mv sed.out $f
end


Platforms tested:
    FreeBSD 4.11 (sleipnir)
    Too minor to require h5committest
2005-08-13 15:53:35 -05:00
James Laird
8570c314ef [svn-r10729] Purpose:
Cray X1 Port

Description:
Porting 1.7 branch to Cray X1.  With these changes, HDF5 builds, but
there are some errors in the tests.  Working on the errors.

Solution:
Added nv1-cray file to config directory.
Cleaned up some code in hl/c++ that was causing compiler to complain.

Platforms tested:
Cray X1, mir, sleipnir

Misc. update:
2005-05-05 11:51:46 -05:00
James Laird
73e5d04993 [svn-r10467]
Purpose:
Made the C++ Packet Table tests look like other HDF5 tests (using PASSED(), etc.).

Platforms tested:
sleipnir, mir, modi4, windows
2005-03-28 14:55:02 -05:00
James Laird
0faa9455fc [svn-r10461]
Purpose:
Bug fix -- ensure that C++ packet table test cleans up its output file.

Platforms tested:
sleipnir (minor change)
2005-03-28 12:07:18 -05:00
James Laird
9452992c09 [svn-r10459]
Purpose:
Added C++ wrapper for Packet Table API.

Description:
Added macro for high-level C++ library (LIBH5CPP_HL), which changes every
Makefile.in.
Added directories for high-level C++ library (though currently only Packet
Table API is supported).
Added both C++ source and tests.

Platforms tested:
sleipnir, mir, modi4

Misc. update:
2005-03-28 11:32:20 -05:00