Commit Graph

4643 Commits

Author SHA1 Message Date
Allen Byrne
6569d7437a [svn-r24682] Add IF SHARED block around Windows PDB file generation command. 2014-02-04 10:11:36 -05:00
Scot Breitenfeld
ee10548723 [svn-r24681] Description:
Fix for HDF5/HDFFV-8620 H5Rget_name with NULL name parameter fails.
The name parameter now excepts NULL, in which case the length of then
name is returned.


Tested: jam (intel and gnu)
2014-02-04 10:11:20 -05:00
HDF Tester
ddf75b10f6 [svn-r24676] Snapshot version 1.9 release 170 2014-02-02 03:34:20 -05:00
Neil Fortner
132601ba46 [svn-r24635] Change some range check assertions to errors in H5HF_man_remove in an attempt
to aid in diagnosing issue HDFFV-8647.

Tested: ummon
2014-01-16 16:31:26 -05:00
Mohamad Chaarawi
cdcf54a614 [svn-r24598] allocate and use the H5AC_aux_t struct even if num_procs == 1. This
was a bug exposed by running a single process with a program that
generates lots of dirty metadata that needs to be flushed.

h5committest done!
2013-12-30 15:22:28 -05:00
Quincey Koziol
0a506a625b [svn-r24476] Description:
Remove duplicate "intent" flags from top & shared file structures, leaving
    them only in the shared file structure.

Tested on:
    Mac OSX/64 10.9.0 (amazon) w/gcc 4.8, both parallel & serial
    (too minor to require h5committest)
2013-11-30 00:51:42 -05:00
HDF Tester
bc09cdc302 [svn-r24465] Snapshot version 1.9 release 169 2013-11-24 22:31:26 -05:00
Raymond Lu
200e48e08c [svn-r24463] Issue 8484 - Segfault during H5Fopen of corrupt file. I put a condition check to make sure a pointer isn't NULL.
Tested on jam - very simple change.
2013-11-22 15:59:07 -05:00
Raymond Lu
2eb24b16da [svn-r24368] Issue 8147 - clang's -fcatch-undefined-behavior exposed undefined behavior in the alignment detection algorithm for integers in H5detect.c. Quincey decided to solve it in two steps. First, catch illegal instruction signal in the original algorithm. Second, use POSIX __alignof function to detect alignment if it's available. This checkin is the first step.
Tested on wren, jam, ostrich, platypas, and koala.
2013-10-28 16:25:46 -05:00
HDF Tester
56803a1970 [svn-r24362] Snapshot version 1.9 release 168 2013-10-27 04:33:34 -05:00
Raymond Lu
277ee2f7ee [svn-r24360] Jira issue 8528: H5Fget_obj_ids overfilled the list of object IDs by one. This is the second round of checkin after
receiving review comments from people. I put the safeguard in both H5F_get_objects and H5F_get_objects_cb to prevent 
overfill the list.

tested with h5committest.
2013-10-25 14:26:08 -05:00
HDF Tester
8538cf61f9 [svn-r24334] Snapshot version 1.9 release 167 2013-10-20 04:21:31 -05:00
Dana Robinson
e9203a73e2 [svn-r24333] Added a few volatile keywords to H5detect.c to quiet Visual Studio warnings. Also added a void to a Windows-specific function.
These are both trivial changes that don't affect behavior.

Tested on: Visual Studio 2010 on 64-bit Windows 7
2013-10-19 18:43:06 -05:00
HDF Tester
5092f5a30e [svn-r24287] Snapshot version 1.9 release 166 2013-10-13 03:43:04 -05:00
Larry Knox
06aa7b6641 [svn-r24285] Eliminate several "passing argument ... with different width due to prototype" warnings by casting constants to size_t where expected by string functions.
Tested on jam, koala,ostrich and platypus with h5committest.
2013-10-10 16:57:04 -05:00
Mohamad Chaarawi
9d954e1136 [svn-r24270] checkin coverity changes from 10/4/2013.
tested with h5committest
2013-10-09 11:55:33 -05:00
Quincey Koziol
53827d4017 [svn-r24261] Description:
Correct H5I use of skip list to acquire the 'next' pointer in the skip
list after the ID's 'free' callback has been called, since it occasionally
deletes the 'next' node.

	Also a little bit of code cleanup in other modules.

Tested on:
        FreeBSD/32 8.2 (loyalty) w/gcc4.6, w/C++ & FORTRAN, in debug mode
        FreeBSD/64 8.2 (freedom) w/gcc4.6, w/C++ & FORTRAN, in debug mode
        Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x,
                w/C++ & FORTRAN, w/threadsafe, in debug mode
        Linux/64-amd64 2.6 (koala) w/Intel compilers, w/default API=1.6.x,
                w/C++ & FORTRAN, in production mode
        Solaris/32 2.11 (emu) w/deprecated symbols disabled, w/C++ & FORTRAN,
                w/szip filter, w/threadsafe, in production mode
        Linux/PPC 2.6 (ostrich) w/C++ & FORTRAN, w/threadsafe, in debug mode
2013-10-07 14:35:12 -05:00
Quincey Koziol
5f2a34b462 [svn-r24256] Description:
Clean up warnings

Tested on:
    Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
    (too minor for h5committest)
2013-10-04 14:28:22 -05:00
Quincey Koziol
2060d4f6b9 [svn-r24255] Description:
Switch H5I internal data structure from using hash table to skip lists.

Tested on:
    Mac OSX 10.8.4 (amazon) w/C++ & FORTRAN
    FreeBSD, Linux, etc. forthcoming
2013-10-04 12:03:07 -05:00
Allen Byrne
4611f95d4c [svn-r24224] HDFFV-8529: Space separate define strings
Tested: h5committest
2013-09-30 11:52:03 -05:00
HDF Tester
a4ab8b0e1d [svn-r24218] Snapshot version 1.9 release 165 2013-09-29 03:41:59 -05:00
Raymond Lu
421e7549a5 [svn-r24210] Jira issue 8528: H5Fget_obj_ids overfilled the list of object IDs by one. I moved the safeguard in H5F_get_objects_cb
to the beginning of the function to prevent overfill the list.  I added a new test case for this problem and fix in tfile.c.

Tested with h5committest.
2013-09-27 15:15:52 -05:00
Larry Knox
ab239810e1 [svn-r24194] Don't add hdf5 library dependencies to lib files when --disable-sharedlib-rpath configure option is invoked. Fix for HDFFV-8276.
Tested with h5committest and on hdf-duck.
2013-09-23 20:14:24 -05:00
HDF Tester
f9a758f442 [svn-r24186] Snapshot version 1.9 release 164 2013-09-22 04:17:20 -05:00
Neil Fortner
be3a331550 [svn-r24171] Purpose: Fix problem with gcc 4.8
Description:
With optimization enabled, gcc 4.8 inserts garbage into the padding bytes of
floating point types when assigning from a literal constant.  This caused
problems when H5detect.c scanned the bits in floating point types to determine
their properties.

Modified H5detect.c to scan for padding before further analyzing the type, and
to ignore all information in the padding areas.  Also removed code that
temporarily disabled optimization.

Tested: jam, koala, ostrich, platypus (h5committest)
2013-09-19 13:57:41 -05:00
Allen Byrne
0653325f0d [svn-r24167] HDFFV-8513, HDFFV-8522 Plugin testing in h5repack, h5dump.
Add more usage info for UserMacros.
Add new option information about the Plugin default path.

Tested: local linux, jam
2013-09-19 11:38:08 -05:00
Neil Fortner
a80cf34324 [svn-r24140] Purpose: Remove problematic abandonment of error stack
Description:
H5Fis_hdf5 uses H5F_locate_signature to check if the file is hdf5.  If it does
not locate the signature, H5F_locate_signature would issue an error and return
HADDR_UNDEF.  H5Fis_hdf5 does not consider it an error if the signature is not
found, so it does not issue an error or clear the stack.  The filled stack could
then cause issues later on.

Changed H5F_locate_signature to return herr_t, not issue an error if the
signature is not found, and added a parameter for a pointer to the signature
address that the function fills in.

Tested: jam, koala, ostrich (h5committest)
2013-09-13 17:03:22 -05:00
Neil Fortner
309f3e7a23 [svn-r24139] Remove "will never be exectued" warnings in H5detect.c
Tested: jam, koala, ostrich (h5committest)
2013-09-13 16:49:39 -05:00
Allen Byrne
175e82e484 [svn-r24120] HDFFV-8345: plugin test properly checks static-exec result to include test.
Tested: jam
2013-09-10 09:24:34 -05:00
Quincey Koziol
79c8e26fa7 [svn-r24111] Description:
Restrict GCC diagnostic pragmas to only gcc 4.6+

Tested on:
    Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
2013-09-06 14:03:35 -05:00
Allen Byrne
145f1ce9e3 [svn-r24104] HDFFV-8345: add User Defined filters to h5repack.
Reviewed in H5T-61

Tested: local linux - cmake and autotools
2013-09-06 10:15:50 -05:00
Allen Byrne
ddbc3c841c [svn-r24103] Force NO optimization of H5detect.c 2013-09-06 09:44:55 -05:00
Quincey Koziol
5b876c929f [svn-r24101] Description:
Clean up warnings, enable new compiler warning flag(s) and bring back
changes from Coverity branch:

r20813:
Remove the dead code as listed for coverity bug #1722. h5committested.

r20814:
Issue 69: Check return value and throw error if negative return. Also free datatype id on error

r20815:
Use HDstrncpy. --gh

r20816:
Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.

r20817:
Use HDstrncpy and HDstrncat. --gh

r20818:
Purpose: Fix valgrind issues with h5jam

Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().

r20819:
Issue 80: change loop to use int as loop index.

r20820:
Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
    1) it tried to unnecessary free NULL pointer
    2) it tried to allocate c_name buffer that is done by H5Pget_class_name


Tested on:
    Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN
    (too minor to require h5committest)
2013-09-05 15:44:14 -05:00
Raymond Lu
a1fe10691c [svn-r24098] Issue 8500 - H5detect.c has trouble to find info for long double with GCC 4.8. A user in the forum found the
problem in H5detect.c (uninitialized buffer) and provided the solution.  I checked it in yesterday.  But it 
turned out to be a false fix.  So I'm back it out.

Tested on jam - reverse of changes.
2013-09-04 17:09:23 -05:00
Raymond Lu
d50c061d38 [svn-r24095] Issue 8500 - H5detect.c has trouble to find info for long double with GCC 4.8. A user in the forum found the
problem in H5detect.c (uninitialized buffer) and provided the solution.  Allen and I verified it.

Tested with h5committest and CMake on jam, koala, ostrich, playtus, and Allen's virtual machine.
2013-09-03 14:39:34 -05:00
HDF Tester
a4294ab3cc [svn-r24092] Snapshot version 1.9 release 163 2013-09-01 03:37:42 -05:00
Mohamad Chaarawi
a3e0aecb22 [svn-r24087] Rename the private H5RC (reference count) module to H5UC (Use Count).
This is needed to avoid a conflict with the Read Context object to be
introduced in another Project.

No impact on users, since this is a private module, and low for
developers as the RC module use is very sparse in the library.

Tested with h5committest.
2013-08-30 12:05:42 -05:00
HDF Tester
ca60bda9fb [svn-r24068] Snapshot version 1.9 release 162 2013-08-25 03:44:51 -05:00
Allen Byrne
6bc36a0c46 [svn-r24046] HDFFV-8500: set h5detect compile optimization to -O0
will generate correct H5Tinit.c file.

Tested: local gcc 4.8.2 linux
2013-08-21 12:12:08 -05:00
Quincey Koziol
482a9c28e7 [svn-r24030] Description:
Clean up more compiler warnings.

Tested on:
    Mac OSX/64 10.8.4 (amazon) w/gcc, C++ & FORTRAN
    (too minor to require h5committest)
2013-08-19 17:13:15 -05:00
Mohamad Chaarawi
fcb21bb3dd [svn-r24027] merge r 23938 from reduce warnings branch into trunk.
This is the fix for "switch missing default case" warnings in src.
Mohamad & Vailin worked on this patch.
2013-08-19 16:36:03 -05:00
Quincey Koziol
308c378ccd [svn-r24020] Description:
Clean up compiler warnings

Tested on:
    Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
    (too minor to require h5committest)
2013-08-17 15:05:27 -05:00
HDF Tester
407d3db6a4 [svn-r23989] Snapshot version 1.9 release 161 2013-08-11 03:37:02 -05:00
Quincey Koziol
5c3bd21963 [svn-r23988] Description:
Make compiler happier and issue less warnings.

Tested on:
	Mac OSX/64 10.8.4 (amazon) w/gcc 4.8
2013-08-10 13:20:38 -05:00
Neil Fortner
825fe56892 [svn-r23987] Merge r23939 from reduce_warning branch to trunk
Tested: jam, koala, ostrich (h5committest)

Log from r23939:
Fix unused variables warnings in trunk
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros

Tested: koala
2013-08-09 16:59:14 -05:00
Jerome Soumagne
345e57b0b1 [svn-r23985] Merge commit 23937 from reduce_warning branch
Remove unused param (src) and unused var (hl) warnings

Tested on koala
2013-08-09 16:06:46 -05:00
HDF Tester
f1b5d46cd0 [svn-r23968] Snapshot version 1.9 release 160 2013-08-04 03:35:17 -05:00
Neil Fortner
cd7ba8ad55 [svn-r23939] Fix unused variables warnings in trunk
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros

Tested: koala
2013-07-26 17:14:03 -05:00
Mohamad Chaarawi
69e501fc70 [svn-r23938] remove "switch missing default case" in src. 2013-07-26 12:28:26 -05:00
Jerome Soumagne
cb41664db2 [svn-r23937] Remove unused param / var warnings and fix H5HF_sect_single_dblock_info prototype 2013-07-26 12:05:38 -05:00