Fix on Kludge
Description:
Forgot another chunk of parallel I/O code that needed to change for the
generic property list kludge... :-/
Platforms tested:
Parallel Linux 2.2.18smp (eirene)
Kludge
Description:
Since we're only about halfway through converting the internal use of
property lists from the "old way" to the generic property lists, we turned
off snapshots to avoid exposing lots of API changes to users, until the
APIs settled down.
Getting the snapshots rolling again seems to have become a priority, so
some changes are going to have to be made now that were going to be
postponed until we were completely finished with the conversion. This
requires that the old API functions be able to deal with both the old
and new property lists smoothly.
Solution:
Kludge together the property list code so that they can transparently handle
dealing with both the old and new property lists
Platforms tested:
FreeBSD 4.4 (hawkwind)
Adding Feature
Description:
Added new H5Pcopy_prop function to copy a property (value) from one property
list or class to another.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Purpose:
Bug Fix
Description:
Was getting warnings about converting pointers to integers
without a cast.
Solution:
Changed some of the RETURN ERRORs from returning NULL to
returning FAIL instead.
Platforms tested:
Linux
Code cleanup (sorta)
Description:
When the first versions of the HDF5 library were designed, I remembered
vividly the difficulties of porting code from a 32-bit platform to a 16-bit
platform and asked that people use intn & uintn instead of int & unsigned
int, respectively. However, in hindsight, this was overkill and
unnecessary since we weren't going to be porting the HDF5 library to
16-bit architectures.
Currently, the extra uintn & intn typedefs are causing problems for users
who'd like to include both the HDF5 and HDF4 header files in one source
module (like Kent's h4toh5 library).
Solution:
Changed the uintn & intn's to unsigned and int's respectively.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Bug Fix
Description:
The datatype conversion buffer size was only halfway converted from hsize_t
to size_t and was causing problems. Also, the H5P_peek_<foo> routines have
a bunch of identical code.
Solution:
Finished converting the datatype conversion buffer size to size_t and
cleaned up the implementation of the H5P_peek_<foo> routines to call a
common routine instead of reimplementing a bunch of code.
Platforms tested:
Solaris 2.7 (arabica)
New Features!
Description:
Start migrating the internal use of property lists in the library from the
older implementation to the new generic property lists.
Currently, only the dataset transfer property lists are migrated to the
new architecture, all the rest of the property list types are still using
the older architecture.
Also, the backward compatibility features are not implemented yet, so
applications which use dataset transfer properties may need to make the
following changes:
H5Pcreate(H5P_DATASET_XFER) -> H5Pcreate_list(H5P_DATASET_XFER_NEW)
and
H5Pclose(<a dataset transfer property list>) -> H5Pclose_list(id)
This still may have some bugs in it, especially with Fortran, but I should
be wrapping up those later today.
Platforms tested:
FreeBSD 4.4 (hawkwind)
Feature shift
Description:
Take out the v1.2.x compatibility stubs and put in the hooks for v1.4.x
compatibility when needed.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Bug Fix
Description:
H5FD_fapl_copy is being called in H5Pset_driver when copying a dataset
transfer property list instead of H5FD_dxpl_copy and could potentially
cause problems if the file driver information was different.
Solution:
Changed call to H5FD_dxpl_copy() until the generic property code gets
merged in.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Bug Fix
Description:
H5Pset_driver had a resource leak which was dropping dataset transfer IDs
when switching drivers.
Solution:
Decrement dataset transfer ID reference count properly
Platforms tested:
IRIX64 6.5 (modi4)
Bug Fix
Description:
Header file is using incorrect macro for detecting parallel I/O when
backward compability is turned on.
Solution:
Fix header files to define prototypes for parallel I/O property list
functions when compiled with v1.2 backward compatibility turned on.
Platforms tested:
Eyeballed... (Elena will be testing shortly)
Bug fix... (sorta)
Description:
Added --enable-linux-lfs configure flag to have better control over whether
the enable large file support on Linux machines. Also removed the
-malign-double flag for gcc since it can potentially cause errors which
are difficult to detect.
Platforms tested:
Linix 2.2 & 2.4 (eirene and dangermouse)
Bug Fix, Code Cleanup, Code Optimization, etc.
Description:
Fold in the hyperslab speedups, clean up compile warnings and change a
few things from using 'unsigned' or 'hsize_t' to use 'size_t' instead.
Platforms tested:
FreeBSD 4.3 (hawkwind), Solaris 2.7 (arabica), Irix64 6.5 (modi4)
Code fix
Description:
Unresolved references to the image code were left behind when it was removed
from the library..
Solution:
Finished taking out the image stuff...
Platforms tested:
FreeBSD 4.3 (hawkwind)
Bug fix for Pablo integration
Description:
Several API functions were using FUNC_ENTER, without using FUNC_LEAVE,
HRETURN or HRETURN_ERROR to leave the function. (Using "plain" 'return'
statements instead).
Solution:
Changed return statements to FUNC_LEAVE, HRETURN or HRETURN_ERROR, as
appropriate.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code Simplification
Description:
H5Pget_class() was being called from the H5.c module. Changed it so
that it calls H5P_get_class() instead. Also, the H5Pget_class() and
H5P_get_class() functions were identical. Changed so that
H5Pget_class() calls H5P_get_class().
Platforms tested:
Linux
Update
Description:
Changed
#include <hdf_file.h>
construct to
#include "hdf_file.h"
so that the GNU compiler can more easily pick up the dependencies
which it places in the .depend and Dependencies files. Also
regenerated the Dependencies to go along with this.
Platforms tested:
Linux
Bug fix (sort of)
Description:
The RCSID string in H5public.h was causing the C++ code problem as it
was included multiple times and C++ did not like multiple definitions
of the same static variable.
Solution:
Since we don't really make use of the RCSID strings as we have not
installed it in all source files, we decided to remove it.
Platforms tested:
eirene (linux), modi4 (IRIX64-64) both serial and parallel modes.
C++ compatibility fix
Description:
'delete' is a reserved word in C++
Solution:
Change structure member named 'delete' into 'del'
Platforms tested:
FreeBSD 4.2 (hawkwind)
Code checkpoint
Description:
Checkpointing generic property code before removing the older [non-generic]
property list implementation and switching all the property lists to use
the generic code.
Generic properties are feature complete and as fully tested as I can
determine.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Bug Fix
Description:
Generic property code was leaking memory when removing a property from a
property list class in certain situations.
Solution:
Remove property correctly from class in all situations.
Platforms tested:
Solaris 2.7 (arabica)
Code cleanup for C++
Description:
'xor' is a keyword in C++, causing problems compiling the library with a
C++ compiler.
Solution:
Change variables and structure fields from 'xor' to 'xor_val'
Platforms tested:
FreeBSD 4.2 (hawkwind)
Code cleanup.
Description:
Fixed _lots_ (I mean _tons_) of warnings spit out by the gcc with the
extra warnings. Including a few show-stoppers for compression on IRIX
machines.
Solution:
Changed lots of variables' types to more sensible and consistent types,
more range-checking, more variable typecasts, etc.
Platforms tested:
FreeBSD 4.2 (hawkwind), IRIX64-64 (modi4)
Bug Fix
Description:
If the library was compiled with 'NDEBUG' defined, but the user's program
(the fortran API in this case) was compiled with 'NDEBUG' not defined, the
IDs returned from the library would appear to be incorrect.
Solution:
Removed 'ifndef NDEBUG' from around "H5I_TEMPLAX_MAX" definition and error
checking.
Platforms tested:
Linux 2.2 (eirene) & FreeBSD 4.2 (hawkwind)
Bug fix
Description:
When the v1.2 compatibility code was turned on, internal functions in the
library were getting confused.
Solution:
Separated guts of H5Pget_driver call into an API function (the definition
of which depends on the compatibility switch) and an internal function
which always behaves like the v1.3/4 function. Replaced API function calls
in the library code with the internal function.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Code cleanup
Description:
Several places in the code were using -2 as a default value for various
features. However, when a default value is returned from a function that
is supposed to return negative on failure, it was causing confusion and
extra work for users to check for the special value.
Solution:
Replaced hard-coded -2 values in the code with symbolic names, then changed
symbolic names to 0 instead of -2.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Bug fix
Description:
Fixed some typo that cause compiling errors in parallel mode.
Also added a default case in the H5Pget_xfer code to catch
potential future added data transfer mode.
Platforms tested:
IRIX64-64, parallel.
Backward compatibility code
Description:
Add in code to allow the library to emulate the v1.2 API and behavior.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Buglet fix
Description:
Get rid of compiler warnings. The HGOTO_RETURN was returning NULL
when it should have returned FAIL.
Solution:
Swapped the two.
Platforms tested:
Linux
Bug fix and code checkpoint
Description:
HP's compilers didn't seem to like comparing function pointers with '<'
& '>', so I've changed how the function pointers are compared to aviod
those operations. This should fix last night's daily test failures on
opus and sangamon.
Also, more code development for generic property lists.
Platforms tested:
FreeBSD 4.1.1 (hawkwind)
API cleanup
Description:
Tweaked some parts of the generic properties API to reduce warnings.
Platforms tested:
FreeBSD 4.1.1 (hawkwind) & SGI O2K (modi4)
Code updates
Description:
Finished fleshing out code for generic properties, although they are not
used anywhere in the library yet.
Platforms tested:
FreeBSD 4.1.1 (hawkwind)
Bug Fix
Description:
Generic property lists were leaking memory.
Solution:
Tied them into the regular cleanup code called at the library's termination
Platforms tested:
Solaris 2.6 (baldric) & FreeBSD 4.1.1 (hawkwind)
Maintainance & performance enhancements
Description:
Re-arranged header files to protect private symbols better.
Changed optimized regular hyperslab I/O to compute the offsets more
efficiently from previous method of using matrix operations.
Added sequential I/O operations at a more abstract level (at the same level
as H5F_arr_read/write), to support the optimized hyperslab I/O.
Platforms tested:
Solaris 2.6 (baldric) & FreeBSD 4.1.1 (hawkwind)
Implemented new feature
Description:
Added data sieve buffering code to raw I/O data path. This is enabled for
all the VFL drivers except the mpio & core drivers. Also added two new
API functions to control the sieve buffer size: H5Pset_sieve_buf_size() and
H5Pget_sieve_buf_size().
Platforms tested:
Solaris 2.6 (i.e. baldric)
