Commit Graph

314 Commits

Author SHA1 Message Date
David Young
f8096dcea3 Use H5_ATTR_NDEBUG_UNUSED instead of H5_ATTR_SANITY_CHECK. 2020-05-20 09:37:21 -05:00
Quincey Koziol
4ad7dca124 Avoid allocating a chunk index for datasets with 0-sized dimensions, until
the dataset is extended.
2020-05-20 09:37:20 -05:00
Quincey Koziol
d35daa45e9 Trim trailing whitespace 2020-05-20 09:37:19 -05:00
David Young
2360f6e644 testpar/t_2Gio.c: Fix a typo that I think was introduced by a
previous warnings PR.  An array element was assigned to
        itself---shape[2]Â =Â shape[2];---instead of being assigned to
        chunk[2].

fortran/src/H5Pf.c: move conditional compilation controlled by
        H5_NO_DEPRECATED_SYMBOLS outside of a function for readability.

fortran/src/H5match_types.c: put a variable's declaration under the same
        conditional compilation (H5_FORTRAN_HAVE_C_LONG_DOUBLE) as its
        use.

For now, skip compilation of some unused debug dump routines in the JNI.
While I'm in the JNI, delete a set-but-unused variable.

src/H5Z.c: condition a variable declaration on H5_NO_DEPRECATED_SYMBOLS
        so that it's not declared but unused or vice versa.

test/cache_common.h: add an #include in to get some symbols we need to
        avoid implicit declaration warnings.

test/dsets.c: use a more conventional conditional-compilation syntax.

test/dt_arith.c, test/fillval.c: initialize a bunch of uninitialized
        variables before use.

test/vfd.c: pass the expected type of `void **` to posix_memalign(3)
        instead of `int **`.

testpar/t_bigio.c: explicitly compare with 0 instead of using ! when
        "equal to 0?" is the question not "is false?"  Repair some
        indentation while I'm here.

testpar/testpar.h: repair misaligned line-continuation backslashes in a
        macro that probably should be a function so that we don't have
        to fiddle with the line continuation to begin with.

tools/src/h5repack/h5repack_main.c: fix some compiler fussing about
        enums.

tools/test/perform/pio_engine.c: the compiler fusses if you cast a
        function call returning double directly to off_t.  It's ok if
        you cast a variable that's a double to off_t, however.  Write
        and use a new function, sqrto(), to avoid the cast warnings.
2020-05-20 09:31:53 -05:00
Dana Robinson
3290803120 Revert "Revert "Moved -Wunsuffixed-float-constants to the developer warnings.""
This reverts commit 6486e06545.
2020-05-20 09:31:52 -05:00
Dana Robinson
36647e79b9 Revert "Moved -Wunsuffixed-float-constants to the developer warnings."
This reverts commit 12bc75c617.
2020-05-20 09:31:52 -05:00
Dana Robinson
40c5e67e41 Moved -Wunsuffixed-float-constants to the developer warnings. 2020-05-20 09:31:52 -05:00
kmu
30e61cf090 squash cast warning fix 2020-05-20 09:31:52 -05:00
kmu
27c618b91d fix unused related warnings 2020-05-20 09:31:51 -05:00
Dana Robinson
55b41104b9 Tidying from code review. 2020-05-20 09:31:50 -05:00
Dana Robinson
0585e6fb34 Fixed stack and frame size warnings. Not complete, but fixes most of
the easier cases.
2020-05-20 09:31:50 -05:00
Dana Robinson
3e6a192e9c Squashed commit of the token_refactoring branch: 2020-05-20 09:31:50 -05:00
kmu
271bce5b10 remove unnecessary check macro 2020-05-20 09:20:25 -05:00
kmu
1d46e82317 fix intel compile warnings 2020-05-20 09:20:25 -05:00
kmu
fb8f955a73 Revert "fix warnings from Intel compiler"
This reverts commit 8b9338ab57.
2020-05-20 09:20:24 -05:00
kmu
9d8fb46a2c Revert "fix issues from previous PR comments"
This reverts commit d242a900f4.
2020-05-20 09:20:24 -05:00
kmu
f2028c7568 Revert "using a different MACRO"
This reverts commit fc61b7a9f3.
2020-05-20 09:20:24 -05:00
kmu
9a3a13cacb using a different MACRO 2020-05-20 09:20:23 -05:00
kmu
bb53a566e8 fix issues from previous PR comments 2020-05-20 09:20:23 -05:00
kmu
6725222332 fix warnings from Intel compiler 2020-05-20 09:20:23 -05:00
Quincey Koziol
d1d4635550 Small changes from the token_refactoring branch, to reduce the delta to develop 2020-05-20 09:20:23 -05:00
Allen Byrne
9f5fdc677a Remove const 2020-05-20 09:20:21 -05:00
Allen Byrne
344f4139d7 Fix compile error - declaration after executable statement 2020-05-20 09:20:21 -05:00
Dana Robinson
e4f9ad3dbb Yanked -Wc++-compat from the flags used to build the C library in both
the Autotools and CMake.
2020-05-20 09:20:18 -05:00
David Young
77144641df Revert "Make a squash commit of 'Quiet some warnings by adjusting warnings level and fixing some code.' (commit 5c911d8baf)" 2020-05-20 09:20:17 -05:00
David Young
d1ceb04c5d Quiet decleration-after-statement warnings. 2020-05-20 09:19:37 -05:00
David Young
e067612d25 Use HD prefix. 2020-05-20 09:17:26 -05:00
David Young
c8f533cfc3 Merge all of my changes from merge-back-to-feature-vfd_swmr-attempt-1,
including the merge of `hdffv/hdf5/develop`, back to the branch that Vailin and
I share.

Now I need to put this branch on a fork with a less confusing name than
vchoi_fork!
2019-12-09 10:30:58 -06:00
David Young
90a602634e I've changed test/dsets so that every time it needs to visit all
cells in a matrix in an arbitrary order, first it chooses a random
starting `offset` in [0, rows * columns - 1].  Then it chooses a
random `increment` that's relatively prime to `rows * columns`.
Then it visits every cell in `rows * columns` steps:

        for (i = 0; i < rows * columns; i++) {
                visit(cell[offset / columns][offset % columns]);
                offset = (increment + offset) % (rows * columns);
        }

By moving the HDrandom() calls outside of the main loop and visiting
each cell only once, this probably speeds things up quite a bit.  It's
also more resilient to a crummy random sequence.  The new code visits
cells in an order that's probably arbitrary enough for testing purposes.
2019-10-17 16:36:17 -05:00
Dana Robinson
eb78fd8832 Develop normalization with vol_integration.
Mostly peripheral things like the tools and wrappers,
with just enough core library code to support that.
2018-09-18 22:57:37 -07:00
Vailin Choi
b178d80be0 Changes made based on feedback from pull request #1039. 2018-05-14 12:26:48 -05:00
Vailin Choi
e6bc326ec0 Fix for HDFFV-10180 Performance issues with H5Oget_info. 2018-04-24 15:10:13 -05:00
Quincey Koziol
d812c6fe60 Cleanup API context function usage. 2018-03-18 22:51:19 -05:00
Quincey Koziol
f38864920d Merge branch 'develop' of https://bitbucket.hdfgroup.org/scm/hdffv/hdf5 into merge_func_enter_vol
Plus initial steps toward merging API context push into FUNC_ENTER_API* macros
2018-03-18 18:36:49 -05:00
Quincey Koziol
4a17aff408 Add API context interface and use it throughout the library. 2018-03-15 16:54:30 -05:00
Binh-Minh Ribler
39e3da7563 Improving tests
Description:
    - Added test for version bounds with nested datatypes
    - Added script for additional version bound test in h5repack
    - Cleaned up tests for consistency
    - Removed extra included header files
Platforms tested:
    Linux/64 (jelly)
    Linux/64 (moohan)
    Darwin (osx1010test)
2018-02-17 16:18:37 -06:00
Allen Byrne
41d541f1c2 More includes cleanup 2018-02-14 11:14:26 -06:00
Binh-Minh Ribler
0a61befddc Additional tests
Description:
    - Revised and add more variety to version bound tests per review
    - Revised gen_bounds.c per review
Platforms tested:
    Linux/64 (jelly)
    Linux/32 (jam)
    Darwin (osx1010test)
2018-02-13 11:05:08 -06:00
Allen Byrne
637a8f7562 Correct linkage of filters and other libs 2017-11-16 09:04:51 -06:00
Allen Byrne
c577a5e995 HDFFV-10297 update calls to H5Zfilter_avail 2017-10-09 17:00:15 -05:00
Vailin Choi
8935c921f7 Fix for HDFFV-10217 infinite loop in H5VM_power2up().
The function H5VM_power2up() returns the next power of 2 for n.
When n exceeds 2^63, it overflows and becomes 0 causing the infinite looping.
The fix ensures that the function checks for n >= 2^63 and returns 0.
2017-07-10 03:22:48 -05:00
Dana Robinson
1e9354bcf5 Merge branch 'develop' into windows_open 2017-05-31 15:07:49 -07:00
Dana Robinson
18ae45027c Fixed additional minor warnings. 2017-05-25 08:42:18 -04:00
lrknox
c8a5520d3a Call to H5Dopen has H5dopen2 arguments at line 12704 of test/dsets.c -
changed to H5Dopen2 to fix failure with --with-default-api-version=v16
configure option.
2017-05-10 14:44:58 -05:00
Vailin Choi
d436db6c6e Fix for the two issues reported in HDFFV-10051
Modifications made based on the review comments from pull request #494
Tested on moohan, mayll, kituo, platypus, ostrich, osx1010test, quail, emu.
2017-05-08 22:14:20 -05:00
Vailin Choi
6a4f1187cc Fix for the two issues reported in HDFFV-10051:
(1) Repeated open/close of a compact dataset fails due to the
increment of ndims in the dataset structure for every open.
--This is done only for chunked dataset via H5D__chunk_set_sizes().
(2) layout "dirty" flag for a compact dataset is not reset
properly after flushing the data at dataset close.
--Reset the "dirty" flag before flushing the message to the object header
via H5O_msg_write().
Tested on moohan, kituo, platypus, ostrich, osx1010test, quail, emu.
2017-05-06 23:40:44 -05:00
Dana Robinson
734aebc395 Rework of the POSIX file open permissions and macros to clean up
HDopen() calls.

Also fixed a minor const warning in the core VFD.
2017-04-28 18:13:22 -04:00
Dana Robinson
d3b664b6a7 Changed the Windows POSIX open() file permissions to be correct
according to MSDN. Partial fix for HDFFV-9630.
2017-04-28 08:11:29 -07:00
Larry Knox
89fbe00dec Merge pull request #426 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10 to hdf5_1_10
* commit '54957d37f5aa73912763dbb6e308555e863c43f4':
  Commit copyright header change for src/H5PLpkg.c which was added after running script to make changes.
  Add new files in release_docs to MANIFEST. Cimmit changes to Makefile.in(s) and H5PL.c that resulted from running autogen.sh.
  Merge pull request #407 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10_1 to hdf5_1_10_1
  Change copyright headers to replace url referring to file to be removed and replace it with new url for COPYING file.
2017-04-25 16:05:36 -05:00
Quincey Koziol
0313cbb91d Final merge of page buffering branch to develop 2017-03-13 21:30:37 -07:00