Commit Graph

177 Commits

Author SHA1 Message Date
David Young
b5ec806496 Reduce diffs with develop. 2020-05-20 09:37:22 -05:00
David Young
19a6976899 Make sure to initialize vfd_info.fname. 2020-05-20 09:37:22 -05:00
David Young
dd31948823 Reduce diffs with develop. 2020-05-20 09:37:22 -05:00
Quincey Koziol
82e3368f78 Range check # of 'extra' command-line parameters against array size. 2020-05-20 09:37:20 -05:00
Quincey Koziol
2eec9f839b Refactor "extra" command-line arguments, and clean up code so the tool doesn't
assert when exiting.
2020-05-20 09:37:20 -05:00
Quincey Koziol
828504f46a Extend h5debug to support 3-D datasets for chunks. 2020-05-20 09:37:20 -05:00
Jordan Henderson
3454833bf7 Fix memory error in h5dump xml 'escape the string' routine 2020-05-20 09:37:20 -05:00
Dana Robinson
6eebd57742 Further updates to the tools warnings fixes from code review. 2020-05-20 09:37:20 -05:00
Dana Robinson
e0d954f845 Updates to tools warning PR from code review. 2020-05-20 09:37:20 -05:00
Dana Robinson
3efed9c111 Fixes for warnings in the tools code. 2020-05-20 09:37:20 -05:00
Dana Robinson
2f5d6bac34 Fixed h5diff command-line parameters to use 1 and 2 instead of src
and dst.
2020-05-20 09:37:19 -05:00
Dana Robinson
957e4eba9c Added VOL command-line options to (p)h5diff, h5ls, h5dump, and h5mkgrp. 2020-05-20 09:37:19 -05:00
Dana Robinson
ce4be694e8 Separated VFD and VOL parameters in tools. 2020-05-20 09:37:19 -05:00
Quincey Koziol
d35daa45e9 Trim trailing whitespace 2020-05-20 09:37:19 -05:00
Dana Robinson
58dfaafcce Fixed problems with S3 and HDFS VFDs.
* Updated info struct parameter to correct info_string
* Fixed Makefile.am where the S3 VFD was listed twice, causing
  duplicated symbols errors.
2020-05-20 09:35:18 -05:00
Dana Robinson
6609048ecf Update h5repack long arguments for id-->value changes. 2020-05-20 09:34:20 -05:00
Dana Robinson
755971029c Changed identifiers and command-line options from "id" to "value" in tools
code to be in agreement with H5VL API terminology.
2020-05-20 09:34:20 -05:00
Dana Robinson
59d1a0e7a1 Added support for passing connector info strings via the command
line to the tools internals.
2020-05-20 09:31:58 -05:00
Dana Robinson
55e2b3170e Fix for passthrough VOL not passing tools tests due to incorrect
optional callback queries.
2020-05-20 09:31:58 -05:00
Dana Robinson
12ecc595d8 Added checks for native optional call support in some of the tools. 2020-05-20 09:31:57 -05:00
Dana Robinson
2001e80bb2 Misc changes for h5dump VOL changes. 2020-05-20 09:31:57 -05:00
Allen Byrne
f5dc2a2f8d TRILAB-192 add c++ and fortran warnings build systems one file 2020-05-20 09:31:57 -05:00
Dana Robinson
02f8df1937 Fixed unnecessary H5R casts in the tools that were raising warnings. 2020-05-20 09:31:57 -05:00
Dana Robinson
d4a43eebdf Minor renaming in the tools code. 2020-05-20 09:31:57 -05:00
Gerd Heber
a641a130e7 Fix for HDFFV-11065. 2020-05-20 09:31:57 -05:00
Jordan Henderson
ba79f94586 Fix latent bug in h5repack options file reading
Add 'enable-error-stack' option to h5format_convert
2020-05-20 09:31:57 -05:00
Dana Robinson
5b17d45120 Minor renaming in h5dump (addr --> token) 2020-05-20 09:31:57 -05:00
Jordan Henderson
46a9771a9e A few small tweaks to the tools from review 2020-05-20 09:31:56 -05:00
Jordan Henderson
1da4855528 Replace usage of some standard library functions with HD- versions 2020-05-20 09:31:56 -05:00
Jordan Henderson
254388494a Update Tools library to be better compatible with VOL connectors
Modify h5repack to integrate with VOL connectors

Update tools library to accomodate VOL connectors

Update logic in h5tools_fopen for VOL connectors

Add command-line options to h5repack for specifying in/out VOL
connectors

Implement h5tools_set_vol_fapl

Fix library shutdown issue

Integrate ROS3 and HDFS VFDs into new h5tools_get_fapl() scheme

Avoid H5Ocopy in h5repack when using different VOL connectors

Update h5tools_test_utils.c for ROS3 and HDFS integration
2020-05-20 09:31:56 -05:00
Allen Byrne
f4333990dd Add extensive warnings to tools executables 2020-05-20 09:31:56 -05:00
Allen Byrne
0e45724b69 Fix standalone link 2020-05-20 09:31:55 -05:00
Allen Byrne
60a4987f97 TRILAB-142 Change minimum CMake version to 3.12 2020-05-20 09:31:55 -05:00
Muqun Yang
9c3fe9fe7c HDFFV-11014, fix the h5repack issue that misses a few attributes during the repacking. The flag that checks the object reference attribute is not updated properly. The fix is trivial. Just need to move the flag update line into the inner loop. Tested at Jelly. Also update the release.txt. 2020-05-20 09:31:54 -05:00
Allen Byrne
e0e020eb6b Small fixes for tools and skip autotools tests for no filter 2020-05-20 09:31:54 -05:00
David Young
2badc1bf32 Reduce casts of HDcalloc()/HDmalloc() that -Wc++-compat required.
Reduce gratuitous casts---e.g., (size_t)1.

Use the right format string for a pointer.

In the H5C sanity checks, change a "size increase" variable from ssize_t
(too narrow) to int64_t (wide enough).

Parenthesize every appearance of `storage` in the macro
`H5D_CHUNK_STORAGE_INDEX_CHK(storage)` so that you can pass in an
expression like &sc and it works properly.

Disallow re-assignment of the `dset` parameter to H5D__chunk_init()
because it helped assure me that it's safe to replace the repeating
expression `&dset->shared->layout.storage.u.chunk` with `sc` throughout.

Replace lengthy expressions such as
`&dset->shared->layout.storage.u.chunk` with `sc` throughout several
functions in H5Dchunk.c ISTR that the compiler warned that `sc` was
declared but unused in a couple of functions, and then I found that `sc`
could be used in many places.  Maybe the disused `sc` appeared because a
bunch of code was copied and pasted, I don't know.  Anyway, it's a lot
tighter code now that I use `sc`.

In H5D__chunk_update_old_edge_chunks() and H5D__chunk_delete()
I actually expand `sc` and another temporary variable, `pline`,
because they're used only in !defined(NDEBUG) code.  This squashes
unused-variable warnings in the defined(NDEBUG) configuration.

Don't drop the `volatile` qualification with a cast in
tools/src/h5import/h5import.c.
2020-05-20 09:31:53 -05:00
David Young
2360f6e644 testpar/t_2Gio.c: Fix a typo that I think was introduced by a
previous warnings PR.  An array element was assigned to
        itself---shape[2]Â =Â shape[2];---instead of being assigned to
        chunk[2].

fortran/src/H5Pf.c: move conditional compilation controlled by
        H5_NO_DEPRECATED_SYMBOLS outside of a function for readability.

fortran/src/H5match_types.c: put a variable's declaration under the same
        conditional compilation (H5_FORTRAN_HAVE_C_LONG_DOUBLE) as its
        use.

For now, skip compilation of some unused debug dump routines in the JNI.
While I'm in the JNI, delete a set-but-unused variable.

src/H5Z.c: condition a variable declaration on H5_NO_DEPRECATED_SYMBOLS
        so that it's not declared but unused or vice versa.

test/cache_common.h: add an #include in to get some symbols we need to
        avoid implicit declaration warnings.

test/dsets.c: use a more conventional conditional-compilation syntax.

test/dt_arith.c, test/fillval.c: initialize a bunch of uninitialized
        variables before use.

test/vfd.c: pass the expected type of `void **` to posix_memalign(3)
        instead of `int **`.

testpar/t_bigio.c: explicitly compare with 0 instead of using ! when
        "equal to 0?" is the question not "is false?"  Repair some
        indentation while I'm here.

testpar/testpar.h: repair misaligned line-continuation backslashes in a
        macro that probably should be a function so that we don't have
        to fiddle with the line continuation to begin with.

tools/src/h5repack/h5repack_main.c: fix some compiler fussing about
        enums.

tools/test/perform/pio_engine.c: the compiler fusses if you cast a
        function call returning double directly to off_t.  It's ok if
        you cast a variable that's a double to off_t, however.  Write
        and use a new function, sqrto(), to avoid the cast warnings.
2020-05-20 09:31:53 -05:00
kmu
cfcac15f03 fix bad function cast warning 2020-05-20 09:31:53 -05:00
kmu
51f9a51c25 fix Wredundant-decls, Wswitch-default, Wdeclaration-after-statement, Wsign-compare, Wmisleading-indentation, Wshadow 2020-05-20 09:31:53 -05:00
kmu
30e61cf090 squash cast warning fix 2020-05-20 09:31:52 -05:00
Allen Byrne
cfd8856288 Change tools debug macros to not use error stack 2020-05-20 09:31:52 -05:00
kmu
27c618b91d fix unused related warnings 2020-05-20 09:31:51 -05:00
kmu
a6e8f34b7b remove unsed var,function,macro, etc 2020-05-20 09:31:51 -05:00
Dana Robinson
0585e6fb34 Fixed stack and frame size warnings. Not complete, but fixes most of
the easier cases.
2020-05-20 09:31:50 -05:00
Dana Robinson
3e6a192e9c Squashed commit of the token_refactoring branch: 2020-05-20 09:31:50 -05:00
Allen Byrne
16245b0440 Update tools hid_t declarations with H5I_INVALID_HID 2020-05-20 09:20:26 -05:00
kmu
fd374fb234 address problems from comments 2020-05-20 09:20:25 -05:00
kmu
95e509db46 fix and address comments 2020-05-20 09:20:25 -05:00
kmu
271bce5b10 remove unnecessary check macro 2020-05-20 09:20:25 -05:00
kmu
1d46e82317 fix intel compile warnings 2020-05-20 09:20:25 -05:00