philipp/hdf5
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[svn-r29759] Purpose: Code improvements

Browse Source 
Description:
    - Changed object in catch statements to reference
    - Replaced old-style casts or reinterpret_cast with static_cast
    - Removed unused name H5Library::need_cleanup
    - Removed Exception::printError from documentation
Platforms tested:
    Linux/32 2.6 (jam)
    Linux/64 (platypus)
    Darwin (osx1010test)
This commit is contained in:
Binh-Minh Ribler
2016-04-22 06:22:34 -05:00
parent c63f96d6e7
commit c37607eb58
30 changed files with 256 additions and 222 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
c++/src/H5Attribute.cpp
View File

@@ -293,7 +293,7 @@ H5std_string Attribute::getFileName() const
try {
return(p_get_file_name());
}
catch (IdComponentException E) {
catch (IdComponentException& E) {
throw FileIException("Attribute::getFileName", E.getDetailMsg());
}
}
@@ -348,7 +348,7 @@ H5std_string Attribute::getName() const
H5std_string attr_name(""); // attribute name to return
// Preliminary call to get the size of the attribute name
ssize_t name_size = H5Aget_name(id, (size_t)0, NULL);
ssize_t name_size = H5Aget_name(id, static_cast<size_t>(0), NULL);
// If H5Aget_name failed, throw exception
if (name_size < 0)
@@ -630,7 +630,7 @@ void Attribute::p_setId(const hid_t new_id)
try {
close();
}
catch (Exception close_error) {
catch (Exception& close_error) {
throw AttributeIException("Attribute::p_setId", close_error.getDetailMsg());
}
// reset object's id to the given id
@@ -674,7 +674,7 @@ Attribute::~Attribute()
try {
close();
}
catch (Exception close_error) {
catch (Exception& close_error) {
cerr << "Attribute::~Attribute - " << close_error.getDetailMsg() << endl;
}
}