Commit Graph

113 Commits

Author SHA1 Message Date
Sergio Martins
755bc6ac14 cmake: Don't add src/ to include path
Fully qualify includes instead
2022-06-14 16:57:22 +01:00
Sergio Martins
a4d337e891 Fully qualify header paths when including controllers
so this still works when private headers are installed
2022-06-13 23:24:43 +01:00
Sergio Martins
59013303ac examples: Port MyViewFactory to new design
It was commented out still
2022-06-13 22:31:13 +01:00
Sergio Martins
32b6c3acbe Simplify ViewFactory by making it receive View parents instead of Controllers
Users don't need to worry about such details, like casting to QWidget.
2022-06-13 20:35:57 +01:00
Sergio Martins
91398d5fab Minor: Make method protected instead of private 2022-06-13 20:16:11 +01:00
Sergio Martins
ec56120290 Don't include controller headers in view headers
view headers will be installed, so shouldn't leak impl details
much. Controllers are more low level things that the user won't use
much
2022-06-13 19:44:47 +01:00
Sergio Martins
2e4c01f604 Move some m2 TODOs to m3, as they're not related to QtQuick stabilization 2022-06-13 02:46:31 +01:00
Sergio Martins
efc42e8d3f Move updating size constraints from FloatingWindow view to controller 2022-06-13 02:28:56 +01:00
Sergio Martins
e49ecc880e Replace View::onLayoutRequest() with a signal
Which moves more logic into the controllers.
2022-06-13 02:12:12 +01:00
Sergio Martins
cfd4e61a3b Remove View::setLayoutItem()
Because it's specific to Frame
2022-06-13 01:49:06 +01:00
Sergio Martins
b56cf151fe TitleBar_qtwidgets: Header cleanup 2022-06-12 16:34:35 +01:00
Sergio Martins
87414585ea SideBar_qtwidgets: Cleanups
Include cleanups and making things protected/private.
2022-06-12 16:27:04 +01:00
Sergio Martins
3b814866e2 Remove unneeded isVertical() from Sidebar view 2022-06-12 16:21:11 +01:00
Sergio Martins
55620a5d10 TODO cleanup
Removed stale TODOs and promoted some to TODOm2 , as they should
be tackled next
2022-06-12 16:07:29 +01:00
Sergio Martins
6c589f0500 Postpone some m2 TODOs to m3
m2 will focus on QtQuick being usable
2022-06-12 15:25:35 +01:00
Sergio Martins
1acbf48786 Don't depend directly on QSizePolicy, as that's QtWidgets
Introduce our own enum. Soon our qtquick frontend won't link
against QtWidgets
2022-06-11 18:22:38 +01:00
Sergio Martins
581451c342 Remove old ViewWrapper::asDropArea()
It's unneeded, and it wasn't implemented for QtQuick
2022-06-06 10:28:44 +01:00
Sergio Martins
792aaf76da Normalize handling of close event for Frame and FloatingWindow too
Fixes windows not closing correctly for QtQuick
2022-06-05 12:47:53 +01:00
Sergio Martins
f11a6a6a8c Honour View::closeRequested signal
This noramalizes how both qtwidgets and qtquick were handling it.
Fixes tests related to close events in qtquick
2022-06-05 03:23:19 +01:00
Sergio Martins
a2b5f40ed1 qtquick: Implement Stack_qtquick::tabBarObj() 2022-06-04 20:38:40 +01:00
Sergio Martins
9332eb3bf8 Remove unneeded FrameOptions argument from createFrame()
It's passed to the controller, the view doesn't need it.
2022-06-04 20:08:26 +01:00
Sergio Martins
f1f722f1ce Replace TODOv2 tags with TODOm2 and TODOm3 tags
Not all todos are required for milestone m2
2022-06-04 19:53:25 +01:00
Sergio Martins
b9b8bfc430 Fix Werorr build due to missing override 2022-05-31 10:05:39 +01:00
Sergio Martins
9881e0488f windows: Port FloatingWindow's nchittest code
Only DragController needs to be ported on Windows now
2022-05-30 23:36:54 +01:00
Sergio Martins
5a4342c0af windows: Port FloatingWindow::nativeEventFilter() 2022-05-30 23:26:26 +01:00
Sergio Martins
94afae2729 windows: Reviewed and ported a bunch of Q_OS_WIN_OLD usages
Those are fine. Will tackle the difficult ones next.
2022-05-30 22:04:35 +01:00
Sergio Martins
d8e703275f windows: Replace Q_OS_WIN with Q_OS_WIN_TODO so we can start porting
Now it builds. This way I can port each Q_OS_WIN one by one and make
sure everything still builds, without risking breaking Linux/macOS.
2022-05-30 21:55:49 +01:00
Sergio Martins
ab9396af61 Remove unneeded KDDockWidgets::isWindow() 2022-05-30 19:35:20 +01:00
Sergio Martins
2421e607a9 Users now instantiate DockWidget view instead of controller
The controllers are private and not intentend for the public.
2022-05-30 11:45:43 +01:00
Sergio Martins
eff711b9ca Port MainWindowMDI to the new architecture
Has a qtquick implementation now.
2022-05-29 21:57:08 +01:00
Sergio Martins
df0dde80ef Remove unneeded "initView" parameter from MainWindow 2022-05-27 10:41:50 +01:00
Sergio Martins
1dde7e3e99 Add a generic interface for the classic indicator window
this removes QWidget references from ClassicIndicators.cpp.
Both the QtQuick and QtWidgets impl will implement this new
interface, which is what ClassicIndicators.cpp uses now
2022-05-26 23:10:26 +01:00
Sergio Martins
bb4f5a5037 Mass renaming of last usages of FrameworkWidgetFactory 2022-05-19 08:12:29 +01:00
Sergio Martins
09eb303bab Rename some methods from FrameworkWidget to View 2022-05-19 08:00:20 +01:00
Sergio Martins
4708b2c25d Rename FrameworkWidgetFactory_qtwidgets|qtquick to ViewFactory_* 2022-05-19 07:51:50 +01:00
Sergio Martins
e54ebd096c Both ClassicIndicatorsWindow qtquick and qtwidgets build
They don't clash anymore. Rename them to include the suffix.
Next step is abstracting the creation of IndicatorWindow so we
remove the last qtwidget traces from ClassicIndicators.cpp
2022-05-18 05:27:24 +01:00
Sergio Martins
6054ccfdf2 Move Indicator class into .cpp file
It's impl detail
2022-05-18 05:19:24 +01:00
Sergio Martins
2fda6d11e1 Removed the qtquick/qtwidgets ifdefs from ClassicIndicatorsWindow_*
They now each have their own implementation.
qtquick one still not compiling, as it duplicates symbols.
2022-05-18 05:10:01 +01:00
Sergio Martins
34c25a065a Copy ClassicIndicatorsWindow.cpp into qtwidgets and qtquick
No other changes made.
In preparation to remove the ifdefs.
2022-05-18 05:03:15 +01:00
Sergio Martins
30c3a047d1 Move the indicator classes into controllers/indicators/ 2022-05-18 04:35:33 +01:00
Sergio Martins
2b6c18dbcd Move the drop indicators into Controllers namespace 2022-05-18 04:24:16 +01:00
Sergio Martins
7b486bb28c qtwidgets: Add views for the Classical and Segmented indicators
Copied from indicators/
2022-05-18 04:10:01 +01:00
Sergio Martins
10b61f0e30 Remove unused Type::DropIndicatorOverlayInterface 2022-05-17 23:45:54 +01:00
Sergio Martins
be8250acb7 tests: Remove instances of QLineEdit from the tests
It's now generic
2022-05-16 21:59:43 +01:00
Sergio Martins
7434865967 Move Layout.cpp to controllers/ folder
as it's a controller
2022-05-15 21:30:31 +01:00
Sergio Martins
97baed0ef9 Rename layoutWidget variable/method name to layout
It's a controller, so don't suffix it with Widget/View
2022-05-15 21:12:01 +01:00
Sergio Martins
8e506aa327 Rename LayoutWidget.cpp to Layout.cpp , as it's a controller 2022-05-15 16:51:55 +01:00
Sergio Martins
df96b7ab81 Move MDILayout into Controllers namespace 2022-05-15 16:47:05 +01:00
Sergio Martins
20cd7b04a5 Rename MDILayoutWidget class to MDILayout
Since it's a controller, we strip the suffix
2022-05-15 16:27:51 +01:00
Sergio Martins
fa16020d61 Rename MDILayoutWidget to MDILayout and move it to controllers/
Since it's not a view, remove the "Widget" suffix
2022-05-15 16:24:57 +01:00