Commit Graph

3051 Commits

Author SHA1 Message Date
Sergio Martins
45aab49be7 qtquick: Fix -Wclazy-fully-qualified-moc-types
Might even fix a few bugs as QML is very picky about this
2021-07-03 16:31:15 +01:00
Sergio Martins
2c66238791 qtquick: Fix a -Wclazy-returning-void-expression and missing Q_EMIT 2021-07-03 16:27:36 +01:00
Sergio Martins
bec1ddae67 qtquick: Fix a -Wclazy-range-loop-reference 2021-07-03 16:27:30 +01:00
Sergio Martins
d3d040adee qtquick: Fix tab current widget being wrong when current is removed
When the current dock widget is removed we need to assign another
one. QTabBar does this automatically.

Fixes #215
2021-07-02 22:54:20 +01:00
Sergio Martins
31f5cc10cf qtquick: Add qWarning() when there's no current index in tabWidget 2021-07-02 22:34:46 +01:00
Sergio Martins
463b6a1322 qtquick: Fix using initial visibility option
Needs to be fully qualified.
Added an example.

Fixes #212
2021-07-02 16:41:49 +01:00
Sergio Martins
00a95ac468 Fix invisible tabbar from eating hover events
Fixes #214
2021-07-02 16:15:04 +01:00
Sergio Martins
966f30e356 qtquick: Fix dock widgets not getting title
Title can be set before onComplete(), so we need to remember it

Fixes #218
2021-07-02 15:05:55 +01:00
Sergio Martins
ced1c4dcc8 TabWidgetWidget: Don't hardcode margins, so we support DPI != 96
For people using font DPI instead of DPR
2021-07-01 22:17:31 +01:00
Sergio Martins
e1578436d0 Added Flag_ShowButtonsOnTabBarIfTitleBarHidden 2021-07-01 18:08:41 +01:00
Sergio Martins
701df72db6 Remove some ifdefs regarding 5.9
The one missing QT_VERSION_CHECK was even wrong and triggering
even with Qt 5.15.
2021-07-01 16:54:44 +01:00
Sergio Martins
c4ebef1f1e Remove an ifdef only relevant to older Qt 2021-07-01 16:50:01 +01:00
Eism
02d4611501 Fixed toggling dock widgets 2021-06-29 00:16:14 +01:00
Sergio Martins
457ea402d5 qtquick|example: Fix toggling not working on non-current tab
A non-current tab isn't visible, its dock widget is however opened.
Relates to #211
2021-06-28 23:30:05 +01:00
Allen Winter
720dad1ed6 clean comment of double words "to to" and "the the" 2021-06-25 10:21:33 -04:00
Sergio Martins
6417db6d91 Added Config::InternalFlag_DisableTranslucency
In case one doesn't want to use the env variable
2021-06-25 14:38:19 +01:00
Sergio Martins
ec681e99ca Disable translucency when KDDW_NO_TRANSLUCENCY env var is set
Useful for running on weird window managers which don't support
transparent windows.
2021-06-25 14:31:00 +01:00
Sergio Martins
47ef203643 qtquick|minor: Remove a call to Config::self().qmlEngine() 2021-06-23 19:03:40 +01:00
Sergio Martins
844aa2f36a qtquick|minor: Move qml engine one level up 2021-06-23 18:37:34 +01:00
Sergio Martins
e2e8f10948 Fix QtQuick tests 2021-06-22 23:40:40 +01:00
Sergio Martins
1c49e2297a Fix QtQuick build 2021-06-22 23:22:02 +01:00
Sergio Martins
6f031e3c33 Windows: Fix initial FloatingWindow size in HDPI
When:
- Screen A (100%), B (150%)
- MainWindow on screen B
- Trying to open a floating window on screen A (via setGeometry())

The Qt Windows QPA would error out when setting the geometry and it
would be too small.

The solution is to call setGeometry() before we create the QWindow.

Too much of an edge case to risk putting this on 1.3 branch.
Will be in 1.4.0.

Fixes #191
2021-06-22 23:09:38 +01:00
Sergio Martins
f74fd52d53 DebugWindow: When dumping windows don't dump the DebugWindow itself 2021-06-22 17:27:27 +01:00
Sergio Martins
2d4cef670b Fix build with qtquick 2021-06-21 08:50:36 +01:00
Sergio Martins
dfaf455624 Add support for the rubber bands to be top-level
Worksaround a bug where they can't be transparent when embedded
in a MFC application
2021-06-20 21:26:43 +01:00
Sergio Martins
5ff720f432 Export DropArea, has some useful symbols 2021-06-18 17:51:36 +01:00
Sergio Martins
6f7e47324c Minor: improve an include 2021-06-18 17:50:42 +01:00
Sergio Martins
b68f81779c Fix possible crash
Observed with an MFC application
2021-06-18 16:02:33 +01:00
Sergio Martins
4c1b433269 Fix a -Wclazy-fully-qualified-moc-types error 2021-06-17 22:02:35 +01:00
Sergio Martins
7c63da18ed Remove some dead code
Both if branches already return something
2021-06-17 13:03:00 +01:00
Sergio Martins
6f2e5ecc3b Add a missing qglobal.h include 2021-06-17 13:00:48 +01:00
Sergio Martins
759cf33f08 Windows: Link to Dwmapi.lib via pragma
So I don't have to figure out some exotic non-cmake build systems

It's more self-contained this way anyway.
2021-06-16 12:41:40 +01:00
Sergio Martins
77279d21ef Fixed a MSVC warning about unreachable code 2021-06-16 12:32:25 +01:00
Sergio Martins
46872fdfe8 Fix build if each header is built individually, probably
This header is included by QWidgetAdapter.h, but if some exotic
build system builds QWidgetAdapter_widgets_p.h individially then
we need to forward declare some functions
2021-06-15 21:35:55 +01:00
Sergio Martins
79fe9c2875 cmake: Remove private/ from our PRIVATE include path
Because some build systems don't support public/private includes,
and would require us to add private/ to the public include path.

This allows for an easier integration with some more exotic
build systems
2021-06-15 19:53:05 +01:00
Sergio Martins
d2db92f1e7 Remove private/multisplitter/ from private include path
It's not needed.
Even wrong since then ../LayoutSaver_p.h would work
2021-06-15 16:46:07 +01:00
Sergio Martins
206433e430 Fix embedding in non-KDDW QMainWindow
Supports the case of having our KDDW MainWindow parented to another
main window. Was broken on Windows.
2021-06-14 06:43:06 +01:00
Roman Pudashkin
b85e291d40 need to remove the old filter instead of the new one 2021-06-05 16:09:04 +01:00
Sergio Martins
bb1b3c7b7b Fix non-windows developer build
Build was complaining about unused function
2021-05-25 14:06:14 +01:00
Eism
0ab701bab6 qtquick: Fix detecting top level geometry
For QtQuick we want the QWindow geometry. For QtWidget it just works,
as the top level widget as the same geometry as the window, unlike
QQuickItem.

Fixes issue #199
2021-05-24 11:45:37 +01:00
Sergio Martins
1721415799 Fix more warnings at shutdown 2021-05-23 22:42:26 +01:00
Sergio Martins
26269459db qtquick: Fix some warnings at shutdown 2021-05-23 22:37:42 +01:00
Eism
3e30685eb4 Expose MainWindowBase::windowGeometry(), so it can be used
Just moves the code from private to public.
For issue #199
2021-05-23 11:34:53 +01:00
Roman Pudashkin
95cbba4618 qtquick: Fix crash by using deleteLater()
For issue #200
2021-05-22 10:22:58 +01:00
Sergio Martins
d89c6b9c06 qtquick|windows: Fix potential crash with offscreen QPA
Which also fixes a test. Now all tests pass.
The explanation was added in a comment.
2021-05-21 23:46:42 +01:00
Sergio Martins
4bda994d5c qtquick: Fix Qt6 warning about "mouse" being injected 2021-05-21 16:44:30 +01:00
Sergio Martins
2b4f6f33af qtquick: Fix Qt6 build 2021-05-21 16:38:12 +01:00
Sergio Martins
62500a322f qtquick: Fix calling titleBarFilename() function
Probably worked before, but the argument was bogus, as the
function doesn't accept arguments
2021-05-21 09:47:09 +01:00
Sergio Martins
ae58a8b9df Fix boolean variables being accessed before initialization
As detected by ASAN:
ClassicIndicators.cpp:66:12: runtime error: load of value 190, which is not a valid value for type 'bool'
2021-05-21 09:24:58 +01:00
Sergio Martins
7fb5a8d444 Merge branch '1.3' 2021-05-20 18:54:18 +01:00