philipp/KDDockWidgets
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,056 Commits 41 Branches 12 Tags
3f732e91a738344892e9eaa0b526a86c720b5f74
Commit Graph

246 Commits

Author SHA1 Message Date
Sergio Martins
6fb0694aab LayoutSaver: Replace saveToDisk() with saveToFile(jsonFilename) 
Same for restore.
This is better API as LayoutSaver shouldn't be concerned about
QSettings. It also assumed the user only had a single layout, which
is normally not the case.

And finally, storing escaped json in .ini files is not very elegant.
 2020-02-24 15:10:12 +00:00
Sergio Martins
579b222418 Make AddingOption_StartHidden also work for tabs 
You can now pass that option to DockWidget::addDockWidgetAsTab().
 2020-02-19 16:36:50 +00:00
Sergio Martins
aded290573 Don't save last position if the window was hidden already 
Bug was happening when calling close() an closed dock widget, it
would then save the position of the invisible window. Next time it
was open it would appear in a bogus location. 0,0 in my case.
 2020-02-06 15:01:58 +00:00
Allen Winter
df692686e7 various - update copyright year 2020-01-07 11:36:56 -05:00
Sergio Martins
2ff2b78f5a Fix unit-tests on Windows with Qt 5.9 
Our RAII class that ensures that each test leaves 0 top-levels behind
was being initialized with somthing bigger than 0 since the
rectForDrop() test wasn't doing proper cleanup.

Not sure why only repro with 5.9, but it's correct now.
 2020-01-04 22:24:11 +00:00
Sergio Martins
6be2490c08 tests: When cleanup fails print the top-levels that we compared to 
Since qApp->topLevels() contains buttons which will be deleted later
 2020-01-04 21:15:39 +00:00
Sergio Martins
f37ecc0765 tests: Remove test with hardcoded values 
It's flaky as the min sizes are varying with Qt versions. Also what
it tests is already tested in previous tests and elsewhere.
 2020-01-04 18:33:43 +00:00
Sergio Martins
3b20f99092 tests: Add some missing window cleanup checks 2020-01-04 18:27:20 +00:00
Sergio Martins
9f5c7b5e6a tests: Use fusion style on all platforms 
To make the tests more robust, as some widgets min size will
vary
 2020-01-04 18:19:26 +00:00
Sergio Martins
e5df8db045 tests: Add some tests for double close 2019-12-29 18:29:27 +00:00
Sergio Martins
6be6aee56a Fix dock widgets not filling their complete available space 
To repro:
 - stack 3 dock widgets vertically
 - close the top one
 - close the top one
 The remaining one should now fill the whole window but it wasn't.

Culprit was the code that makes sure that when a dock is closed that
the adjacent ones get to share their space
 2019-12-23 14:28:40 +00:00
Sergio Martins
7452520662 Add DockRegistry::dockWidgetForGuest() 
So you can find out the dock widget which hosts a widget
 2019-12-20 10:57:05 +00:00
Sergio Martins
787f7802be Move the private code into a private/ folder 
It's nice to have a similar include hierarchy at build time and install
time.

It also makes things more explicit
 2019-10-20 19:24:54 +01:00
Sergio Martins
27cae066a6 Fix Anchor::cumulativeMinLength 
We don't want to count the size of separators that are following
others, but we might be in the middle of an operation that will
change which separators are following, like when restoring a placeholder.

So query the actual separators that will follow.

Fixes fuzzer 8.json and 2.json
 2019-10-17 13:30:31 +01:00
Sergio Martins
92bbe4d4f7 Remove a dock widget from the layout before adding as tab 
So the layout can grow first and not complain there's not enough
space.

Fixes fuzzer test-case 3.json.
The warning was: "Constraints not honoured" in Item::onLayoutRequest()
 2019-10-15 12:51:49 +01:00
Sergio Martins
a2e610ee4b tests: share waitForEvent() and waitForDeleted() 2019-10-11 11:38:21 +01:00
Sergio Martins
83625bdda3 tests: Move the qDebug filter to Testing.h 
So it can be shared with the fuzzer
 2019-10-11 08:46:51 +01:00
Sergio Martins
ac313c5a24 Don't save floating geometry on clear() 
clear() shouldn't save anything.
Fixes floating dockwidgets not having proper geometry when shown
after clear() was called.
 2019-10-08 14:59:31 +01:00
Sergio Martins
58e90bd7c4 Make MainWindow_None the default, instead of MainWindow_HasCentralFrame 
Central Frame is the old Qt way. With KDDockWidgets everwhere
is fair game to dock and undock.
 2019-10-07 14:02:30 +01:00
Sergio Martins
a0d05b4e2b Move Frame::Options enum to KDDockWidgets.h 
So we can forward declare Frame and not include private headers
in FrameworkWidgetFactory.h
 2019-10-07 13:43:48 +01:00
Sergio Martins
21579f2743 Minor method renames 2019-10-07 00:16:16 +01:00
Sergio Martins
c5149ab13c Fix title bar being visible with Flag_HideTitleBarWhenTabsVisible 
Frame::updateTitleBarVisibility() was bailing out early. That
guard looks like some leftover, m_dropArea isn't even dereferenced
there, so just remove the guard.
 2019-09-30 11:00:38 +01:00
Sergio Martins
8df3eddd9b Fix crash when trying to drag a single tab 
and the tab was in a floating window and we were using "TabsAlwaysVisible"
 2019-09-12 17:22:29 +01:00
Sergio Martins
254dde64c7 Tests++ 2019-09-12 15:58:17 +01:00
Sergio Martins
9ef006bce4 tests++ 2019-09-12 15:50:11 +01:00
Sergio Martins
370780cf22 Don't run the sanity checks during a restore 
During a restore the layout is in an intermediate state, so we're
not suppose to do such tight checks.
 2019-09-10 19:41:39 +01:00
Sergio Martins
abbc79f0e0 Progress with the QtQuick port 2019-09-07 16:20:22 +01:00
Sergio Martins
76640d16b3 Fix support static separators with 0 thickness 2019-09-02 11:26:57 +01:00
Sergio Martins
9f7969bfc3 Tests now pass with static anchor thickness > 2 
Still need to fix with =0
 2019-09-02 11:07:58 +01:00
Sergio Martins
8cb34e4d65 tests: Fix tst_rectForDrop() with variable static anchor thickness 2019-09-02 10:56:48 +01:00
Sergio Martins
5caca65843 Fix test that didn't support static anchor thickness != 1 2019-09-02 10:52:03 +01:00
Sergio Martins
7797599b5d Fix unit-tests when separator thickness is even 2019-09-01 19:04:37 +01:00
Sergio Martins
30135acbd0 tests: Remove hardcoded anchor thicknesses 2019-09-01 15:03:04 +01:00
Sergio Martins
46a5a580bc Add LayoutSaver::restoredDockWidgets() 
Implemented as a property it's better that the LayoutSaver
doesn't carry state about this. Then we would need to remove dock
widgets from the list if they are deleted. Also not a important
enough feature to be on the DockWidget public interface.
 2019-08-28 17:56:18 +01:00
Sergio Martins
f0078c3649 Fix dragging window by title bar when using document mode 
When using document mode the click goes to the tab bar, not the
tab widget
 2019-08-28 17:05:45 +01:00
Sergio Martins
59cdadf386 Add DockWidgetBase::titleBar() 2019-08-24 22:55:06 +01:00
Sergio Martins
9e9ca66382 Call ensureAnchorsBounded() directly in setSize() 
No need for it to be scattered in random places.
Also, don't warn in Anchor::setPosition() if we're in the middle
of a resize, ensureAnchorsBounded() will be called soon.
 2019-08-20 18:19:20 +01:00
Sergio Martins
ecf1b61f22 Respond immediatley to min size changes 
instead of waiting for LayoutRequests from the main window
which can be async.
 2019-08-20 17:48:55 +01:00
Sergio Martins
7a91fb5310 tests: Add more checkSanity() 2019-08-19 22:50:27 +01:00
Sergio Martins
9f544975f1 Support existing widget's minSize changing 
previously we only honoured the min size of when they were
added to the layout
 2019-08-19 19:44:51 +01:00
Sergio Martins
dd58836ddf Fix another case of out of bounds anchor position 
Happens because rectForDrop() is returning the rect without considering
the widget that we're adding, so doesn't respect the bounds.

Let's just ignore the out of bounds warning. ensureAnchorsBounded()
is ran at the end anyway so we're fine.
 2019-08-19 19:26:54 +01:00
Sergio Martins
c6a8b236af Update the item's minimum size when restoring a placeholder 2019-08-13 14:08:08 +01:00
Sergio Martins
c1ea98825e Improve includes 2019-08-12 16:41:00 +01:00
Sergio Martins
cace480ff2 Add failing unit-test 2019-08-12 14:51:46 +01:00
Sergio Martins
776a0f78ed Rename contentsSize to size 
When MultiSplitterLayout was a widget it made sence to have
a different name, but now anymore
 2019-08-12 11:56:37 +01:00
Sergio Martins
3385b6c15c After restoring a placeholder we need to ensure all anchors are bounded 
We only ensure the ones next to our item are bounded, but there can be
indirect ones that were holding items that now must shrink
 2019-08-12 11:29:45 +01:00
Sergio Martins
b8de3aa21f TitleBar: Allow to makeWindow() even if it's not visible 
The MainWindow can be hidden still.
Anyway, this won't be called if really invisible, the assert
is a bit tight.
 2019-08-08 22:51:33 +01:00
Sergio Martins
74997d35c5 Add test that we can add to an hidden window 2019-08-08 22:45:33 +01:00
Sergio Martins
990e487fed rename name() to uniqueName() for readability 2019-08-08 22:30:29 +01:00
Sergio Martins
daef0c470e Try to not expose the tab bar 
It's an implementation detail of FrameWidget. Makes porting
to QtQuick easier
 2019-08-08 10:08:38 +01:00