Commit Graph

38 Commits

Author SHA1 Message Date
Sergio Martins
38432ccacd Make MainWindow::windowGeometry() private 2022-06-15 16:09:04 +01:00
Sergio Martins
0825a6bdc2 Move sidebars into MainWindow controller
No reason to have them duplicated between qtwidgets and qtquick
2022-06-15 15:57:50 +01:00
Sergio Martins
0c95550af6 Move some common view code into MainWindowViewInterface
So that it's not duplicated between QtWidgets and QtQuick
2022-06-15 12:29:14 +01:00
Sergio Martins
e1fe8054d0 Remove public MainWindow::onResized 2022-06-15 11:23:51 +01:00
Sergio Martins
755bc6ac14 cmake: Don't add src/ to include path
Fully qualify includes instead
2022-06-14 16:57:22 +01:00
Sergio Martins
55620a5d10 TODO cleanup
Removed stale TODOs and promoted some to TODOm2 , as they should
be tackled next
2022-06-12 16:07:29 +01:00
Sergio Martins
2421e607a9 Users now instantiate DockWidget view instead of controller
The controllers are private and not intentend for the public.
2022-05-30 11:45:43 +01:00
Sergio Martins
fb8639969c Delete QObject::setParent() in the controller
To find places where we're setting parent on the controller instead
of in the view. Fix such case where the dock widget view
wasn't being parented to the frame view.
2022-05-27 13:25:06 +01:00
Sergio Martins
df0dde80ef Remove unneeded "initView" parameter from MainWindow 2022-05-27 10:41:50 +01:00
Sergio Martins
03f1a6930c Added Platform::createMainWindow()
Called by tests and layout linter to create a main window.

Simplifies creation of the main window, we can now remove one of the ctors.
Before we supported both the controller creating the view and vice-versa,
while this is convenient it's complex to support, due to order or initializations.

Now, you a create a view, and it creates the controller behind the scenes.
MainWindow is special in this sense, as it's created by the end user, it's
not something internal we want in the ViewFactory.
2022-05-27 10:36:54 +01:00
Sergio Martins
bb4f5a5037 Mass renaming of last usages of FrameworkWidgetFactory 2022-05-19 08:12:29 +01:00
Sergio Martins
09eb303bab Rename some methods from FrameworkWidget to View 2022-05-19 08:00:20 +01:00
Sergio Martins
97baed0ef9 Rename layoutWidget variable/method name to layout
It's a controller, so don't suffix it with Widget/View
2022-05-15 21:12:01 +01:00
Sergio Martins
378f380968 Rename LayoutWidget to Layout , since it's not a view
Controllers shouldn't be suffixed
2022-05-15 21:04:07 +01:00
Sergio Martins
20cd7b04a5 Rename MDILayoutWidget class to MDILayout
Since it's a controller, we strip the suffix
2022-05-15 16:27:51 +01:00
Sergio Martins
fa16020d61 Rename MDILayoutWidget to MDILayout and move it to controllers/
Since it's not a view, remove the "Widget" suffix
2022-05-15 16:24:57 +01:00
Sergio Martins
f719697852 Remove DockWidget::setWidget(QWidget) 2022-05-14 09:38:55 +01:00
Sergio Martins
07be3dd0d4 Port away from DockWidget::widget()
Use guestView() instead
2022-05-11 23:59:10 +01:00
Sergio Martins
9f7c4cb217 Removed the DockWidgetBase typedef
That existed only to ease porting
2022-05-10 22:53:16 +01:00
Sergio Martins
3fabf34bee Renamed View::windowHandle() to View::window()
windowHandle() is missnamed in Qt because QWidget::window() was already
taken in Qt4. But we can make it better here.
2022-05-01 23:09:18 +01:00
Sergio Martins
6ebb432932 Port LayoutWidget away from QWidget
DropArea and MDILayout now inherit from it, in addittion to QWidget.
This mean DropArea can now be split into View/Controller alone,
without having to port LayoutWidget and MDILayout in the same commit,
which would be hard to review.
2022-04-24 12:57:20 +01:00
Sergio Martins
dc6d77e266 Fold MultiSplitter into DropArea
The separation was never very useful. There's was always only
one derived class, the DropArea. Merge the two.
2022-04-23 15:22:38 +01:00
Sergio Martins
daa6afd14c Move DropArea into controllers/
In preparation to split it into View/Controller.
This is just the move, no code changed yet.
Next will be the namespace change.
2022-04-23 11:46:11 +01:00
Sergio Martins
28754ec260 Fold DropAreaWithCentralFrame into DropArea
This separation was never useful
2022-04-23 00:17:20 +01:00
Sergio Martins
8015e49bee Add Platform::screenSizeFor(window), removes more asQWidget() usage 2022-04-21 22:10:59 +01:00
Sergio Martins
3f97845c9c Use Window instead of QWindow in a few more places 2022-04-21 21:50:58 +01:00
Sergio Martins
4946cdeed3 Add Platform::screenNumberFor, removes more asQWidget() usage 2022-04-21 21:47:55 +01:00
Sergio Martins
0249b0e933 Remove more usages of asQWidget()
Adds View::mapTo()
2022-04-20 23:18:41 +01:00
Sergio Martins
8cfb10ef10 Use View::setParent() instead of QWidget::setParent() 2022-04-07 22:54:50 +01:00
Sergio Martins
81e5d14e4f Cleanup DropArea and base classes re receiving QWidget
They receive View now
2022-04-03 23:19:53 +01:00
Sergio Martins
ad1b77f79e Add MainWindow view interface 2022-04-03 22:25:57 +01:00
Sergio Martins
d5700d94e6 MainWindow controller now receives View parent instead of QWidget 2022-04-03 21:23:03 +01:00
Sergio Martins
aab3de29e1 Add a title bar interface, so we don't need to depend on TitleBar_qtwidgets 2022-04-02 18:50:35 +01:00
Sergio Martins
0d8479b206 Add Controller::type() 2022-03-31 12:28:34 +01:00
Sergio Martins
15601fc3c9 Split MainWindow into view/controller 2022-03-30 11:51:31 +01:00
Sergio Martins
9fba1e9799 Rename Controller::DockWidgetBase to Controller::DockWidget
As done for other controllers
2022-03-25 10:53:02 +00:00
Sergio Martins
8656108e81 Renamed MainWindowBase to MainWindow
As done for other controllers
2022-03-25 10:47:20 +00:00
Sergio Martins
0c686c1339 Renamed MainWindowBase.h to MainWindow.h
As done for other controllers
2022-03-25 10:30:07 +00:00