Commit Graph

1069 Commits

Author SHA1 Message Date
Sergio Martins
7a91fb5310 tests: Add more checkSanity() 2019-08-19 22:50:27 +01:00
Sergio Martins
e604037cba Add another checkSanity() check 2019-08-19 22:18:56 +01:00
Sergio Martins
ffe4a6a4da Remove some ifdefs, use maybeCheckSanity() instead 2019-08-19 21:00:37 +01:00
Sergio Martins
b24763478a Add more sanity checks 2019-08-19 20:58:30 +01:00
Sergio Martins
74be72a816 developer_build: Check sanity after adding a dock widget
Tests will fail if a warning is printed
2019-08-19 20:54:22 +01:00
Sergio Martins
682524610f Remove unneeded setDoSanityChecks() 2019-08-19 20:51:26 +01:00
Sergio Martins
eed6082d0c DebugWindow: Add option to call ensureAnchorsBounded() 2019-08-19 20:38:32 +01:00
Sergio Martins
9f544975f1 Support existing widget's minSize changing
previously we only honoured the min size of when they were
added to the layout
2019-08-19 19:44:51 +01:00
Sergio Martins
807a9a5d90 Remove complexities from MultiSplitterLayout::rectForDrop
The anchors get adjusted in ensureAnchorsBounded(), when we
add an item
2019-08-19 19:37:51 +01:00
Sergio Martins
dd58836ddf Fix another case of out of bounds anchor position
Happens because rectForDrop() is returning the rect without considering
the widget that we're adding, so doesn't respect the bounds.

Let's just ignore the out of bounds warning. ensureAnchorsBounded()
is ran at the end anyway so we're fine.
2019-08-19 19:26:54 +01:00
Sergio Martins
aa7f5d6c39 Remove some qDebug 2019-08-19 16:47:51 +01:00
Sergio Martins
7ca590cb58 Minor refactoring 2019-08-19 16:43:27 +01:00
Sergio Martins
8ebd4dd05b Update .gitignore 2019-08-18 18:35:02 +01:00
Sergio Martins
2a0e8f1404 Remove DockWidgetBase::setLocked()
It's not implemented and not sure we need it
2019-08-18 18:33:17 +01:00
Sergio Martins
8ebf7aa085 Actually fix the leak instead of crashing 2019-08-13 22:27:54 +01:00
Renato Araujo Oliveira Filho
ae3518bcae Update include dirs
Change-Id: If74d94833f5d9e018a17910715cb9492b345f167
Reviewed-on: https://codereview.kdab.com/69852
Reviewed-by: Sérgio Martins <sergio@kdab.com>
2019-08-13 23:03:17 +02:00
Sergio Martins
3f4aeed009 Document ownership 2019-08-13 16:53:58 +01:00
Sergio Martins
c2ca75966a Fix mem leak 2019-08-13 16:51:12 +01:00
Sergio Martins
79e3b3f63c Don't call QLoggingCategory::setLoggingRules()
It gets called by apps
2019-08-13 14:39:30 +01:00
Sergio Martins
c3e24e495a Remove completed TODO 2019-08-13 14:08:45 +01:00
Sergio Martins
c6a8b236af Update the item's minimum size when restoring a placeholder 2019-08-13 14:08:08 +01:00
Sergio Martins
e62e6e554c Fix includes 2019-08-12 21:10:48 +01:00
Sergio Martins
ccf534a7d7 Make function public so it can actually be useful 2019-08-12 21:09:10 +01:00
Sergio Martins
5116a228b4 Expose Button, so it can be reused 2019-08-12 21:04:27 +01:00
Sergio Martins
0e3f922608 Install more includes 2019-08-12 20:43:53 +01:00
Sergio Martins
a97759ab46 Install Frame_p.h too, as its needed due to the enum 2019-08-12 20:12:44 +01:00
Sergio Martins
2d68d90a50 Make sure there's enough space when adding a placeholder
Because the placeholder if a non-placeholder for an instant
2019-08-12 16:44:18 +01:00
Sergio Martins
f7564def31 Dont' run ensureBounded() on anchors that are following 2019-08-12 16:44:18 +01:00
Sergio Martins
9b1f499f65 Don't issue out of bounds warning while restoring placeholder
Anchors will be adjusted afterwards
2019-08-12 16:41:30 +01:00
Sergio Martins
c1ea98825e Improve includes 2019-08-12 16:41:00 +01:00
Sergio Martins
cace480ff2 Add failing unit-test 2019-08-12 14:51:46 +01:00
Sergio Martins
776a0f78ed Rename contentsSize to size
When MultiSplitterLayout was a widget it made sence to have
a different name, but now anymore
2019-08-12 11:56:37 +01:00
Sergio Martins
3385b6c15c After restoring a placeholder we need to ensure all anchors are bounded
We only ensure the ones next to our item are bounded, but there can be
indirect ones that were holding items that now must shrink
2019-08-12 11:29:45 +01:00
Sergio Martins
47ff3869f1 Update size constraints after updating anchor followings
As anchors occupy space too
2019-08-09 15:43:35 +01:00
Sergio Martins
b8de3aa21f TitleBar: Allow to makeWindow() even if it's not visible
The MainWindow can be hidden still.
Anyway, this won't be called if really invisible, the assert
is a bit tight.
2019-08-08 22:51:33 +01:00
Sergio Martins
74997d35c5 Add test that we can add to an hidden window 2019-08-08 22:45:33 +01:00
Sergio Martins
5325b93573 Add a DockWidget::setLocked() stub 2019-08-08 22:31:14 +01:00
Sergio Martins
990e487fed rename name() to uniqueName() for readability 2019-08-08 22:30:29 +01:00
Sergio Martins
17b3048aeb cmake: Rename target to kddockwidgets instead of docks 2019-08-08 16:03:59 +01:00
Sergio Martins
b946627961 cmake: Fix some includes 2019-08-08 15:58:22 +01:00
Sergio Martins
020571b6f5 The QtQuick stuff compiles now 2019-08-08 12:52:18 +01:00
Sergio Martins
2a0c228733 Abstract the indicator style, now comes from the factory 2019-08-08 11:37:14 +01:00
Sergio Martins
a8ac0412fa More build fixes without QtWidgets 2019-08-08 11:37:14 +01:00
Sergio Martins
b593bcaab3 Abstract TabBar away from QtWidgets 2019-08-08 10:50:58 +01:00
Sergio Martins
daef0c470e Try to not expose the tab bar
It's an implementation detail of FrameWidget. Makes porting
to QtQuick easier
2019-08-08 10:08:38 +01:00
Sergio Martins
cd5ec8cc4a Fix some includes 2019-08-08 02:36:31 +01:00
Sergio Martins
89757def76 Abstract TabWidget away from QtWidgets, so can be used for QtQuick 2019-08-08 00:41:48 +01:00
Sergio Martins
0ba3371c6c Move layouting code from Frame to FrameWidget 2019-08-07 23:53:10 +01:00
Sergio Martins
70db3fe2a3 tests: Don't create frame directly 2019-08-07 23:11:34 +01:00
Sergio Martins
77244f93f5 Fix FloatingWindow sometimes appearing with title bar 2019-08-07 22:29:44 +01:00