Commit Graph

1069 Commits

Author SHA1 Message Date
Sergio Martins
fca010ce2a Center floating dock widgets within their main window
In case they don't have any previous position.
This is better than showing them at 0,0
2020-02-06 14:30:01 +00:00
Sergio Martins
3771aa7a40 Fix toggleAction() emitting spurious toggle events
When showing a dockwidget it's inserted into a tab widget, which
will generate a hide event, which will toggle the action to off
even though the dock widget is opened for our purposes
2020-02-05 13:06:53 +00:00
Sergio Martins
1cac350547 Add convenience method DockWidget::isOpen() 2020-02-01 19:47:16 +00:00
Sergio Martins
4c15335339 Don't access MultiSplitter methods after its dtor ran
~MultiSplitter dtor eventually triggers Frame::setDropArea()
which dereferences the MultiSplitter. Instead, keep the connection
in a QMetaObject::Connection, so we can disconnect without needing
the MultiSplitter
2020-01-29 16:07:52 +00:00
Sergio Martins
6da1a65591 Fix build with gcc -Werror=type-limits 2020-01-29 15:27:11 +00:00
Sergio Martins
6338e6b03e Fix my Werror clang build 2020-01-29 15:17:01 +00:00
Sergio Martins
48ef73d6d3 cmake: Rename OPTION_ASAN_SUPPORT to OPTION_SANITIZER_SUPPORT
As it can work with any type of sanitizers
2020-01-29 15:04:51 +00:00
Sergio Martins
52e53c4fd9 fuzzer: Trim the failing test 2020-01-29 15:04:51 +00:00
Sergio Martins
81c180fbfd Debug++ 2020-01-27 22:12:28 +00:00
Sergio Martins
07f9e9a0df Fix fuzzer testcase failing/2.json
And renamed it to 17.json, as we already have an unrelated 2.json.

The removed check isn't needed, as we'll check again when we
finish restoring the placeholder. It was also a false-positive
warning sometimes because boundPositionForAnchor() would fail
since the "anchors following" wasnt initialized yet, as we do
a clearAnchorsFollowing while restoring the placeholder
2020-01-27 18:47:37 +00:00
Sergio Martins
6dd8a0cda1 Debug++ 2020-01-27 18:35:01 +00:00
Sergio Martins
25f3e83fc3 Debug++ 2020-01-27 18:30:13 +00:00
Sergio Martins
195c8121c0 fuzzer: Simplify names for 2.json 2020-01-27 15:17:30 +00:00
Sergio Martins
2b1518b1c2 Fuzzer: Add a new failing testcase 2020-01-27 15:10:55 +00:00
Sergio Martins
ca98d376b7 fuzzer: Move 14.json from failing to ok
It passes now
2020-01-24 20:05:43 +00:00
Sergio Martins
16b564a005 Add a test which is failing on macOS 2020-01-24 20:02:26 +00:00
Sergio Martins
c3483ba480 Fix ensureMinSize making the item smaller
this function should either make it bigger or leave it.
Never make it smaller.
Fixes fuzzer testcase 14
2020-01-24 18:13:19 +00:00
Sergio Martins
162bf0e828 Don't move anchors that are following others
Move the real ones instead. Fixes some bugs found with the fuzzer.
2020-01-24 16:19:42 +00:00
Sergio Martins
3bbeec06f8 DebugWindow: Allow to toggle a dock widget 2020-01-24 15:48:35 +00:00
Sergio Martins
2f3b7642ed Fix debug window crash 2020-01-24 12:04:45 +00:00
Sergio Martins
068eb7cc25 fuzzer: trim 15.json a bit
smaller and still repro
2020-01-24 11:52:51 +00:00
Sergio Martins
8c37c3a7ec fuzzer: print the name of the failing test 2020-01-24 11:38:21 +00:00
Sergio Martins
e2d47001db fuzzer: Move failing tests to a failing directory
So we can run the correct ones with *.json
2020-01-24 11:37:45 +00:00
Sergio Martins
8898ec82a4 Don't account for the anchor thickness of an anchor which is following
Fixes fuzzer testcase 10
2020-01-24 11:26:35 +00:00
Sergio Martins
9ca03b65f0 Improve comment
The function already explains what it does.
2020-01-24 10:12:15 +00:00
Sergio Martins
b80a795968 Improve comments on this function 2020-01-24 10:02:22 +00:00
Sergio Martins
8aaffa26c6 Fix build with c++11 2020-01-24 09:31:22 +00:00
Sergio Martins
da3917ae64 Replace assert with a warning and early return
A warning will still abort the unit-tests, so it's fine
2020-01-22 22:53:18 +00:00
Sergio Martins
0003b508d6 Bound interval when adding the widget
rectForDrop() doesn't know about the anchors bounds, so we need to
adjust the interval after. Fixes fuzzer testcase 16
2020-01-22 22:49:45 +00:00
Sergio Martins
d5162efa31 When calculating bounds start from the anchor we're following 2020-01-22 21:50:39 +00:00
Sergio Martins
a71361341c Don't warn when updateAnchorFollowing is being executed 2020-01-22 21:46:18 +00:00
Sergio Martins
08cbbd5178 Fix Anchor::cumulativeMinLength() not returning correct result
For complex situations with placeholders.
Now the way the number of anchors to take into account is easier.
It's simply numNonPlacholderItems -1.
2020-01-22 20:54:55 +00:00
Sergio Martins
94c02a1fe9 Fix case where the bounds wouldn't count with the actual anchor
Now the method is split in two and the preamble will always
add it
2020-01-22 18:05:13 +00:00
Sergio Martins
8a05980cd5 Minor refactoring 2020-01-22 17:40:50 +00:00
Sergio Martins
45b2fb63bc Fix frames with duplicate name in the debug output
when a tab is removed, update the frame's object name
Was making it very difficult to debug the fuzzer's output
2020-01-22 15:05:34 +00:00
Sergio Martins
4a6b73cae1 fuzzer: Decouple skipping last from no quitting
There's two separate options now, as it's useful to pause without
skipping the last test
2020-01-22 14:44:56 +00:00
Sergio Martins
d738fbd154 fuzzer: Fix description of skipped operation
Only generate the description after all other dockwidgets are placed
, as the state of the others will be in the last description too
2020-01-22 12:47:42 +00:00
Sergio Martins
7c10ab37f4 fuzzer: print description of skipped operation
involves making sure the description is generated
2020-01-22 11:54:09 +00:00
Sergio Martins
460d3f9ec1 fuzzer: Print the skipped operation 2020-01-22 11:48:04 +00:00
Sergio Martins
4c19ccade7 fuzzer: don't destroy the windows when we use -d
so we can debug the app
2020-01-22 11:36:49 +00:00
Sergio Martins
03cc8abd94 fuzzer: Add skipAndPause (-d) option
So we can pause before the last test and debug the app
2020-01-22 11:17:59 +00:00
Sergio Martins
8447cefc14 fuzzer: trim testcase 16
Now has the minimum to reproduce
2020-01-22 10:56:11 +00:00
Sergio Martins
141cbc55f4 add a failing testcase 2020-01-21 22:05:32 +00:00
Sergio Martins
873978a99e Add some failing testcases 2020-01-21 22:05:03 +00:00
Sergio Martins
b8279633ac fuzzer: add an -l option, so it loops until it crashes 2020-01-21 17:10:29 +00:00
Sergio Martins
cfa1cc47b6 Rephrase the warning about the insane layout 2020-01-13 12:50:45 +00:00
Sergio Martins
4ca140c0cc Fix unmatched beginBlockPropagateGeo()
Fixes an assert
2020-01-08 09:56:03 +00:00
Allen Winter
d505eeb0a5 LICENSE.GPL.txt - https: urls 2020-01-07 11:39:33 -05:00
Allen Winter
df692686e7 various - update copyright year 2020-01-07 11:36:56 -05:00
Sergio Martins
a25435fc2d Remove leftover duplicate close button
also fixes a weird hover effect when mouse is over the title bar
2020-01-07 15:53:59 +00:00