From d50fcb80c5a92e88a9d4dc85262ca0ab13b5cd7c Mon Sep 17 00:00:00 2001 From: Sergio Martins Date: Mon, 12 Oct 2020 17:07:30 +0100 Subject: [PATCH] qtquick: Fixed all the layouting spam/warnings Don't layout a view with 0x0. --- src/private/quick/FloatingWindowQuick.cpp | 8 ++++++-- tests/Testing.cpp | 3 --- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/private/quick/FloatingWindowQuick.cpp b/src/private/quick/FloatingWindowQuick.cpp index e9ecf82f..d508d7ca 100644 --- a/src/private/quick/FloatingWindowQuick.cpp +++ b/src/private/quick/FloatingWindowQuick.cpp @@ -85,13 +85,17 @@ void FloatingWindowQuick::init() } }); - m_quickWindow->setResizeMode(QQuickView::SizeViewToRootObject); + const QSize minSize(100, 100); + m_quickWindow->resize(minSize); + m_quickWindow->contentItem()->setSize(minSize); + m_quickWindow->setTransientParent(candidateParentWindow()); - QWidgetAdapter::setParent(m_quickWindow->contentItem()); QWidgetAdapter::makeItemFillParent(this); + m_quickWindow->setResizeMode(QQuickView::SizeViewToRootObject); + QQuickItem *visualItem = createItem(Config::self().qmlEngine(), QStringLiteral("qrc:/kddockwidgets/private/quick/qml/FloatingWindow.qml")); Q_ASSERT(visualItem); visualItem->setParent(this); diff --git a/tests/Testing.cpp b/tests/Testing.cpp index e3aca08f..a37b33e6 100644 --- a/tests/Testing.cpp +++ b/tests/Testing.cpp @@ -61,9 +61,6 @@ static bool shouldBlacklistWarning(const QString &msg, const QString &category) msg.contains(QLatin1String("Testing::")) || msg.contains(QLatin1String("outside any known screen, using primary screen")) #ifdef KDDOCKWIDGETS_QTQUICK - // TODO: Debug why this happens - || msg.contains(QLatin1String("Layouting::ItemContainer::setSize_recursive")) - // TODO: Fix later, not important right now || msg.contains(QLatin1String("Binding loop detected for property")) #endif