philipp/KDDockWidgets
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the FloatingWindow window state overrides

Browse Source 
Nothing is inheriting from controller now. Those methods are already
virtual in view, so just remove them from the controller
This commit is contained in:
Sergio Martins
2022-06-25 17:41:03 +01:00
parent f640d8852b
commit c9fede2aab
8 changed files with 22 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/qtwidgets/tst_qtwidgets.cpp
View File

@@ -1368,8 +1368,8 @@ void TestQtWidgets::tst_restoreFloatingMaximizedState()
EnsureTopLevelsDeleted e;
KDDockWidgets::Config::self().setFlags(KDDockWidgets::Config::Flag_TitleBarHasMaximizeButton);
auto dock1 = createDockWidget("dock1", Platform::instance()->tests_createView({ true }));
const QRect originalNormalGeometry = dock1->floatingWindow()->normalGeometry();
dock1->floatingWindow()->showMaximized();
const QRect originalNormalGeometry = dock1->floatingWindow()->view()->normalGeometry();
dock1->floatingWindow()->view()->showMaximized();
qDebug() << originalNormalGeometry;
QCOMPARE(dock1->floatingWindow()->view()->window()->windowState(), Qt::WindowMaximized);
@@ -1380,12 +1380,10 @@ void TestQtWidgets::tst_restoreFloatingMaximizedState()
saver.restoreLayout(saved);
QCOMPARE(dock1->floatingWindow()->view()->window()->windowState(), Qt::WindowMaximized);
QCOMPARE(dock1->floatingWindow()->view()->normalGeometry(), originalNormalGeometry);
QCOMPARE(dock1->floatingWindow()->normalGeometry(), originalNormalGeometry);
dock1->floatingWindow()->showNormal();
QCOMPARE(dock1->floatingWindow()->normalGeometry(), originalNormalGeometry);
dock1->floatingWindow()->view()->showNormal();
QCOMPARE(dock1->floatingWindow()->view()->normalGeometry(), originalNormalGeometry);
}
void TestQtWidgets::tst_complex()