refactor: Decouple moveToSideBar from overlaying

overlaying just shows/hides the overlay, and not requires the dock widget was added to the sidebar before
2020-09-20 13:44:04 +01:00
parent c85873c6ce
commit 2659ddb76b
7 changed files with 45 additions and 33 deletions
--- a/src/DockWidgetBase.cpp
+++ b/src/DockWidgetBase.cpp
@@ -489,10 +489,12 @@ void DockWidgetBase::setAffinities(const QStringList &affinityNames)
    d->affinities = affinities;
 }

-void DockWidgetBase::minimizeToSideBar()
+void DockWidgetBase::moveToSideBar()
 {
-    if (MainWindowBase *m = mainWindow())
+    if (MainWindowBase *m = mainWindow()) {
+        m->moveToSideBar(this);
        m->overlayOnSideBar(this);
+    }
 }

 FloatingWindow *DockWidgetBase::morphIntoFloatingWindow()