philipp/KDDockWidgets
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix separators not being deleted

Browse Source 
Bug found with QtQuick but also reproducible with QtWidgets.
Added unit-test for both stacks.
This commit is contained in:
Sergio Martins
2020-10-05 18:25:33 +01:00
parent b0ec0e22e4
commit 128ae2d889
4 changed files with 51 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/tst_common.cpp
View File

@@ -62,6 +62,7 @@ private Q_SLOTS:
void tst_doesntHaveNativeTitleBar();
void tst_resizeWindow2();
void tst_hasLastDockedLocation();
void tst_ghostSeparator();
};
void TestCommon::tst_simple1()
@@ -142,6 +143,36 @@ void TestCommon::tst_hasLastDockedLocation()
delete window1;
}
void TestCommon::tst_ghostSeparator()
{
// Tests a situation where a separator wouldn't be removed after a widget had been removed
EnsureTopLevelsDeleted e;
auto m = createMainWindow(QSize(501, 500), MainWindowOption_None);
auto dock1 = createDockWidget("1");
auto dock2 = createDockWidget("2");
auto dock3 = createDockWidget("3");
QPointer<FloatingWindow> fw1 = dock1->floatingWindow();
QPointer<FloatingWindow> fw2 = dock2->floatingWindow();
QPointer<FloatingWindow> fw3 = dock3->floatingWindow();
dock1->addDockWidgetToContainingWindow(dock2, Location_OnRight);
QCOMPARE(fw1->multiSplitter()->separators().size(), 1);
QCOMPARE(Layouting::Separator::numSeparators(), 1);
m->addDockWidget(dock3, Location_OnBottom);
QCOMPARE(m->multiSplitter()->separators().size(), 0);
QCOMPARE(Layouting::Separator::numSeparators(), 1);
m->multiSplitter()->addMultiSplitter(fw1->multiSplitter(), Location_OnRight);
QCOMPARE(m->multiSplitter()->separators().size(), 2);
QCOMPARE(Layouting::Separator::numSeparators(), 2);
delete fw1;
delete fw2;
delete fw3;
}
int main(int argc, char *argv[])
{
if (!qpaPassedAsArgument(argc, argv)) {