philipp/KDDockWidgets
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: Add sanity checks for the tested rects

Browse Source 
Catches the situtions fixed in the two previous commits.
This commit is contained in:
Sergio Martins
2020-05-16 19:44:35 +01:00
parent 0f796da901
commit 0bd2f8f23a
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/private/multisplitter/Item.cpp
View File

@@ -2709,8 +2709,10 @@ bool ItemContainer::test_suggestedRect()
if (auto c = relativeTo->asContainer()) {
c->test_suggestedRect();
} else {
QHash<Location, QRect> rects;
for (Location loc : { Location_OnTop, Location_OnLeft, Location_OnRight, Location_OnBottom}) {
const QRect rect = suggestedDropRect(itemToDrop, relativeTo, loc);
rects.insert(loc, rect);
if (rect.isEmpty()) {
qWarning() << Q_FUNC_INFO << "Empty rect";
return false;
@@ -2718,8 +2720,16 @@ bool ItemContainer::test_suggestedRect()
root()->dumpLayout();
qWarning() << Q_FUNC_INFO << "Suggested rect is out of bounds" << rect
<< "; loc=" << loc << "; relativeTo=" << relativeTo;
return false;
}
}
if (rects.value(Location_OnBottom).y() <= rects.value(Location_OnTop).y() ||
rects.value(Location_OnRight).x() <= rects.value(Location_OnLeft).x()) {
root()->dumpLayout();
qWarning() << Q_FUNC_INFO << "Invalid suggested rects" << rects
<< this << "; relativeTo=" << relativeTo;
return false;
}
}
}