From 0a6f760100f65e762040dbf5511824a491e8dab5 Mon Sep 17 00:00:00 2001 From: Sergio Martins Date: Fri, 7 Aug 2020 22:21:35 +0100 Subject: [PATCH] Fix a couple of clazy warnings --- .clazy | 2 +- examples/dockwidgets/MyMainWindow.cpp | 2 ++ src/private/multisplitter/Item.cpp | 4 ++-- src/private/multisplitter/Separator_qwidget.cpp | 4 +++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.clazy b/.clazy index b86be79f..8dbddd84 100644 --- a/.clazy +++ b/.clazy @@ -1 +1 @@ -CHECKS level2,detaching-member,heap-allocated-small-trivial-type,isempty-vs-count,qstring-varargs,qvariant-template-instantiation,raw-environment-function,reserve-candidates,signal-with-return-value,thread-with-slots +CHECKS level2,detaching-member,heap-allocated-small-trivial-type,isempty-vs-count,qstring-varargs,qvariant-template-instantiation,raw-environment-function,reserve-candidates,signal-with-return-value,thread-with-slots,no-ctor-missing-parent-argument,no-missing-qobject-macro diff --git a/examples/dockwidgets/MyMainWindow.cpp b/examples/dockwidgets/MyMainWindow.cpp index 353d7ca8..8de45b7f 100644 --- a/examples/dockwidgets/MyMainWindow.cpp +++ b/examples/dockwidgets/MyMainWindow.cpp @@ -27,6 +27,8 @@ #include #include +// clazy:excludeall=qstring-allocations + static MyWidget *newMyWidget() { #if QT_VERSION < QT_VERSION_CHECK(5, 10, 0) diff --git a/src/private/multisplitter/Item.cpp b/src/private/multisplitter/Item.cpp index 6806ea11..c6d23bc7 100644 --- a/src/private/multisplitter/Item.cpp +++ b/src/private/multisplitter/Item.cpp @@ -2918,8 +2918,8 @@ SizingInfo::List ItemContainer::sizes(bool ignoreBeingInserted) const return result; } -QVector ItemContainer::calculateSqueezes(SizingInfo::List::ConstIterator begin, - SizingInfo::List::ConstIterator end, int needed, +QVector ItemContainer::calculateSqueezes(SizingInfo::List::ConstIterator begin, //clazy:exclude=function-args-by-ref + SizingInfo::List::ConstIterator end, int needed, //clazy:exclude=function-args-by-ref NeighbourSqueezeStrategy strategy, bool reversed) const { QVector availabilities; diff --git a/src/private/multisplitter/Separator_qwidget.cpp b/src/private/multisplitter/Separator_qwidget.cpp index e05dc031..338d872b 100644 --- a/src/private/multisplitter/Separator_qwidget.cpp +++ b/src/private/multisplitter/Separator_qwidget.cpp @@ -24,7 +24,7 @@ namespace Layouting { class RubberBand : public QRubberBand , public Layouting::Widget_qwidget { - +Q_OBJECT public: RubberBand(Layouting::Widget *parent) : QRubberBand(QRubberBand::Line, parent ? parent->asQWidget() : nullptr) @@ -107,3 +107,5 @@ Widget *SeparatorWidget::asWidget() { return this; } + +#include